deepcrayon
/
buildroot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
buildroot/.flake8

6 lines
96 B
Plaintext
Raw Permalink Normal View History

.flake8: add config file for Python code style We recommend wrapping at 80 columns but we accept 132 columns when it makes more readable. Follow up of discussion at this thread: http://lists.busybox.net/pipermail/buildroot/2017-October/203624.html Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Peter Korsgaard <peter@korsgaard.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Yann E. MORIN <yann.morin.1998@free.fr> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
2017-10-05 15:42:11 -06:00
[flake8]
.flake8: ignore utils/diffconfig This script comes from the kernel source, so ignore any code style warnings for it in order to keep it as close as possible to the original one, making synchronization between repos easier. The option --exclude for flake8/pycodestyle is an absolute list and has a default, so ideally the default values should be added too. But the use cases for flake8 in the tree are: - when developing a new script or changing an existing one, the developer calls flake8 only on that script; - in the GitLab job, a list of all Python files to be tested is created and then passed to flake8. None of these involve calling 'flake8' without parameters, so don't care about adding the default value. Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Cc: Marcus Folkesson <marcus.folkesson@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2018-03-12 21:09:45 -06:00
exclude=
# copied from the kernel sources
utils/diffconfig
Revert ".flake8: fix check for 80/132 columns" Commit 7d17ae2acf63 (.flake8: fix check for 80/132 columns) introduced a difference in how flake8 behaves between the automatic checks done in the CI, where the maximum line length is 132, and the local checks, where the maximum line length is 80. The rationale at the time was that we recommend 80 char lines, but that we accept 132 when it makes sense for readability. However, this is very annoying when running flake8 locally, because of two reasons: 1. human reviews on python scripts have not been as thorough as we did expect; indeed, we've let a lot of long lines slip through; this causes a lot of spurious failures that hide away the actual errors; 2. when hacking on a python script, the issues reported will not be caused by the current changes, so the many reported failures actually hide away the newly introduced issues. Additionally, our 'make check-flake8' rule already enforces the 132-char limit, and the issues reported are different than when manually running flake8 on individual files. Furthermore, the readability rationale for the 80-char limit is definitely shattered by the mere rationale of allowing 132-char limit for... readability... We've arrived to a point where this separation is causing our checks around flake8 to become mostly unusable and useless, as they do not report meaningful issues, and people are no longer paying attention, and this has caused actual issues to be introduced. Finally, terminal emulators of today have long lifted the 80-char limit, and are more than capable of displaying 132-char wide lines. Switch back to using a 132-char limit. This reverts commit 7d17ae2acf63810495cc480da38127c4612e4da9. Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Cc: Peter Korsgaard <peter@korsgaard.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
2021-01-02 03:56:05 -07:00
max-line-length=132