From 1567fbd72d4b547f70a7509247bf9abb73ab58e3 Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Thu, 8 Dec 2022 21:26:10 +0100 Subject: [PATCH] package/libuwsc: fix wolfssl build libuwsc needs BR2_PACKAGE_WOLFSSL_ALL (which enables openssl compat layer) to avoid the following wolfssl build failure raised since the addition of the package in commit 120c04775d7ebe5a2cfc14848f5d11f3a333970b: /home/br-user/work/instance-1/output-1/build/libuwsc-3.3.5/src/ssl.c:62:5: error: unknown type name 'SSL_CTX' 62 | SSL_CTX *ctx; | ^~~~~~~ Note that we do not select _ALL when wolfssl is enabled, because wolfssl is neither the only nor the preferred choice, so the condition would have to be a bit more complex: select BR2_PACKAGE_WOLFSSL_ALL if BR2_PACKAGE_WOLFSSL \ && !BR2_STATIC_LIBS && !BR2_PACKAGE_OPENSSL It is not overly complicated, but it is no longer trivial or obvious, and would easily break if the ordering of preferences were to change in the .mk fie in the future. Fixes: - http://autobuild.buildroot.org/results/6c2a6ed6fca1f92aab299f6ed9cd900b20e8d512 Signed-off-by: Fabrice Fontaine [yann.morin.1998@free.fr: explain why we don't select _ALL] Signed-off-by: Yann E. MORIN --- package/libuwsc/libuwsc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/libuwsc/libuwsc.mk b/package/libuwsc/libuwsc.mk index cad351529d..051ea411fa 100644 --- a/package/libuwsc/libuwsc.mk +++ b/package/libuwsc/libuwsc.mk @@ -18,7 +18,7 @@ LIBUWSC_CONF_OPTS += \ -DUWSC_USE_MBEDTLS=OFF \ -DUWSC_USE_OPENSSL=ON \ -DUWSC_USE_WOLFSSL=OFF -else ifeq ($(BR2_PACKAGE_WOLFSSL),y) +else ifeq ($(BR2_PACKAGE_WOLFSSL_ALL),y) LIBUWSC_DEPENDENCIES += wolfssl LIBUWSC_CONF_OPTS += \ -DUWSC_SSL_SUPPORT=ON \