support/download: rename internal 'verbose' variable where applicable

Most 'verbose' variable inside the download helpers actually mean 'quiet'.
I.e. they are assigned in case quiet operation is requested, and empty in
case of non-quiet operation. Using the name 'verbose' for such a variable is
confusing, especially when you want to test the variable on emptiness or
non-emptiness (in a subsequent commit).

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
2021.05.x
Thomas De Schampheleire 2021-01-15 16:00:45 +01:00 committed by Yann E. MORIN
parent ec0b716c4b
commit 3300788ce0
7 changed files with 21 additions and 21 deletions

View File

@ -16,10 +16,10 @@ set -e
# BZR : the bzr command to call
verbose=
quiet=
while getopts "${BR_BACKEND_DL_GETOPTS}" OPT; do
case "${OPT}" in
q) verbose=-q;;
q) quiet=-q;;
o) output="${OPTARG}";;
u) uri="${OPTARG}";;
c) cset="${OPTARG}";;
@ -53,6 +53,6 @@ if [ ${bzr_version} -ge ${bzr_min_version} ]; then
timestamp_opt="--per-file-timestamps"
fi
_bzr export ${verbose} --root="'${basename}/'" --format=tgz \
_bzr export ${quiet} --root="'${basename}/'" --format=tgz \
${timestamp_opt} - "${@}" "'${uri}'" -r "'${cset}'" \
>"${output}"

View File

@ -16,10 +16,10 @@ set -e
# Environment:
# CVS : the cvs command to call
verbose=
quiet=
while getopts "${BR_BACKEND_DL_GETOPTS}" OPT; do
case "${OPT}" in
q) verbose=-Q;;
q) quiet=-Q;;
o) output="${OPTARG}";;
u) uri="${OPTARG#*://}";;
c) rev="${OPTARG}";;
@ -57,7 +57,7 @@ if [[ ! "${uri}" =~ ^: ]]; then
fi
export TZ=UTC
_cvs ${verbose} -z3 -d"'${uri}'" \
_cvs ${quiet} -z3 -d"'${uri}'" \
co "${@}" -d "'${basename}'" ${select} "'${rev}'" -P "'${rawname}'"
tar czf "${output}" "${basename}"

View File

@ -50,11 +50,11 @@ _on_error() {
exec "${myname}" "${OPTS[@]}" || exit ${ret}
}
verbose=
quiet=
recurse=0
while getopts "${BR_BACKEND_DL_GETOPTS}" OPT; do
case "${OPT}" in
q) verbose=-q; exec >/dev/null;;
q) quiet=-q; exec >/dev/null;;
r) recurse=1;;
o) output="${OPTARG}";;
u) uri="${OPTARG}";;

View File

@ -15,10 +15,10 @@ set -e
# Environment:
# HG : the hg command to call
verbose=
quiet=
while getopts "${BR_BACKEND_DL_GETOPTS}" OPT; do
case "${OPT}" in
q) verbose=-q;;
q) quiet=-q;;
o) output="${OPTARG}";;
u) uri="${OPTARG}";;
c) cset="${OPTARG}";;
@ -36,8 +36,8 @@ _hg() {
eval ${HG} "${@}"
}
_hg clone ${verbose} "${@}" --noupdate "'${uri}'" "'${basename}'"
_hg clone ${quiet} "${@}" --noupdate "'${uri}'" "'${basename}'"
_hg archive ${verbose} --repository "'${basename}'" --type tgz \
_hg archive ${quiet} --repository "'${basename}'" --type tgz \
--prefix "'${basename}'" --rev "'${cset}'" \
- >"${output}"

View File

@ -14,10 +14,10 @@ set -e
# Environment:
# SCP : the scp command to call
verbose=
quiet=
while getopts "${BR_BACKEND_DL_GETOPTS}" OPT; do
case "${OPT}" in
q) verbose=-q;;
q) quiet=-q;;
o) output="${OPTARG}";;
f) filename="${OPTARG}";;
u) uri="${OPTARG}";;
@ -37,4 +37,4 @@ _scp() {
# Remove any scheme prefix
uri="${uri##scp://}"
_scp ${verbose} "${@}" "'${uri}/${filename}'" "'${output}'"
_scp ${quiet} "${@}" "'${uri}/${filename}'" "'${output}'"

View File

@ -22,10 +22,10 @@ set -e
. "${0%/*}/helpers"
verbose=
quiet=
while getopts "${BR_BACKEND_DL_GETOPTS}" OPT; do
case "${OPT}" in
q) verbose=-q;;
q) quiet=-q;;
o) output="${OPTARG}";;
u) uri="${OPTARG}";;
c) rev="${OPTARG}";;
@ -43,7 +43,7 @@ _svn() {
eval ${SVN} "${@}"
}
_svn export --ignore-keywords ${verbose} "${@}" "'${uri}@${rev}'" "'${basename}'"
_svn export --ignore-keywords ${quiet} "${@}" "'${uri}@${rev}'" "'${basename}'"
# Get the date of the revision, to generate reproducible archives.
# The output format is YYYY-MM-DDTHH:MM:SS.mmmuuuZ (i.e. always in the

View File

@ -15,10 +15,10 @@ set -e
# Environment:
# WGET : the wget command to call
verbose=
quiet=
while getopts "${BR_BACKEND_DL_GETOPTS}" OPT; do
case "${OPT}" in
q) verbose=-q;;
q) quiet=-q;;
o) output="${OPTARG}";;
f) filename="${OPTARG}";;
u) url="${OPTARG}";;
@ -40,4 +40,4 @@ _wget() {
# mirror
[ -n "${encode}" ] && filename=${filename//\?/%3F}
_wget ${verbose} "${@}" -O "'${output}'" "'${url}/${filename}'"
_wget ${quiet} "${@}" -O "'${output}'" "'${url}/${filename}'"