From 97f3ad7af3dd54a15a10aa35786e7fa08cf5e7b1 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sat, 9 Oct 2021 21:16:41 +0200 Subject: [PATCH] package/gdb: append to dependencies in conditional Repeat after me: "Forcing the value of _DEPENDENCIES inside a conditional is the root of all evil." Repeat after me: "Forcing the value of _DEPENDENCIES inside a conditional is the root of all evil." Repeat after me: "Forcing the value of _DEPENDENCIES inside a conditional is the root of all evil." Repeat after me: "Forcing the value of _DEPENDENCIES inside a conditional is the root of all evil." Enough? :-) Due to this mistake, any other GDB_DEPENDENCIES defined before this assignment were lost. For example, the host-flex host-bison added inside the GDB_FROM_GIT==y condition were ignored if BR2_PACKAGE_GDB_DEBUGGER. Fixes the build of all ARC configurations that have BR2_PACKAGE_GDB_DEBUGGER enabled. Signed-off-by: Thomas Petazzoni Signed-off-by: Yann E. MORIN --- package/gdb/gdb.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk index f9010019f5..4ead75289e 100644 --- a/package/gdb/gdb.mk +++ b/package/gdb/gdb.mk @@ -147,7 +147,7 @@ ifeq ($(BR2_PACKAGE_GDB_DEBUGGER),y) GDB_CONF_OPTS += \ --enable-gdb \ --with-curses -GDB_DEPENDENCIES = ncurses \ +GDB_DEPENDENCIES += ncurses \ $(if $(BR2_PACKAGE_LIBICONV),libiconv) else GDB_CONF_OPTS += \