deepcrayon/buildroot
deepcrayon/buildroot
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

graph-depends: avoid use of global var 'rule' in get_depends

Browse source 
Function get_depends was recently changed to support both normal
dependencies as reverse dependencies, via a global variable 'rule' that
equals 'show-depends' or 'show-rdepends'.

As a subsequent function will extract this function get_depends to a
separate file, the use of globals is problematic.

Instead, pass the global as an argument.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Thomas De Schampheleire 2017-02-03 21:57:42 +01:00 committed by Thomas Petazzoni
parent ff28d37dfa
commit bd8b531d24
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
support/scripts/graph-depends
View file

@ -161,7 +161,7 @@ def get_targets():
# Execute the "make <pkg>-show-depends" command to get the list of
# dependencies of a given list of packages, and return the list of
# dependencies formatted as a Python dictionary.
def get_depends(pkgs):
def get_depends(pkgs, rule):
sys.stderr.write("Getting dependencies for %s\n" % pkgs)
cmd = ["make", "-s", "--no-print-directory" ]
for pkg in pkgs:
@ -204,7 +204,7 @@ def get_all_depends(pkgs):
if len(filtered_pkgs) == 0:
return []
depends = get_depends(filtered_pkgs)
depends = get_depends(filtered_pkgs, rule)
deps = set()
for pkg in filtered_pkgs: