deepcrayon/buildroot
deepcrayon/buildroot
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

package/pppd: disable for musl toolchains

Browse source 
For the same reason as for ipsec-tools [1], disable pppd for musl
toolchains.
It also include <sys/cdefs.h> which is not provided by musl [2].

This fixes a compilation error with musl libc because of undeclared
__P and missing sys/cdefs.h include.

Propagate the dependency to network-manager and rp-pppoe
packages.

[1] 33499484e4
[2] http://wiki.musl-libc.org/wiki/FAQ#Q:_I.27m_trying_to_compile_something_against_musl_and_I_get_error_messages_about_sys.2Fcdefs.h

Signed-off-by: Romain Naour <romain.naour@gmail.com>
[Thomas: add Config.in comment in network-manager.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This commit is contained in:
Romain Naour 2016-07-16 18:08:18 +02:00 committed by Thomas Petazzoni
parent f5dd604082
commit d2c997e6b0
3 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
package/network-manager/Config.in
View file

@ -47,9 +47,14 @@ config BR2_PACKAGE_NETWORK_MANAGER_MODEM_MANAGER
config BR2_PACKAGE_NETWORK_MANAGER_PPPD
bool "pppd support"
depends on !BR2_TOOLCHAIN_USES_MUSL # pppd
select BR2_PACKAGE_PPPD
help
This option enables support for PPPD daemon
comment "pppd support needs a glibc or uClibc toolchain"
depends on BR2_TOOLCHAIN_USES_MUSL
endif
comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.7"

5
package/pppd/Config.in
View file

@ -1,6 +1,7 @@
config BR2_PACKAGE_PPPD
bool "pppd"
depends on !BR2_STATIC_LIBS
depends on !BR2_TOOLCHAIN_USES_MUSL # Use __P() macro all over the tree
depends on BR2_USE_MMU
help
An implementation of the Point-to-point protocol.
@ -24,6 +25,6 @@ config BR2_PACKAGE_PPPD_RADIUS
endif
comment "pppd needs a toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS
comment "pppd needs a uClibc or glibc toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL
depends on BR2_USE_MMU

5
package/rp-pppoe/Config.in
View file

@ -1,10 +1,11 @@
comment "rp-pppoe needs a toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS
comment "rp-pppoe needs a uClibc or glibc toolchain w/ dynamic library"
depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL
depends on BR2_USE_MMU
config BR2_PACKAGE_RP_PPPOE
bool "rp-pppoe"
depends on !BR2_STATIC_LIBS
depends on !BR2_TOOLCHAIN_USES_MUSL # pppd
depends on BR2_USE_MMU # fork()
select BR2_PACKAGE_PPPD
help