utils/size-stats-compare: clarify meaning of variables in print_result
print_result is juggling with entry[x][y] which is not very readable. While a better solution would be to use a class and reference named attributes, that would require some bigger changes in the script. Instead, make a minimal improvement by assigning the entry[x][y] values to intermediate variables. Store them in a dict for easy usage from a format string. Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
This commit is contained in:
parent
bebeb772eb
commit
e9b1dffa5d
|
@ -77,9 +77,15 @@ def print_results(result, threshold):
|
||||||
# list_result is a list of tuples: (name, (flag, size difference))
|
# list_result is a list of tuples: (name, (flag, size difference))
|
||||||
|
|
||||||
for entry in sorted(list_result, key=lambda entry: entry[1][1]):
|
for entry in sorted(list_result, key=lambda entry: entry[1][1]):
|
||||||
if threshold is not None and abs(entry[1][1]) <= threshold:
|
data = dict(
|
||||||
|
name=entry[0],
|
||||||
|
action=entry[1][0],
|
||||||
|
size=entry[1][1],
|
||||||
|
)
|
||||||
|
|
||||||
|
if threshold is not None and abs(data['size']) <= threshold:
|
||||||
continue
|
continue
|
||||||
print('%12s %7s %s' % (entry[1][1], entry[1][0], entry[0]))
|
print('{size:12d} {action:7s} {name}'.format(**data))
|
||||||
|
|
||||||
|
|
||||||
# main #########################################################################
|
# main #########################################################################
|
||||||
|
|
Loading…
Reference in a new issue