02b165dc71
This script currently uses "/usr/bin/env python" as shebang but it does not really support Python3. Instead of limiting the script to Python2, fix it to support both versions. So change all imports to absolute imports because Python3 follows PEP328 and dropped implicit relative imports. In order to avoid errors when decoding files with the default 'utf-8' codec, use errors="surrogateescape" when opening files, the docs for open() states: "This is useful for processing files in an unknown encoding.". This argument is not compatible with Python2 open() so import 'six' to use it only when running in Python3. As a consequence the file handler becomes explicit, so use it to close() the file after it got processed. This "surrogateescape" is a simple alternative to the complete solution of opening files with "rb" and changing all functions in the lib*.py files to use bytes objects instead of strings. The only case we can have non-ascii/non-utf-8 files being checked by the script are for patch files when the upstream file to be patched is not ascii or utf-8. There is currently one case in the tree: package/urg/0002-urg-gcc6-fix-narrowing-conversion.patch. Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Cc: Arnout Vandecappelle <arnout@mind.be> Reviewed-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> Tested-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
56 lines
2 KiB
Python
56 lines
2 KiB
Python
# See utils/checkpackagelib/readme.txt before editing this file.
|
|
# The validity of the hashes itself is checked when building, so below check
|
|
# functions don't need to check for things already checked by running
|
|
# "make package-dirclean package-source".
|
|
|
|
import re
|
|
|
|
from checkpackagelib.base import _CheckFunction
|
|
from checkpackagelib.lib import ConsecutiveEmptyLines # noqa: F401
|
|
from checkpackagelib.lib import EmptyLastLine # noqa: F401
|
|
from checkpackagelib.lib import NewlineAtEof # noqa: F401
|
|
from checkpackagelib.lib import TrailingSpace # noqa: F401
|
|
|
|
|
|
def _empty_line_or_comment(text):
|
|
return text.strip() == "" or text.startswith("#")
|
|
|
|
|
|
class HashNumberOfFields(_CheckFunction):
|
|
def check_line(self, lineno, text):
|
|
if _empty_line_or_comment(text):
|
|
return
|
|
|
|
fields = text.split()
|
|
if len(fields) != 3:
|
|
return ["{}:{}: expected three fields ({}#adding-packages-hash)"
|
|
.format(self.filename, lineno, self.url_to_manual),
|
|
text]
|
|
|
|
|
|
class HashType(_CheckFunction):
|
|
len_of_hash = {"md5": 32, "sha1": 40, "sha224": 56, "sha256": 64,
|
|
"sha384": 96, "sha512": 128}
|
|
|
|
def check_line(self, lineno, text):
|
|
if _empty_line_or_comment(text):
|
|
return
|
|
|
|
fields = text.split()
|
|
if len(fields) < 2:
|
|
return
|
|
|
|
htype, hexa = fields[:2]
|
|
if htype == "none":
|
|
return
|
|
if htype not in self.len_of_hash.keys():
|
|
return ["{}:{}: unexpected type of hash ({}#adding-packages-hash)"
|
|
.format(self.filename, lineno, self.url_to_manual),
|
|
text]
|
|
if not re.match("^[0-9A-Fa-f]{%s}$" % self.len_of_hash[htype], hexa):
|
|
return ["{}:{}: hash size does not match type "
|
|
"({}#adding-packages-hash)"
|
|
.format(self.filename, lineno, self.url_to_manual),
|
|
text,
|
|
"expected {} hex digits".format(self.len_of_hash[htype])]
|