![Thomas Petazzoni](/assets/img/avatar_default.png)
Raw strings need to be used when calling re.compile() otherwise Python 3.x flake8 complains with: W605 invalid escape sequence '\s' Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Reviewed-by: Titouan Christophe <titouan.christophe@railnova.eu> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
63 lines
1.9 KiB
Python
63 lines
1.9 KiB
Python
# See utils/checkpackagelib/readme.txt before editing this file.
|
|
# The format of the patch files is tested during the build, so below check
|
|
# functions don't need to check for things already checked by running
|
|
# "make package-dirclean package-patch".
|
|
|
|
import os
|
|
import re
|
|
|
|
from checkpackagelib.base import _CheckFunction
|
|
from checkpackagelib.lib import NewlineAtEof # noqa: F401
|
|
|
|
|
|
class ApplyOrder(_CheckFunction):
|
|
APPLY_ORDER = re.compile(r"\d{1,4}-[^/]*$")
|
|
|
|
def before(self):
|
|
if not self.APPLY_ORDER.match(os.path.basename(self.filename)):
|
|
return ["{}:0: use name <number>-<description>.patch "
|
|
"({}#_providing_patches)"
|
|
.format(self.filename, self.url_to_manual)]
|
|
|
|
|
|
class NumberedSubject(_CheckFunction):
|
|
NUMBERED_PATCH = re.compile(r"Subject:\s*\[PATCH\s*\d+/\d+\]")
|
|
|
|
def before(self):
|
|
self.git_patch = False
|
|
self.lineno = 0
|
|
self.text = None
|
|
|
|
def check_line(self, lineno, text):
|
|
if text.startswith("diff --git"):
|
|
self.git_patch = True
|
|
return
|
|
if self.NUMBERED_PATCH.search(text):
|
|
self.lineno = lineno
|
|
self.text = text
|
|
|
|
def after(self):
|
|
if self.git_patch and self.text:
|
|
return ["{}:{}: generate your patches with 'git format-patch -N'"
|
|
.format(self.filename, self.lineno),
|
|
self.text]
|
|
|
|
|
|
class Sob(_CheckFunction):
|
|
SOB_ENTRY = re.compile(r"^Signed-off-by: .*$")
|
|
|
|
def before(self):
|
|
self.found = False
|
|
|
|
def check_line(self, lineno, text):
|
|
if self.found:
|
|
return
|
|
if self.SOB_ENTRY.search(text):
|
|
self.found = True
|
|
|
|
def after(self):
|
|
if not self.found:
|
|
return ["{}:0: missing Signed-off-by in the header "
|
|
"({}#_format_and_licensing_of_the_package_patches)"
|
|
.format(self.filename, self.url_to_manual)]
|