3663d810ca
In libIEC61850 before version 1.4.3, when a message with COTP message length field with value < 4 is received an integer underflow will happen leading to heap buffer overflow. This can cause an application crash or on some platforms even the execution of remote code. If your application is used in open networks or there are untrusted nodes in the network it is highly recommend to apply the patch. This was patched with commit 033ab5b. Users of version 1.4.x should upgrade to version 1.4.3 when available. As a workaround changes of commit 033ab5b can be applied to older versions. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
28 lines
989 B
Diff
28 lines
989 B
Diff
From 033ab5b6488250c8c3b838f25a7cbc3e099230bb Mon Sep 17 00:00:00 2001
|
|
From: Michael Zillgith <michael.zillgith@mz-automation.de>
|
|
Date: Wed, 12 Aug 2020 07:25:37 +0200
|
|
Subject: [PATCH] - COTP: fixed possible heap buffer overflow when handling
|
|
message with invalid (zero) value in length field (#250)
|
|
|
|
[Retrieved from:
|
|
https://github.com/mz-automation/libiec61850/commit/033ab5b6488250c8c3b838f25a7cbc3e099230bb]
|
|
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
|
---
|
|
src/mms/iso_cotp/cotp.c | 3 +++
|
|
1 file changed, 3 insertions(+)
|
|
|
|
diff --git a/src/mms/iso_cotp/cotp.c b/src/mms/iso_cotp/cotp.c
|
|
index cbb34b36..8c37d262 100644
|
|
--- a/src/mms/iso_cotp/cotp.c
|
|
+++ b/src/mms/iso_cotp/cotp.c
|
|
@@ -720,6 +720,9 @@ CotpConnection_readToTpktBuffer(CotpConnection* self)
|
|
goto exit_waiting;
|
|
}
|
|
|
|
+ if (self->packetSize <= bufPos)
|
|
+ goto exit_error;
|
|
+
|
|
readBytes = readFromSocket(self, buffer + bufPos, self->packetSize - bufPos);
|
|
|
|
if (readBytes < 0)
|