5a9a95d0eb
Commit 954509f added a security fix for CVE-2017-8779, involving
pairing all svc_getargs() calls with svc_freeargs() to avoid a memory
leak. However it also introduced a couple of issues:
- The call to svc_freeargs() from rpcbproc_callit_com() may result in
an attempt to free static memory, resulting in undefined behaviour.
- A typo in the svc_freeargs() call from pmapproc_dump() causes NIS
(aka ypbind) to fail.
Backport upstream fixes for these issues to version 0.2.3.
Signed-off-by: Ed Blake <ed.blake@sondrel.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
32 lines
980 B
Diff
32 lines
980 B
Diff
From d3f1f55e50e3c436a2ea91d60da84c3a94e6c53f Mon Sep 17 00:00:00 2001
|
|
From: Steve Dickson <steved@redhat.com>
|
|
Date: Thu, 18 Jan 2018 17:41:49 +0000
|
|
Subject: [PATCH] pmapproc_dump: Fixed typo in memory leak patch
|
|
|
|
commit 7ea36eee introduce a typo that caused
|
|
NIS (aka ypbind) to fail.
|
|
|
|
Signed-off-by: Steve Dickson <steved@redhat.com>
|
|
(cherry picked from commit c49a7ea639eb700823e174fd605bbbe183e229aa)
|
|
Signed-off-by: Ed Blake <ed.blake@sondrel.com>
|
|
---
|
|
src/pmap_svc.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/src/pmap_svc.c b/src/pmap_svc.c
|
|
index bb57b05..ffca7df 100644
|
|
--- a/src/pmap_svc.c
|
|
+++ b/src/pmap_svc.c
|
|
@@ -384,7 +384,7 @@ pmapproc_dump(struct svc_req *rqstp /*__unused*/, SVCXPRT *xprt)
|
|
}
|
|
|
|
done:
|
|
- if (!svc_freeargs(xprt, (xdrproc_t) xdr_pmap, (char *)NULL)) {
|
|
+ if (!svc_freeargs(xprt, (xdrproc_t) xdr_void, (char *)NULL)) {
|
|
if (debugging) {
|
|
(void) xlog(LOG_DEBUG, "unable to free arguments\n");
|
|
if (doabort) {
|
|
--
|
|
2.11.0
|
|
|