![Adam Duskett](/assets/img/avatar_default.png)
The reason for combining these patches is because the old version of setools is not compatible iwth libsepol 2.7. If a user where to do a git pull on a patch that only updates libsepol or setools, the build would fail to compile. setools has been completely rewritten in python instead of C. The current version of setools includes a few programs that require python-qt5 or python-networkx to run, however the package does not check to see if these exist when compiling, and will install the scripts to the target directory even if they don't exist. In the case of python-networkx, this package is not available on Buildroot. The scripts that require them are: sedta and seinfoflow. In the case of python-qt5, qpol is the script that requires it. Some setools.mk notes to get the package to compile: - Convert the package .mk to use python-package instead of autotools-package. - setup.py hard codes base_lib_dirs to point to several host directories. To fix this, sed is used before compiling to point the base_lib_dirs to the staging directory. - setup.py also includes the "Werror" flag, however compilers before gcc6 cause a few autogenerated variables to not be initialized before use, causing the build to fail. To fix this, a patch is provided that removes the Werror flag. - Remove sedta and seinfoflow from the target system after install. These packages rely on the package python-networkx which is not available in buildroot. - Remove the installed apol package and the setoolsgui directory from the target directory if python-qt5 is not selected. Other changes: - Removed all patches, as they are not compatible with the new version of setools. - Add COPYING, COPYING.GPL, and COPYING.LGPL to setools.hash Signed-off-by: Adam Duskett <Adamduskett@outlook.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
30 lines
1.1 KiB
Diff
30 lines
1.1 KiB
Diff
From b2fe84bfd00117d4897f1f2e8f83d3410eb188b8 Mon Sep 17 00:00:00 2001
|
|
From: Adam Duskett <Adamduskett@outlook.com>
|
|
Date: Thu, 12 Oct 2017 22:04:58 -0400
|
|
Subject: [PATCH] remove werror flag from setup
|
|
|
|
Compilers older than gcc6 will generate uninitialized variable warnings which
|
|
will cause compiling to fail.
|
|
|
|
Signed-off-by: Adam Duskett <Adamduskett@outlook.com>
|
|
---
|
|
setup.py | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/setup.py b/setup.py
|
|
index 2ca44c9..9319bf6 100644
|
|
--- a/setup.py
|
|
+++ b/setup.py
|
|
@@ -146,7 +146,7 @@ ext_py_mods = [Extension('setools.policyrep._qpol',
|
|
'libqpol/policy_scan.c',
|
|
'libqpol/xen_query.c'],
|
|
include_dirs=include_dirs,
|
|
- extra_compile_args=['-Werror', '-Wextra',
|
|
+ extra_compile_args=['-Wextra',
|
|
'-Waggregate-return',
|
|
'-Wfloat-equal',
|
|
'-Wformat', '-Wformat=2',
|
|
--
|
|
2.13.6
|
|
|