d020368eea
Enable the common checks: - consecutive empty lines - empty last line - missing new line at end of file - trailing space - warn for executable files, with the hint to instead use '$(INSTALL) -D -m 0755' in the .mk file Check indent with tabs: - add a simple check function to warn only when the indent is done using spaces or a mix of tabs and spaces. It does not check indenting levels, but it already makes the review easier, since it diferentiates spaces and tabs. Check variables: - check DAEMON is defined - when DAEMON is defined, check the filename is in the form S01daemon - when PIDFILE is defined, expect it to be in /var/run and defined using $DAEMON. Also add unit test for this. Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> [Arnout: avoid 'del NotExecutable_base' by importing the module instead of the class; refer to manual in warnings] Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
30 lines
618 B
Python
30 lines
618 B
Python
# See utils/checkpackagelib/readme.txt before editing this file.
|
|
import re
|
|
|
|
|
|
class _CheckFunction(object):
|
|
def __init__(self, filename, url_to_manual):
|
|
self.filename = filename
|
|
self.url_to_manual = url_to_manual
|
|
self.disable = re.compile(r"^\s*# check-package .*\b{}\b".format(self.__class__.__name__))
|
|
|
|
def before(self):
|
|
pass
|
|
|
|
def check_line(self, lineno, text):
|
|
pass
|
|
|
|
def after(self):
|
|
pass
|
|
|
|
|
|
class _Tool(object):
|
|
def __init__(self, filename):
|
|
self.filename = filename
|
|
|
|
def run(self):
|
|
pass
|
|
|
|
def hint(self):
|
|
return ""
|