1f6b283dd9
Setting an unset variable to an empty value is useless in make; an unset
variable just expands to an empty string anyway. So what we do currently
has no side effect:
variable set and not empty -> variable not modified
variable set and empty -> variable not modified
variable unset -> set to an empty string
However, additional variables do have an impact on the parsing time of
the Makefiles, and the more variables, the more collisions in the hash
table used internally by make, which slows down the parsing.
By dropping those conditionally-set-empty variables, we gain about 3%:
Run Before After
1 5.572 5.325
2 5.434 5.354
3 5.490 5.320
4 5.525 5.330
5 5.476 5.330
6 5.511 5.434
7 5.498 5.388
8 5.524 5.371
9 5.479 5.346
10 5.637 5.324
Mean: 5.515 5.352
Yeah, 0.163s does not look like much, and this does not make
autocompletion any more usable. Still, that 3% gain is not to be
ashamed of either.
Note that there are 3 others case where we do set empty variables, but
those are unconditional and serve other purposes:
- pkg-virtual: this is done on purpose to avoid a bug when the
environment may have TOOLCHAIN_VERSION or _SOURCE set, and we really
want those to be empty, so the assignment is not conditional;
- pkg-python: the reason for setting those to empty is dubious at
best; it's been there since the inception of the python infra, back
in 2013; still, the case is different than this patch addresses;
- pkg-toolchain-external: this is the case for a toolchain already
installed, so indeed we want to set _SOURCE and _VERSION to empty.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
273 lines
9.8 KiB
Makefile
273 lines
9.8 KiB
Makefile
################################################################################
|
|
# CMake package infrastructure
|
|
#
|
|
# This file implements an infrastructure that eases development of
|
|
# package .mk files for CMake packages. It should be used for all
|
|
# packages that use CMake as their build system.
|
|
#
|
|
# See the Buildroot documentation for details on the usage of this
|
|
# infrastructure
|
|
#
|
|
# In terms of implementation, this CMake infrastructure requires
|
|
# the .mk file to only specify metadata information about the
|
|
# package: name, version, download URL, etc.
|
|
#
|
|
# We still allow the package .mk file to override what the different
|
|
# steps are doing, if needed. For example, if <PKG>_BUILD_CMDS is
|
|
# already defined, it is used as the list of commands to perform to
|
|
# build the package, instead of the default CMake behaviour. The
|
|
# package can also define some post operation hooks.
|
|
#
|
|
################################################################################
|
|
|
|
# Set compiler variables.
|
|
ifeq ($(BR2_CCACHE),y)
|
|
CMAKE_HOST_C_COMPILER = $(HOSTCC_NOCCACHE)
|
|
CMAKE_HOST_CXX_COMPILER = $(HOSTCXX_NOCCACHE)
|
|
CMAKE_HOST_C_COMPILER_LAUNCHER = $(HOST_DIR)/bin/ccache
|
|
CMAKE_HOST_CXX_COMPILER_LAUNCHER = $(HOST_DIR)/bin/ccache
|
|
else
|
|
CMAKE_HOST_C_COMPILER = $(HOSTCC)
|
|
CMAKE_HOST_CXX_COMPILER = $(HOSTCXX)
|
|
endif
|
|
|
|
ifneq ($(QUIET),)
|
|
CMAKE_QUIET = -DCMAKE_RULE_MESSAGES=OFF -DCMAKE_INSTALL_MESSAGE=NEVER
|
|
endif
|
|
|
|
################################################################################
|
|
# inner-cmake-package -- defines how the configuration, compilation and
|
|
# installation of a CMake package should be done, implements a few hooks to
|
|
# tune the build process and calls the generic package infrastructure to
|
|
# generate the necessary make targets
|
|
#
|
|
# argument 1 is the lowercase package name
|
|
# argument 2 is the uppercase package name, including a HOST_ prefix
|
|
# for host packages
|
|
# argument 3 is the uppercase package name, without the HOST_ prefix
|
|
# for host packages
|
|
# argument 4 is the type (target or host)
|
|
################################################################################
|
|
|
|
define inner-cmake-package
|
|
|
|
$(2)_MAKE ?= $$(MAKE)
|
|
$(2)_INSTALL_OPTS ?= install
|
|
$(2)_INSTALL_STAGING_OPTS ?= DESTDIR=$$(STAGING_DIR) install/fast
|
|
$(2)_INSTALL_TARGET_OPTS ?= DESTDIR=$$(TARGET_DIR) install/fast
|
|
|
|
$(3)_SUPPORTS_IN_SOURCE_BUILD ?= YES
|
|
|
|
|
|
ifeq ($$($(3)_SUPPORTS_IN_SOURCE_BUILD),YES)
|
|
$(2)_BUILDDIR = $$($(2)_SRCDIR)
|
|
else
|
|
$(2)_BUILDDIR = $$($(2)_SRCDIR)/buildroot-build
|
|
endif
|
|
|
|
#
|
|
# Configure step. Only define it if not already defined by the package
|
|
# .mk file. And take care of the differences between host and target
|
|
# packages.
|
|
#
|
|
ifndef $(2)_CONFIGURE_CMDS
|
|
ifeq ($(4),target)
|
|
|
|
# Configure package for target
|
|
#
|
|
# - We are passing BUILD_SHARED_LIBS because it is documented as a
|
|
# standard CMake variable to control the build of shared libraries
|
|
# (see https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior)
|
|
# - We are not passing BUILD_STATIC_LIBS because it is *not*
|
|
# documented as a standard CMake variable. If a package supports it,
|
|
# it must handle it explicitly.
|
|
#
|
|
define $(2)_CONFIGURE_CMDS
|
|
(mkdir -p $$($$(PKG)_BUILDDIR) && \
|
|
cd $$($$(PKG)_BUILDDIR) && \
|
|
rm -f CMakeCache.txt && \
|
|
PATH=$$(BR_PATH) \
|
|
$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
|
|
-DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/share/buildroot/toolchainfile.cmake" \
|
|
-DCMAKE_INSTALL_PREFIX="/usr" \
|
|
-DCMAKE_COLOR_MAKEFILE=OFF \
|
|
-DBUILD_DOC=OFF \
|
|
-DBUILD_DOCS=OFF \
|
|
-DBUILD_EXAMPLE=OFF \
|
|
-DBUILD_EXAMPLES=OFF \
|
|
-DBUILD_TEST=OFF \
|
|
-DBUILD_TESTS=OFF \
|
|
-DBUILD_TESTING=OFF \
|
|
-DBUILD_SHARED_LIBS=$$(if $$(BR2_STATIC_LIBS),OFF,ON) \
|
|
$$(CMAKE_QUIET) \
|
|
$$($$(PKG)_CONF_OPTS) \
|
|
)
|
|
endef
|
|
else
|
|
|
|
# Configure package for host
|
|
define $(2)_CONFIGURE_CMDS
|
|
(mkdir -p $$($$(PKG)_BUILDDIR) && \
|
|
cd $$($$(PKG)_BUILDDIR) && \
|
|
rm -f CMakeCache.txt && \
|
|
PATH=$$(BR_PATH) \
|
|
PKG_CONFIG="$$(PKG_CONFIG_HOST_BINARY)" \
|
|
PKG_CONFIG_SYSROOT_DIR="/" \
|
|
PKG_CONFIG_LIBDIR="$$(HOST_DIR)/lib/pkgconfig:$$(HOST_DIR)/share/pkgconfig" \
|
|
PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 \
|
|
PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 \
|
|
$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
|
|
-DCMAKE_INSTALL_SO_NO_EXE=0 \
|
|
-DCMAKE_FIND_ROOT_PATH="$$(HOST_DIR)" \
|
|
-DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM="BOTH" \
|
|
-DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY="BOTH" \
|
|
-DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE="BOTH" \
|
|
-DCMAKE_INSTALL_PREFIX="$$(HOST_DIR)" \
|
|
-DCMAKE_C_FLAGS="$$(HOST_CFLAGS)" \
|
|
-DCMAKE_CXX_FLAGS="$$(HOST_CXXFLAGS)" \
|
|
-DCMAKE_EXE_LINKER_FLAGS="$$(HOST_LDFLAGS)" \
|
|
-DCMAKE_SHARED_LINKER_FLAGS="$$(HOST_LDFLAGS)" \
|
|
-DCMAKE_ASM_COMPILER="$$(HOSTAS)" \
|
|
-DCMAKE_C_COMPILER="$$(CMAKE_HOST_C_COMPILER)" \
|
|
-DCMAKE_CXX_COMPILER="$$(CMAKE_HOST_CXX_COMPILER)" \
|
|
$(if $$(CMAKE_HOST_C_COMPILER_LAUNCHER),\
|
|
-DCMAKE_C_COMPILER_LAUNCHER="$$(CMAKE_HOST_C_COMPILER_LAUNCHER)" \
|
|
-DCMAKE_CXX_COMPILER_LAUNCHER="$$(CMAKE_HOST_CXX_COMPILER_LAUNCHER)" \
|
|
) \
|
|
-DCMAKE_COLOR_MAKEFILE=OFF \
|
|
-DBUILD_DOC=OFF \
|
|
-DBUILD_DOCS=OFF \
|
|
-DBUILD_EXAMPLE=OFF \
|
|
-DBUILD_EXAMPLES=OFF \
|
|
-DBUILD_TEST=OFF \
|
|
-DBUILD_TESTS=OFF \
|
|
-DBUILD_TESTING=OFF \
|
|
-DBUILD_SHARED_LIBS=ON \
|
|
$$(CMAKE_QUIET) \
|
|
$$($$(PKG)_CONF_OPTS) \
|
|
)
|
|
endef
|
|
endif
|
|
endif
|
|
|
|
# Since some CMake modules (even upstream ones) use pgk_check_modules
|
|
# primitives to find {C,LD}FLAGS, add it to the dependency list.
|
|
$(2)_DEPENDENCIES += host-pkgconf
|
|
|
|
$(2)_DEPENDENCIES += $(BR2_CMAKE_HOST_DEPENDENCY)
|
|
|
|
#
|
|
# Build step. Only define it if not already defined by the package .mk
|
|
# file.
|
|
#
|
|
ifndef $(2)_BUILD_CMDS
|
|
ifeq ($(4),target)
|
|
define $(2)_BUILD_CMDS
|
|
$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) -C $$($$(PKG)_BUILDDIR)
|
|
endef
|
|
else
|
|
define $(2)_BUILD_CMDS
|
|
$$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) -C $$($$(PKG)_BUILDDIR)
|
|
endef
|
|
endif
|
|
endif
|
|
|
|
#
|
|
# Host installation step. Only define it if not already defined by the
|
|
# package .mk file.
|
|
#
|
|
ifndef $(2)_INSTALL_CMDS
|
|
define $(2)_INSTALL_CMDS
|
|
$$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_OPTS) -C $$($$(PKG)_BUILDDIR)
|
|
endef
|
|
endif
|
|
|
|
#
|
|
# Staging installation step. Only define it if not already defined by
|
|
# the package .mk file.
|
|
#
|
|
ifndef $(2)_INSTALL_STAGING_CMDS
|
|
define $(2)_INSTALL_STAGING_CMDS
|
|
$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_STAGING_OPTS) -C $$($$(PKG)_BUILDDIR)
|
|
endef
|
|
endif
|
|
|
|
#
|
|
# Target installation step. Only define it if not already defined by
|
|
# the package .mk file.
|
|
#
|
|
ifndef $(2)_INSTALL_TARGET_CMDS
|
|
define $(2)_INSTALL_TARGET_CMDS
|
|
$$(TARGET_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) $$($$(PKG)_MAKE_OPTS) $$($$(PKG)_INSTALL_TARGET_OPTS) -C $$($$(PKG)_BUILDDIR)
|
|
endef
|
|
endif
|
|
|
|
# Call the generic package infrastructure to generate the necessary
|
|
# make targets
|
|
$(call inner-generic-package,$(1),$(2),$(3),$(4))
|
|
|
|
endef
|
|
|
|
################################################################################
|
|
# cmake-package -- the target generator macro for CMake packages
|
|
################################################################################
|
|
|
|
cmake-package = $(call inner-cmake-package,$(pkgname),$(call UPPERCASE,$(pkgname)),$(call UPPERCASE,$(pkgname)),target)
|
|
host-cmake-package = $(call inner-cmake-package,host-$(pkgname),$(call UPPERCASE,host-$(pkgname)),$(call UPPERCASE,$(pkgname)),host)
|
|
|
|
################################################################################
|
|
# Generation of the CMake toolchain file
|
|
################################################################################
|
|
|
|
# CMAKE_SYSTEM_PROCESSOR should match uname -m
|
|
ifeq ($(BR2_ARM_CPU_ARMV4),y)
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv4
|
|
else ifeq ($(BR2_ARM_CPU_ARMV5),y)
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv5
|
|
else ifeq ($(BR2_ARM_CPU_ARMV6),y)
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv6
|
|
else ifeq ($(BR2_ARM_CPU_ARMV7A),y)
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv7
|
|
else ifeq ($(BR2_ARM_CPU_ARMV8A),y)
|
|
CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT = armv8
|
|
endif
|
|
|
|
ifeq ($(BR2_arm),y)
|
|
CMAKE_SYSTEM_PROCESSOR = $(CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT)l
|
|
else ifeq ($(BR2_armeb),y)
|
|
CMAKE_SYSTEM_PROCESSOR = $(CMAKE_SYSTEM_PROCESSOR_ARM_VARIANT)b
|
|
else ifeq ($(call qstrip,$(BR2_ARCH)),powerpc64)
|
|
CMAKE_SYSTEM_PROCESSOR = ppc64
|
|
else ifeq ($(call qstrip,$(BR2_ARCH)),powerpc64le)
|
|
CMAKE_SYSTEM_PROCESSOR = ppc64le
|
|
else
|
|
CMAKE_SYSTEM_PROCESSOR = $(BR2_ARCH)
|
|
endif
|
|
|
|
# In order to allow the toolchain to be relocated, we calculate the HOST_DIR
|
|
# based on the toolchainfile.cmake file's location: $(HOST_DIR)/share/buildroot
|
|
# In all the other variables, HOST_DIR will be replaced by RELOCATED_HOST_DIR,
|
|
# so we have to strip "$(HOST_DIR)/" from the paths that contain it.
|
|
define TOOLCHAIN_CMAKE_INSTALL_FILES
|
|
@mkdir -p $(HOST_DIR)/share/buildroot
|
|
sed \
|
|
-e 's#@@STAGING_SUBDIR@@#$(call qstrip,$(STAGING_SUBDIR))#' \
|
|
-e 's#@@TARGET_CFLAGS@@#$(call qstrip,$(TARGET_CFLAGS))#' \
|
|
-e 's#@@TARGET_CXXFLAGS@@#$(call qstrip,$(TARGET_CXXFLAGS))#' \
|
|
-e 's#@@TARGET_FCFLAGS@@#$(call qstrip,$(TARGET_FCFLAGS))#' \
|
|
-e 's#@@TARGET_LDFLAGS@@#$(call qstrip,$(TARGET_LDFLAGS))#' \
|
|
-e 's#@@TARGET_CC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CC)))#' \
|
|
-e 's#@@TARGET_CXX@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CXX)))#' \
|
|
-e 's#@@TARGET_FC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_FC)))#' \
|
|
-e 's#@@CMAKE_SYSTEM_PROCESSOR@@#$(call qstrip,$(CMAKE_SYSTEM_PROCESSOR))#' \
|
|
-e 's#@@TOOLCHAIN_HAS_CXX@@#$(if $(BR2_INSTALL_LIBSTDCPP),1,0)#' \
|
|
-e 's#@@TOOLCHAIN_HAS_FORTRAN@@#$(if $(BR2_TOOLCHAIN_HAS_FORTRAN),1,0)#' \
|
|
-e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_RUNTIME_DEBUG),Debug,Release)#' \
|
|
$(TOPDIR)/support/misc/toolchainfile.cmake.in \
|
|
> $(HOST_DIR)/share/buildroot/toolchainfile.cmake
|
|
$(Q)$(INSTALL) -D -m 0644 support/misc/Buildroot.cmake \
|
|
$(HOST_DIR)/share/buildroot/Platform/Buildroot.cmake
|
|
endef
|
|
|
|
TOOLCHAIN_POST_INSTALL_STAGING_HOOKS += TOOLCHAIN_CMAKE_INSTALL_FILES
|