c3af086395
Currently, when we detect that tar is BSD-tar, we fake an unsupported version (major, minor) and rely on the version check to reject BSD-tar. There is no reason to use such shenanigans, when we can simply reject it from the onset. Simplify the logic: - use positive logic in the condition - directly exit in error Also, comment that case like the other cases are commented. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
60 lines
1.5 KiB
Bash
Executable file
60 lines
1.5 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
candidate="$1"
|
|
|
|
tar=`which $candidate`
|
|
if [ ! -x "$tar" ]; then
|
|
tar=`which tar`
|
|
if [ ! -x "$tar" ]; then
|
|
# echo nothing: no suitable tar found
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
# Output of 'tar --version' examples:
|
|
# tar (GNU tar) 1.15.1
|
|
# tar (GNU tar) 1.25
|
|
# bsdtar 2.8.3 - libarchive 2.8.3
|
|
version=`$tar --version | head -n 1 | sed 's/^.*\s\([0-9]\+\.\S\+\).*$/\1/'`
|
|
major=`echo "$version" | cut -d. -f1`
|
|
minor=`echo "$version" | cut -d. -f2`
|
|
bugfix=`echo "$version" | cut -d. -f3`
|
|
version_bsd=`$tar --version | grep 'bsdtar'`
|
|
|
|
# BSD tar does not have all the command-line options
|
|
if [ -n "${version_bsd}" ] ; then
|
|
# echo nothing: no suitable tar found
|
|
exit 1
|
|
fi
|
|
|
|
# Minimal version = 1.27 (previous versions do not correctly unpack archives
|
|
# containing hard-links if the --strip-components option is used or create
|
|
# different gnu long link headers for path elements > 100 characters).
|
|
major_min=1
|
|
minor_min=27
|
|
|
|
# Maximal version = 1.29 (1.30 changed --numeric-owner output for
|
|
# filenames > 100 characters). This is really a fix for a bug in
|
|
# earlier tar versions regarding deterministic output so it is
|
|
# unlikely to be reverted in later versions.
|
|
major_max=1
|
|
minor_max=29
|
|
|
|
if [ $major -lt $major_min -o $major -gt $major_max ]; then
|
|
# echo nothing: no suitable tar found
|
|
exit 1
|
|
fi
|
|
|
|
if [ $major -eq $major_min -a $minor -lt $minor_min ]; then
|
|
# echo nothing: no suitable tar found
|
|
exit 1
|
|
fi
|
|
|
|
if [ $major -eq $major_max -a $minor -gt $minor_max ]; then
|
|
# echo nothing: no suitable tar found
|
|
exit 1
|
|
fi
|
|
|
|
# valid
|
|
echo $tar
|