![Thomas Petazzoni](/assets/img/avatar_default.png)
Patches with renames apply properly with patch >= 2.7, but not with older patch versions. Since "git format-patch" by default generates patches with renames, Buildroot developers often don't realize that their patches will not apply properly on build machines that have patch < 2.7. In order to prevent such a situation from happening again, this commit adds some logic in apply-patches.sh to refuse applying patches that contain renames. Note that just searching for '^rename' is not sufficient, since the patch commit message may contain the words "rename from" or "rename to" as well. Therefore, the grep expression is made as accurate as possible, checking both. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> [Arnout: spaces instead of tabs (suggested by Yann); extend commit message.] Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
174 lines
5.9 KiB
Bash
Executable file
174 lines
5.9 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# A little script I whipped up to make it easy to
|
|
# patch source trees and have sane error handling
|
|
# -Erik
|
|
#
|
|
# (c) 2002 Erik Andersen <andersen@codepoet.org>
|
|
#
|
|
# Parameters:
|
|
# - "-s", optional. Silent operation, don't print anything if there
|
|
# isn't any error.
|
|
# - the build directory, optional, default value is '.'. The place where are
|
|
# the package sources.
|
|
# - the patch directory, optional, default '../kernel-patches'. The place
|
|
# where are the scripts you want to apply.
|
|
# - other parameters are the patch name patterns, optional, default value is
|
|
# '*'. Pattern(s) describing the patch names you want to apply.
|
|
#
|
|
# The script will look recursively for patches from the patch directory. If a
|
|
# file named 'series' exists then the patches mentioned in it will be applied
|
|
# as plain patches, regardless of their file name. If no 'series' file exists,
|
|
# the script will look for file names matching pattern(s). If the name
|
|
# ends with '.tar.*', '.tbz2' or '.tgz', the file is considered as an archive
|
|
# and will be uncompressed into a directory named
|
|
# '.patches-name_of_the_archive-unpacked'. It's the turn of this directory to
|
|
# be scanned with '*' as pattern. Remember that scanning is recursive. Other
|
|
# files than series file and archives are considered as a patch.
|
|
#
|
|
# Once a patch is found, the script will try to apply it. If its name doesn't
|
|
# end with '.gz', '.bz', '.bz2', '.xz', '.zip', '.Z', '.diff*' or '.patch*',
|
|
# it will be skipped. If necessary, the patch will be uncompressed before being
|
|
# applied. The list of the patches applied is stored in '.applied_patches_list'
|
|
# file in the build directory.
|
|
|
|
set -e
|
|
|
|
silent=
|
|
if [ "$1" = "-s" ] ; then
|
|
# add option to be used by the patch tool
|
|
silent=-s
|
|
shift
|
|
fi
|
|
|
|
# Set directories from arguments, or use defaults.
|
|
builddir=${1-.}
|
|
patchdir=${2-../kernel-patches}
|
|
shift 2
|
|
patchpattern=${@-*}
|
|
|
|
# use a well defined sorting order
|
|
export LC_COLLATE=C
|
|
|
|
if [ ! -d "${builddir}" ] ; then
|
|
echo "Aborting. '${builddir}' is not a directory."
|
|
exit 1
|
|
fi
|
|
if [ ! -d "${patchdir}" ] ; then
|
|
echo "Aborting. '${patchdir}' is not a directory."
|
|
exit 1
|
|
fi
|
|
|
|
# Remove any rejects present BEFORE patching - Because if there are
|
|
# any, even if patches are well applied, at the end it will complain
|
|
# about rejects in builddir.
|
|
find ${builddir}/ '(' -name '*.rej' -o -name '.*.rej' ')' -print0 | \
|
|
xargs -0 -r rm -f
|
|
|
|
function apply_patch {
|
|
path="${1%%/}"
|
|
patch="${2}"
|
|
case "${path}" in
|
|
/*) ;;
|
|
*) path="$PWD/${path}";;
|
|
esac
|
|
if [ "$3" ]; then
|
|
type="series"; uncomp="cat"
|
|
else
|
|
case "$patch" in
|
|
*.gz)
|
|
type="gzip"; uncomp="gunzip -dc"; ;;
|
|
*.bz)
|
|
type="bzip"; uncomp="bunzip -dc"; ;;
|
|
*.bz2)
|
|
type="bzip2"; uncomp="bunzip2 -dc"; ;;
|
|
*.xz)
|
|
type="xz"; uncomp="unxz -dc"; ;;
|
|
*.zip)
|
|
type="zip"; uncomp="unzip -d"; ;;
|
|
*.Z)
|
|
type="compress"; uncomp="uncompress -c"; ;;
|
|
*.diff*)
|
|
type="diff"; uncomp="cat"; ;;
|
|
*.patch*)
|
|
type="patch"; uncomp="cat"; ;;
|
|
*)
|
|
echo "Unsupported file type for ${path}/${patch}, skipping";
|
|
return 0
|
|
;;
|
|
esac
|
|
fi
|
|
if [ -z "$silent" ] ; then
|
|
echo ""
|
|
echo "Applying $patch using ${type}: "
|
|
fi
|
|
if [ ! -e "${path}/$patch" ] ; then
|
|
echo "Error: missing patch file ${path}/$patch"
|
|
exit 1
|
|
fi
|
|
existing="$(grep -E "/${patch}\$" ${builddir}/.applied_patches_list || true)"
|
|
if [ -n "${existing}" ]; then
|
|
echo "Error: duplicate filename '${patch}'"
|
|
echo "Conflicting files are:"
|
|
echo " already applied: ${existing}"
|
|
echo " to be applied : ${path}/${patch}"
|
|
exit 1
|
|
fi
|
|
if grep -q "^rename from" ${path}/${patch} && \
|
|
grep -q "^rename to" ${path}/${patch} ; then
|
|
echo "Error: patch contains some renames, not supported by old patch versions"
|
|
exit 1
|
|
fi
|
|
echo "${path}/${patch}" >> ${builddir}/.applied_patches_list
|
|
${uncomp} "${path}/$patch" | patch -g0 -p1 -E -d "${builddir}" -t -N $silent
|
|
if [ $? != 0 ] ; then
|
|
echo "Patch failed! Please fix ${patch}!"
|
|
exit 1
|
|
fi
|
|
}
|
|
|
|
function scan_patchdir {
|
|
local path=$1
|
|
shift 1
|
|
patches=${@-*}
|
|
|
|
# If there is a series file, use it instead of using ls sort order
|
|
# to apply patches. Skip line starting with a dash.
|
|
if [ -e "${path}/series" ] ; then
|
|
# The format of a series file accepts a second field that is
|
|
# used to specify the number of directory components to strip
|
|
# when applying the patch, in the form -pN (N an integer >= 0)
|
|
# We assume this field to always be -p1 whether it is present
|
|
# or missing.
|
|
series_patches="`grep -Ev "^#" ${path}/series | cut -d ' ' -f1 2> /dev/null`"
|
|
for i in $series_patches; do
|
|
apply_patch "$path" "$i" series
|
|
done
|
|
else
|
|
for i in `cd $path; ls -d $patches 2> /dev/null` ; do
|
|
if [ -d "${path}/$i" ] ; then
|
|
scan_patchdir "${path}/$i"
|
|
elif echo "$i" | grep -q -E "\.tar(\..*)?$|\.tbz2?$|\.tgz$" ; then
|
|
unpackedarchivedir="$builddir/.patches-$(basename $i)-unpacked"
|
|
rm -rf "$unpackedarchivedir" 2> /dev/null
|
|
mkdir "$unpackedarchivedir"
|
|
tar -C "$unpackedarchivedir" -xaf "${path}/$i"
|
|
scan_patchdir "$unpackedarchivedir"
|
|
else
|
|
apply_patch "$path" "$i"
|
|
fi
|
|
done
|
|
fi
|
|
}
|
|
|
|
touch ${builddir}/.applied_patches_list
|
|
scan_patchdir "$patchdir" "$patchpattern"
|
|
|
|
# Check for rejects...
|
|
if [ "`find $builddir/ '(' -name '*.rej' -o -name '.*.rej' ')' -print`" ] ; then
|
|
echo "Aborting. Reject files found."
|
|
exit 1
|
|
fi
|
|
|
|
# Remove backup files
|
|
find $builddir/ '(' -name '*.orig' -o -name '.*.orig' ')' -exec rm -f {} \;
|