Revert "Show games in perfstat from player's perspective"

This reverts commit a0c13389ce.

use pov=username instead

app/views/user/perfStat.scala

@@ -62,7 +62,7 @@ object perfStat {
             counter(stat.count),
             highlow(stat),
             resultStreak(stat.resultStreak),
-            result(stat),
+            result(stat, user),
             playStreakNb(stat.playStreak),
             playStreakTime(stat.playStreak)
           )
@@ -259,7 +259,9 @@ object perfStat {
       resultStreakSide(streak.loss, losingStreak(), "red")
     )
 
-  private def resultTable(results: lila.perfStat.Results, title: Frag)(implicit lang: Lang): Frag =
+  private def resultTable(results: lila.perfStat.Results, title: Frag, user: User)(implicit
+      lang: Lang
+  ): Frag =
     div(
       table(
         thead(
@@ -272,7 +274,7 @@ object perfStat {
             tr(
               td(userIdLink(r.opId.value.some, withOnline = false), " (", r.opInt, ")"),
               td(
-                a(cls := "glpt", href := routes.Round.watcher(r.gameId, r.color.name))(
+                a(cls := "glpt", href := s"${routes.Round.watcher(r.gameId, "white")}?pov=${user.username}")(
                   absClientDateTime(r.at)
                 )
               )
@@ -282,10 +284,10 @@ object perfStat {
       )
     )
 
-  private def result(stat: PerfStat)(implicit lang: Lang): Frag =
+  private def result(stat: PerfStat, user: User)(implicit lang: Lang): Frag =
     st.section(cls := "result split")(
-      resultTable(stat.bestWins, bestRated()),
-      resultTable(stat.worstLosses, worstRated())
+      resultTable(stat.bestWins, bestRated(), user),
+      resultTable(stat.worstLosses, worstRated(), user)
     )
 
   private def playStreakNbStreak(s: lila.perfStat.Streak, title: Frag => Frag)(implicit lang: Lang): Frag =

modules/perfStat/src/main/PerfStat.scala

@@ -1,6 +1,5 @@
 package lila.perfStat
 
-import chess.Color
 import org.joda.time.{ DateTime, Period }
 
 import lila.common.Heapsort
@@ -197,7 +196,7 @@ object RatingAt {
       } orElse cur
 }
 
-case class Result(opInt: Int, opId: UserId, at: DateTime, gameId: String, color: Color)
+case class Result(opInt: Int, opId: UserId, at: DateTime, gameId: String)
 
 case class Results(results: List[Result]) extends AnyVal {
   def agg(pov: Pov, comp: Int) =
@@ -211,8 +210,7 @@ case class Results(results: List[Result]) extends AnyVal {
               opInt,
               UserId(~pov.opponent.userId),
               pov.game.movedAt,
-              pov.gameId,
-              pov.player.color
+              pov.gameId
             ) :: results,
             Results.nb,
             Ordering.by[Result, Int](_.opInt * comp)