type safety: use Status rather than Int - for #9850

also filters out exotic status numbers

app/controllers/Api.scala

@@ -272,12 +272,12 @@ final class Api(
   def tournamentsByOwner(name: String, status: List[Int]) =
     Action.async { implicit req =>
       implicit val lang = reqLang
-      (name != "lichess") ?? env.user.repo.named(name) flatMap {
+      (name != lila.user.User.lichessId) ?? env.user.repo.named(name) flatMap {
         _ ?? { user =>
           val nb = getInt("nb", req) | Int.MaxValue
           jsonStream {
             env.tournament.api
-              .byOwnerStream(user, status, MaxPerSecond(20), nb)
+              .byOwnerStream(user, status flatMap lila.tournament.Status.apply, MaxPerSecond(20), nb)
               .mapAsync(1)(env.tournament.apiJsonView.fullJson)
           }.fuccess
         }

modules/tournament/src/main/Status.scala

@@ -10,7 +10,7 @@ sealed abstract private[tournament] class Status(val id: Int) extends Ordered[St
   def is(f: Status.type => Status): Boolean = is(f(Status))
 }
 
-private[tournament] object Status {
+object Status {
 
   case object Created  extends Status(10)
   case object Started  extends Status(20)

modules/tournament/src/main/TournamentApi.scala

@@ -668,7 +668,12 @@ final class TournamentApi(
         }
       }
 
-  def byOwnerStream(owner: User, status: List[Int], perSecond: MaxPerSecond, nb: Int): Source[Tournament, _] =
+  def byOwnerStream(
+      owner: User,
+      status: List[Status],
+      perSecond: MaxPerSecond,
+      nb: Int
+  ): Source[Tournament, _] =
     tournamentRepo
       .sortedCursor(owner, status, perSecond.value)
       .documentSource(nb)

modules/tournament/src/main/TournamentRepo.scala

@@ -389,12 +389,12 @@ final class TournamentRepo(val coll: Coll, playerCollName: CollName)(implicit
 
   private[tournament] def sortedCursor(
       owner: lila.user.User,
-      status: List[Int],
+      status: List[Status],
       batchSize: Int,
       readPreference: ReadPreference = ReadPreference.secondaryPreferred
   ): AkkaStreamCursor[Tournament] =
     coll
-      .find($doc("createdBy" -> owner.id ) ++ ( !status.isEmpty ?? $doc("status" $in status) ))
+      .find($doc("createdBy" -> owner.id) ++ (status.nonEmpty ?? $doc("status" $in status)))
       .sort($sort desc "startsAt")
       .batchSize(batchSize)
       .cursor[Tournament](readPreference)