deepcrayon
/
lila
1
0
Fork 0
Code Releases Activity

limit game plies to 600 

Analysis of a 2000 plies game caused a stack overflow
pull/4013/head
Thibault Duplessis 2018-02-04 00:26:36 -05:00
parent 08e05ec51f
commit 5d938e2b60
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/game/src/main/BSONHandlers.scala
View File

@ -69,7 +69,7 @@ object BSONHandlers {
def reads(r: BSON.Reader): Game = {
val gameVariant = Variant(r intD F.variant) | chess.variant.Standard
val plies = r int F.turns
val plies = r int F.turns atMost Game.maxPlies // unlimited can cause StackOverflowError
val turnColor = Color.fromPly(plies)
val decoded = r.bytesO(F.huffmanPgn).map { PgnStorage.Huffman.decode(_, plies) } | {
@ -187,7 +187,7 @@ object BSONHandlers {
) ++ {
o.pgnStorage match {
case f @ PgnStorage.OldBin => $doc(
F.oldPgn -> f.encode(o.pgnMoves),
F.oldPgn -> f.encode(o.pgnMoves take Game.maxPlies),
F.binaryPieces -> BinaryFormat.piece.write(o.board.pieces),
F.positionHashes -> o.history.positionHashes,
F.unmovedRooks -> o.history.unmovedRooks,
@ -200,7 +200,7 @@ object BSONHandlers {
F.crazyData -> o.board.crazyData
)
case f @ PgnStorage.Huffman => $doc(
F.huffmanPgn -> f.encode(o.pgnMoves)
F.huffmanPgn -> f.encode(o.pgnMoves take Game.maxPlies)
)
}
}

2
modules/game/src/main/Game.scala
View File

@ -565,6 +565,8 @@ object Game {
val maxPlayingRealtime = 100 // plus 200 correspondence games
val maxPlies = 600 // unlimited can cause StackOverflowError
val analysableVariants: Set[Variant] = Set(
chess.variant.Standard,
chess.variant.Crazyhouse,