strictness of board validation

app/ai/stockfish/Ai.scala

@@ -26,7 +26,7 @@ final class Ai(server: Server) extends lila.ai.Ai with Stockfish {
     server.analyse(pgn, initialFen)
 
   private def withValidSituation[A](dbGame: DbGame)(op: ⇒ Future[Valid[A]]): Future[Valid[A]] =
-    if (dbGame.toChess.situation.playable) op
+    if (dbGame.toChess.situation playable true) op
     else Future { !!("Invalid game situation: " + dbGame.toChess.situation) }
 
   private implicit val executor = Akka.system.dispatcher

app/controllers/Setup.scala

@@ -115,7 +115,8 @@ object Setup extends LilaController with TheftPrevention with RoundEventPerforme
       for {
         fen ← get("fen")
         parsed ← chess.format.Forsyth <<< fen
-        if parsed.situation.playable
+        strict = get("strict").isDefined
+        if (parsed.situation playable strict)
         validated = chess.format.Forsyth >> parsed
       } yield """<div class="mini_board parse_fen" data-color="%s" data-fen="%s"></div> """.format(
         parsed.situation.color.name, validated)

app/setup/FormFactory.scala

@@ -47,7 +47,7 @@ private[setup] final class FormFactory(
       "increment" -> increment,
       "level" -> level,
       "color" -> color,
-      "fen" -> fen
+      "fen" -> fen(true)
     )(AiConfig.<<)(_.>>)
   )
 
@@ -69,7 +69,7 @@ private[setup] final class FormFactory(
       "increment" -> increment,
       "mode" -> mode(ctx.isAuth),
       "color" -> color,
-      "fen" -> fen
+      "fen" -> fen(false)
     )(FriendConfig.<<)(_.>>) verifying ("Invalid clock", _.validClock)
   )
 

app/setup/Mappings.scala

@@ -23,7 +23,7 @@ object Mappings {
   val speed = number.verifying(Config.speeds contains _)
   val eloDiff = number.verifying(FilterConfig.eloDiffs contains _)
 
-  val fen = optional {
-    nonEmptyText verifying { source ⇒ ~(Forsyth <<< source).map(_.situation.playable) }
+  def fen(strict: Boolean) = optional {
+    nonEmptyText verifying { source ⇒ ~(Forsyth <<< source).map(_.situation playable strict) }
   }
 }

app/views/setup/ai.scala.html

@@ -4,7 +4,7 @@
 <div class="variants buttons">
   @setup.radios(form("variant"), translatedVariantChoicesWithFen)
 </div>
-@fenInput(form("fen"))
+@fenInput(form("fen"), true)
 @setup.clock(form, lila.setup.AiConfig)
 @trans.level()
 <div class="level buttons">

app/views/setup/fenInput.scala.html

@@ -1,6 +1,6 @@
-@(field: play.api.data.Field)(implicit ctx: Context)
+@(field: play.api.data.Field, strict: Boolean)(implicit ctx: Context)
 
-<div class="fen_position optional_config" data-validate-url="@routes.Setup.validateFen">
+<div class="fen_position optional_config" data-validate-url="@routes.Setup.validateFen@strict.fold("?strict=1", "")">
   @base.input(field, placeholder=trans.pasteTheFenStringHere.str().some)
   <div class="preview"></div>
 </div>

app/views/setup/friend.scala.html

@@ -6,7 +6,7 @@
 <div class="variants buttons">
   @setup.radios(form("variant"), translatedVariantChoicesWithFen)
 </div>
-@fenInput(form("fen"))
+@fenInput(form("fen"), false)
 @setup.clock(form, lila.setup.FriendConfig)
 @if(ctx.isAuth) {
 <div class="mode_choice buttons">

scalachess

@@ -1 +1 @@
-Subproject commit 195b624927560fa580daa0b54b5eb4c7c23bd582
+Subproject commit 5d7b1e1d42143c6a16cc11928ebd741c8ab4d973

todo

@@ -1,4 +1,3 @@
-finish flagged game
 start chess960 after both player move http://fr.lichess.org/forum/lichess-feedback/clock-fairness-in-chess960-games
 guess friend list
 takeback play 2 times ?? http://en.lichess.org/analyse/nfjchnmo/black move 45