From c7ae8c5a99fa463dea23c34e0bd70e71dfc118b9 Mon Sep 17 00:00:00 2001 From: Jim Mussared Date: Tue, 22 Oct 2019 12:36:02 +1100 Subject: [PATCH] py/objstr: Size-optimise failure path for mp_obj_str_get_buffer. These fields are never looked at if the function returns non-zero. --- py/objstr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/py/objstr.c b/py/objstr.c index 882436363..e221982c5 100644 --- a/py/objstr.c +++ b/py/objstr.c @@ -1913,9 +1913,6 @@ mp_int_t mp_obj_str_get_buffer(mp_obj_t self_in, mp_buffer_info_t *bufinfo, mp_u return 0; } else { // can't write to a string - bufinfo->buf = NULL; - bufinfo->len = 0; - bufinfo->typecode = -1; return 1; } }