2019-06-04 02:11:33 -06:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2006-11-28 18:34:59 -07:00
|
|
|
/* Helper handling for netfilter. */
|
|
|
|
|
|
|
|
/* (C) 1999-2001 Paul `Rusty' Russell
|
|
|
|
* (C) 2002-2006 Netfilter Core Team <coreteam@netfilter.org>
|
|
|
|
* (C) 2003,2004 USAGI/WIDE Project <http://www.linux-ipv6.org>
|
2013-04-06 07:24:29 -06:00
|
|
|
* (C) 2006-2012 Patrick McHardy <kaber@trash.net>
|
2006-11-28 18:34:59 -07:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/netfilter.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/skbuff.h>
|
|
|
|
#include <linux/vmalloc.h>
|
|
|
|
#include <linux/stddef.h>
|
|
|
|
#include <linux/random.h>
|
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/netdevice.h>
|
2008-05-13 07:37:05 -06:00
|
|
|
#include <linux/rculist.h>
|
2008-11-05 04:03:18 -07:00
|
|
|
#include <linux/rtnetlink.h>
|
2006-11-28 18:34:59 -07:00
|
|
|
|
|
|
|
#include <net/netfilter/nf_conntrack.h>
|
2006-11-28 18:35:06 -07:00
|
|
|
#include <net/netfilter/nf_conntrack_l4proto.h>
|
2006-11-28 18:34:59 -07:00
|
|
|
#include <net/netfilter/nf_conntrack_helper.h>
|
|
|
|
#include <net/netfilter/nf_conntrack_core.h>
|
2007-07-07 23:23:42 -06:00
|
|
|
#include <net/netfilter/nf_conntrack_extend.h>
|
2013-02-10 10:56:56 -07:00
|
|
|
#include <net/netfilter/nf_log.h>
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2008-01-31 05:36:54 -07:00
|
|
|
static DEFINE_MUTEX(nf_ct_helper_mutex);
|
2012-05-13 13:44:54 -06:00
|
|
|
struct hlist_head *nf_ct_helper_hash __read_mostly;
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_hash);
|
|
|
|
unsigned int nf_ct_helper_hsize __read_mostly;
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_hsize);
|
2007-07-07 23:36:46 -06:00
|
|
|
static unsigned int nf_ct_helper_count __read_mostly;
|
|
|
|
|
2016-04-14 09:13:41 -06:00
|
|
|
static bool nf_ct_auto_assign_helper __read_mostly = false;
|
2012-04-18 03:20:41 -06:00
|
|
|
module_param_named(nf_conntrack_helper, nf_ct_auto_assign_helper, bool, 0644);
|
|
|
|
MODULE_PARM_DESC(nf_conntrack_helper,
|
2016-04-14 09:13:41 -06:00
|
|
|
"Enable automatic conntrack helper assignment (default 0)");
|
2012-04-18 03:20:41 -06:00
|
|
|
|
2019-04-17 08:46:15 -06:00
|
|
|
static DEFINE_MUTEX(nf_ct_nat_helpers_mutex);
|
|
|
|
static struct list_head nf_ct_nat_helpers __read_mostly;
|
|
|
|
|
2007-07-07 23:36:46 -06:00
|
|
|
/* Stupid hash, but collision free for the default registrations of the
|
|
|
|
* helpers currently in the kernel. */
|
|
|
|
static unsigned int helper_hash(const struct nf_conntrack_tuple *tuple)
|
|
|
|
{
|
|
|
|
return (((tuple->src.l3num << 8) | tuple->dst.protonum) ^
|
2007-07-26 10:33:19 -06:00
|
|
|
(__force __u16)tuple->src.u.all) % nf_ct_helper_hsize;
|
2007-07-07 23:36:46 -06:00
|
|
|
}
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2008-11-18 03:54:05 -07:00
|
|
|
static struct nf_conntrack_helper *
|
2006-11-28 18:34:59 -07:00
|
|
|
__nf_ct_helper_find(const struct nf_conntrack_tuple *tuple)
|
|
|
|
{
|
2007-07-07 23:36:46 -06:00
|
|
|
struct nf_conntrack_helper *helper;
|
2007-07-07 23:31:32 -06:00
|
|
|
struct nf_conntrack_tuple_mask mask = { .src.u.all = htons(0xFFFF) };
|
2007-07-07 23:36:46 -06:00
|
|
|
unsigned int h;
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2007-07-07 23:36:46 -06:00
|
|
|
if (!nf_ct_helper_count)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
h = helper_hash(tuple);
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-27 18:06:00 -07:00
|
|
|
hlist_for_each_entry_rcu(helper, &nf_ct_helper_hash[h], hnode) {
|
2007-07-07 23:36:46 -06:00
|
|
|
if (nf_ct_tuple_src_mask_cmp(tuple, &helper->tuple, &mask))
|
|
|
|
return helper;
|
2006-11-28 18:34:59 -07:00
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct nf_conntrack_helper *
|
2010-02-03 05:41:29 -07:00
|
|
|
__nf_conntrack_helper_find(const char *name, u16 l3num, u8 protonum)
|
2006-11-28 18:34:59 -07:00
|
|
|
{
|
|
|
|
struct nf_conntrack_helper *h;
|
2007-07-07 23:36:46 -06:00
|
|
|
unsigned int i;
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2007-07-07 23:36:46 -06:00
|
|
|
for (i = 0; i < nf_ct_helper_hsize; i++) {
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-27 18:06:00 -07:00
|
|
|
hlist_for_each_entry_rcu(h, &nf_ct_helper_hash[i], hnode) {
|
2016-11-03 07:44:42 -06:00
|
|
|
if (strcmp(h->name, name))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (h->tuple.src.l3num != NFPROTO_UNSPEC &&
|
|
|
|
h->tuple.src.l3num != l3num)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (h->tuple.dst.protonum == protonum)
|
2007-07-07 23:36:46 -06:00
|
|
|
return h;
|
|
|
|
}
|
2006-11-28 18:34:59 -07:00
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
2010-02-03 05:41:29 -07:00
|
|
|
EXPORT_SYMBOL_GPL(__nf_conntrack_helper_find);
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2010-02-03 09:17:06 -07:00
|
|
|
struct nf_conntrack_helper *
|
|
|
|
nf_conntrack_helper_try_module_get(const char *name, u16 l3num, u8 protonum)
|
|
|
|
{
|
|
|
|
struct nf_conntrack_helper *h;
|
|
|
|
|
2017-03-29 05:11:27 -06:00
|
|
|
rcu_read_lock();
|
|
|
|
|
2010-02-03 09:17:06 -07:00
|
|
|
h = __nf_conntrack_helper_find(name, l3num, protonum);
|
|
|
|
#ifdef CONFIG_MODULES
|
|
|
|
if (h == NULL) {
|
2017-03-29 05:11:27 -06:00
|
|
|
rcu_read_unlock();
|
|
|
|
if (request_module("nfct-helper-%s", name) == 0) {
|
|
|
|
rcu_read_lock();
|
2010-02-03 09:17:06 -07:00
|
|
|
h = __nf_conntrack_helper_find(name, l3num, protonum);
|
2017-03-29 05:11:27 -06:00
|
|
|
} else {
|
|
|
|
return h;
|
|
|
|
}
|
2010-02-03 09:17:06 -07:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
if (h != NULL && !try_module_get(h->me))
|
|
|
|
h = NULL;
|
2017-05-07 08:01:56 -06:00
|
|
|
if (h != NULL && !refcount_inc_not_zero(&h->refcnt)) {
|
|
|
|
module_put(h->me);
|
|
|
|
h = NULL;
|
|
|
|
}
|
2010-02-03 09:17:06 -07:00
|
|
|
|
2017-03-29 05:11:27 -06:00
|
|
|
rcu_read_unlock();
|
|
|
|
|
2010-02-03 09:17:06 -07:00
|
|
|
return h;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_conntrack_helper_try_module_get);
|
|
|
|
|
2017-05-07 08:01:55 -06:00
|
|
|
void nf_conntrack_helper_put(struct nf_conntrack_helper *helper)
|
|
|
|
{
|
2017-05-07 08:01:56 -06:00
|
|
|
refcount_dec(&helper->refcnt);
|
2017-05-07 08:01:55 -06:00
|
|
|
module_put(helper->me);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_conntrack_helper_put);
|
|
|
|
|
2019-04-17 08:46:15 -06:00
|
|
|
static struct nf_conntrack_nat_helper *
|
|
|
|
nf_conntrack_nat_helper_find(const char *mod_name)
|
|
|
|
{
|
|
|
|
struct nf_conntrack_nat_helper *cur;
|
|
|
|
bool found = false;
|
|
|
|
|
|
|
|
list_for_each_entry_rcu(cur, &nf_ct_nat_helpers, list) {
|
|
|
|
if (!strcmp(cur->mod_name, mod_name)) {
|
|
|
|
found = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return found ? cur : NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
nf_nat_helper_try_module_get(const char *name, u16 l3num, u8 protonum)
|
|
|
|
{
|
|
|
|
struct nf_conntrack_helper *h;
|
|
|
|
struct nf_conntrack_nat_helper *nat;
|
|
|
|
char mod_name[NF_CT_HELPER_NAME_LEN];
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
rcu_read_lock();
|
|
|
|
h = __nf_conntrack_helper_find(name, l3num, protonum);
|
|
|
|
if (!h) {
|
|
|
|
rcu_read_unlock();
|
|
|
|
return -ENOENT;
|
|
|
|
}
|
|
|
|
|
|
|
|
nat = nf_conntrack_nat_helper_find(h->nat_mod_name);
|
|
|
|
if (!nat) {
|
|
|
|
snprintf(mod_name, sizeof(mod_name), "%s", h->nat_mod_name);
|
|
|
|
rcu_read_unlock();
|
|
|
|
request_module(mod_name);
|
|
|
|
|
|
|
|
rcu_read_lock();
|
|
|
|
nat = nf_conntrack_nat_helper_find(mod_name);
|
|
|
|
if (!nat) {
|
|
|
|
rcu_read_unlock();
|
|
|
|
return -ENOENT;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!try_module_get(nat->module))
|
|
|
|
ret = -ENOENT;
|
|
|
|
|
|
|
|
rcu_read_unlock();
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_nat_helper_try_module_get);
|
|
|
|
|
|
|
|
void nf_nat_helper_put(struct nf_conntrack_helper *helper)
|
|
|
|
{
|
|
|
|
struct nf_conntrack_nat_helper *nat;
|
|
|
|
|
|
|
|
nat = nf_conntrack_nat_helper_find(helper->nat_mod_name);
|
|
|
|
if (WARN_ON_ONCE(!nat))
|
|
|
|
return;
|
|
|
|
|
|
|
|
module_put(nat->module);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_nat_helper_put);
|
|
|
|
|
2012-06-07 04:11:50 -06:00
|
|
|
struct nf_conn_help *
|
2018-07-09 04:06:33 -06:00
|
|
|
nf_ct_helper_ext_add(struct nf_conn *ct, gfp_t gfp)
|
2007-07-07 23:35:56 -06:00
|
|
|
{
|
|
|
|
struct nf_conn_help *help;
|
|
|
|
|
2017-04-15 17:29:17 -06:00
|
|
|
help = nf_ct_ext_add(ct, NF_CT_EXT_HELPER, gfp);
|
2007-07-07 23:35:56 -06:00
|
|
|
if (help)
|
|
|
|
INIT_HLIST_HEAD(&help->expectations);
|
|
|
|
else
|
|
|
|
pr_debug("failed to add helper extension area");
|
|
|
|
return help;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_ext_add);
|
|
|
|
|
2017-02-01 13:01:54 -07:00
|
|
|
static struct nf_conntrack_helper *
|
|
|
|
nf_ct_lookup_helper(struct nf_conn *ct, struct net *net)
|
|
|
|
{
|
|
|
|
if (!net->ct.sysctl_auto_assign_helper) {
|
|
|
|
if (net->ct.auto_assign_helper_warned)
|
|
|
|
return NULL;
|
|
|
|
if (!__nf_ct_helper_find(&ct->tuplehash[IP_CT_DIR_REPLY].tuple))
|
|
|
|
return NULL;
|
|
|
|
pr_info("nf_conntrack: default automatic helper assignment "
|
|
|
|
"has been turned off for security reasons and CT-based "
|
|
|
|
" firewall rule not found. Use the iptables CT target "
|
|
|
|
"to attach helpers instead.\n");
|
|
|
|
net->ct.auto_assign_helper_warned = 1;
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return __nf_ct_helper_find(&ct->tuplehash[IP_CT_DIR_REPLY].tuple);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2010-02-03 06:13:03 -07:00
|
|
|
int __nf_ct_try_assign_helper(struct nf_conn *ct, struct nf_conn *tmpl,
|
|
|
|
gfp_t flags)
|
2008-11-18 03:54:05 -07:00
|
|
|
{
|
2010-02-03 06:13:03 -07:00
|
|
|
struct nf_conntrack_helper *helper = NULL;
|
|
|
|
struct nf_conn_help *help;
|
2012-04-18 03:20:41 -06:00
|
|
|
struct net *net = nf_ct_net(ct);
|
2008-11-18 03:54:05 -07:00
|
|
|
|
2012-05-02 20:17:45 -06:00
|
|
|
/* We already got a helper explicitly attached. The function
|
|
|
|
* nf_conntrack_alter_reply - in case NAT is in use - asks for looking
|
|
|
|
* the helper up again. Since now the user is in full control of
|
|
|
|
* making consistent helper configurations, skip this automatic
|
|
|
|
* re-lookup, otherwise we'll lose the helper.
|
|
|
|
*/
|
|
|
|
if (test_bit(IPS_HELPER_BIT, &ct->status))
|
|
|
|
return 0;
|
|
|
|
|
2010-02-03 06:13:03 -07:00
|
|
|
if (tmpl != NULL) {
|
|
|
|
help = nfct_help(tmpl);
|
2012-05-02 20:17:45 -06:00
|
|
|
if (help != NULL) {
|
2010-02-03 06:13:03 -07:00
|
|
|
helper = help->helper;
|
2012-05-02 20:17:45 -06:00
|
|
|
set_bit(IPS_HELPER_BIT, &ct->status);
|
|
|
|
}
|
2010-02-03 06:13:03 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
help = nfct_help(ct);
|
2012-04-18 03:20:41 -06:00
|
|
|
|
2008-11-18 03:54:05 -07:00
|
|
|
if (helper == NULL) {
|
2017-02-01 13:01:54 -07:00
|
|
|
helper = nf_ct_lookup_helper(ct, net);
|
|
|
|
if (helper == NULL) {
|
|
|
|
if (help)
|
|
|
|
RCU_INIT_POINTER(help->helper, NULL);
|
|
|
|
return 0;
|
|
|
|
}
|
2008-11-18 03:54:05 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
if (help == NULL) {
|
2018-07-09 04:06:33 -06:00
|
|
|
help = nf_ct_helper_ext_add(ct, flags);
|
2016-09-09 06:01:26 -06:00
|
|
|
if (help == NULL)
|
|
|
|
return -ENOMEM;
|
2008-11-18 03:54:05 -07:00
|
|
|
} else {
|
2012-06-18 09:29:53 -06:00
|
|
|
/* We only allow helper re-assignment of the same sort since
|
|
|
|
* we cannot reallocate the helper extension area.
|
|
|
|
*/
|
2013-02-11 22:59:53 -07:00
|
|
|
struct nf_conntrack_helper *tmp = rcu_dereference(help->helper);
|
|
|
|
|
|
|
|
if (tmp && tmp->help != helper->help) {
|
2012-06-18 09:29:53 -06:00
|
|
|
RCU_INIT_POINTER(help->helper, NULL);
|
2016-09-09 06:01:26 -06:00
|
|
|
return 0;
|
2012-06-18 09:29:53 -06:00
|
|
|
}
|
2008-11-18 03:54:05 -07:00
|
|
|
}
|
|
|
|
|
2012-01-11 21:41:32 -07:00
|
|
|
rcu_assign_pointer(help->helper, helper);
|
2016-09-09 06:01:26 -06:00
|
|
|
|
|
|
|
return 0;
|
2008-11-18 03:54:05 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(__nf_ct_try_assign_helper);
|
|
|
|
|
2014-10-29 23:57:19 -06:00
|
|
|
/* appropriate ct lock protecting must be taken by caller */
|
2017-05-28 08:35:52 -06:00
|
|
|
static int unhelp(struct nf_conn *ct, void *me)
|
2006-11-28 18:34:59 -07:00
|
|
|
{
|
|
|
|
struct nf_conn_help *help = nfct_help(ct);
|
|
|
|
|
2014-03-03 06:46:01 -07:00
|
|
|
if (help && rcu_dereference_raw(help->helper) == me) {
|
2006-11-28 18:34:59 -07:00
|
|
|
nf_conntrack_event(IPCT_HELPER, ct);
|
2011-08-01 10:19:00 -06:00
|
|
|
RCU_INIT_POINTER(help->helper, NULL);
|
2006-11-28 18:34:59 -07:00
|
|
|
}
|
2017-05-28 08:35:52 -06:00
|
|
|
|
|
|
|
/* We are not intended to delete this conntrack. */
|
2006-11-28 18:34:59 -07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-06-13 04:28:22 -06:00
|
|
|
void nf_ct_helper_destroy(struct nf_conn *ct)
|
|
|
|
{
|
|
|
|
struct nf_conn_help *help = nfct_help(ct);
|
|
|
|
struct nf_conntrack_helper *helper;
|
|
|
|
|
|
|
|
if (help) {
|
|
|
|
rcu_read_lock();
|
|
|
|
helper = rcu_dereference(help->helper);
|
|
|
|
if (helper && helper->destroy)
|
|
|
|
helper->destroy(ct);
|
|
|
|
rcu_read_unlock();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-02-04 19:44:51 -07:00
|
|
|
static LIST_HEAD(nf_ct_helper_expectfn_list);
|
|
|
|
|
|
|
|
void nf_ct_helper_expectfn_register(struct nf_ct_helper_expectfn *n)
|
|
|
|
{
|
2014-03-03 06:46:01 -07:00
|
|
|
spin_lock_bh(&nf_conntrack_expect_lock);
|
2012-02-04 19:44:51 -07:00
|
|
|
list_add_rcu(&n->head, &nf_ct_helper_expectfn_list);
|
2014-03-03 06:46:01 -07:00
|
|
|
spin_unlock_bh(&nf_conntrack_expect_lock);
|
2012-02-04 19:44:51 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_expectfn_register);
|
|
|
|
|
|
|
|
void nf_ct_helper_expectfn_unregister(struct nf_ct_helper_expectfn *n)
|
|
|
|
{
|
2014-03-03 06:46:01 -07:00
|
|
|
spin_lock_bh(&nf_conntrack_expect_lock);
|
2012-02-04 19:44:51 -07:00
|
|
|
list_del_rcu(&n->head);
|
2014-03-03 06:46:01 -07:00
|
|
|
spin_unlock_bh(&nf_conntrack_expect_lock);
|
2012-02-04 19:44:51 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_expectfn_unregister);
|
|
|
|
|
2017-03-29 05:11:27 -06:00
|
|
|
/* Caller should hold the rcu lock */
|
2012-02-04 19:44:51 -07:00
|
|
|
struct nf_ct_helper_expectfn *
|
|
|
|
nf_ct_helper_expectfn_find_by_name(const char *name)
|
|
|
|
{
|
|
|
|
struct nf_ct_helper_expectfn *cur;
|
|
|
|
bool found = false;
|
|
|
|
|
|
|
|
list_for_each_entry_rcu(cur, &nf_ct_helper_expectfn_list, head) {
|
|
|
|
if (!strcmp(cur->name, name)) {
|
|
|
|
found = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return found ? cur : NULL;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_expectfn_find_by_name);
|
|
|
|
|
2017-03-29 05:11:27 -06:00
|
|
|
/* Caller should hold the rcu lock */
|
2012-02-04 19:44:51 -07:00
|
|
|
struct nf_ct_helper_expectfn *
|
|
|
|
nf_ct_helper_expectfn_find_by_symbol(const void *symbol)
|
|
|
|
{
|
|
|
|
struct nf_ct_helper_expectfn *cur;
|
|
|
|
bool found = false;
|
|
|
|
|
|
|
|
list_for_each_entry_rcu(cur, &nf_ct_helper_expectfn_list, head) {
|
|
|
|
if (cur->expectfn == symbol) {
|
|
|
|
found = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return found ? cur : NULL;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_expectfn_find_by_symbol);
|
|
|
|
|
2013-02-10 10:56:56 -07:00
|
|
|
__printf(3, 4)
|
|
|
|
void nf_ct_helper_log(struct sk_buff *skb, const struct nf_conn *ct,
|
|
|
|
const char *fmt, ...)
|
|
|
|
{
|
|
|
|
const struct nf_conn_help *help;
|
|
|
|
const struct nf_conntrack_helper *helper;
|
2013-02-18 14:51:07 -07:00
|
|
|
struct va_format vaf;
|
|
|
|
va_list args;
|
|
|
|
|
|
|
|
va_start(args, fmt);
|
|
|
|
|
|
|
|
vaf.fmt = fmt;
|
|
|
|
vaf.va = &args;
|
2013-02-10 10:56:56 -07:00
|
|
|
|
|
|
|
/* Called from the helper function, this call never fails */
|
|
|
|
help = nfct_help(ct);
|
|
|
|
|
2016-09-21 09:35:04 -06:00
|
|
|
/* rcu_read_lock()ed by nf_hook_thresh */
|
2013-02-10 10:56:56 -07:00
|
|
|
helper = rcu_dereference(help->helper);
|
|
|
|
|
2013-03-24 17:50:40 -06:00
|
|
|
nf_log_packet(nf_ct_net(ct), nf_ct_l3num(ct), 0, skb, NULL, NULL, NULL,
|
2013-02-18 14:51:07 -07:00
|
|
|
"nf_ct_%s: dropping packet: %pV ", helper->name, &vaf);
|
|
|
|
|
|
|
|
va_end(args);
|
2013-02-10 10:56:56 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_log);
|
|
|
|
|
2006-11-28 18:34:59 -07:00
|
|
|
int nf_conntrack_helper_register(struct nf_conntrack_helper *me)
|
|
|
|
{
|
2016-05-24 03:23:51 -06:00
|
|
|
struct nf_conntrack_tuple_mask mask = { .src.u.all = htons(0xFFFF) };
|
2007-07-07 23:36:46 -06:00
|
|
|
unsigned int h = helper_hash(&me->tuple);
|
2016-05-24 03:23:51 -06:00
|
|
|
struct nf_conntrack_helper *cur;
|
netfilter: nf_ct_helper: permit cthelpers with different names via nfnetlink
cthelpers added via nfnetlink may have the same tuple, i.e. except for
the l3proto and l4proto, other fields are all zero. So even with the
different names, we will also fail to add them:
# nfct helper add ssdp inet udp
# nfct helper add tftp inet udp
nfct v1.4.3: netlink error: File exists
So in order to avoid unpredictable behaviour, we should:
1. cthelpers can be selected by nft ct helper obj or xt_CT target, so
report error if duplicated { name, l3proto, l4proto } tuple exist.
2. cthelpers can be selected by nf_ct_tuple_src_mask_cmp when
nf_ct_auto_assign_helper is enabled, so also report error if duplicated
{ l3proto, l4proto, src-port } tuple exist.
Also note, if the cthelper is added from userspace, then the src-port will
always be zero, it's invalid for nf_ct_auto_assign_helper, so there's no
need to check the second point listed above.
Fixes: 893e093c786c ("netfilter: nf_ct_helper: bail out on duplicated helpers")
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2017-04-15 05:27:42 -06:00
|
|
|
int ret = 0, i;
|
2007-07-07 23:36:46 -06:00
|
|
|
|
2008-03-25 21:09:15 -06:00
|
|
|
BUG_ON(me->expect_policy == NULL);
|
|
|
|
BUG_ON(me->expect_class_max >= NF_CT_MAX_EXPECT_CLASSES);
|
2009-03-25 11:44:01 -06:00
|
|
|
BUG_ON(strlen(me->name) > NF_CT_HELPER_NAME_LEN - 1);
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2017-03-24 07:32:19 -06:00
|
|
|
if (me->expect_policy->max_expected > NF_CT_EXPECT_MAX_CNT)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2008-01-31 05:36:54 -07:00
|
|
|
mutex_lock(&nf_ct_helper_mutex);
|
netfilter: nf_ct_helper: permit cthelpers with different names via nfnetlink
cthelpers added via nfnetlink may have the same tuple, i.e. except for
the l3proto and l4proto, other fields are all zero. So even with the
different names, we will also fail to add them:
# nfct helper add ssdp inet udp
# nfct helper add tftp inet udp
nfct v1.4.3: netlink error: File exists
So in order to avoid unpredictable behaviour, we should:
1. cthelpers can be selected by nft ct helper obj or xt_CT target, so
report error if duplicated { name, l3proto, l4proto } tuple exist.
2. cthelpers can be selected by nf_ct_tuple_src_mask_cmp when
nf_ct_auto_assign_helper is enabled, so also report error if duplicated
{ l3proto, l4proto, src-port } tuple exist.
Also note, if the cthelper is added from userspace, then the src-port will
always be zero, it's invalid for nf_ct_auto_assign_helper, so there's no
need to check the second point listed above.
Fixes: 893e093c786c ("netfilter: nf_ct_helper: bail out on duplicated helpers")
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2017-04-15 05:27:42 -06:00
|
|
|
for (i = 0; i < nf_ct_helper_hsize; i++) {
|
|
|
|
hlist_for_each_entry(cur, &nf_ct_helper_hash[i], hnode) {
|
|
|
|
if (!strcmp(cur->name, me->name) &&
|
|
|
|
(cur->tuple.src.l3num == NFPROTO_UNSPEC ||
|
|
|
|
cur->tuple.src.l3num == me->tuple.src.l3num) &&
|
|
|
|
cur->tuple.dst.protonum == me->tuple.dst.protonum) {
|
|
|
|
ret = -EEXIST;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* avoid unpredictable behaviour for auto_assign_helper */
|
|
|
|
if (!(me->flags & NF_CT_HELPER_F_USERSPACE)) {
|
|
|
|
hlist_for_each_entry(cur, &nf_ct_helper_hash[h], hnode) {
|
|
|
|
if (nf_ct_tuple_src_mask_cmp(&cur->tuple, &me->tuple,
|
|
|
|
&mask)) {
|
|
|
|
ret = -EEXIST;
|
|
|
|
goto out;
|
|
|
|
}
|
2012-05-13 13:44:54 -06:00
|
|
|
}
|
|
|
|
}
|
2017-05-07 08:01:56 -06:00
|
|
|
refcount_set(&me->refcnt, 1);
|
2008-01-31 05:36:54 -07:00
|
|
|
hlist_add_head_rcu(&me->hnode, &nf_ct_helper_hash[h]);
|
2007-07-07 23:36:46 -06:00
|
|
|
nf_ct_helper_count++;
|
2012-05-13 13:44:54 -06:00
|
|
|
out:
|
2008-01-31 05:36:54 -07:00
|
|
|
mutex_unlock(&nf_ct_helper_mutex);
|
2012-05-13 13:44:54 -06:00
|
|
|
return ret;
|
2006-11-28 18:34:59 -07:00
|
|
|
}
|
2006-12-02 23:11:25 -07:00
|
|
|
EXPORT_SYMBOL_GPL(nf_conntrack_helper_register);
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2017-07-25 16:02:31 -06:00
|
|
|
static bool expect_iter_me(struct nf_conntrack_expect *exp, void *data)
|
2006-11-28 18:34:59 -07:00
|
|
|
{
|
2017-07-25 16:02:31 -06:00
|
|
|
struct nf_conn_help *help = nfct_help(exp->master);
|
|
|
|
const struct nf_conntrack_helper *me = data;
|
|
|
|
const struct nf_conntrack_helper *this;
|
|
|
|
|
|
|
|
if (exp->helper == me)
|
|
|
|
return true;
|
2016-05-15 11:50:14 -06:00
|
|
|
|
2017-07-25 16:02:31 -06:00
|
|
|
this = rcu_dereference_protected(help->helper,
|
|
|
|
lockdep_is_held(&nf_conntrack_expect_lock));
|
|
|
|
return this == me;
|
|
|
|
}
|
|
|
|
|
|
|
|
void nf_conntrack_helper_unregister(struct nf_conntrack_helper *me)
|
|
|
|
{
|
2016-05-15 11:50:14 -06:00
|
|
|
mutex_lock(&nf_ct_helper_mutex);
|
|
|
|
hlist_del_rcu(&me->hnode);
|
|
|
|
nf_ct_helper_count--;
|
|
|
|
mutex_unlock(&nf_ct_helper_mutex);
|
|
|
|
|
|
|
|
/* Make sure every nothing is still using the helper unless its a
|
|
|
|
* connection in the hash.
|
|
|
|
*/
|
|
|
|
synchronize_rcu();
|
2006-11-28 18:34:59 -07:00
|
|
|
|
2017-07-25 16:02:31 -06:00
|
|
|
nf_ct_expect_iterate_destroy(expect_iter_me, NULL);
|
2017-05-28 08:35:52 -06:00
|
|
|
nf_ct_iterate_destroy(unhelp, me);
|
2018-06-12 22:26:13 -06:00
|
|
|
|
|
|
|
/* Maybe someone has gotten the helper already when unhelp above.
|
|
|
|
* So need to wait it.
|
|
|
|
*/
|
|
|
|
synchronize_rcu();
|
2008-10-08 03:35:06 -06:00
|
|
|
}
|
2006-12-02 23:11:25 -07:00
|
|
|
EXPORT_SYMBOL_GPL(nf_conntrack_helper_unregister);
|
2007-07-07 23:23:42 -06:00
|
|
|
|
2016-07-17 21:39:23 -06:00
|
|
|
void nf_ct_helper_init(struct nf_conntrack_helper *helper,
|
|
|
|
u16 l3num, u16 protonum, const char *name,
|
|
|
|
u16 default_port, u16 spec_port, u32 id,
|
|
|
|
const struct nf_conntrack_expect_policy *exp_pol,
|
2017-04-15 17:29:17 -06:00
|
|
|
u32 expect_class_max,
|
2016-07-17 21:39:23 -06:00
|
|
|
int (*help)(struct sk_buff *skb, unsigned int protoff,
|
|
|
|
struct nf_conn *ct,
|
|
|
|
enum ip_conntrack_info ctinfo),
|
|
|
|
int (*from_nlattr)(struct nlattr *attr,
|
|
|
|
struct nf_conn *ct),
|
|
|
|
struct module *module)
|
|
|
|
{
|
|
|
|
helper->tuple.src.l3num = l3num;
|
|
|
|
helper->tuple.dst.protonum = protonum;
|
|
|
|
helper->tuple.src.u.all = htons(spec_port);
|
|
|
|
helper->expect_policy = exp_pol;
|
|
|
|
helper->expect_class_max = expect_class_max;
|
|
|
|
helper->help = help;
|
|
|
|
helper->from_nlattr = from_nlattr;
|
|
|
|
helper->me = module;
|
2019-04-17 08:46:15 -06:00
|
|
|
snprintf(helper->nat_mod_name, sizeof(helper->nat_mod_name),
|
|
|
|
NF_NAT_HELPER_PREFIX "%s", name);
|
2016-07-17 21:39:23 -06:00
|
|
|
|
|
|
|
if (spec_port == default_port)
|
|
|
|
snprintf(helper->name, sizeof(helper->name), "%s", name);
|
|
|
|
else
|
|
|
|
snprintf(helper->name, sizeof(helper->name), "%s-%u", name, id);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_ct_helper_init);
|
|
|
|
|
|
|
|
int nf_conntrack_helpers_register(struct nf_conntrack_helper *helper,
|
|
|
|
unsigned int n)
|
|
|
|
{
|
|
|
|
unsigned int i;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
err = nf_conntrack_helper_register(&helper[i]);
|
|
|
|
if (err < 0)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
return err;
|
|
|
|
err:
|
|
|
|
if (i > 0)
|
|
|
|
nf_conntrack_helpers_unregister(helper, i);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_conntrack_helpers_register);
|
|
|
|
|
|
|
|
void nf_conntrack_helpers_unregister(struct nf_conntrack_helper *helper,
|
|
|
|
unsigned int n)
|
|
|
|
{
|
|
|
|
while (n-- > 0)
|
|
|
|
nf_conntrack_helper_unregister(&helper[n]);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_conntrack_helpers_unregister);
|
|
|
|
|
2019-04-17 08:46:15 -06:00
|
|
|
void nf_nat_helper_register(struct nf_conntrack_nat_helper *nat)
|
|
|
|
{
|
|
|
|
mutex_lock(&nf_ct_nat_helpers_mutex);
|
|
|
|
list_add_rcu(&nat->list, &nf_ct_nat_helpers);
|
|
|
|
mutex_unlock(&nf_ct_nat_helpers_mutex);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_nat_helper_register);
|
|
|
|
|
|
|
|
void nf_nat_helper_unregister(struct nf_conntrack_nat_helper *nat)
|
|
|
|
{
|
|
|
|
mutex_lock(&nf_ct_nat_helpers_mutex);
|
|
|
|
list_del_rcu(&nat->list);
|
|
|
|
mutex_unlock(&nf_ct_nat_helpers_mutex);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(nf_nat_helper_unregister);
|
|
|
|
|
2017-04-20 01:54:23 -06:00
|
|
|
static const struct nf_ct_ext_type helper_extend = {
|
2007-07-07 23:23:42 -06:00
|
|
|
.len = sizeof(struct nf_conn_help),
|
|
|
|
.align = __alignof__(struct nf_conn_help),
|
|
|
|
.id = NF_CT_EXT_HELPER,
|
|
|
|
};
|
|
|
|
|
2018-12-18 15:04:49 -07:00
|
|
|
void nf_conntrack_helper_pernet_init(struct net *net)
|
2007-07-07 23:23:42 -06:00
|
|
|
{
|
2012-04-18 03:20:41 -06:00
|
|
|
net->ct.auto_assign_helper_warned = false;
|
|
|
|
net->ct.sysctl_auto_assign_helper = nf_ct_auto_assign_helper;
|
2013-01-21 15:10:30 -07:00
|
|
|
}
|
2012-04-18 03:20:41 -06:00
|
|
|
|
2013-01-21 15:10:30 -07:00
|
|
|
int nf_conntrack_helper_init(void)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
nf_ct_helper_hsize = 1; /* gets rounded up to use one page */
|
|
|
|
nf_ct_helper_hash =
|
|
|
|
nf_ct_alloc_hashtable(&nf_ct_helper_hsize, 0);
|
|
|
|
if (!nf_ct_helper_hash)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
ret = nf_ct_extend_register(&helper_extend);
|
|
|
|
if (ret < 0) {
|
|
|
|
pr_err("nf_ct_helper: Unable to register helper extension.\n");
|
|
|
|
goto out_extend;
|
2012-04-18 03:20:41 -06:00
|
|
|
}
|
|
|
|
|
2019-04-17 08:46:15 -06:00
|
|
|
INIT_LIST_HEAD(&nf_ct_nat_helpers);
|
2007-07-07 23:36:46 -06:00
|
|
|
return 0;
|
2013-01-21 15:10:30 -07:00
|
|
|
out_extend:
|
netfilter: use kvmalloc_array to allocate memory for hashtable
nf_ct_alloc_hashtable is used to allocate memory for conntrack,
NAT bysrc and expectation hashtable. Assuming 64k bucket size,
which means 7th order page allocation, __get_free_pages, called
by nf_ct_alloc_hashtable, will trigger the direct memory reclaim
and stall for a long time, when system has lots of memory stress
so replace combination of __get_free_pages and vzalloc with
kvmalloc_array, which provides a overflow check and a fallback
if no high order memory is available, and do not retry to reclaim
memory, reduce stall
and remove nf_ct_free_hashtable, since it is just a kvfree
Signed-off-by: Zhang Yu <zhangyu31@baidu.com>
Signed-off-by: Wang Li <wangli39@baidu.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2018-07-25 01:52:13 -06:00
|
|
|
kvfree(nf_ct_helper_hash);
|
2013-01-21 15:10:30 -07:00
|
|
|
return ret;
|
2007-07-07 23:23:42 -06:00
|
|
|
}
|
|
|
|
|
2013-01-21 15:10:30 -07:00
|
|
|
void nf_conntrack_helper_fini(void)
|
2007-07-07 23:23:42 -06:00
|
|
|
{
|
2013-01-21 15:10:30 -07:00
|
|
|
nf_ct_extend_unregister(&helper_extend);
|
netfilter: use kvmalloc_array to allocate memory for hashtable
nf_ct_alloc_hashtable is used to allocate memory for conntrack,
NAT bysrc and expectation hashtable. Assuming 64k bucket size,
which means 7th order page allocation, __get_free_pages, called
by nf_ct_alloc_hashtable, will trigger the direct memory reclaim
and stall for a long time, when system has lots of memory stress
so replace combination of __get_free_pages and vzalloc with
kvmalloc_array, which provides a overflow check and a fallback
if no high order memory is available, and do not retry to reclaim
memory, reduce stall
and remove nf_ct_free_hashtable, since it is just a kvfree
Signed-off-by: Zhang Yu <zhangyu31@baidu.com>
Signed-off-by: Wang Li <wangli39@baidu.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2018-07-25 01:52:13 -06:00
|
|
|
kvfree(nf_ct_helper_hash);
|
2007-07-07 23:23:42 -06:00
|
|
|
}
|