2005-04-16 16:20:36 -06:00
|
|
|
/*
|
|
|
|
* Intel IO-APIC support for multi-Pentium hosts.
|
|
|
|
*
|
|
|
|
* Copyright (C) 1997, 1998, 1999, 2000 Ingo Molnar, Hajnalka Szabo
|
|
|
|
*
|
|
|
|
* Many thanks to Stig Venaas for trying out countless experimental
|
|
|
|
* patches and reporting/debugging problems patiently!
|
|
|
|
*
|
|
|
|
* (c) 1999, Multiple IO-APIC support, developed by
|
|
|
|
* Ken-ichi Yaku <yaku@css1.kbnes.nec.co.jp> and
|
|
|
|
* Hidemi Kishimoto <kisimoto@css1.kbnes.nec.co.jp>,
|
|
|
|
* further tested and cleaned up by Zach Brown <zab@redhat.com>
|
|
|
|
* and Ingo Molnar <mingo@redhat.com>
|
|
|
|
*
|
|
|
|
* Fixes
|
|
|
|
* Maciej W. Rozycki : Bits for genuine 82489DX APICs;
|
|
|
|
* thanks to Eric Gilmore
|
|
|
|
* and Rolf G. Tews
|
|
|
|
* for testing these extensively
|
|
|
|
* Paul Diefenbaugh : Added full ACPI support
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/sched.h>
|
2006-10-04 03:16:42 -06:00
|
|
|
#include <linux/pci.h>
|
2005-04-16 16:20:36 -06:00
|
|
|
#include <linux/mc146818rtc.h>
|
|
|
|
#include <linux/acpi.h>
|
|
|
|
#include <linux/sysdev.h>
|
2006-10-04 03:16:59 -06:00
|
|
|
#include <linux/msi.h>
|
2006-10-04 03:17:01 -06:00
|
|
|
#include <linux/htirq.h>
|
2007-10-21 17:41:54 -06:00
|
|
|
#include <linux/dmar.h>
|
2008-01-30 05:32:19 -07:00
|
|
|
#include <linux/jiffies.h>
|
2006-02-16 15:42:04 -07:00
|
|
|
#ifdef CONFIG_ACPI
|
|
|
|
#include <acpi/acpi_bus.h>
|
|
|
|
#endif
|
2008-01-30 05:30:19 -07:00
|
|
|
#include <linux/bootmem.h>
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-02-23 04:40:58 -07:00
|
|
|
#include <asm/idle.h>
|
2005-04-16 16:20:36 -06:00
|
|
|
#include <asm/io.h>
|
|
|
|
#include <asm/smp.h>
|
|
|
|
#include <asm/desc.h>
|
|
|
|
#include <asm/proto.h>
|
2005-05-31 15:39:26 -06:00
|
|
|
#include <asm/acpi.h>
|
2006-01-11 14:44:27 -07:00
|
|
|
#include <asm/dma.h>
|
2008-07-14 10:18:04 -06:00
|
|
|
#include <asm/i8259.h>
|
2006-06-26 05:57:01 -06:00
|
|
|
#include <asm/nmi.h>
|
2006-10-04 03:16:42 -06:00
|
|
|
#include <asm/msidef.h>
|
2006-10-04 03:16:55 -06:00
|
|
|
#include <asm/hypertransport.h>
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2008-03-25 10:28:56 -06:00
|
|
|
#include <mach_ipi.h>
|
2008-03-25 15:10:46 -06:00
|
|
|
#include <mach_apic.h>
|
2008-03-25 10:28:56 -06:00
|
|
|
|
2007-02-23 04:32:47 -07:00
|
|
|
struct irq_cfg {
|
|
|
|
cpumask_t domain;
|
2007-02-23 04:40:58 -07:00
|
|
|
cpumask_t old_domain;
|
|
|
|
unsigned move_cleanup_count;
|
2007-02-23 04:32:47 -07:00
|
|
|
u8 vector;
|
2007-02-23 04:40:58 -07:00
|
|
|
u8 move_in_progress : 1;
|
2007-02-23 04:32:47 -07:00
|
|
|
};
|
|
|
|
|
|
|
|
/* irq_cfg is indexed by the sum of all RTEs in all I/O APICs. */
|
2008-05-12 07:43:36 -06:00
|
|
|
static struct irq_cfg irq_cfg[NR_IRQS] __read_mostly = {
|
2007-02-23 04:38:26 -07:00
|
|
|
[0] = { .domain = CPU_MASK_ALL, .vector = IRQ0_VECTOR, },
|
|
|
|
[1] = { .domain = CPU_MASK_ALL, .vector = IRQ1_VECTOR, },
|
|
|
|
[2] = { .domain = CPU_MASK_ALL, .vector = IRQ2_VECTOR, },
|
|
|
|
[3] = { .domain = CPU_MASK_ALL, .vector = IRQ3_VECTOR, },
|
|
|
|
[4] = { .domain = CPU_MASK_ALL, .vector = IRQ4_VECTOR, },
|
|
|
|
[5] = { .domain = CPU_MASK_ALL, .vector = IRQ5_VECTOR, },
|
|
|
|
[6] = { .domain = CPU_MASK_ALL, .vector = IRQ6_VECTOR, },
|
|
|
|
[7] = { .domain = CPU_MASK_ALL, .vector = IRQ7_VECTOR, },
|
|
|
|
[8] = { .domain = CPU_MASK_ALL, .vector = IRQ8_VECTOR, },
|
|
|
|
[9] = { .domain = CPU_MASK_ALL, .vector = IRQ9_VECTOR, },
|
|
|
|
[10] = { .domain = CPU_MASK_ALL, .vector = IRQ10_VECTOR, },
|
|
|
|
[11] = { .domain = CPU_MASK_ALL, .vector = IRQ11_VECTOR, },
|
|
|
|
[12] = { .domain = CPU_MASK_ALL, .vector = IRQ12_VECTOR, },
|
|
|
|
[13] = { .domain = CPU_MASK_ALL, .vector = IRQ13_VECTOR, },
|
|
|
|
[14] = { .domain = CPU_MASK_ALL, .vector = IRQ14_VECTOR, },
|
|
|
|
[15] = { .domain = CPU_MASK_ALL, .vector = IRQ15_VECTOR, },
|
2007-02-23 04:32:47 -07:00
|
|
|
};
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
static int assign_irq_vector(int irq, cpumask_t mask);
|
2006-10-04 03:16:46 -06:00
|
|
|
|
2008-04-15 14:36:56 -06:00
|
|
|
int first_system_vector = 0xfe;
|
|
|
|
|
|
|
|
char system_vectors[NR_VECTORS] = { [0 ... NR_VECTORS-1] = SYS_VECTOR_FREE};
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
#define __apicdebuginit __init
|
|
|
|
|
|
|
|
int sis_apic_bug; /* not actually supported, dummy for compile */
|
|
|
|
|
2005-05-20 15:27:59 -06:00
|
|
|
static int no_timer_check;
|
|
|
|
|
2007-01-08 16:04:46 -07:00
|
|
|
static int disable_timer_pin_1 __initdata;
|
|
|
|
|
2008-05-21 15:10:22 -06:00
|
|
|
int timer_through_8259 __initdata;
|
2007-01-08 16:04:46 -07:00
|
|
|
|
2006-01-11 14:46:06 -07:00
|
|
|
/* Where if anywhere is the i8259 connect in external int mode */
|
|
|
|
static struct { int pin, apic; } ioapic_i8259 = { -1, -1 };
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
static DEFINE_SPINLOCK(ioapic_lock);
|
2006-10-24 17:00:23 -06:00
|
|
|
DEFINE_SPINLOCK(vector_lock);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* # of IRQ routing registers
|
|
|
|
*/
|
|
|
|
int nr_ioapic_registers[MAX_IO_APICS];
|
|
|
|
|
2008-04-04 13:41:19 -06:00
|
|
|
/* I/O APIC entries */
|
2008-05-14 09:03:10 -06:00
|
|
|
struct mp_config_ioapic mp_ioapics[MAX_IO_APICS];
|
2008-04-04 13:41:19 -06:00
|
|
|
int nr_ioapics;
|
|
|
|
|
2008-04-04 13:41:38 -06:00
|
|
|
/* MP IRQ source entries */
|
2008-05-14 09:03:17 -06:00
|
|
|
struct mp_config_intsrc mp_irqs[MAX_IRQ_SOURCES];
|
2008-04-04 13:41:38 -06:00
|
|
|
|
|
|
|
/* # of MP IRQ source entries */
|
|
|
|
int mp_irq_entries;
|
|
|
|
|
2008-05-19 09:47:16 -06:00
|
|
|
DECLARE_BITMAP(mp_bus_not_pci, MAX_MP_BUSSES);
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/*
|
|
|
|
* Rough estimation of how many shared IRQs there are, can
|
|
|
|
* be changed anytime.
|
|
|
|
*/
|
2007-02-23 04:26:53 -07:00
|
|
|
#define MAX_PLUS_SHARED_IRQS NR_IRQS
|
2005-04-16 16:20:36 -06:00
|
|
|
#define PIN_MAP_SIZE (MAX_PLUS_SHARED_IRQS + NR_IRQS)
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This is performance-critical, we want to do it O(1)
|
|
|
|
*
|
|
|
|
* the indexing order of this array favors 1:1 mappings
|
|
|
|
* between pins and IRQs.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static struct irq_pin_list {
|
|
|
|
short apic, pin, next;
|
|
|
|
} irq_2_pin[PIN_MAP_SIZE];
|
|
|
|
|
2006-11-08 11:23:03 -07:00
|
|
|
struct io_apic {
|
|
|
|
unsigned int index;
|
|
|
|
unsigned int unused[3];
|
|
|
|
unsigned int data;
|
|
|
|
};
|
|
|
|
|
|
|
|
static __attribute_const__ struct io_apic __iomem *io_apic_base(int idx)
|
|
|
|
{
|
|
|
|
return (void __iomem *) __fix_to_virt(FIX_IO_APIC_BASE_0 + idx)
|
2008-05-14 09:03:10 -06:00
|
|
|
+ (mp_ioapics[idx].mp_apicaddr & ~PAGE_MASK);
|
2006-11-08 11:23:03 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline unsigned int io_apic_read(unsigned int apic, unsigned int reg)
|
|
|
|
{
|
|
|
|
struct io_apic __iomem *io_apic = io_apic_base(apic);
|
|
|
|
writel(reg, &io_apic->index);
|
|
|
|
return readl(&io_apic->data);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void io_apic_write(unsigned int apic, unsigned int reg, unsigned int value)
|
|
|
|
{
|
|
|
|
struct io_apic __iomem *io_apic = io_apic_base(apic);
|
|
|
|
writel(reg, &io_apic->index);
|
|
|
|
writel(value, &io_apic->data);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Re-write a value: to be used for read-modify-write
|
|
|
|
* cycles where the read already set up the index register.
|
|
|
|
*/
|
|
|
|
static inline void io_apic_modify(unsigned int apic, unsigned int value)
|
|
|
|
{
|
|
|
|
struct io_apic __iomem *io_apic = io_apic_base(apic);
|
|
|
|
writel(value, &io_apic->data);
|
|
|
|
}
|
|
|
|
|
2008-04-05 07:39:04 -06:00
|
|
|
static bool io_apic_level_ack_pending(unsigned int irq)
|
2007-07-21 09:10:45 -06:00
|
|
|
{
|
|
|
|
struct irq_pin_list *entry;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
entry = irq_2_pin + irq;
|
|
|
|
for (;;) {
|
|
|
|
unsigned int reg;
|
|
|
|
int pin;
|
|
|
|
|
|
|
|
pin = entry->pin;
|
|
|
|
if (pin == -1)
|
|
|
|
break;
|
|
|
|
reg = io_apic_read(entry->apic, 0x10 + pin*2);
|
|
|
|
/* Is the remote IRR bit set? */
|
2008-06-07 09:53:57 -06:00
|
|
|
if (reg & IO_APIC_REDIR_REMOTE_IRR) {
|
2008-04-05 07:39:04 -06:00
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
return true;
|
|
|
|
}
|
2007-07-21 09:10:45 -06:00
|
|
|
if (!entry->next)
|
|
|
|
break;
|
|
|
|
entry = irq_2_pin + entry->next;
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
2008-04-05 07:39:04 -06:00
|
|
|
|
|
|
|
return false;
|
2007-07-21 09:10:45 -06:00
|
|
|
}
|
|
|
|
|
2006-11-08 11:23:03 -07:00
|
|
|
/*
|
|
|
|
* Synchronize the IO-APIC and the CPU by doing
|
|
|
|
* a dummy read from the IO-APIC
|
|
|
|
*/
|
|
|
|
static inline void io_apic_sync(unsigned int apic)
|
|
|
|
{
|
|
|
|
struct io_apic __iomem *io_apic = io_apic_base(apic);
|
|
|
|
readl(&io_apic->data);
|
|
|
|
}
|
|
|
|
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
#define __DO_ACTION(R, ACTION, FINAL) \
|
|
|
|
\
|
|
|
|
{ \
|
|
|
|
int pin; \
|
|
|
|
struct irq_pin_list *entry = irq_2_pin + irq; \
|
|
|
|
\
|
2005-11-05 09:25:53 -07:00
|
|
|
BUG_ON(irq >= NR_IRQS); \
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
for (;;) { \
|
|
|
|
unsigned int reg; \
|
|
|
|
pin = entry->pin; \
|
|
|
|
if (pin == -1) \
|
|
|
|
break; \
|
|
|
|
reg = io_apic_read(entry->apic, 0x10 + R + pin*2); \
|
|
|
|
reg ACTION; \
|
|
|
|
io_apic_modify(entry->apic, reg); \
|
2007-02-23 04:23:52 -07:00
|
|
|
FINAL; \
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
if (!entry->next) \
|
|
|
|
break; \
|
|
|
|
entry = irq_2_pin + entry->next; \
|
|
|
|
} \
|
|
|
|
}
|
|
|
|
|
2006-09-26 02:52:30 -06:00
|
|
|
union entry_union {
|
|
|
|
struct { u32 w1, w2; };
|
|
|
|
struct IO_APIC_route_entry entry;
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct IO_APIC_route_entry ioapic_read_entry(int apic, int pin)
|
|
|
|
{
|
|
|
|
union entry_union eu;
|
|
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
eu.w1 = io_apic_read(apic, 0x10 + 2 * pin);
|
|
|
|
eu.w2 = io_apic_read(apic, 0x11 + 2 * pin);
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
return eu.entry;
|
|
|
|
}
|
|
|
|
|
2006-11-08 11:27:54 -07:00
|
|
|
/*
|
|
|
|
* When we write a new IO APIC routing entry, we need to write the high
|
|
|
|
* word first! If the mask bit in the low word is clear, we will enable
|
|
|
|
* the interrupt, and we need to make sure the entry is fully populated
|
|
|
|
* before that happens.
|
|
|
|
*/
|
2006-12-06 18:14:07 -07:00
|
|
|
static void
|
|
|
|
__ioapic_write_entry(int apic, int pin, struct IO_APIC_route_entry e)
|
2006-09-26 02:52:30 -06:00
|
|
|
{
|
|
|
|
union entry_union eu;
|
|
|
|
eu.entry = e;
|
2006-11-08 11:27:54 -07:00
|
|
|
io_apic_write(apic, 0x11 + 2*pin, eu.w2);
|
|
|
|
io_apic_write(apic, 0x10 + 2*pin, eu.w1);
|
2006-12-06 18:14:07 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void ioapic_write_entry(int apic, int pin, struct IO_APIC_route_entry e)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
__ioapic_write_entry(apic, pin, e);
|
2006-11-08 11:27:54 -07:00
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* When we mask an IO APIC routing entry, we need to write the low
|
|
|
|
* word first, in order to set the mask bit before we change the
|
|
|
|
* high bits!
|
|
|
|
*/
|
|
|
|
static void ioapic_mask_entry(int apic, int pin)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
union entry_union eu = { .entry.mask = 1 };
|
|
|
|
|
2006-09-26 02:52:30 -06:00
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
io_apic_write(apic, 0x10 + 2*pin, eu.w1);
|
|
|
|
io_apic_write(apic, 0x11 + 2*pin, eu.w2);
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
}
|
|
|
|
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
#ifdef CONFIG_SMP
|
2006-10-04 03:16:51 -06:00
|
|
|
static void __target_IO_APIC_irq(unsigned int irq, unsigned int dest, u8 vector)
|
|
|
|
{
|
|
|
|
int apic, pin;
|
|
|
|
struct irq_pin_list *entry = irq_2_pin + irq;
|
|
|
|
|
|
|
|
BUG_ON(irq >= NR_IRQS);
|
|
|
|
for (;;) {
|
|
|
|
unsigned int reg;
|
|
|
|
apic = entry->apic;
|
|
|
|
pin = entry->pin;
|
|
|
|
if (pin == -1)
|
|
|
|
break;
|
|
|
|
io_apic_write(apic, 0x11 + pin*2, dest);
|
|
|
|
reg = io_apic_read(apic, 0x10 + pin*2);
|
2008-06-07 09:53:57 -06:00
|
|
|
reg &= ~IO_APIC_REDIR_VECTOR_MASK;
|
2006-10-04 03:16:51 -06:00
|
|
|
reg |= vector;
|
|
|
|
io_apic_modify(apic, reg);
|
|
|
|
if (!entry->next)
|
|
|
|
break;
|
|
|
|
entry = irq_2_pin + entry->next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
static void set_ioapic_affinity_irq(unsigned int irq, cpumask_t mask)
|
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
unsigned long flags;
|
|
|
|
unsigned int dest;
|
|
|
|
cpumask_t tmp;
|
|
|
|
|
|
|
|
cpus_and(tmp, mask, cpu_online_map);
|
|
|
|
if (cpus_empty(tmp))
|
2007-02-23 04:20:59 -07:00
|
|
|
return;
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
if (assign_irq_vector(irq, mask))
|
2006-10-04 03:16:51 -06:00
|
|
|
return;
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
cpus_and(tmp, cfg->domain, mask);
|
2006-10-04 03:16:51 -06:00
|
|
|
dest = cpu_mask_to_apicid(tmp);
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Only the high 8 bits are valid.
|
|
|
|
*/
|
|
|
|
dest = SET_APIC_LOGICAL_ID(dest);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
2007-02-23 04:35:05 -07:00
|
|
|
__target_IO_APIC_irq(irq, dest, cfg->vector);
|
2007-02-23 04:13:55 -07:00
|
|
|
irq_desc[irq].affinity = mask;
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/*
|
|
|
|
* The common case is 1:1 IRQ<->pin mappings. Sometimes there are
|
|
|
|
* shared ISA-space IRQs, so we have to support them. We are super
|
|
|
|
* fast in the common case, and fast for shared ISA-space IRQs.
|
|
|
|
*/
|
|
|
|
static void add_pin_to_irq(unsigned int irq, int apic, int pin)
|
|
|
|
{
|
|
|
|
static int first_free_entry = NR_IRQS;
|
|
|
|
struct irq_pin_list *entry = irq_2_pin + irq;
|
|
|
|
|
2005-11-05 09:25:53 -07:00
|
|
|
BUG_ON(irq >= NR_IRQS);
|
2005-04-16 16:20:36 -06:00
|
|
|
while (entry->next)
|
|
|
|
entry = irq_2_pin + entry->next;
|
|
|
|
|
|
|
|
if (entry->pin != -1) {
|
|
|
|
entry->next = first_free_entry;
|
|
|
|
entry = irq_2_pin + entry->next;
|
|
|
|
if (++first_free_entry >= PIN_MAP_SIZE)
|
2005-11-05 09:25:53 -07:00
|
|
|
panic("io_apic.c: ran out of irq_2_pin entries!");
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
entry->apic = apic;
|
|
|
|
entry->pin = pin;
|
|
|
|
}
|
|
|
|
|
2008-06-30 18:19:31 -06:00
|
|
|
/*
|
|
|
|
* Reroute an IRQ to a different pin.
|
|
|
|
*/
|
|
|
|
static void __init replace_pin_at_irq(unsigned int irq,
|
|
|
|
int oldapic, int oldpin,
|
|
|
|
int newapic, int newpin)
|
|
|
|
{
|
|
|
|
struct irq_pin_list *entry = irq_2_pin + irq;
|
|
|
|
|
|
|
|
while (1) {
|
|
|
|
if (entry->apic == oldapic && entry->pin == oldpin) {
|
|
|
|
entry->apic = newapic;
|
|
|
|
entry->pin = newpin;
|
|
|
|
}
|
|
|
|
if (!entry->next)
|
|
|
|
break;
|
|
|
|
entry = irq_2_pin + entry->next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
#define DO_ACTION(name,R,ACTION, FINAL) \
|
|
|
|
\
|
|
|
|
static void name##_IO_APIC_irq (unsigned int irq) \
|
|
|
|
__DO_ACTION(R, ACTION, FINAL)
|
|
|
|
|
2008-06-07 09:53:57 -06:00
|
|
|
/* mask = 1 */
|
|
|
|
DO_ACTION(__mask, 0, |= IO_APIC_REDIR_MASKED, io_apic_sync(entry->apic))
|
|
|
|
|
|
|
|
/* mask = 0 */
|
|
|
|
DO_ACTION(__unmask, 0, &= ~IO_APIC_REDIR_MASKED, )
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
static void mask_IO_APIC_irq (unsigned int irq)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
__mask_IO_APIC_irq(irq);
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void unmask_IO_APIC_irq (unsigned int irq)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
__unmask_IO_APIC_irq(irq);
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void clear_IO_APIC_pin(unsigned int apic, unsigned int pin)
|
|
|
|
{
|
|
|
|
struct IO_APIC_route_entry entry;
|
|
|
|
|
|
|
|
/* Check delivery_mode to be sure we're not clearing an SMI pin */
|
2006-09-26 02:52:30 -06:00
|
|
|
entry = ioapic_read_entry(apic, pin);
|
2005-04-16 16:20:36 -06:00
|
|
|
if (entry.delivery_mode == dest_SMI)
|
|
|
|
return;
|
|
|
|
/*
|
|
|
|
* Disable it in the IO-APIC irq-routing table:
|
|
|
|
*/
|
2006-11-08 11:27:54 -07:00
|
|
|
ioapic_mask_entry(apic, pin);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
static void clear_IO_APIC (void)
|
|
|
|
{
|
|
|
|
int apic, pin;
|
|
|
|
|
|
|
|
for (apic = 0; apic < nr_ioapics; apic++)
|
|
|
|
for (pin = 0; pin < nr_ioapic_registers[apic]; pin++)
|
|
|
|
clear_IO_APIC_pin(apic, pin);
|
|
|
|
}
|
|
|
|
|
|
|
|
int skip_ioapic_setup;
|
|
|
|
int ioapic_force;
|
|
|
|
|
2007-08-16 01:34:22 -06:00
|
|
|
static int __init parse_noapic(char *str)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-08-16 01:34:22 -06:00
|
|
|
disable_ioapic_setup();
|
2006-09-26 02:52:32 -06:00
|
|
|
return 0;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2007-08-16 01:34:22 -06:00
|
|
|
early_param("noapic", parse_noapic);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-01-08 16:04:46 -07:00
|
|
|
/* Actually the next is obsolete, but keep it for paranoid reasons -AK */
|
|
|
|
static int __init disable_timer_pin_setup(char *arg)
|
|
|
|
{
|
|
|
|
disable_timer_pin_1 = 1;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
__setup("disable_timer_pin_1", disable_timer_pin_setup);
|
|
|
|
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/*
|
|
|
|
* Find the IRQ entry number of a certain pin.
|
|
|
|
*/
|
|
|
|
static int find_irq_entry(int apic, int pin, int type)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < mp_irq_entries; i++)
|
2008-05-14 09:03:17 -06:00
|
|
|
if (mp_irqs[i].mp_irqtype == type &&
|
|
|
|
(mp_irqs[i].mp_dstapic == mp_ioapics[apic].mp_apicid ||
|
|
|
|
mp_irqs[i].mp_dstapic == MP_APIC_ALL) &&
|
|
|
|
mp_irqs[i].mp_dstirq == pin)
|
2005-04-16 16:20:36 -06:00
|
|
|
return i;
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Find the pin to which IRQ[irq] (ISA) is connected
|
|
|
|
*/
|
2006-01-11 14:46:06 -07:00
|
|
|
static int __init find_isa_irq_pin(int irq, int type)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < mp_irq_entries; i++) {
|
2008-05-14 09:03:17 -06:00
|
|
|
int lbus = mp_irqs[i].mp_srcbus;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2006-09-26 02:52:30 -06:00
|
|
|
if (test_bit(lbus, mp_bus_not_pci) &&
|
2008-05-14 09:03:17 -06:00
|
|
|
(mp_irqs[i].mp_irqtype == type) &&
|
|
|
|
(mp_irqs[i].mp_srcbusirq == irq))
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2008-05-14 09:03:17 -06:00
|
|
|
return mp_irqs[i].mp_dstirq;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2006-01-11 14:46:06 -07:00
|
|
|
static int __init find_isa_irq_apic(int irq, int type)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < mp_irq_entries; i++) {
|
2008-05-14 09:03:17 -06:00
|
|
|
int lbus = mp_irqs[i].mp_srcbus;
|
2006-01-11 14:46:06 -07:00
|
|
|
|
2006-09-26 02:52:30 -06:00
|
|
|
if (test_bit(lbus, mp_bus_not_pci) &&
|
2008-05-14 09:03:17 -06:00
|
|
|
(mp_irqs[i].mp_irqtype == type) &&
|
|
|
|
(mp_irqs[i].mp_srcbusirq == irq))
|
2006-01-11 14:46:06 -07:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (i < mp_irq_entries) {
|
|
|
|
int apic;
|
|
|
|
for(apic = 0; apic < nr_ioapics; apic++) {
|
2008-05-14 09:03:17 -06:00
|
|
|
if (mp_ioapics[apic].mp_apicid == mp_irqs[i].mp_dstapic)
|
2006-01-11 14:46:06 -07:00
|
|
|
return apic;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/*
|
|
|
|
* Find a specific PCI IRQ entry.
|
|
|
|
* Not an __init, possibly needed by modules
|
|
|
|
*/
|
|
|
|
static int pin_2_irq(int idx, int apic, int pin);
|
|
|
|
|
|
|
|
int IO_APIC_get_PCI_irq_vector(int bus, int slot, int pin)
|
|
|
|
{
|
|
|
|
int apic, i, best_guess = -1;
|
|
|
|
|
|
|
|
apic_printk(APIC_DEBUG, "querying PCI -> IRQ mapping bus:%d, slot:%d, pin:%d.\n",
|
|
|
|
bus, slot, pin);
|
2008-05-19 09:47:09 -06:00
|
|
|
if (test_bit(bus, mp_bus_not_pci)) {
|
2005-04-16 16:20:36 -06:00
|
|
|
apic_printk(APIC_VERBOSE, "PCI BIOS passed nonexistent PCI bus %d!\n", bus);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
for (i = 0; i < mp_irq_entries; i++) {
|
2008-05-14 09:03:17 -06:00
|
|
|
int lbus = mp_irqs[i].mp_srcbus;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
for (apic = 0; apic < nr_ioapics; apic++)
|
2008-05-14 09:03:17 -06:00
|
|
|
if (mp_ioapics[apic].mp_apicid == mp_irqs[i].mp_dstapic ||
|
|
|
|
mp_irqs[i].mp_dstapic == MP_APIC_ALL)
|
2005-04-16 16:20:36 -06:00
|
|
|
break;
|
|
|
|
|
2006-09-26 02:52:30 -06:00
|
|
|
if (!test_bit(lbus, mp_bus_not_pci) &&
|
2008-05-14 09:03:17 -06:00
|
|
|
!mp_irqs[i].mp_irqtype &&
|
2005-04-16 16:20:36 -06:00
|
|
|
(bus == lbus) &&
|
2008-05-14 09:03:17 -06:00
|
|
|
(slot == ((mp_irqs[i].mp_srcbusirq >> 2) & 0x1f))) {
|
|
|
|
int irq = pin_2_irq(i,apic,mp_irqs[i].mp_dstirq);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
if (!(apic || IO_APIC_IRQ(irq)))
|
|
|
|
continue;
|
|
|
|
|
2008-05-14 09:03:17 -06:00
|
|
|
if (pin == (mp_irqs[i].mp_srcbusirq & 3))
|
2005-04-16 16:20:36 -06:00
|
|
|
return irq;
|
|
|
|
/*
|
|
|
|
* Use the first all-but-pin matching entry as a
|
|
|
|
* best-guess fuzzy result for broken mptables.
|
|
|
|
*/
|
|
|
|
if (best_guess < 0)
|
|
|
|
best_guess = irq;
|
|
|
|
}
|
|
|
|
}
|
2005-11-05 09:25:53 -07:00
|
|
|
BUG_ON(best_guess >= NR_IRQS);
|
2005-04-16 16:20:36 -06:00
|
|
|
return best_guess;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* ISA interrupts are always polarity zero edge triggered,
|
|
|
|
* when listed as conforming in the MP table. */
|
|
|
|
|
|
|
|
#define default_ISA_trigger(idx) (0)
|
|
|
|
#define default_ISA_polarity(idx) (0)
|
|
|
|
|
|
|
|
/* PCI interrupts are always polarity one level triggered,
|
|
|
|
* when listed as conforming in the MP table. */
|
|
|
|
|
|
|
|
#define default_PCI_trigger(idx) (1)
|
|
|
|
#define default_PCI_polarity(idx) (1)
|
|
|
|
|
2007-11-16 23:05:28 -07:00
|
|
|
static int MPBIOS_polarity(int idx)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2008-05-14 09:03:17 -06:00
|
|
|
int bus = mp_irqs[idx].mp_srcbus;
|
2005-04-16 16:20:36 -06:00
|
|
|
int polarity;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Determine IRQ line polarity (high active or low active):
|
|
|
|
*/
|
2008-05-14 09:03:17 -06:00
|
|
|
switch (mp_irqs[idx].mp_irqflag & 3)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
case 0: /* conforms, ie. bus-type dependent polarity */
|
2006-09-26 02:52:30 -06:00
|
|
|
if (test_bit(bus, mp_bus_not_pci))
|
|
|
|
polarity = default_ISA_polarity(idx);
|
|
|
|
else
|
|
|
|
polarity = default_PCI_polarity(idx);
|
2005-04-16 16:20:36 -06:00
|
|
|
break;
|
|
|
|
case 1: /* high active */
|
|
|
|
{
|
|
|
|
polarity = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case 2: /* reserved */
|
|
|
|
{
|
|
|
|
printk(KERN_WARNING "broken BIOS!!\n");
|
|
|
|
polarity = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case 3: /* low active */
|
|
|
|
{
|
|
|
|
polarity = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default: /* invalid */
|
|
|
|
{
|
|
|
|
printk(KERN_WARNING "broken BIOS!!\n");
|
|
|
|
polarity = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return polarity;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int MPBIOS_trigger(int idx)
|
|
|
|
{
|
2008-05-14 09:03:17 -06:00
|
|
|
int bus = mp_irqs[idx].mp_srcbus;
|
2005-04-16 16:20:36 -06:00
|
|
|
int trigger;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Determine IRQ trigger mode (edge or level sensitive):
|
|
|
|
*/
|
2008-05-14 09:03:17 -06:00
|
|
|
switch ((mp_irqs[idx].mp_irqflag>>2) & 3)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
case 0: /* conforms, ie. bus-type dependent */
|
2006-09-26 02:52:30 -06:00
|
|
|
if (test_bit(bus, mp_bus_not_pci))
|
|
|
|
trigger = default_ISA_trigger(idx);
|
|
|
|
else
|
|
|
|
trigger = default_PCI_trigger(idx);
|
2005-04-16 16:20:36 -06:00
|
|
|
break;
|
|
|
|
case 1: /* edge */
|
|
|
|
{
|
|
|
|
trigger = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case 2: /* reserved */
|
|
|
|
{
|
|
|
|
printk(KERN_WARNING "broken BIOS!!\n");
|
|
|
|
trigger = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case 3: /* level */
|
|
|
|
{
|
|
|
|
trigger = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default: /* invalid */
|
|
|
|
{
|
|
|
|
printk(KERN_WARNING "broken BIOS!!\n");
|
|
|
|
trigger = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return trigger;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int irq_polarity(int idx)
|
|
|
|
{
|
|
|
|
return MPBIOS_polarity(idx);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int irq_trigger(int idx)
|
|
|
|
{
|
|
|
|
return MPBIOS_trigger(idx);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int pin_2_irq(int idx, int apic, int pin)
|
|
|
|
{
|
|
|
|
int irq, i;
|
2008-05-14 09:03:17 -06:00
|
|
|
int bus = mp_irqs[idx].mp_srcbus;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Debugging check, we are in big trouble if this message pops up!
|
|
|
|
*/
|
2008-05-14 09:03:17 -06:00
|
|
|
if (mp_irqs[idx].mp_dstirq != pin)
|
2005-04-16 16:20:36 -06:00
|
|
|
printk(KERN_ERR "broken BIOS or MPTABLE parser, ayiee!!\n");
|
|
|
|
|
2006-09-26 02:52:30 -06:00
|
|
|
if (test_bit(bus, mp_bus_not_pci)) {
|
2008-05-14 09:03:17 -06:00
|
|
|
irq = mp_irqs[idx].mp_srcbusirq;
|
2006-09-26 02:52:30 -06:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* PCI IRQs are mapped in order
|
|
|
|
*/
|
|
|
|
i = irq = 0;
|
|
|
|
while (i < apic)
|
|
|
|
irq += nr_ioapic_registers[i++];
|
|
|
|
irq += pin;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2005-11-05 09:25:53 -07:00
|
|
|
BUG_ON(irq >= NR_IRQS);
|
2005-04-16 16:20:36 -06:00
|
|
|
return irq;
|
|
|
|
}
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
static int __assign_irq_vector(int irq, cpumask_t mask)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2006-10-04 03:16:51 -06:00
|
|
|
/*
|
|
|
|
* NOTE! The local APIC isn't very good at handling
|
|
|
|
* multiple interrupts at the same interrupt level.
|
|
|
|
* As the interrupt level is determined by taking the
|
|
|
|
* vector number and shifting that right by 4, we
|
|
|
|
* want to spread these out a bit so that they don't
|
|
|
|
* all fall in the same interrupt level.
|
|
|
|
*
|
|
|
|
* Also, we've got to be careful not to trash gate
|
|
|
|
* 0x80, because int 0x80 is hm, kind of importantish. ;)
|
|
|
|
*/
|
2006-10-24 17:00:22 -06:00
|
|
|
static int current_vector = FIRST_DEVICE_VECTOR, current_offset = 0;
|
2007-02-23 04:35:05 -07:00
|
|
|
unsigned int old_vector;
|
2006-10-04 03:16:51 -06:00
|
|
|
int cpu;
|
2007-02-23 04:32:47 -07:00
|
|
|
struct irq_cfg *cfg;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-02-23 04:26:53 -07:00
|
|
|
BUG_ON((unsigned)irq >= NR_IRQS);
|
2007-02-23 04:32:47 -07:00
|
|
|
cfg = &irq_cfg[irq];
|
2006-06-26 05:56:43 -06:00
|
|
|
|
2006-10-24 17:00:23 -06:00
|
|
|
/* Only try and allocate irqs on cpus that are present */
|
|
|
|
cpus_and(mask, mask, cpu_online_map);
|
|
|
|
|
2007-02-23 04:40:58 -07:00
|
|
|
if ((cfg->move_in_progress) || cfg->move_cleanup_count)
|
|
|
|
return -EBUSY;
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
old_vector = cfg->vector;
|
|
|
|
if (old_vector) {
|
|
|
|
cpumask_t tmp;
|
|
|
|
cpus_and(tmp, cfg->domain, mask);
|
|
|
|
if (!cpus_empty(tmp))
|
|
|
|
return 0;
|
2006-06-26 05:56:43 -06:00
|
|
|
}
|
2006-10-04 03:16:51 -06:00
|
|
|
|
2008-05-12 13:21:13 -06:00
|
|
|
for_each_cpu_mask_nr(cpu, mask) {
|
2006-10-24 17:00:23 -06:00
|
|
|
cpumask_t domain, new_mask;
|
2007-02-23 04:40:58 -07:00
|
|
|
int new_cpu;
|
2006-10-04 03:16:51 -06:00
|
|
|
int vector, offset;
|
2006-10-08 07:47:55 -06:00
|
|
|
|
|
|
|
domain = vector_allocation_domain(cpu);
|
2006-10-24 17:00:23 -06:00
|
|
|
cpus_and(new_mask, domain, cpu_online_map);
|
2006-10-08 07:47:55 -06:00
|
|
|
|
2006-10-24 17:00:22 -06:00
|
|
|
vector = current_vector;
|
|
|
|
offset = current_offset;
|
2005-04-16 16:20:36 -06:00
|
|
|
next:
|
2006-10-04 03:16:51 -06:00
|
|
|
vector += 8;
|
2008-04-15 14:36:56 -06:00
|
|
|
if (vector >= first_system_vector) {
|
2006-10-04 03:16:51 -06:00
|
|
|
/* If we run out of vectors on large boxen, must share them. */
|
|
|
|
offset = (offset + 1) % 8;
|
|
|
|
vector = FIRST_DEVICE_VECTOR + offset;
|
|
|
|
}
|
2006-10-24 17:00:22 -06:00
|
|
|
if (unlikely(current_vector == vector))
|
2006-10-04 03:16:51 -06:00
|
|
|
continue;
|
|
|
|
if (vector == IA32_SYSCALL_VECTOR)
|
|
|
|
goto next;
|
2008-05-12 13:21:13 -06:00
|
|
|
for_each_cpu_mask_nr(new_cpu, new_mask)
|
2006-10-21 10:37:01 -06:00
|
|
|
if (per_cpu(vector_irq, new_cpu)[vector] != -1)
|
2006-10-08 07:47:55 -06:00
|
|
|
goto next;
|
2006-10-04 03:16:51 -06:00
|
|
|
/* Found one! */
|
2006-10-24 17:00:22 -06:00
|
|
|
current_vector = vector;
|
|
|
|
current_offset = offset;
|
2007-02-23 04:40:58 -07:00
|
|
|
if (old_vector) {
|
|
|
|
cfg->move_in_progress = 1;
|
|
|
|
cfg->old_domain = cfg->domain;
|
|
|
|
}
|
2008-05-12 13:21:13 -06:00
|
|
|
for_each_cpu_mask_nr(new_cpu, new_mask)
|
2006-10-08 07:47:55 -06:00
|
|
|
per_cpu(vector_irq, new_cpu)[vector] = irq;
|
2007-02-23 04:32:47 -07:00
|
|
|
cfg->vector = vector;
|
|
|
|
cfg->domain = domain;
|
2007-02-23 04:35:05 -07:00
|
|
|
return 0;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2006-10-04 03:16:51 -06:00
|
|
|
return -ENOSPC;
|
2006-10-04 03:16:46 -06:00
|
|
|
}
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
static int assign_irq_vector(int irq, cpumask_t mask)
|
2006-10-04 03:16:46 -06:00
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
int err;
|
2006-10-04 03:16:46 -06:00
|
|
|
unsigned long flags;
|
2006-06-26 05:56:43 -06:00
|
|
|
|
2006-10-04 03:16:46 -06:00
|
|
|
spin_lock_irqsave(&vector_lock, flags);
|
2007-02-23 04:35:05 -07:00
|
|
|
err = __assign_irq_vector(irq, mask);
|
2006-06-26 05:57:16 -06:00
|
|
|
spin_unlock_irqrestore(&vector_lock, flags);
|
2007-02-23 04:35:05 -07:00
|
|
|
return err;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2006-12-06 18:14:05 -07:00
|
|
|
static void __clear_irq_vector(int irq)
|
|
|
|
{
|
2007-02-23 04:32:47 -07:00
|
|
|
struct irq_cfg *cfg;
|
2006-12-06 18:14:05 -07:00
|
|
|
cpumask_t mask;
|
|
|
|
int cpu, vector;
|
|
|
|
|
2007-02-23 04:32:47 -07:00
|
|
|
BUG_ON((unsigned)irq >= NR_IRQS);
|
|
|
|
cfg = &irq_cfg[irq];
|
|
|
|
BUG_ON(!cfg->vector);
|
2006-12-06 18:14:05 -07:00
|
|
|
|
2007-02-23 04:32:47 -07:00
|
|
|
vector = cfg->vector;
|
|
|
|
cpus_and(mask, cfg->domain, cpu_online_map);
|
2008-05-12 13:21:13 -06:00
|
|
|
for_each_cpu_mask_nr(cpu, mask)
|
2006-12-06 18:14:05 -07:00
|
|
|
per_cpu(vector_irq, cpu)[vector] = -1;
|
|
|
|
|
2007-02-23 04:32:47 -07:00
|
|
|
cfg->vector = 0;
|
2008-04-04 19:11:12 -06:00
|
|
|
cpus_clear(cfg->domain);
|
2006-12-06 18:14:05 -07:00
|
|
|
}
|
|
|
|
|
2008-05-28 21:34:19 -06:00
|
|
|
static void __setup_vector_irq(int cpu)
|
2006-10-24 17:00:23 -06:00
|
|
|
{
|
|
|
|
/* Initialize vector_irq on a new cpu */
|
|
|
|
/* This function must be called with vector_lock held */
|
|
|
|
int irq, vector;
|
|
|
|
|
|
|
|
/* Mark the inuse vectors */
|
2007-02-23 04:26:53 -07:00
|
|
|
for (irq = 0; irq < NR_IRQS; ++irq) {
|
2007-02-23 04:32:47 -07:00
|
|
|
if (!cpu_isset(cpu, irq_cfg[irq].domain))
|
2006-10-24 17:00:23 -06:00
|
|
|
continue;
|
2007-02-23 04:32:47 -07:00
|
|
|
vector = irq_cfg[irq].vector;
|
2006-10-24 17:00:23 -06:00
|
|
|
per_cpu(vector_irq, cpu)[vector] = irq;
|
|
|
|
}
|
|
|
|
/* Mark the free vectors */
|
|
|
|
for (vector = 0; vector < NR_VECTORS; ++vector) {
|
|
|
|
irq = per_cpu(vector_irq, cpu)[vector];
|
|
|
|
if (irq < 0)
|
|
|
|
continue;
|
2007-02-23 04:32:47 -07:00
|
|
|
if (!cpu_isset(cpu, irq_cfg[irq].domain))
|
2006-10-24 17:00:23 -06:00
|
|
|
per_cpu(vector_irq, cpu)[vector] = -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-05-28 21:34:19 -06:00
|
|
|
void setup_vector_irq(int cpu)
|
|
|
|
{
|
|
|
|
spin_lock(&vector_lock);
|
|
|
|
__setup_vector_irq(smp_processor_id());
|
|
|
|
spin_unlock(&vector_lock);
|
|
|
|
}
|
|
|
|
|
2006-10-24 17:00:23 -06:00
|
|
|
|
2006-10-04 03:16:25 -06:00
|
|
|
static struct irq_chip ioapic_chip;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-02-23 04:16:31 -07:00
|
|
|
static void ioapic_register_intr(int irq, unsigned long trigger)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-08-12 09:46:36 -06:00
|
|
|
if (trigger) {
|
|
|
|
irq_desc[irq].status |= IRQ_LEVEL;
|
2006-10-17 01:10:03 -06:00
|
|
|
set_irq_chip_and_handler_name(irq, &ioapic_chip,
|
|
|
|
handle_fasteoi_irq, "fasteoi");
|
2007-08-12 09:46:36 -06:00
|
|
|
} else {
|
|
|
|
irq_desc[irq].status &= ~IRQ_LEVEL;
|
2006-10-17 01:10:03 -06:00
|
|
|
set_irq_chip_and_handler_name(irq, &ioapic_chip,
|
|
|
|
handle_edge_irq, "edge");
|
2007-08-12 09:46:36 -06:00
|
|
|
}
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2007-02-23 04:19:08 -07:00
|
|
|
|
|
|
|
static void setup_IO_APIC_irq(int apic, int pin, unsigned int irq,
|
|
|
|
int trigger, int polarity)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
2005-04-16 16:20:36 -06:00
|
|
|
struct IO_APIC_route_entry entry;
|
2007-02-23 04:19:08 -07:00
|
|
|
cpumask_t mask;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-02-23 04:19:08 -07:00
|
|
|
if (!IO_APIC_IRQ(irq))
|
|
|
|
return;
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
mask = TARGET_CPUS;
|
|
|
|
if (assign_irq_vector(irq, mask))
|
2007-02-23 04:19:08 -07:00
|
|
|
return;
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
cpus_and(mask, cfg->domain, mask);
|
|
|
|
|
2007-02-23 04:19:08 -07:00
|
|
|
apic_printk(APIC_VERBOSE,KERN_DEBUG
|
|
|
|
"IOAPIC[%d]: Set routing entry (%d-%d -> 0x%x -> "
|
|
|
|
"IRQ %d Mode:%i Active:%i)\n",
|
2008-05-14 09:03:10 -06:00
|
|
|
apic, mp_ioapics[apic].mp_apicid, pin, cfg->vector,
|
2007-02-23 04:19:08 -07:00
|
|
|
irq, trigger, polarity);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2006-12-06 18:14:19 -07:00
|
|
|
/*
|
|
|
|
* add it to the IO-APIC irq-routing table:
|
|
|
|
*/
|
|
|
|
memset(&entry,0,sizeof(entry));
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2006-12-06 18:14:19 -07:00
|
|
|
entry.delivery_mode = INT_DELIVERY_MODE;
|
|
|
|
entry.dest_mode = INT_DEST_MODE;
|
2007-02-23 04:19:08 -07:00
|
|
|
entry.dest = cpu_mask_to_apicid(mask);
|
2006-12-06 18:14:19 -07:00
|
|
|
entry.mask = 0; /* enable IRQ */
|
2007-02-23 04:19:08 -07:00
|
|
|
entry.trigger = trigger;
|
|
|
|
entry.polarity = polarity;
|
2007-02-23 04:35:05 -07:00
|
|
|
entry.vector = cfg->vector;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-02-23 04:19:08 -07:00
|
|
|
/* Mask level triggered irqs.
|
|
|
|
* Use IRQ_DELAYED_DISABLE for edge triggered irqs.
|
|
|
|
*/
|
|
|
|
if (trigger)
|
2006-12-06 18:14:19 -07:00
|
|
|
entry.mask = 1;
|
|
|
|
|
2007-02-23 04:19:08 -07:00
|
|
|
ioapic_register_intr(irq, trigger);
|
|
|
|
if (irq < 16)
|
|
|
|
disable_8259A_irq(irq);
|
2006-12-06 18:14:19 -07:00
|
|
|
|
|
|
|
ioapic_write_entry(apic, pin, entry);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __init setup_IO_APIC_irqs(void)
|
|
|
|
{
|
|
|
|
int apic, pin, idx, irq, first_notcon = 1;
|
|
|
|
|
|
|
|
apic_printk(APIC_VERBOSE, KERN_DEBUG "init IO_APIC IRQs\n");
|
|
|
|
|
|
|
|
for (apic = 0; apic < nr_ioapics; apic++) {
|
|
|
|
for (pin = 0; pin < nr_ioapic_registers[apic]; pin++) {
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
idx = find_irq_entry(apic,pin,mp_INT);
|
|
|
|
if (idx == -1) {
|
|
|
|
if (first_notcon) {
|
2008-05-14 09:03:10 -06:00
|
|
|
apic_printk(APIC_VERBOSE, KERN_DEBUG " IO-APIC (apicid-pin) %d-%d", mp_ioapics[apic].mp_apicid, pin);
|
2005-04-16 16:20:36 -06:00
|
|
|
first_notcon = 0;
|
|
|
|
} else
|
2008-05-14 09:03:10 -06:00
|
|
|
apic_printk(APIC_VERBOSE, ", %d-%d", mp_ioapics[apic].mp_apicid, pin);
|
2005-04-16 16:20:36 -06:00
|
|
|
continue;
|
|
|
|
}
|
2007-10-17 10:04:41 -06:00
|
|
|
if (!first_notcon) {
|
|
|
|
apic_printk(APIC_VERBOSE, " not connected.\n");
|
|
|
|
first_notcon = 1;
|
|
|
|
}
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
irq = pin_2_irq(idx, apic, pin);
|
|
|
|
add_pin_to_irq(irq, apic, pin);
|
|
|
|
|
2007-02-23 04:19:08 -07:00
|
|
|
setup_IO_APIC_irq(apic, pin, irq,
|
|
|
|
irq_trigger(idx), irq_polarity(idx));
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!first_notcon)
|
2007-10-17 10:04:41 -06:00
|
|
|
apic_printk(APIC_VERBOSE, " not connected.\n");
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2008-05-27 14:19:34 -06:00
|
|
|
* Set up the timer pin, possibly with the 8259A-master behind.
|
2005-04-16 16:20:36 -06:00
|
|
|
*/
|
2008-05-27 14:19:34 -06:00
|
|
|
static void __init setup_timer_IRQ0_pin(unsigned int apic, unsigned int pin,
|
|
|
|
int vector)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
struct IO_APIC_route_entry entry;
|
|
|
|
|
2008-04-05 07:39:05 -06:00
|
|
|
memset(&entry, 0, sizeof(entry));
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We use logical delivery to get the timer IRQ
|
|
|
|
* to the first CPU.
|
|
|
|
*/
|
|
|
|
entry.dest_mode = INT_DEST_MODE;
|
2008-05-27 14:19:45 -06:00
|
|
|
entry.mask = 1; /* mask IRQ now */
|
2007-02-13 05:26:25 -07:00
|
|
|
entry.dest = cpu_mask_to_apicid(TARGET_CPUS);
|
2005-04-16 16:20:36 -06:00
|
|
|
entry.delivery_mode = INT_DELIVERY_MODE;
|
|
|
|
entry.polarity = 0;
|
|
|
|
entry.trigger = 0;
|
|
|
|
entry.vector = vector;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The timer IRQ doesn't have to know that behind the
|
2008-05-27 14:19:34 -06:00
|
|
|
* scene we may have a 8259A-master in AEOI mode ...
|
2005-04-16 16:20:36 -06:00
|
|
|
*/
|
2006-10-17 01:10:03 -06:00
|
|
|
set_irq_chip_and_handler_name(0, &ioapic_chip, handle_edge_irq, "edge");
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Add it to the IO-APIC irq-routing table:
|
|
|
|
*/
|
2008-04-05 07:39:05 -06:00
|
|
|
ioapic_write_entry(apic, pin, entry);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
void __apicdebuginit print_IO_APIC(void)
|
|
|
|
{
|
|
|
|
int apic, i;
|
|
|
|
union IO_APIC_reg_00 reg_00;
|
|
|
|
union IO_APIC_reg_01 reg_01;
|
|
|
|
union IO_APIC_reg_02 reg_02;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (apic_verbosity == APIC_QUIET)
|
|
|
|
return;
|
|
|
|
|
|
|
|
printk(KERN_DEBUG "number of MP IRQ sources: %d.\n", mp_irq_entries);
|
|
|
|
for (i = 0; i < nr_ioapics; i++)
|
|
|
|
printk(KERN_DEBUG "number of IO-APIC #%d registers: %d.\n",
|
2008-05-14 09:03:10 -06:00
|
|
|
mp_ioapics[i].mp_apicid, nr_ioapic_registers[i]);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We are a bit conservative about what we expect. We have to
|
|
|
|
* know about every hardware change ASAP.
|
|
|
|
*/
|
|
|
|
printk(KERN_INFO "testing the IO APIC.......................\n");
|
|
|
|
|
|
|
|
for (apic = 0; apic < nr_ioapics; apic++) {
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
reg_00.raw = io_apic_read(apic, 0);
|
|
|
|
reg_01.raw = io_apic_read(apic, 1);
|
|
|
|
if (reg_01.bits.version >= 0x10)
|
|
|
|
reg_02.raw = io_apic_read(apic, 2);
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
|
|
|
|
printk("\n");
|
2008-05-14 09:03:10 -06:00
|
|
|
printk(KERN_DEBUG "IO APIC #%d......\n", mp_ioapics[apic].mp_apicid);
|
2005-04-16 16:20:36 -06:00
|
|
|
printk(KERN_DEBUG ".... register #00: %08X\n", reg_00.raw);
|
|
|
|
printk(KERN_DEBUG "....... : physical APIC id: %02X\n", reg_00.bits.ID);
|
|
|
|
|
|
|
|
printk(KERN_DEBUG ".... register #01: %08X\n", *(int *)®_01);
|
|
|
|
printk(KERN_DEBUG "....... : max redirection entries: %04X\n", reg_01.bits.entries);
|
|
|
|
|
|
|
|
printk(KERN_DEBUG "....... : PRQ implemented: %X\n", reg_01.bits.PRQ);
|
|
|
|
printk(KERN_DEBUG "....... : IO APIC version: %04X\n", reg_01.bits.version);
|
|
|
|
|
|
|
|
if (reg_01.bits.version >= 0x10) {
|
|
|
|
printk(KERN_DEBUG ".... register #02: %08X\n", reg_02.raw);
|
|
|
|
printk(KERN_DEBUG "....... : arbitration: %02X\n", reg_02.bits.arbitration);
|
|
|
|
}
|
|
|
|
|
|
|
|
printk(KERN_DEBUG ".... IRQ redirection table:\n");
|
|
|
|
|
2007-02-13 05:26:25 -07:00
|
|
|
printk(KERN_DEBUG " NR Dst Mask Trig IRR Pol"
|
|
|
|
" Stat Dmod Deli Vect: \n");
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
for (i = 0; i <= reg_01.bits.entries; i++) {
|
|
|
|
struct IO_APIC_route_entry entry;
|
|
|
|
|
2006-09-26 02:52:30 -06:00
|
|
|
entry = ioapic_read_entry(apic, i);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-02-13 05:26:25 -07:00
|
|
|
printk(KERN_DEBUG " %02x %03X ",
|
2005-04-16 16:20:36 -06:00
|
|
|
i,
|
2007-02-13 05:26:25 -07:00
|
|
|
entry.dest
|
2005-04-16 16:20:36 -06:00
|
|
|
);
|
|
|
|
|
|
|
|
printk("%1d %1d %1d %1d %1d %1d %1d %02X\n",
|
|
|
|
entry.mask,
|
|
|
|
entry.trigger,
|
|
|
|
entry.irr,
|
|
|
|
entry.polarity,
|
|
|
|
entry.delivery_status,
|
|
|
|
entry.dest_mode,
|
|
|
|
entry.delivery_mode,
|
|
|
|
entry.vector
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
printk(KERN_DEBUG "IRQ to pin mappings:\n");
|
|
|
|
for (i = 0; i < NR_IRQS; i++) {
|
|
|
|
struct irq_pin_list *entry = irq_2_pin + i;
|
|
|
|
if (entry->pin < 0)
|
|
|
|
continue;
|
2006-10-04 03:16:46 -06:00
|
|
|
printk(KERN_DEBUG "IRQ%d ", i);
|
2005-04-16 16:20:36 -06:00
|
|
|
for (;;) {
|
|
|
|
printk("-> %d:%d", entry->apic, entry->pin);
|
|
|
|
if (!entry->next)
|
|
|
|
break;
|
|
|
|
entry = irq_2_pin + entry->next;
|
|
|
|
}
|
|
|
|
printk("\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
printk(KERN_INFO ".................................... done.\n");
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
#if 0
|
|
|
|
|
|
|
|
static __apicdebuginit void print_APIC_bitfield (int base)
|
|
|
|
{
|
|
|
|
unsigned int v;
|
|
|
|
int i, j;
|
|
|
|
|
|
|
|
if (apic_verbosity == APIC_QUIET)
|
|
|
|
return;
|
|
|
|
|
|
|
|
printk(KERN_DEBUG "0123456789abcdef0123456789abcdef\n" KERN_DEBUG);
|
|
|
|
for (i = 0; i < 8; i++) {
|
|
|
|
v = apic_read(base + i*0x10);
|
|
|
|
for (j = 0; j < 32; j++) {
|
|
|
|
if (v & (1<<j))
|
|
|
|
printk("1");
|
|
|
|
else
|
|
|
|
printk("0");
|
|
|
|
}
|
|
|
|
printk("\n");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void __apicdebuginit print_local_APIC(void * dummy)
|
|
|
|
{
|
|
|
|
unsigned int v, ver, maxlvt;
|
|
|
|
|
|
|
|
if (apic_verbosity == APIC_QUIET)
|
|
|
|
return;
|
|
|
|
|
|
|
|
printk("\n" KERN_DEBUG "printing local APIC contents on CPU#%d/%d:\n",
|
|
|
|
smp_processor_id(), hard_smp_processor_id());
|
2008-06-05 08:35:10 -06:00
|
|
|
v = apic_read(APIC_ID);
|
2008-03-28 13:12:02 -06:00
|
|
|
printk(KERN_INFO "... APIC ID: %08x (%01x)\n", v, GET_APIC_ID(read_apic_id()));
|
2005-04-16 16:20:36 -06:00
|
|
|
v = apic_read(APIC_LVR);
|
|
|
|
printk(KERN_INFO "... APIC VERSION: %08x\n", v);
|
|
|
|
ver = GET_APIC_VERSION(v);
|
2008-01-30 05:30:14 -07:00
|
|
|
maxlvt = lapic_get_maxlvt();
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
v = apic_read(APIC_TASKPRI);
|
|
|
|
printk(KERN_DEBUG "... APIC TASKPRI: %08x (%02x)\n", v, v & APIC_TPRI_MASK);
|
|
|
|
|
2005-09-12 10:49:24 -06:00
|
|
|
v = apic_read(APIC_ARBPRI);
|
|
|
|
printk(KERN_DEBUG "... APIC ARBPRI: %08x (%02x)\n", v,
|
|
|
|
v & APIC_ARBPRI_MASK);
|
|
|
|
v = apic_read(APIC_PROCPRI);
|
|
|
|
printk(KERN_DEBUG "... APIC PROCPRI: %08x\n", v);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
v = apic_read(APIC_EOI);
|
|
|
|
printk(KERN_DEBUG "... APIC EOI: %08x\n", v);
|
|
|
|
v = apic_read(APIC_RRR);
|
|
|
|
printk(KERN_DEBUG "... APIC RRR: %08x\n", v);
|
|
|
|
v = apic_read(APIC_LDR);
|
|
|
|
printk(KERN_DEBUG "... APIC LDR: %08x\n", v);
|
|
|
|
v = apic_read(APIC_DFR);
|
|
|
|
printk(KERN_DEBUG "... APIC DFR: %08x\n", v);
|
|
|
|
v = apic_read(APIC_SPIV);
|
|
|
|
printk(KERN_DEBUG "... APIC SPIV: %08x\n", v);
|
|
|
|
|
|
|
|
printk(KERN_DEBUG "... APIC ISR field:\n");
|
|
|
|
print_APIC_bitfield(APIC_ISR);
|
|
|
|
printk(KERN_DEBUG "... APIC TMR field:\n");
|
|
|
|
print_APIC_bitfield(APIC_TMR);
|
|
|
|
printk(KERN_DEBUG "... APIC IRR field:\n");
|
|
|
|
print_APIC_bitfield(APIC_IRR);
|
|
|
|
|
2005-09-12 10:49:24 -06:00
|
|
|
v = apic_read(APIC_ESR);
|
|
|
|
printk(KERN_DEBUG "... APIC ESR: %08x\n", v);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
v = apic_read(APIC_ICR);
|
|
|
|
printk(KERN_DEBUG "... APIC ICR: %08x\n", v);
|
|
|
|
v = apic_read(APIC_ICR2);
|
|
|
|
printk(KERN_DEBUG "... APIC ICR2: %08x\n", v);
|
|
|
|
|
|
|
|
v = apic_read(APIC_LVTT);
|
|
|
|
printk(KERN_DEBUG "... APIC LVTT: %08x\n", v);
|
|
|
|
|
|
|
|
if (maxlvt > 3) { /* PC is LVT#4. */
|
|
|
|
v = apic_read(APIC_LVTPC);
|
|
|
|
printk(KERN_DEBUG "... APIC LVTPC: %08x\n", v);
|
|
|
|
}
|
|
|
|
v = apic_read(APIC_LVT0);
|
|
|
|
printk(KERN_DEBUG "... APIC LVT0: %08x\n", v);
|
|
|
|
v = apic_read(APIC_LVT1);
|
|
|
|
printk(KERN_DEBUG "... APIC LVT1: %08x\n", v);
|
|
|
|
|
|
|
|
if (maxlvt > 2) { /* ERR is LVT#3. */
|
|
|
|
v = apic_read(APIC_LVTERR);
|
|
|
|
printk(KERN_DEBUG "... APIC LVTERR: %08x\n", v);
|
|
|
|
}
|
|
|
|
|
|
|
|
v = apic_read(APIC_TMICT);
|
|
|
|
printk(KERN_DEBUG "... APIC TMICT: %08x\n", v);
|
|
|
|
v = apic_read(APIC_TMCCT);
|
|
|
|
printk(KERN_DEBUG "... APIC TMCCT: %08x\n", v);
|
|
|
|
v = apic_read(APIC_TDCR);
|
|
|
|
printk(KERN_DEBUG "... APIC TDCR: %08x\n", v);
|
|
|
|
printk("\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
void print_all_local_APICs (void)
|
|
|
|
{
|
2008-05-09 01:39:44 -06:00
|
|
|
on_each_cpu(print_local_APIC, NULL, 1);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
void __apicdebuginit print_PIC(void)
|
|
|
|
{
|
|
|
|
unsigned int v;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (apic_verbosity == APIC_QUIET)
|
|
|
|
return;
|
|
|
|
|
|
|
|
printk(KERN_DEBUG "\nprinting PIC contents\n");
|
|
|
|
|
|
|
|
spin_lock_irqsave(&i8259A_lock, flags);
|
|
|
|
|
|
|
|
v = inb(0xa1) << 8 | inb(0x21);
|
|
|
|
printk(KERN_DEBUG "... PIC IMR: %04x\n", v);
|
|
|
|
|
|
|
|
v = inb(0xa0) << 8 | inb(0x20);
|
|
|
|
printk(KERN_DEBUG "... PIC IRR: %04x\n", v);
|
|
|
|
|
|
|
|
outb(0x0b,0xa0);
|
|
|
|
outb(0x0b,0x20);
|
|
|
|
v = inb(0xa0) << 8 | inb(0x20);
|
|
|
|
outb(0x0a,0xa0);
|
|
|
|
outb(0x0a,0x20);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&i8259A_lock, flags);
|
|
|
|
|
|
|
|
printk(KERN_DEBUG "... PIC ISR: %04x\n", v);
|
|
|
|
|
|
|
|
v = inb(0x4d1) << 8 | inb(0x4d0);
|
|
|
|
printk(KERN_DEBUG "... PIC ELCR: %04x\n", v);
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* 0 */
|
|
|
|
|
2008-01-30 05:30:39 -07:00
|
|
|
void __init enable_IO_APIC(void)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
union IO_APIC_reg_01 reg_01;
|
2006-01-11 14:46:06 -07:00
|
|
|
int i8259_apic, i8259_pin;
|
|
|
|
int i, apic;
|
2005-04-16 16:20:36 -06:00
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
for (i = 0; i < PIN_MAP_SIZE; i++) {
|
|
|
|
irq_2_pin[i].pin = -1;
|
|
|
|
irq_2_pin[i].next = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The number of IO-APIC IRQ registers (== #pins):
|
|
|
|
*/
|
2006-01-11 14:46:06 -07:00
|
|
|
for (apic = 0; apic < nr_ioapics; apic++) {
|
2005-04-16 16:20:36 -06:00
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
2006-01-11 14:46:06 -07:00
|
|
|
reg_01.raw = io_apic_read(apic, 1);
|
2005-04-16 16:20:36 -06:00
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
2006-01-11 14:46:06 -07:00
|
|
|
nr_ioapic_registers[apic] = reg_01.bits.entries+1;
|
|
|
|
}
|
|
|
|
for(apic = 0; apic < nr_ioapics; apic++) {
|
|
|
|
int pin;
|
|
|
|
/* See if any of the pins is in ExtINT mode */
|
|
|
|
for (pin = 0; pin < nr_ioapic_registers[apic]; pin++) {
|
|
|
|
struct IO_APIC_route_entry entry;
|
2006-09-26 02:52:30 -06:00
|
|
|
entry = ioapic_read_entry(apic, pin);
|
2006-01-11 14:46:06 -07:00
|
|
|
|
|
|
|
/* If the interrupt line is enabled and in ExtInt mode
|
|
|
|
* I have found the pin where the i8259 is connected.
|
|
|
|
*/
|
|
|
|
if ((entry.mask == 0) && (entry.delivery_mode == dest_ExtINT)) {
|
|
|
|
ioapic_i8259.apic = apic;
|
|
|
|
ioapic_i8259.pin = pin;
|
|
|
|
goto found_i8259;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
found_i8259:
|
|
|
|
/* Look to see what if the MP table has reported the ExtINT */
|
|
|
|
i8259_pin = find_isa_irq_pin(0, mp_ExtINT);
|
|
|
|
i8259_apic = find_isa_irq_apic(0, mp_ExtINT);
|
|
|
|
/* Trust the MP table if nothing is setup in the hardware */
|
|
|
|
if ((ioapic_i8259.pin == -1) && (i8259_pin >= 0)) {
|
|
|
|
printk(KERN_WARNING "ExtINT not setup in hardware but reported by MP table\n");
|
|
|
|
ioapic_i8259.pin = i8259_pin;
|
|
|
|
ioapic_i8259.apic = i8259_apic;
|
|
|
|
}
|
|
|
|
/* Complain if the MP table and the hardware disagree */
|
|
|
|
if (((ioapic_i8259.apic != i8259_apic) || (ioapic_i8259.pin != i8259_pin)) &&
|
|
|
|
(i8259_pin >= 0) && (ioapic_i8259.pin >= 0))
|
|
|
|
{
|
|
|
|
printk(KERN_WARNING "ExtINT in hardware and MP table differ\n");
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Do not trust the IO-APIC being empty at bootup
|
|
|
|
*/
|
|
|
|
clear_IO_APIC();
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Not an __init, needed by the reboot code
|
|
|
|
*/
|
|
|
|
void disable_IO_APIC(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Clear the IO-APIC before rebooting:
|
|
|
|
*/
|
|
|
|
clear_IO_APIC();
|
|
|
|
|
2005-06-25 15:57:45 -06:00
|
|
|
/*
|
2005-09-09 04:59:04 -06:00
|
|
|
* If the i8259 is routed through an IOAPIC
|
2005-06-25 15:57:45 -06:00
|
|
|
* Put that IOAPIC in virtual wire mode
|
2005-09-09 04:59:04 -06:00
|
|
|
* so legacy interrupts can be delivered.
|
2005-06-25 15:57:45 -06:00
|
|
|
*/
|
2006-01-11 14:46:06 -07:00
|
|
|
if (ioapic_i8259.pin != -1) {
|
2005-06-25 15:57:45 -06:00
|
|
|
struct IO_APIC_route_entry entry;
|
|
|
|
|
|
|
|
memset(&entry, 0, sizeof(entry));
|
|
|
|
entry.mask = 0; /* Enabled */
|
|
|
|
entry.trigger = 0; /* Edge */
|
|
|
|
entry.irr = 0;
|
|
|
|
entry.polarity = 0; /* High */
|
|
|
|
entry.delivery_status = 0;
|
|
|
|
entry.dest_mode = 0; /* Physical */
|
2006-01-11 14:46:06 -07:00
|
|
|
entry.delivery_mode = dest_ExtINT; /* ExtInt */
|
2005-06-25 15:57:45 -06:00
|
|
|
entry.vector = 0;
|
2008-03-28 13:12:02 -06:00
|
|
|
entry.dest = GET_APIC_ID(read_apic_id());
|
2005-06-25 15:57:45 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Add it to the IO-APIC irq-routing table:
|
|
|
|
*/
|
2006-09-26 02:52:30 -06:00
|
|
|
ioapic_write_entry(ioapic_i8259.apic, ioapic_i8259.pin, entry);
|
2005-06-25 15:57:45 -06:00
|
|
|
}
|
|
|
|
|
2006-01-11 14:46:06 -07:00
|
|
|
disconnect_bsp_APIC(ioapic_i8259.pin != -1);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* There is a nasty bug in some older SMP boards, their mptable lies
|
|
|
|
* about the timer IRQ. We do the following to work around the situation:
|
|
|
|
*
|
|
|
|
* - timer IRQ defaults to IO-APIC IRQ
|
|
|
|
* - if this function detects that timer IRQs are defunct, then we fall
|
|
|
|
* back to ISA timer IRQs
|
|
|
|
*/
|
|
|
|
static int __init timer_irq_works(void)
|
|
|
|
{
|
|
|
|
unsigned long t1 = jiffies;
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
unsigned long flags;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
local_save_flags(flags);
|
2005-04-16 16:20:36 -06:00
|
|
|
local_irq_enable();
|
|
|
|
/* Let ten ticks pass... */
|
|
|
|
mdelay((10 * 1000) / HZ);
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
local_irq_restore(flags);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Expect a few ticks at least, to be sure some possible
|
|
|
|
* glue logic does not lock up after one or two first
|
|
|
|
* ticks in a non-ExtINT mode. Also the local APIC
|
|
|
|
* might have cached one ExtINT interrupt. Finally, at
|
|
|
|
* least one tick may be lost due to delays.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* jiffies wrap? */
|
2008-01-30 05:32:19 -07:00
|
|
|
if (time_after(jiffies, t1 + 4))
|
2005-04-16 16:20:36 -06:00
|
|
|
return 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* In the SMP+IOAPIC case it might happen that there are an unspecified
|
|
|
|
* number of pending IRQ events unhandled. These cases are very rare,
|
|
|
|
* so we 'resend' these IRQs via IPIs, to the same CPU. It's much
|
|
|
|
* better to do it this way as thus we do not have to be aware of
|
|
|
|
* 'pending' interrupts in the IRQ path, except at this point.
|
|
|
|
*/
|
|
|
|
/*
|
|
|
|
* Edge triggered needs to resend any interrupt
|
|
|
|
* that was delayed but this is now handled in the device
|
|
|
|
* independent code.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Starting up a edge-triggered IO-APIC interrupt is
|
|
|
|
* nasty - we need to make sure that we get the edge.
|
|
|
|
* If it is already asserted for some reason, we need
|
|
|
|
* return 1 to indicate that is was pending.
|
|
|
|
*
|
|
|
|
* This is not complete - we should be able to fake
|
|
|
|
* an edge even if it isn't on the 8259A...
|
|
|
|
*/
|
|
|
|
|
2006-10-04 03:16:25 -06:00
|
|
|
static unsigned int startup_ioapic_irq(unsigned int irq)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
int was_pending = 0;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
if (irq < 16) {
|
|
|
|
disable_8259A_irq(irq);
|
|
|
|
if (i8259A_irq_pending(irq))
|
|
|
|
was_pending = 1;
|
|
|
|
}
|
|
|
|
__unmask_IO_APIC_irq(irq);
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
|
|
|
|
return was_pending;
|
|
|
|
}
|
|
|
|
|
2006-10-04 03:16:46 -06:00
|
|
|
static int ioapic_retrigger_irq(unsigned int irq)
|
2006-06-29 03:24:44 -06:00
|
|
|
{
|
2007-02-23 04:32:47 -07:00
|
|
|
struct irq_cfg *cfg = &irq_cfg[irq];
|
2006-10-21 10:37:02 -06:00
|
|
|
unsigned long flags;
|
2006-10-04 03:16:51 -06:00
|
|
|
|
2006-10-21 10:37:02 -06:00
|
|
|
spin_lock_irqsave(&vector_lock, flags);
|
2008-07-15 15:14:31 -06:00
|
|
|
send_IPI_mask(cpumask_of_cpu(first_cpu(cfg->domain)), cfg->vector);
|
2006-10-21 10:37:02 -06:00
|
|
|
spin_unlock_irqrestore(&vector_lock, flags);
|
2006-06-29 03:24:44 -06:00
|
|
|
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/*
|
|
|
|
* Level and edge triggered IO-APIC interrupts need different handling,
|
|
|
|
* so we use two separate IRQ descriptors. Edge triggered IRQs can be
|
|
|
|
* handled with the level-triggered descriptor, but that one has slightly
|
|
|
|
* more overhead. Level-triggered interrupts cannot be handled with the
|
|
|
|
* edge-triggered handler, without risking IRQ storms and other ugly
|
|
|
|
* races.
|
|
|
|
*/
|
|
|
|
|
2007-02-23 04:40:58 -07:00
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
asmlinkage void smp_irq_move_cleanup_interrupt(void)
|
|
|
|
{
|
|
|
|
unsigned vector, me;
|
|
|
|
ack_APIC_irq();
|
|
|
|
exit_idle();
|
|
|
|
irq_enter();
|
|
|
|
|
|
|
|
me = smp_processor_id();
|
|
|
|
for (vector = FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; vector++) {
|
|
|
|
unsigned int irq;
|
|
|
|
struct irq_desc *desc;
|
|
|
|
struct irq_cfg *cfg;
|
|
|
|
irq = __get_cpu_var(vector_irq)[vector];
|
|
|
|
if (irq >= NR_IRQS)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
desc = irq_desc + irq;
|
|
|
|
cfg = irq_cfg + irq;
|
|
|
|
spin_lock(&desc->lock);
|
|
|
|
if (!cfg->move_cleanup_count)
|
|
|
|
goto unlock;
|
|
|
|
|
|
|
|
if ((vector == cfg->vector) && cpu_isset(me, cfg->domain))
|
|
|
|
goto unlock;
|
|
|
|
|
|
|
|
__get_cpu_var(vector_irq)[vector] = -1;
|
|
|
|
cfg->move_cleanup_count--;
|
|
|
|
unlock:
|
|
|
|
spin_unlock(&desc->lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
irq_exit();
|
|
|
|
}
|
|
|
|
|
|
|
|
static void irq_complete_move(unsigned int irq)
|
|
|
|
{
|
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
|
|
|
unsigned vector, me;
|
|
|
|
|
|
|
|
if (likely(!cfg->move_in_progress))
|
|
|
|
return;
|
|
|
|
|
2008-01-30 05:30:56 -07:00
|
|
|
vector = ~get_irq_regs()->orig_ax;
|
2007-02-23 04:40:58 -07:00
|
|
|
me = smp_processor_id();
|
2007-05-02 11:27:08 -06:00
|
|
|
if ((vector == cfg->vector) && cpu_isset(me, cfg->domain)) {
|
2007-02-23 04:40:58 -07:00
|
|
|
cpumask_t cleanup_mask;
|
|
|
|
|
|
|
|
cpus_and(cleanup_mask, cfg->old_domain, cpu_online_map);
|
|
|
|
cfg->move_cleanup_count = cpus_weight(cleanup_mask);
|
|
|
|
send_IPI_mask(cleanup_mask, IRQ_MOVE_CLEANUP_VECTOR);
|
|
|
|
cfg->move_in_progress = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
static inline void irq_complete_move(unsigned int irq) {}
|
|
|
|
#endif
|
|
|
|
|
2006-10-04 03:16:30 -06:00
|
|
|
static void ack_apic_edge(unsigned int irq)
|
|
|
|
{
|
2007-02-23 04:40:58 -07:00
|
|
|
irq_complete_move(irq);
|
2006-10-04 03:16:30 -06:00
|
|
|
move_native_irq(irq);
|
|
|
|
ack_APIC_irq();
|
|
|
|
}
|
|
|
|
|
|
|
|
static void ack_apic_level(unsigned int irq)
|
|
|
|
{
|
|
|
|
int do_unmask_irq = 0;
|
|
|
|
|
2007-02-23 04:40:58 -07:00
|
|
|
irq_complete_move(irq);
|
2008-01-30 05:30:30 -07:00
|
|
|
#ifdef CONFIG_GENERIC_PENDING_IRQ
|
2006-10-04 03:16:30 -06:00
|
|
|
/* If we are moving the irq we need to mask it */
|
|
|
|
if (unlikely(irq_desc[irq].status & IRQ_MOVE_PENDING)) {
|
|
|
|
do_unmask_irq = 1;
|
|
|
|
mask_IO_APIC_irq(irq);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We must acknowledge the irq before we move it or the acknowledge will
|
2007-05-08 23:14:03 -06:00
|
|
|
* not propagate properly.
|
2006-10-04 03:16:30 -06:00
|
|
|
*/
|
|
|
|
ack_APIC_irq();
|
|
|
|
|
|
|
|
/* Now we can move and renable the irq */
|
2007-07-21 09:10:45 -06:00
|
|
|
if (unlikely(do_unmask_irq)) {
|
|
|
|
/* Only migrate the irq if the ack has been received.
|
|
|
|
*
|
|
|
|
* On rare occasions the broadcast level triggered ack gets
|
|
|
|
* delayed going to ioapics, and if we reprogram the
|
|
|
|
* vector while Remote IRR is still set the irq will never
|
|
|
|
* fire again.
|
|
|
|
*
|
|
|
|
* To prevent this scenario we read the Remote IRR bit
|
|
|
|
* of the ioapic. This has two effects.
|
|
|
|
* - On any sane system the read of the ioapic will
|
|
|
|
* flush writes (and acks) going to the ioapic from
|
|
|
|
* this cpu.
|
|
|
|
* - We get to see if the ACK has actually been delivered.
|
|
|
|
*
|
|
|
|
* Based on failed experiments of reprogramming the
|
|
|
|
* ioapic entry from outside of irq context starting
|
|
|
|
* with masking the ioapic entry and then polling until
|
|
|
|
* Remote IRR was clear before reprogramming the
|
|
|
|
* ioapic I don't trust the Remote IRR bit to be
|
|
|
|
* completey accurate.
|
|
|
|
*
|
|
|
|
* However there appears to be no other way to plug
|
|
|
|
* this race, so if the Remote IRR bit is not
|
|
|
|
* accurate and is causing problems then it is a hardware bug
|
|
|
|
* and you can go talk to the chipset vendor about it.
|
|
|
|
*/
|
|
|
|
if (!io_apic_level_ack_pending(irq))
|
|
|
|
move_masked_irq(irq);
|
2006-10-04 03:16:30 -06:00
|
|
|
unmask_IO_APIC_irq(irq);
|
2007-07-21 09:10:45 -06:00
|
|
|
}
|
2006-10-04 03:16:30 -06:00
|
|
|
}
|
|
|
|
|
2006-10-04 03:16:25 -06:00
|
|
|
static struct irq_chip ioapic_chip __read_mostly = {
|
|
|
|
.name = "IO-APIC",
|
2006-10-04 03:16:46 -06:00
|
|
|
.startup = startup_ioapic_irq,
|
|
|
|
.mask = mask_IO_APIC_irq,
|
|
|
|
.unmask = unmask_IO_APIC_irq,
|
2006-10-04 03:16:30 -06:00
|
|
|
.ack = ack_apic_edge,
|
|
|
|
.eoi = ack_apic_level,
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
#ifdef CONFIG_SMP
|
2006-10-04 03:16:46 -06:00
|
|
|
.set_affinity = set_ioapic_affinity_irq,
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
#endif
|
2006-10-04 03:16:46 -06:00
|
|
|
.retrigger = ioapic_retrigger_irq,
|
2005-04-16 16:20:36 -06:00
|
|
|
};
|
|
|
|
|
|
|
|
static inline void init_IO_APIC_traps(void)
|
|
|
|
{
|
|
|
|
int irq;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* NOTE! The local APIC isn't very good at handling
|
|
|
|
* multiple interrupts at the same interrupt level.
|
|
|
|
* As the interrupt level is determined by taking the
|
|
|
|
* vector number and shifting that right by 4, we
|
|
|
|
* want to spread these out a bit so that they don't
|
|
|
|
* all fall in the same interrupt level.
|
|
|
|
*
|
|
|
|
* Also, we've got to be careful not to trash gate
|
|
|
|
* 0x80, because int 0x80 is hm, kind of importantish. ;)
|
|
|
|
*/
|
|
|
|
for (irq = 0; irq < NR_IRQS ; irq++) {
|
2008-04-05 07:39:07 -06:00
|
|
|
if (IO_APIC_IRQ(irq) && !irq_cfg[irq].vector) {
|
2005-04-16 16:20:36 -06:00
|
|
|
/*
|
|
|
|
* Hmm.. We don't have an entry for this,
|
|
|
|
* so default to an old-fashioned 8259
|
|
|
|
* interrupt if we can..
|
|
|
|
*/
|
|
|
|
if (irq < 16)
|
|
|
|
make_8259A_irq(irq);
|
|
|
|
else
|
|
|
|
/* Strange. Oh, well.. */
|
2006-10-04 03:16:25 -06:00
|
|
|
irq_desc[irq].chip = &no_irq_chip;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-07-11 12:35:17 -06:00
|
|
|
static void unmask_lapic_irq(unsigned int irq)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
unsigned long v;
|
|
|
|
|
|
|
|
v = apic_read(APIC_LVT0);
|
2006-01-11 14:46:51 -07:00
|
|
|
apic_write(APIC_LVT0, v & ~APIC_LVT_MASKED);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2008-07-11 12:35:17 -06:00
|
|
|
static void mask_lapic_irq(unsigned int irq)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
unsigned long v;
|
|
|
|
|
|
|
|
v = apic_read(APIC_LVT0);
|
2006-01-11 14:46:51 -07:00
|
|
|
apic_write(APIC_LVT0, v | APIC_LVT_MASKED);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
static void ack_lapic_irq (unsigned int irq)
|
|
|
|
{
|
|
|
|
ack_APIC_irq();
|
|
|
|
}
|
|
|
|
|
2008-07-11 12:35:17 -06:00
|
|
|
static struct irq_chip lapic_chip __read_mostly = {
|
|
|
|
.name = "local-APIC",
|
|
|
|
.mask = mask_lapic_irq,
|
|
|
|
.unmask = unmask_lapic_irq,
|
|
|
|
.ack = ack_lapic_irq,
|
2005-04-16 16:20:36 -06:00
|
|
|
};
|
|
|
|
|
2008-07-11 12:35:17 -06:00
|
|
|
static void lapic_register_intr(int irq)
|
|
|
|
{
|
|
|
|
irq_desc[irq].status &= ~IRQ_LEVEL;
|
|
|
|
set_irq_chip_and_handler_name(irq, &lapic_chip, handle_edge_irq,
|
|
|
|
"edge");
|
|
|
|
}
|
|
|
|
|
2008-01-30 05:31:24 -07:00
|
|
|
static void __init setup_nmi(void)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Dirty trick to enable the NMI watchdog ...
|
|
|
|
* We put the 8259A master into AEOI mode and
|
|
|
|
* unmask on all local APICs LVT0 as NMI.
|
|
|
|
*
|
|
|
|
* The idea to use the 8259A in AEOI mode ('8259A Virtual Wire')
|
|
|
|
* is from Maciej W. Rozycki - so we do not have to EOI from
|
|
|
|
* the NMI handler or the timer interrupt.
|
|
|
|
*/
|
|
|
|
printk(KERN_INFO "activating NMI Watchdog ...");
|
|
|
|
|
2008-01-30 05:31:24 -07:00
|
|
|
enable_NMI_through_LVT0();
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
printk(" done.\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This looks a bit hackish but it's about the only one way of sending
|
|
|
|
* a few INTA cycles to 8259As and any associated glue logic. ICR does
|
|
|
|
* not support the ExtINT mode, unfortunately. We need to send these
|
|
|
|
* cycles as some i82489DX-based boards have glue logic that keeps the
|
|
|
|
* 8259A interrupt line asserted until INTA. --macro
|
|
|
|
*/
|
2008-04-11 05:29:04 -06:00
|
|
|
static inline void __init unlock_ExtINT_logic(void)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2006-01-11 14:46:06 -07:00
|
|
|
int apic, pin, i;
|
2005-04-16 16:20:36 -06:00
|
|
|
struct IO_APIC_route_entry entry0, entry1;
|
|
|
|
unsigned char save_control, save_freq_select;
|
|
|
|
|
2006-01-11 14:46:06 -07:00
|
|
|
pin = find_isa_irq_pin(8, mp_INT);
|
|
|
|
apic = find_isa_irq_apic(8, mp_INT);
|
2005-04-16 16:20:36 -06:00
|
|
|
if (pin == -1)
|
|
|
|
return;
|
|
|
|
|
2008-04-05 07:39:05 -06:00
|
|
|
entry0 = ioapic_read_entry(apic, pin);
|
|
|
|
|
2006-01-11 14:46:06 -07:00
|
|
|
clear_IO_APIC_pin(apic, pin);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
memset(&entry1, 0, sizeof(entry1));
|
|
|
|
|
|
|
|
entry1.dest_mode = 0; /* physical delivery */
|
|
|
|
entry1.mask = 0; /* unmask IRQ now */
|
2007-02-13 05:26:25 -07:00
|
|
|
entry1.dest = hard_smp_processor_id();
|
2005-04-16 16:20:36 -06:00
|
|
|
entry1.delivery_mode = dest_ExtINT;
|
|
|
|
entry1.polarity = entry0.polarity;
|
|
|
|
entry1.trigger = 0;
|
|
|
|
entry1.vector = 0;
|
|
|
|
|
2008-04-05 07:39:05 -06:00
|
|
|
ioapic_write_entry(apic, pin, entry1);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
save_control = CMOS_READ(RTC_CONTROL);
|
|
|
|
save_freq_select = CMOS_READ(RTC_FREQ_SELECT);
|
|
|
|
CMOS_WRITE((save_freq_select & ~RTC_RATE_SELECT) | 0x6,
|
|
|
|
RTC_FREQ_SELECT);
|
|
|
|
CMOS_WRITE(save_control | RTC_PIE, RTC_CONTROL);
|
|
|
|
|
|
|
|
i = 100;
|
|
|
|
while (i-- > 0) {
|
|
|
|
mdelay(10);
|
|
|
|
if ((CMOS_READ(RTC_INTR_FLAGS) & RTC_PF) == RTC_PF)
|
|
|
|
i -= 10;
|
|
|
|
}
|
|
|
|
|
|
|
|
CMOS_WRITE(save_control, RTC_CONTROL);
|
|
|
|
CMOS_WRITE(save_freq_select, RTC_FREQ_SELECT);
|
2006-01-11 14:46:06 -07:00
|
|
|
clear_IO_APIC_pin(apic, pin);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2008-04-05 07:39:05 -06:00
|
|
|
ioapic_write_entry(apic, pin, entry0);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This code may look a bit paranoid, but it's supposed to cooperate with
|
|
|
|
* a wide range of boards and BIOS bugs. Fortunately only the timer IRQ
|
|
|
|
* is so screwy. Thanks to Brian Perkins for testing/hacking this beast
|
|
|
|
* fanatically on his truly buggy board.
|
2007-01-08 16:04:46 -07:00
|
|
|
*
|
|
|
|
* FIXME: really need to revamp this for modern platforms only.
|
2005-04-16 16:20:36 -06:00
|
|
|
*/
|
2008-01-30 05:31:24 -07:00
|
|
|
static inline void __init check_timer(void)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
struct irq_cfg *cfg = irq_cfg + 0;
|
2006-01-11 14:46:06 -07:00
|
|
|
int apic1, pin1, apic2, pin2;
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
unsigned long flags;
|
2008-05-27 14:19:51 -06:00
|
|
|
int no_pin1 = 0;
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
|
|
|
|
local_irq_save(flags);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* get/set the timer IRQ vector:
|
|
|
|
*/
|
|
|
|
disable_8259A_irq(0);
|
2007-02-23 04:35:05 -07:00
|
|
|
assign_irq_vector(0, TARGET_CPUS);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
2008-05-21 15:09:11 -06:00
|
|
|
* As IRQ0 is to be enabled in the 8259A, the virtual
|
|
|
|
* wire has to be disabled in the local APIC.
|
2005-04-16 16:20:36 -06:00
|
|
|
*/
|
2006-01-11 14:46:51 -07:00
|
|
|
apic_write(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_EXTINT);
|
2005-04-16 16:20:36 -06:00
|
|
|
init_8259A(1);
|
|
|
|
|
2006-01-11 14:46:06 -07:00
|
|
|
pin1 = find_isa_irq_pin(0, mp_INT);
|
|
|
|
apic1 = find_isa_irq_apic(0, mp_INT);
|
|
|
|
pin2 = ioapic_i8259.pin;
|
|
|
|
apic2 = ioapic_i8259.apic;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "..TIMER: vector=0x%02X "
|
|
|
|
"apic1=%d pin1=%d apic2=%d pin2=%d\n",
|
|
|
|
cfg->vector, apic1, pin1, apic2, pin2);
|
2006-12-06 18:14:06 -07:00
|
|
|
|
2008-05-27 14:19:51 -06:00
|
|
|
/*
|
|
|
|
* Some BIOS writers are clueless and report the ExtINTA
|
|
|
|
* I/O APIC input from the cascaded 8259A as the timer
|
|
|
|
* interrupt input. So just in case, if only one pin
|
|
|
|
* was found above, try it both directly and through the
|
|
|
|
* 8259A.
|
|
|
|
*/
|
|
|
|
if (pin1 == -1) {
|
|
|
|
pin1 = pin2;
|
|
|
|
apic1 = apic2;
|
|
|
|
no_pin1 = 1;
|
|
|
|
} else if (pin2 == -1) {
|
|
|
|
pin2 = pin1;
|
|
|
|
apic2 = apic1;
|
|
|
|
}
|
|
|
|
|
2007-01-08 16:04:46 -07:00
|
|
|
if (pin1 != -1) {
|
|
|
|
/*
|
|
|
|
* Ok, does IRQ0 through the IOAPIC work?
|
|
|
|
*/
|
2008-05-27 14:19:51 -06:00
|
|
|
if (no_pin1) {
|
|
|
|
add_pin_to_irq(0, apic1, pin1);
|
2008-05-31 04:20:10 -06:00
|
|
|
setup_timer_IRQ0_pin(apic1, pin1, cfg->vector);
|
2008-05-27 14:19:51 -06:00
|
|
|
}
|
2007-01-08 16:04:46 -07:00
|
|
|
unmask_IO_APIC_irq(0);
|
|
|
|
if (!no_timer_check && timer_irq_works()) {
|
|
|
|
if (nmi_watchdog == NMI_IO_APIC) {
|
|
|
|
setup_nmi();
|
|
|
|
enable_8259A_irq(0);
|
|
|
|
}
|
|
|
|
if (disable_timer_pin_1 > 0)
|
|
|
|
clear_IO_APIC_pin(0, pin1);
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
goto out;
|
2007-01-08 16:04:46 -07:00
|
|
|
}
|
|
|
|
clear_IO_APIC_pin(apic1, pin1);
|
2008-05-27 14:19:51 -06:00
|
|
|
if (!no_pin1)
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_ERR "..MP-BIOS bug: "
|
2008-05-27 14:19:51 -06:00
|
|
|
"8254 timer not connected to IO-APIC\n");
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "...trying to set up timer "
|
|
|
|
"(IRQ0) through the 8259A ...\n");
|
|
|
|
apic_printk(APIC_QUIET, KERN_INFO
|
|
|
|
"..... (found apic %d pin %d) ...\n", apic2, pin2);
|
2007-01-08 16:04:46 -07:00
|
|
|
/*
|
|
|
|
* legacy devices should be connected to IO APIC #0
|
|
|
|
*/
|
2008-06-30 18:19:31 -06:00
|
|
|
replace_pin_at_irq(0, apic1, pin1, apic2, pin2);
|
2008-05-27 14:19:34 -06:00
|
|
|
setup_timer_IRQ0_pin(apic2, pin2, cfg->vector);
|
2008-05-27 14:19:40 -06:00
|
|
|
unmask_IO_APIC_irq(0);
|
2008-05-21 15:09:19 -06:00
|
|
|
enable_8259A_irq(0);
|
2007-01-08 16:04:46 -07:00
|
|
|
if (timer_irq_works()) {
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "....... works.\n");
|
2008-05-21 15:10:22 -06:00
|
|
|
timer_through_8259 = 1;
|
2007-01-08 16:04:46 -07:00
|
|
|
if (nmi_watchdog == NMI_IO_APIC) {
|
2008-05-21 15:09:34 -06:00
|
|
|
disable_8259A_irq(0);
|
2007-01-08 16:04:46 -07:00
|
|
|
setup_nmi();
|
2008-05-21 15:09:34 -06:00
|
|
|
enable_8259A_irq(0);
|
2007-01-08 16:04:46 -07:00
|
|
|
}
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
goto out;
|
2007-01-08 16:04:46 -07:00
|
|
|
}
|
|
|
|
/*
|
|
|
|
* Cleanup, just in case ...
|
|
|
|
*/
|
2008-05-21 15:09:19 -06:00
|
|
|
disable_8259A_irq(0);
|
2007-01-08 16:04:46 -07:00
|
|
|
clear_IO_APIC_pin(apic2, pin2);
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "....... failed.\n");
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2006-02-25 20:18:40 -07:00
|
|
|
if (nmi_watchdog == NMI_IO_APIC) {
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_WARNING "timer doesn't work "
|
|
|
|
"through the IO-APIC - disabling NMI Watchdog!\n");
|
2008-05-29 12:32:30 -06:00
|
|
|
nmi_watchdog = NMI_NONE;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO
|
|
|
|
"...trying to set up timer as Virtual Wire IRQ...\n");
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2008-07-11 12:35:17 -06:00
|
|
|
lapic_register_intr(0);
|
2007-02-23 04:35:05 -07:00
|
|
|
apic_write(APIC_LVT0, APIC_DM_FIXED | cfg->vector); /* Fixed mode */
|
2005-04-16 16:20:36 -06:00
|
|
|
enable_8259A_irq(0);
|
|
|
|
|
|
|
|
if (timer_irq_works()) {
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "..... works.\n");
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
goto out;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2008-05-21 15:09:26 -06:00
|
|
|
disable_8259A_irq(0);
|
2007-02-23 04:35:05 -07:00
|
|
|
apic_write(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_FIXED | cfg->vector);
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "..... failed.\n");
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO
|
|
|
|
"...trying to set up timer as ExtINT IRQ...\n");
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
init_8259A(0);
|
|
|
|
make_8259A_irq(0);
|
2006-01-11 14:46:51 -07:00
|
|
|
apic_write(APIC_LVT0, APIC_DM_EXTINT);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
unlock_ExtINT_logic();
|
|
|
|
|
|
|
|
if (timer_irq_works()) {
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "..... works.\n");
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
goto out;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2008-07-14 12:08:13 -06:00
|
|
|
apic_printk(APIC_QUIET, KERN_INFO "..... failed :(.\n");
|
|
|
|
panic("IO-APIC + timer doesn't work! Boot with apic=debug and send a "
|
|
|
|
"report. Then try booting with the 'noapic' option.\n");
|
x86: fix "Kernel panic - not syncing: IO-APIC + timer doesn't work!"
this is the tale of a full day spent debugging an ancient but elusive bug.
after booting up thousands of random .config kernels, i finally happened
to generate a .config that produced the following rare bootup failure
on 32-bit x86:
| ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
| ..MP-BIOS bug: 8254 timer not connected to IO-APIC
| ...trying to set up timer (IRQ0) through the 8259A ... failed.
| ...trying to set up timer as Virtual Wire IRQ... failed.
| ...trying to set up timer as ExtINT IRQ... failed :(.
| Kernel panic - not syncing: IO-APIC + timer doesn't work! Boot with apic=debug
| and send a report. Then try booting with the 'noapic' option
this bug has been reported many times during the years, but it was never
reproduced nor fixed.
the bug that i hit was extremely sensitive to .config details.
First i did a .config-bisection - suspecting some .config detail.
That led to CONFIG_X86_MCE: enabling X86_MCE magically made the bug disappear
and the system would boot up just fine.
Debugging my way through the MCE code ended up identifying two unlikely
candidates: the thing that made a real difference to the hang was that
X86_MCE did two printks:
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#1.
Adding the same printks to a !CONFIG_X86_MCE kernel made the bug go away!
this left timing as the main suspect: i experimented with adding various
udelay()s to the arch/x86/kernel/io_apic_32.c:check_timer() function, and
the race window turned out to be narrower than 30 microseconds (!).
That made debugging especially funny, debugging without having printk
ability before the bug hits is ... interesting ;-)
eventually i started suspecting IRQ activities - those are pretty much the
only thing that happen this early during bootup and have the timescale of
a few dozen microseconds. Also, check_timer() changes the IRQ hardware
in various creative ways, so the main candidate became IRQ0 interaction.
i've added a counter to track timer irqs (on which core they arrived, at
what exact time, etc.) and found that no timer IRQ would arrive after the
bug condition hits - even if we re-enable IRQ0 and re-initialize the i8259A,
but that we'd get a small number of timer irqs right around the time when we
call the check_timer() function.
Eventually i got the following backtrace triggered from debug code in the
timer interrupt:
...trying to set up timer as Virtual Wire IRQ... failed.
...trying to set up timer as ExtINT IRQ...
Pid: 1, comm: swapper Not tainted (2.6.24-rc5 #57)
EIP: 0060:[<c044d57e>] EFLAGS: 00000246 CPU: 0
EIP is at _spin_unlock_irqrestore+0x5/0x1c
EAX: c0634178 EBX: 00000000 ECX: c4947d63 EDX: 00000246
ESI: 00000002 EDI: 00010031 EBP: c04e0f2e ESP: f7c41df4
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
CR0: 8005003b CR2: ffe04000 CR3: 00630000 CR4: 000006d0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[<c05f5784>] setup_IO_APIC+0x9c3/0xc5c
the spin_unlock() was called from init_8259A(). Wait ... we have an IRQ0
entry while we are in the middle of setting up the local APIC, the i8259A
and the PIT??
That is certainly not how it's supposed to work! check_timer() was supposed
to be called with irqs turned off - but this eroded away sometime in the
past. This code would still work most of the time because this code runs
very quickly, but just the right timing conditions are present and IRQ0
hits in this small, ~30 usecs window, timer irqs stop and the system does
not boot up. Also, given how early this is during bootup, the hang is
very deterministic - but it would only occur on certain machines (and
certain configs).
The fix was quite simple: disable/restore interrupts properly in this
function. With that in place the test-system now boots up just fine.
(64-bit x86 io_apic_64.c had the same bug.)
Phew! One down, only 1500 other kernel bugs are left ;-)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2007-12-18 10:05:58 -07:00
|
|
|
out:
|
|
|
|
local_irq_restore(flags);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2005-05-20 15:27:59 -06:00
|
|
|
static int __init notimercheck(char *s)
|
|
|
|
{
|
|
|
|
no_timer_check = 1;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
__setup("no_timer_check", notimercheck);
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/*
|
x86: I/O APIC: Never configure IRQ2
There is no such entity as ISA IRQ2. The ACPI spec does not make it
explicitly clear, but does not preclude it either -- all it says is ISA
legacy interrupts are identity mapped by default (subject to overrides),
but it does not state whether IRQ2 exists or not. As a result if there is
no IRQ0 override, then IRQ2 is normally initialised as an ISA interrupt,
which implies an edge-triggered line, which is unmasked by default as this
is what we do for edge-triggered I/O APIC interrupts so as not to miss an
edge.
To the best of my knowledge it is useless, as IRQ2 has not been in use
since the PC/AT as back then it was taken by the 8259A cascade interrupt
to the slave, with the line position in the slot rerouted to newly-created
IRQ9. No device could thus make use of this line with the pair of 8259A
chips. Now in theory INTIN2 of the I/O APIC may be usable, but the
interrupt of the device wired to it would not be available in the PIC mode
at all, so I seriously doubt if anybody decided to reuse it for a regular
device.
However there are two common uses of INTIN2. One is for IRQ0, with an
ACPI interrupt override (or its equivalent in the MP table). But in this
case IRQ2 is gone entirely with INTIN0 left vacant. The other one is for
an 8959A ExtINTA cascade. In this case IRQ0 goes to INTIN0 and if ACPI is
used INTIN2 is assumed to be IRQ2 (there is no override and ACPI has no
way to report ExtINTA interrupts). This is where a problem happens.
The problem is INTIN2 is configured as a native APIC interrupt, with a
vector assigned and the mask cleared. And the line may indeed get active
and inject interrupts if the master 8959A has its timer interrupt enabled
(it might happen for other interrupts too, but they are normally masked in
the process of rerouting them to the I/O APIC). There are two cases where
it will happen:
* When the I/O APIC NMI watchdog is enabled. This is actually a misnomer
as the watchdog pulses are delivered through the 8259A to the LINT0
inputs of all the local APICs in the system. The implication is the
output of the master 8259A goes high and low repeatedly, signalling
interrupts to INTIN2 which is enabled too!
[The origin of the name is I think for a brief period during the
development we had a capability in our code to configure the watchdog to
use an I/O APIC input; that would be INTIN2 in this scenario.]
* When the native route of IRQ0 via INTIN0 fails for whatever reason -- as
it happens with the system considered here. In this scenario the timer
pulse is delivered through the 8259A to LINT0 input of the local APIC of
the bootstrap processor, quite similarly to how is done for the watchdog
described above. The result is, again, INTIN2 receives these pulses
too. Rafael's system used to escape this scenario, because an incorrect
IRQ0 override would occupy INTIN2 and prevent it from being unmasked.
My conclusion is IRQ2 should be excluded from configuration in all the
cases and the current exception for ACPI systems should be lifted. The
reason being the exception not only being useless, but harmful as well.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2008-07-11 12:35:23 -06:00
|
|
|
* Traditionally ISA IRQ2 is the cascade IRQ, and is not available
|
|
|
|
* to devices. However there may be an I/O APIC pin available for
|
|
|
|
* this interrupt regardless. The pin may be left unconnected, but
|
|
|
|
* typically it will be reused as an ExtINT cascade interrupt for
|
|
|
|
* the master 8259A. In the MPS case such a pin will normally be
|
|
|
|
* reported as an ExtINT interrupt in the MP table. With ACPI
|
|
|
|
* there is no provision for ExtINT interrupts, and in the absence
|
|
|
|
* of an override it would be treated as an ordinary ISA I/O APIC
|
|
|
|
* interrupt, that is edge-triggered and unmasked by default. We
|
|
|
|
* used to do this, but it caused problems on some systems because
|
|
|
|
* of the NMI watchdog and sometimes IRQ0 of the 8254 timer using
|
|
|
|
* the same ExtINT cascade interrupt to drive the local APIC of the
|
|
|
|
* bootstrap processor. Therefore we refrain from routing IRQ2 to
|
|
|
|
* the I/O APIC in all cases now. No actual device should request
|
|
|
|
* it anyway. --macro
|
2005-04-16 16:20:36 -06:00
|
|
|
*/
|
|
|
|
#define PIC_IRQS (1<<2)
|
|
|
|
|
|
|
|
void __init setup_IO_APIC(void)
|
|
|
|
{
|
2008-01-30 05:30:39 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* calling enable_IO_APIC() is moved to setup_local_APIC for BP
|
|
|
|
*/
|
2005-04-16 16:20:36 -06:00
|
|
|
|
x86: I/O APIC: Never configure IRQ2
There is no such entity as ISA IRQ2. The ACPI spec does not make it
explicitly clear, but does not preclude it either -- all it says is ISA
legacy interrupts are identity mapped by default (subject to overrides),
but it does not state whether IRQ2 exists or not. As a result if there is
no IRQ0 override, then IRQ2 is normally initialised as an ISA interrupt,
which implies an edge-triggered line, which is unmasked by default as this
is what we do for edge-triggered I/O APIC interrupts so as not to miss an
edge.
To the best of my knowledge it is useless, as IRQ2 has not been in use
since the PC/AT as back then it was taken by the 8259A cascade interrupt
to the slave, with the line position in the slot rerouted to newly-created
IRQ9. No device could thus make use of this line with the pair of 8259A
chips. Now in theory INTIN2 of the I/O APIC may be usable, but the
interrupt of the device wired to it would not be available in the PIC mode
at all, so I seriously doubt if anybody decided to reuse it for a regular
device.
However there are two common uses of INTIN2. One is for IRQ0, with an
ACPI interrupt override (or its equivalent in the MP table). But in this
case IRQ2 is gone entirely with INTIN0 left vacant. The other one is for
an 8959A ExtINTA cascade. In this case IRQ0 goes to INTIN0 and if ACPI is
used INTIN2 is assumed to be IRQ2 (there is no override and ACPI has no
way to report ExtINTA interrupts). This is where a problem happens.
The problem is INTIN2 is configured as a native APIC interrupt, with a
vector assigned and the mask cleared. And the line may indeed get active
and inject interrupts if the master 8959A has its timer interrupt enabled
(it might happen for other interrupts too, but they are normally masked in
the process of rerouting them to the I/O APIC). There are two cases where
it will happen:
* When the I/O APIC NMI watchdog is enabled. This is actually a misnomer
as the watchdog pulses are delivered through the 8259A to the LINT0
inputs of all the local APICs in the system. The implication is the
output of the master 8259A goes high and low repeatedly, signalling
interrupts to INTIN2 which is enabled too!
[The origin of the name is I think for a brief period during the
development we had a capability in our code to configure the watchdog to
use an I/O APIC input; that would be INTIN2 in this scenario.]
* When the native route of IRQ0 via INTIN0 fails for whatever reason -- as
it happens with the system considered here. In this scenario the timer
pulse is delivered through the 8259A to LINT0 input of the local APIC of
the bootstrap processor, quite similarly to how is done for the watchdog
described above. The result is, again, INTIN2 receives these pulses
too. Rafael's system used to escape this scenario, because an incorrect
IRQ0 override would occupy INTIN2 and prevent it from being unmasked.
My conclusion is IRQ2 should be excluded from configuration in all the
cases and the current exception for ACPI systems should be lifted. The
reason being the exception not only being useless, but harmful as well.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2008-07-11 12:35:23 -06:00
|
|
|
io_apic_irqs = ~PIC_IRQS;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
apic_printk(APIC_VERBOSE, "ENABLING IO-APIC IRQs\n");
|
|
|
|
|
|
|
|
sync_Arb_IDs();
|
|
|
|
setup_IO_APIC_irqs();
|
|
|
|
init_IO_APIC_traps();
|
|
|
|
check_timer();
|
|
|
|
if (!acpi_ioapic)
|
|
|
|
print_IO_APIC();
|
|
|
|
}
|
|
|
|
|
|
|
|
struct sysfs_ioapic_data {
|
|
|
|
struct sys_device dev;
|
|
|
|
struct IO_APIC_route_entry entry[0];
|
|
|
|
};
|
|
|
|
static struct sysfs_ioapic_data * mp_ioapic_data[MAX_IO_APICS];
|
|
|
|
|
2005-04-16 16:25:31 -06:00
|
|
|
static int ioapic_suspend(struct sys_device *dev, pm_message_t state)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
struct IO_APIC_route_entry *entry;
|
|
|
|
struct sysfs_ioapic_data *data;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
data = container_of(dev, struct sysfs_ioapic_data, dev);
|
|
|
|
entry = data->entry;
|
2006-09-26 02:52:30 -06:00
|
|
|
for (i = 0; i < nr_ioapic_registers[dev->id]; i ++, entry ++ )
|
|
|
|
*entry = ioapic_read_entry(dev->id, i);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ioapic_resume(struct sys_device *dev)
|
|
|
|
{
|
|
|
|
struct IO_APIC_route_entry *entry;
|
|
|
|
struct sysfs_ioapic_data *data;
|
|
|
|
unsigned long flags;
|
|
|
|
union IO_APIC_reg_00 reg_00;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
data = container_of(dev, struct sysfs_ioapic_data, dev);
|
|
|
|
entry = data->entry;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
reg_00.raw = io_apic_read(dev->id, 0);
|
2008-05-14 09:03:10 -06:00
|
|
|
if (reg_00.bits.ID != mp_ioapics[dev->id].mp_apicid) {
|
|
|
|
reg_00.bits.ID = mp_ioapics[dev->id].mp_apicid;
|
2005-04-16 16:20:36 -06:00
|
|
|
io_apic_write(dev->id, 0, reg_00.raw);
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
2006-09-26 02:52:30 -06:00
|
|
|
for (i = 0; i < nr_ioapic_registers[dev->id]; i++)
|
|
|
|
ioapic_write_entry(dev->id, i, entry[i]);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct sysdev_class ioapic_sysdev_class = {
|
2007-12-19 18:09:39 -07:00
|
|
|
.name = "ioapic",
|
2005-04-16 16:20:36 -06:00
|
|
|
.suspend = ioapic_suspend,
|
|
|
|
.resume = ioapic_resume,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init ioapic_init_sysfs(void)
|
|
|
|
{
|
|
|
|
struct sys_device * dev;
|
2007-10-17 10:04:38 -06:00
|
|
|
int i, size, error;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
error = sysdev_class_register(&ioapic_sysdev_class);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
for (i = 0; i < nr_ioapics; i++ ) {
|
|
|
|
size = sizeof(struct sys_device) + nr_ioapic_registers[i]
|
|
|
|
* sizeof(struct IO_APIC_route_entry);
|
2007-10-17 10:04:38 -06:00
|
|
|
mp_ioapic_data[i] = kzalloc(size, GFP_KERNEL);
|
2005-04-16 16:20:36 -06:00
|
|
|
if (!mp_ioapic_data[i]) {
|
|
|
|
printk(KERN_ERR "Can't suspend/resume IOAPIC %d\n", i);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
dev = &mp_ioapic_data[i]->dev;
|
|
|
|
dev->id = i;
|
|
|
|
dev->cls = &ioapic_sysdev_class;
|
|
|
|
error = sysdev_register(dev);
|
|
|
|
if (error) {
|
|
|
|
kfree(mp_ioapic_data[i]);
|
|
|
|
mp_ioapic_data[i] = NULL;
|
|
|
|
printk(KERN_ERR "Can't suspend/resume IOAPIC %d\n", i);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
device_initcall(ioapic_init_sysfs);
|
|
|
|
|
2006-10-04 03:16:40 -06:00
|
|
|
/*
|
2006-10-04 03:16:46 -06:00
|
|
|
* Dynamic irq allocate and deallocation
|
2006-10-04 03:16:40 -06:00
|
|
|
*/
|
|
|
|
int create_irq(void)
|
|
|
|
{
|
2006-10-04 03:16:46 -06:00
|
|
|
/* Allocate an unused irq */
|
|
|
|
int irq;
|
|
|
|
int new;
|
2006-10-04 03:16:40 -06:00
|
|
|
unsigned long flags;
|
|
|
|
|
2006-10-04 03:16:46 -06:00
|
|
|
irq = -ENOSPC;
|
|
|
|
spin_lock_irqsave(&vector_lock, flags);
|
|
|
|
for (new = (NR_IRQS - 1); new >= 0; new--) {
|
|
|
|
if (platform_legacy_irq(new))
|
|
|
|
continue;
|
2007-02-23 04:32:47 -07:00
|
|
|
if (irq_cfg[new].vector != 0)
|
2006-10-04 03:16:46 -06:00
|
|
|
continue;
|
2007-02-23 04:35:05 -07:00
|
|
|
if (__assign_irq_vector(new, TARGET_CPUS) == 0)
|
2006-10-04 03:16:46 -06:00
|
|
|
irq = new;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&vector_lock, flags);
|
2006-10-04 03:16:40 -06:00
|
|
|
|
2006-10-04 03:16:46 -06:00
|
|
|
if (irq >= 0) {
|
2006-10-04 03:16:40 -06:00
|
|
|
dynamic_irq_init(irq);
|
|
|
|
}
|
|
|
|
return irq;
|
|
|
|
}
|
|
|
|
|
|
|
|
void destroy_irq(unsigned int irq)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
dynamic_irq_cleanup(irq);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&vector_lock, flags);
|
2006-12-06 18:14:05 -07:00
|
|
|
__clear_irq_vector(irq);
|
2006-10-04 03:16:40 -06:00
|
|
|
spin_unlock_irqrestore(&vector_lock, flags);
|
|
|
|
}
|
|
|
|
|
2006-10-04 03:16:42 -06:00
|
|
|
/*
|
2007-10-19 17:25:36 -06:00
|
|
|
* MSI message composition
|
2006-10-04 03:16:42 -06:00
|
|
|
*/
|
|
|
|
#ifdef CONFIG_PCI_MSI
|
2006-10-04 03:16:59 -06:00
|
|
|
static int msi_compose_msg(struct pci_dev *pdev, unsigned int irq, struct msi_msg *msg)
|
2006-10-04 03:16:42 -06:00
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
|
|
|
int err;
|
2006-10-04 03:16:42 -06:00
|
|
|
unsigned dest;
|
2006-10-08 07:47:55 -06:00
|
|
|
cpumask_t tmp;
|
2006-10-04 03:16:42 -06:00
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
tmp = TARGET_CPUS;
|
|
|
|
err = assign_irq_vector(irq, tmp);
|
|
|
|
if (!err) {
|
|
|
|
cpus_and(tmp, cfg->domain, tmp);
|
2006-10-04 03:16:42 -06:00
|
|
|
dest = cpu_mask_to_apicid(tmp);
|
|
|
|
|
|
|
|
msg->address_hi = MSI_ADDR_BASE_HI;
|
|
|
|
msg->address_lo =
|
|
|
|
MSI_ADDR_BASE_LO |
|
|
|
|
((INT_DEST_MODE == 0) ?
|
|
|
|
MSI_ADDR_DEST_MODE_PHYSICAL:
|
|
|
|
MSI_ADDR_DEST_MODE_LOGICAL) |
|
|
|
|
((INT_DELIVERY_MODE != dest_LowestPrio) ?
|
|
|
|
MSI_ADDR_REDIRECTION_CPU:
|
|
|
|
MSI_ADDR_REDIRECTION_LOWPRI) |
|
|
|
|
MSI_ADDR_DEST_ID(dest);
|
|
|
|
|
|
|
|
msg->data =
|
|
|
|
MSI_DATA_TRIGGER_EDGE |
|
|
|
|
MSI_DATA_LEVEL_ASSERT |
|
|
|
|
((INT_DELIVERY_MODE != dest_LowestPrio) ?
|
|
|
|
MSI_DATA_DELIVERY_FIXED:
|
|
|
|
MSI_DATA_DELIVERY_LOWPRI) |
|
2007-02-23 04:35:05 -07:00
|
|
|
MSI_DATA_VECTOR(cfg->vector);
|
2006-10-04 03:16:42 -06:00
|
|
|
}
|
2007-02-23 04:35:05 -07:00
|
|
|
return err;
|
2006-10-04 03:16:42 -06:00
|
|
|
}
|
|
|
|
|
2006-10-04 03:16:59 -06:00
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
static void set_msi_irq_affinity(unsigned int irq, cpumask_t mask)
|
2006-10-04 03:16:42 -06:00
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
2006-10-04 03:16:59 -06:00
|
|
|
struct msi_msg msg;
|
|
|
|
unsigned int dest;
|
|
|
|
cpumask_t tmp;
|
|
|
|
|
|
|
|
cpus_and(tmp, mask, cpu_online_map);
|
|
|
|
if (cpus_empty(tmp))
|
2007-02-23 04:20:59 -07:00
|
|
|
return;
|
2006-10-04 03:16:42 -06:00
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
if (assign_irq_vector(irq, mask))
|
2006-10-04 03:16:59 -06:00
|
|
|
return;
|
2006-10-04 03:16:51 -06:00
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
cpus_and(tmp, cfg->domain, mask);
|
2006-10-04 03:16:59 -06:00
|
|
|
dest = cpu_mask_to_apicid(tmp);
|
2006-10-04 03:16:42 -06:00
|
|
|
|
2006-10-04 03:16:59 -06:00
|
|
|
read_msi_msg(irq, &msg);
|
|
|
|
|
|
|
|
msg.data &= ~MSI_DATA_VECTOR_MASK;
|
2007-02-23 04:35:05 -07:00
|
|
|
msg.data |= MSI_DATA_VECTOR(cfg->vector);
|
2006-10-04 03:16:59 -06:00
|
|
|
msg.address_lo &= ~MSI_ADDR_DEST_ID_MASK;
|
|
|
|
msg.address_lo |= MSI_ADDR_DEST_ID(dest);
|
|
|
|
|
|
|
|
write_msi_msg(irq, &msg);
|
2007-02-23 04:13:55 -07:00
|
|
|
irq_desc[irq].affinity = mask;
|
2006-10-04 03:16:42 -06:00
|
|
|
}
|
2006-10-04 03:16:59 -06:00
|
|
|
#endif /* CONFIG_SMP */
|
2006-10-04 03:16:42 -06:00
|
|
|
|
2006-10-04 03:16:59 -06:00
|
|
|
/*
|
|
|
|
* IRQ Chip for MSI PCI/PCI-X/PCI-Express Devices,
|
|
|
|
* which implement the MSI or MSI-X Capability Structure.
|
|
|
|
*/
|
|
|
|
static struct irq_chip msi_chip = {
|
|
|
|
.name = "PCI-MSI",
|
|
|
|
.unmask = unmask_msi_irq,
|
|
|
|
.mask = mask_msi_irq,
|
|
|
|
.ack = ack_apic_edge,
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
.set_affinity = set_msi_irq_affinity,
|
|
|
|
#endif
|
|
|
|
.retrigger = ioapic_retrigger_irq,
|
2006-10-04 03:16:42 -06:00
|
|
|
};
|
|
|
|
|
2007-01-28 12:56:37 -07:00
|
|
|
int arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
|
2006-10-04 03:16:59 -06:00
|
|
|
{
|
|
|
|
struct msi_msg msg;
|
2007-01-28 12:56:37 -07:00
|
|
|
int irq, ret;
|
|
|
|
irq = create_irq();
|
|
|
|
if (irq < 0)
|
|
|
|
return irq;
|
|
|
|
|
2006-10-04 03:16:59 -06:00
|
|
|
ret = msi_compose_msg(dev, irq, &msg);
|
2007-01-28 12:56:37 -07:00
|
|
|
if (ret < 0) {
|
|
|
|
destroy_irq(irq);
|
2006-10-04 03:16:59 -06:00
|
|
|
return ret;
|
2007-01-28 12:56:37 -07:00
|
|
|
}
|
2006-10-04 03:16:59 -06:00
|
|
|
|
2007-04-18 03:39:21 -06:00
|
|
|
set_irq_msi(irq, desc);
|
2006-10-04 03:16:59 -06:00
|
|
|
write_msi_msg(irq, &msg);
|
|
|
|
|
2006-10-17 01:10:03 -06:00
|
|
|
set_irq_chip_and_handler_name(irq, &msi_chip, handle_edge_irq, "edge");
|
2006-10-04 03:16:59 -06:00
|
|
|
|
2007-04-18 03:39:21 -06:00
|
|
|
return 0;
|
2006-10-04 03:16:59 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
void arch_teardown_msi_irq(unsigned int irq)
|
|
|
|
{
|
2007-01-28 12:56:37 -07:00
|
|
|
destroy_irq(irq);
|
2006-10-04 03:16:59 -06:00
|
|
|
}
|
|
|
|
|
2007-10-21 17:41:54 -06:00
|
|
|
#ifdef CONFIG_DMAR
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
static void dmar_msi_set_affinity(unsigned int irq, cpumask_t mask)
|
|
|
|
{
|
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
|
|
|
struct msi_msg msg;
|
|
|
|
unsigned int dest;
|
|
|
|
cpumask_t tmp;
|
|
|
|
|
|
|
|
cpus_and(tmp, mask, cpu_online_map);
|
|
|
|
if (cpus_empty(tmp))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (assign_irq_vector(irq, mask))
|
|
|
|
return;
|
|
|
|
|
|
|
|
cpus_and(tmp, cfg->domain, mask);
|
|
|
|
dest = cpu_mask_to_apicid(tmp);
|
|
|
|
|
|
|
|
dmar_msi_read(irq, &msg);
|
|
|
|
|
|
|
|
msg.data &= ~MSI_DATA_VECTOR_MASK;
|
|
|
|
msg.data |= MSI_DATA_VECTOR(cfg->vector);
|
|
|
|
msg.address_lo &= ~MSI_ADDR_DEST_ID_MASK;
|
|
|
|
msg.address_lo |= MSI_ADDR_DEST_ID(dest);
|
|
|
|
|
|
|
|
dmar_msi_write(irq, &msg);
|
|
|
|
irq_desc[irq].affinity = mask;
|
|
|
|
}
|
|
|
|
#endif /* CONFIG_SMP */
|
|
|
|
|
|
|
|
struct irq_chip dmar_msi_type = {
|
|
|
|
.name = "DMAR_MSI",
|
|
|
|
.unmask = dmar_msi_unmask,
|
|
|
|
.mask = dmar_msi_mask,
|
|
|
|
.ack = ack_apic_edge,
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
.set_affinity = dmar_msi_set_affinity,
|
|
|
|
#endif
|
|
|
|
.retrigger = ioapic_retrigger_irq,
|
|
|
|
};
|
|
|
|
|
|
|
|
int arch_setup_dmar_msi(unsigned int irq)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
struct msi_msg msg;
|
|
|
|
|
|
|
|
ret = msi_compose_msg(NULL, irq, &msg);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
dmar_msi_write(irq, &msg);
|
|
|
|
set_irq_chip_and_handler_name(irq, &dmar_msi_type, handle_edge_irq,
|
|
|
|
"edge");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
#endif
|
2006-10-04 03:16:42 -06:00
|
|
|
|
2007-10-21 17:41:54 -06:00
|
|
|
#endif /* CONFIG_PCI_MSI */
|
2006-10-04 03:16:55 -06:00
|
|
|
/*
|
|
|
|
* Hypertransport interrupt support
|
|
|
|
*/
|
|
|
|
#ifdef CONFIG_HT_IRQ
|
|
|
|
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
|
|
|
|
static void target_ht_irq(unsigned int irq, unsigned int dest, u8 vector)
|
|
|
|
{
|
2006-11-08 18:44:57 -07:00
|
|
|
struct ht_irq_msg msg;
|
|
|
|
fetch_ht_irq_msg(irq, &msg);
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2006-11-08 18:44:57 -07:00
|
|
|
msg.address_lo &= ~(HT_IRQ_LOW_VECTOR_MASK | HT_IRQ_LOW_DEST_ID_MASK);
|
|
|
|
msg.address_hi &= ~(HT_IRQ_HIGH_DEST_ID_MASK);
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2006-11-08 18:44:57 -07:00
|
|
|
msg.address_lo |= HT_IRQ_LOW_VECTOR(vector) | HT_IRQ_LOW_DEST_ID(dest);
|
|
|
|
msg.address_hi |= HT_IRQ_HIGH_DEST_ID(dest);
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2006-11-08 18:44:57 -07:00
|
|
|
write_ht_irq_msg(irq, &msg);
|
2006-10-04 03:16:55 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
static void set_ht_irq_affinity(unsigned int irq, cpumask_t mask)
|
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
2006-10-04 03:16:55 -06:00
|
|
|
unsigned int dest;
|
|
|
|
cpumask_t tmp;
|
|
|
|
|
|
|
|
cpus_and(tmp, mask, cpu_online_map);
|
|
|
|
if (cpus_empty(tmp))
|
2007-02-23 04:20:59 -07:00
|
|
|
return;
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
if (assign_irq_vector(irq, mask))
|
2006-10-04 03:16:55 -06:00
|
|
|
return;
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
cpus_and(tmp, cfg->domain, mask);
|
2006-10-04 03:16:55 -06:00
|
|
|
dest = cpu_mask_to_apicid(tmp);
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
target_ht_irq(irq, dest, cfg->vector);
|
2007-02-23 04:13:55 -07:00
|
|
|
irq_desc[irq].affinity = mask;
|
2006-10-04 03:16:55 -06:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2006-10-11 02:20:43 -06:00
|
|
|
static struct irq_chip ht_irq_chip = {
|
2006-10-04 03:16:55 -06:00
|
|
|
.name = "PCI-HT",
|
|
|
|
.mask = mask_ht_irq,
|
|
|
|
.unmask = unmask_ht_irq,
|
|
|
|
.ack = ack_apic_edge,
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
.set_affinity = set_ht_irq_affinity,
|
|
|
|
#endif
|
|
|
|
.retrigger = ioapic_retrigger_irq,
|
|
|
|
};
|
|
|
|
|
|
|
|
int arch_setup_ht_irq(unsigned int irq, struct pci_dev *dev)
|
|
|
|
{
|
2007-02-23 04:35:05 -07:00
|
|
|
struct irq_cfg *cfg = irq_cfg + irq;
|
|
|
|
int err;
|
2006-10-08 07:47:55 -06:00
|
|
|
cpumask_t tmp;
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
tmp = TARGET_CPUS;
|
|
|
|
err = assign_irq_vector(irq, tmp);
|
|
|
|
if (!err) {
|
2006-11-08 18:44:57 -07:00
|
|
|
struct ht_irq_msg msg;
|
2006-10-04 03:16:55 -06:00
|
|
|
unsigned dest;
|
|
|
|
|
2007-02-23 04:35:05 -07:00
|
|
|
cpus_and(tmp, cfg->domain, tmp);
|
2006-10-04 03:16:55 -06:00
|
|
|
dest = cpu_mask_to_apicid(tmp);
|
|
|
|
|
2006-11-08 18:44:57 -07:00
|
|
|
msg.address_hi = HT_IRQ_HIGH_DEST_ID(dest);
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2006-11-08 18:44:57 -07:00
|
|
|
msg.address_lo =
|
|
|
|
HT_IRQ_LOW_BASE |
|
2006-10-04 03:16:55 -06:00
|
|
|
HT_IRQ_LOW_DEST_ID(dest) |
|
2007-02-23 04:35:05 -07:00
|
|
|
HT_IRQ_LOW_VECTOR(cfg->vector) |
|
2006-10-04 03:16:55 -06:00
|
|
|
((INT_DEST_MODE == 0) ?
|
|
|
|
HT_IRQ_LOW_DM_PHYSICAL :
|
|
|
|
HT_IRQ_LOW_DM_LOGICAL) |
|
|
|
|
HT_IRQ_LOW_RQEOI_EDGE |
|
|
|
|
((INT_DELIVERY_MODE != dest_LowestPrio) ?
|
|
|
|
HT_IRQ_LOW_MT_FIXED :
|
2006-11-08 18:44:57 -07:00
|
|
|
HT_IRQ_LOW_MT_ARBITRATED) |
|
|
|
|
HT_IRQ_LOW_IRQ_MASKED;
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2006-11-08 18:44:57 -07:00
|
|
|
write_ht_irq_msg(irq, &msg);
|
2006-10-04 03:16:55 -06:00
|
|
|
|
2006-10-17 01:10:03 -06:00
|
|
|
set_irq_chip_and_handler_name(irq, &ht_irq_chip,
|
|
|
|
handle_edge_irq, "edge");
|
2006-10-04 03:16:55 -06:00
|
|
|
}
|
2007-02-23 04:35:05 -07:00
|
|
|
return err;
|
2006-10-04 03:16:55 -06:00
|
|
|
}
|
|
|
|
#endif /* CONFIG_HT_IRQ */
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/* --------------------------------------------------------------------------
|
|
|
|
ACPI-based IOAPIC Configuration
|
|
|
|
-------------------------------------------------------------------------- */
|
|
|
|
|
2005-08-24 10:07:20 -06:00
|
|
|
#ifdef CONFIG_ACPI
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
#define IO_APIC_MAX_ID 0xFE
|
|
|
|
|
|
|
|
int __init io_apic_get_redir_entries (int ioapic)
|
|
|
|
{
|
|
|
|
union IO_APIC_reg_01 reg_01;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioapic_lock, flags);
|
|
|
|
reg_01.raw = io_apic_read(ioapic, 1);
|
|
|
|
spin_unlock_irqrestore(&ioapic_lock, flags);
|
|
|
|
|
|
|
|
return reg_01.bits.entries;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
[ACPI] ACPICA 20050930
Completed a major overhaul of the Resource Manager code -
specifically, optimizations in the area of the AML/internal
resource conversion code. The code has been optimized to
simplify and eliminate duplicated code, CPU stack use has
been decreased by optimizing function parameters and local
variables, and naming conventions across the manager have
been standardized for clarity and ease of maintenance (this
includes function, parameter, variable, and struct/typedef
names.)
All Resource Manager dispatch and information tables have
been moved to a single location for clarity and ease of
maintenance. One new file was created, named "rsinfo.c".
The ACPI return macros (return_ACPI_STATUS, etc.) have
been modified to guarantee that the argument is
not evaluated twice, making them less prone to macro
side-effects. However, since there exists the possibility
of additional stack use if a particular compiler cannot
optimize them (such as in the debug generation case),
the original macros are optionally available. Note that
some invocations of the return_VALUE macro may now cause
size mismatch warnings; the return_UINT8 and return_UINT32
macros are provided to eliminate these. (From Randy Dunlap)
Implemented a new mechanism to enable debug tracing for
individual control methods. A new external interface,
acpi_debug_trace(), is provided to enable this mechanism. The
intent is to allow the host OS to easily enable and disable
tracing for problematic control methods. This interface
can be easily exposed to a user or debugger interface if
desired. See the file psxface.c for details.
acpi_ut_callocate() will now return a valid pointer if a
length of zero is specified - a length of one is used
and a warning is issued. This matches the behavior of
acpi_ut_allocate().
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
2005-09-30 17:03:00 -06:00
|
|
|
int io_apic_set_pci_routing (int ioapic, int pin, int irq, int triggering, int polarity)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
if (!IO_APIC_IRQ(irq)) {
|
|
|
|
apic_printk(APIC_QUIET,KERN_ERR "IOAPIC[%d]: Invalid reference to IRQ 0\n",
|
|
|
|
ioapic);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2006-10-04 03:16:51 -06:00
|
|
|
/*
|
|
|
|
* IRQs < 16 are already in the irq_2_pin[] map
|
|
|
|
*/
|
|
|
|
if (irq >= 16)
|
|
|
|
add_pin_to_irq(irq, ioapic, pin);
|
|
|
|
|
2007-02-23 04:19:08 -07:00
|
|
|
setup_IO_APIC_irq(ioapic, pin, irq, triggering, polarity);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2007-11-16 23:05:28 -07:00
|
|
|
int acpi_get_override_irq(int bus_irq, int *trigger, int *polarity)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
if (skip_ioapic_setup)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
for (i = 0; i < mp_irq_entries; i++)
|
2008-05-14 09:03:17 -06:00
|
|
|
if (mp_irqs[i].mp_irqtype == mp_INT &&
|
|
|
|
mp_irqs[i].mp_srcbusirq == bus_irq)
|
2007-11-16 23:05:28 -07:00
|
|
|
break;
|
|
|
|
if (i >= mp_irq_entries)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
*trigger = irq_trigger(i);
|
|
|
|
*polarity = irq_polarity(i);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_ACPI */
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* This function currently is only a helper for the i386 smp boot process where
|
|
|
|
* we need to reprogram the ioredtbls to cater for the cpus which have come online
|
|
|
|
* so mask in all cases should simply be TARGET_CPUS
|
|
|
|
*/
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
#ifdef CONFIG_SMP
|
2005-04-16 16:20:36 -06:00
|
|
|
void __init setup_ioapic_dest(void)
|
|
|
|
{
|
|
|
|
int pin, ioapic, irq, irq_entry;
|
|
|
|
|
|
|
|
if (skip_ioapic_setup == 1)
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (ioapic = 0; ioapic < nr_ioapics; ioapic++) {
|
|
|
|
for (pin = 0; pin < nr_ioapic_registers[ioapic]; pin++) {
|
|
|
|
irq_entry = find_irq_entry(ioapic, pin, mp_INT);
|
|
|
|
if (irq_entry == -1)
|
|
|
|
continue;
|
|
|
|
irq = pin_2_irq(irq_entry, ioapic, pin);
|
2006-12-06 18:14:19 -07:00
|
|
|
|
|
|
|
/* setup_IO_APIC_irqs could fail to get vector for some device
|
|
|
|
* when you have too many devices, because at that time only boot
|
|
|
|
* cpu is online.
|
|
|
|
*/
|
2007-02-23 04:32:47 -07:00
|
|
|
if (!irq_cfg[irq].vector)
|
2007-02-23 04:19:08 -07:00
|
|
|
setup_IO_APIC_irq(ioapic, pin, irq,
|
|
|
|
irq_trigger(irq_entry),
|
|
|
|
irq_polarity(irq_entry));
|
2006-12-06 18:14:19 -07:00
|
|
|
else
|
|
|
|
set_ioapic_affinity_irq(irq, TARGET_CPUS);
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
[PATCH] x86/x86_64: deferred handling of writes to /proc/irqxx/smp_affinity
When handling writes to /proc/irq, current code is re-programming rte
entries directly. This is not recommended and could potentially cause
chipset's to lockup, or cause missing interrupts.
CONFIG_IRQ_BALANCE does this correctly, where it re-programs only when the
interrupt is pending. The same needs to be done for /proc/irq handling as well.
Otherwise user space irq balancers are really not doing the right thing.
- Changed pending_irq_balance_cpumask to pending_irq_migrate_cpumask for
lack of a generic name.
- added move_irq out of IRQ_BALANCE, and added this same to X86_64
- Added new proc handler for write, so we can do deferred write at irq
handling time.
- Display of /proc/irq/XX/smp_affinity used to display CPU_MASKALL, instead
it now shows only active cpu masks, or exactly what was set.
- Provided a common move_irq implementation, instead of duplicating
when using generic irq framework.
Tested on i386/x86_64 and ia64 with CONFIG_PCI_MSI turned on and off.
Tested UP builds as well.
MSI testing: tbd: I have cards, need to look for a x-over cable, although I
did test an earlier version of this patch. Will test in a couple days.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Acked-by: Zwane Mwaikambo <zwane@holomorphy.com>
Grudgingly-acked-by: Andi Kleen <ak@muc.de>
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-06 16:16:15 -06:00
|
|
|
#endif
|
2007-11-16 23:05:28 -07:00
|
|
|
|
2008-01-30 05:30:19 -07:00
|
|
|
#define IOAPIC_RESOURCE_NAME_SIZE 11
|
|
|
|
|
|
|
|
static struct resource *ioapic_resources;
|
|
|
|
|
|
|
|
static struct resource * __init ioapic_setup_resources(void)
|
|
|
|
{
|
|
|
|
unsigned long n;
|
|
|
|
struct resource *res;
|
|
|
|
char *mem;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
if (nr_ioapics <= 0)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
n = IOAPIC_RESOURCE_NAME_SIZE + sizeof(struct resource);
|
|
|
|
n *= nr_ioapics;
|
|
|
|
|
|
|
|
mem = alloc_bootmem(n);
|
|
|
|
res = (void *)mem;
|
|
|
|
|
|
|
|
if (mem != NULL) {
|
|
|
|
mem += sizeof(struct resource) * nr_ioapics;
|
|
|
|
|
|
|
|
for (i = 0; i < nr_ioapics; i++) {
|
|
|
|
res[i].name = mem;
|
|
|
|
res[i].flags = IORESOURCE_MEM | IORESOURCE_BUSY;
|
|
|
|
sprintf(mem, "IOAPIC %u", i);
|
|
|
|
mem += IOAPIC_RESOURCE_NAME_SIZE;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ioapic_resources = res;
|
|
|
|
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
void __init ioapic_init_mappings(void)
|
|
|
|
{
|
|
|
|
unsigned long ioapic_phys, idx = FIX_IO_APIC_BASE_0;
|
|
|
|
struct resource *ioapic_res;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
ioapic_res = ioapic_setup_resources();
|
|
|
|
for (i = 0; i < nr_ioapics; i++) {
|
|
|
|
if (smp_found_config) {
|
2008-05-14 09:03:10 -06:00
|
|
|
ioapic_phys = mp_ioapics[i].mp_apicaddr;
|
2008-01-30 05:30:19 -07:00
|
|
|
} else {
|
|
|
|
ioapic_phys = (unsigned long)
|
|
|
|
alloc_bootmem_pages(PAGE_SIZE);
|
|
|
|
ioapic_phys = __pa(ioapic_phys);
|
|
|
|
}
|
|
|
|
set_fixmap_nocache(idx, ioapic_phys);
|
|
|
|
apic_printk(APIC_VERBOSE,
|
|
|
|
"mapped IOAPIC to %016lx (%016lx)\n",
|
|
|
|
__fix_to_virt(idx), ioapic_phys);
|
|
|
|
idx++;
|
|
|
|
|
|
|
|
if (ioapic_res != NULL) {
|
|
|
|
ioapic_res->start = ioapic_phys;
|
|
|
|
ioapic_res->end = ioapic_phys + (4 * 1024) - 1;
|
|
|
|
ioapic_res++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __init ioapic_insert_resources(void)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
struct resource *r = ioapic_resources;
|
|
|
|
|
|
|
|
if (!r) {
|
|
|
|
printk(KERN_ERR
|
|
|
|
"IO APIC resources could be not be allocated.\n");
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < nr_ioapics; i++) {
|
|
|
|
insert_resource(&iomem_resource, r);
|
|
|
|
r++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Insert the IO APIC resources after PCI initialization has occured to handle
|
|
|
|
* IO APICS that are mapped in on a BAR in PCI space. */
|
|
|
|
late_initcall(ioapic_insert_resources);
|
|
|
|
|