License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 08:07:57 -06:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2011-07-23 00:43:04 -06:00
|
|
|
#ifndef ISCSI_PARAMETERS_H
|
|
|
|
|
#define ISCSI_PARAMETERS_H
|
|
|
|
|
|
2016-11-14 16:47:14 -07:00
|
|
|
#include <linux/types.h>
|
2013-05-23 11:32:17 -06:00
|
|
|
#include <scsi/iscsi_proto.h>
|
|
|
|
|
|
2011-07-23 00:43:04 -06:00
|
|
|
struct iscsi_extra_response {
|
2013-05-23 11:32:17 -06:00
|
|
|
char key[KEY_MAXLEN];
|
2011-07-23 00:43:04 -06:00
|
|
|
char value[32];
|
|
|
|
|
struct list_head er_list;
|
|
|
|
|
} ____cacheline_aligned;
|
|
|
|
|
|
|
|
|
|
struct iscsi_param {
|
|
|
|
|
char *name;
|
|
|
|
|
char *value;
|
|
|
|
|
u8 set_param;
|
|
|
|
|
u8 phase;
|
|
|
|
|
u8 scope;
|
|
|
|
|
u8 sender;
|
|
|
|
|
u8 type;
|
|
|
|
|
u8 use;
|
|
|
|
|
u16 type_range;
|
|
|
|
|
u32 state;
|
|
|
|
|
struct list_head p_list;
|
|
|
|
|
} ____cacheline_aligned;
|
|
|
|
|
|
2016-11-14 16:47:14 -07:00
|
|
|
struct iscsi_conn;
|
|
|
|
|
struct iscsi_conn_ops;
|
|
|
|
|
struct iscsi_param_list;
|
|
|
|
|
struct iscsi_sess_ops;
|
|
|
|
|
|
2011-07-23 00:43:04 -06:00
|
|
|
extern int iscsi_login_rx_data(struct iscsi_conn *, char *, int);
|
|
|
|
|
extern int iscsi_login_tx_data(struct iscsi_conn *, char *, char *, int);
|
|
|
|
|
extern void iscsi_dump_conn_ops(struct iscsi_conn_ops *);
|
|
|
|
|
extern void iscsi_dump_sess_ops(struct iscsi_sess_ops *);
|
|
|
|
|
extern void iscsi_print_params(struct iscsi_param_list *);
|
|
|
|
|
extern int iscsi_create_default_params(struct iscsi_param_list **);
|
2013-03-06 22:54:38 -07:00
|
|
|
extern int iscsi_set_keys_to_negotiate(struct iscsi_param_list *, bool);
|
2011-07-23 00:43:04 -06:00
|
|
|
extern int iscsi_set_keys_irrelevant_for_discovery(struct iscsi_param_list *);
|
|
|
|
|
extern int iscsi_copy_param_list(struct iscsi_param_list **,
|
|
|
|
|
struct iscsi_param_list *, int);
|
|
|
|
|
extern int iscsi_change_param_value(char *, struct iscsi_param_list *, int);
|
|
|
|
|
extern void iscsi_release_param_list(struct iscsi_param_list *);
|
|
|
|
|
extern struct iscsi_param *iscsi_find_param_from_key(char *, struct iscsi_param_list *);
|
|
|
|
|
extern int iscsi_extract_key_value(char *, char **, char **);
|
|
|
|
|
extern int iscsi_update_param_value(struct iscsi_param *, char *);
|
2012-09-29 22:49:59 -06:00
|
|
|
extern int iscsi_decode_text_input(u8, u8, char *, u32, struct iscsi_conn *);
|
2011-07-23 00:43:04 -06:00
|
|
|
extern int iscsi_encode_text_output(u8, u8, char *, u32 *,
|
2017-07-07 15:45:49 -06:00
|
|
|
struct iscsi_param_list *, bool);
|
2011-07-23 00:43:04 -06:00
|
|
|
extern int iscsi_check_negotiated_keys(struct iscsi_param_list *);
|
|
|
|
|
extern void iscsi_set_connection_parameters(struct iscsi_conn_ops *,
|
|
|
|
|
struct iscsi_param_list *);
|
|
|
|
|
extern void iscsi_set_session_parameters(struct iscsi_sess_ops *,
|
|
|
|
|
struct iscsi_param_list *, int);
|
|
|
|
|
|
|
|
|
|
#define YES "Yes"
|
|
|
|
|
#define NO "No"
|
|
|
|
|
#define ALL "All"
|
|
|
|
|
#define IRRELEVANT "Irrelevant"
|
|
|
|
|
#define NONE "None"
|
|
|
|
|
#define NOTUNDERSTOOD "NotUnderstood"
|
|
|
|
|
#define REJECT "Reject"
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* The Parameter Names.
|
|
|
|
|
*/
|
|
|
|
|
#define AUTHMETHOD "AuthMethod"
|
|
|
|
|
#define HEADERDIGEST "HeaderDigest"
|
|
|
|
|
#define DATADIGEST "DataDigest"
|
|
|
|
|
#define MAXCONNECTIONS "MaxConnections"
|
|
|
|
|
#define SENDTARGETS "SendTargets"
|
|
|
|
|
#define TARGETNAME "TargetName"
|
|
|
|
|
#define INITIATORNAME "InitiatorName"
|
|
|
|
|
#define TARGETALIAS "TargetAlias"
|
|
|
|
|
#define INITIATORALIAS "InitiatorAlias"
|
|
|
|
|
#define TARGETADDRESS "TargetAddress"
|
|
|
|
|
#define TARGETPORTALGROUPTAG "TargetPortalGroupTag"
|
|
|
|
|
#define INITIALR2T "InitialR2T"
|
|
|
|
|
#define IMMEDIATEDATA "ImmediateData"
|
|
|
|
|
#define MAXRECVDATASEGMENTLENGTH "MaxRecvDataSegmentLength"
|
2012-09-29 22:47:16 -06:00
|
|
|
#define MAXXMITDATASEGMENTLENGTH "MaxXmitDataSegmentLength"
|
2011-07-23 00:43:04 -06:00
|
|
|
#define MAXBURSTLENGTH "MaxBurstLength"
|
|
|
|
|
#define FIRSTBURSTLENGTH "FirstBurstLength"
|
|
|
|
|
#define DEFAULTTIME2WAIT "DefaultTime2Wait"
|
|
|
|
|
#define DEFAULTTIME2RETAIN "DefaultTime2Retain"
|
|
|
|
|
#define MAXOUTSTANDINGR2T "MaxOutstandingR2T"
|
|
|
|
|
#define DATAPDUINORDER "DataPDUInOrder"
|
|
|
|
|
#define DATASEQUENCEINORDER "DataSequenceInOrder"
|
|
|
|
|
#define ERRORRECOVERYLEVEL "ErrorRecoveryLevel"
|
|
|
|
|
#define SESSIONTYPE "SessionType"
|
|
|
|
|
#define IFMARKER "IFMarker"
|
|
|
|
|
#define OFMARKER "OFMarker"
|
|
|
|
|
#define IFMARKINT "IFMarkInt"
|
|
|
|
|
#define OFMARKINT "OFMarkInt"
|
|
|
|
|
|
2013-03-06 22:54:38 -07:00
|
|
|
/*
|
|
|
|
|
* Parameter names of iSCSI Extentions for RDMA (iSER). See RFC-5046
|
|
|
|
|
*/
|
2013-05-11 17:24:21 -06:00
|
|
|
#define RDMAEXTENSIONS "RDMAExtensions"
|
2013-03-06 22:54:38 -07:00
|
|
|
#define INITIATORRECVDATASEGMENTLENGTH "InitiatorRecvDataSegmentLength"
|
|
|
|
|
#define TARGETRECVDATASEGMENTLENGTH "TargetRecvDataSegmentLength"
|
|
|
|
|
|
2011-07-23 00:43:04 -06:00
|
|
|
/*
|
|
|
|
|
* For AuthMethod.
|
|
|
|
|
*/
|
|
|
|
|
#define KRB5 "KRB5"
|
|
|
|
|
#define SPKM1 "SPKM1"
|
|
|
|
|
#define SPKM2 "SPKM2"
|
|
|
|
|
#define SRP "SRP"
|
|
|
|
|
#define CHAP "CHAP"
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Initial values for Parameter Negotiation.
|
|
|
|
|
*/
|
|
|
|
|
#define INITIAL_AUTHMETHOD CHAP
|
|
|
|
|
#define INITIAL_HEADERDIGEST "CRC32C,None"
|
|
|
|
|
#define INITIAL_DATADIGEST "CRC32C,None"
|
|
|
|
|
#define INITIAL_MAXCONNECTIONS "1"
|
|
|
|
|
#define INITIAL_SENDTARGETS ALL
|
|
|
|
|
#define INITIAL_TARGETNAME "LIO.Target"
|
|
|
|
|
#define INITIAL_INITIATORNAME "LIO.Initiator"
|
|
|
|
|
#define INITIAL_TARGETALIAS "LIO Target"
|
|
|
|
|
#define INITIAL_INITIATORALIAS "LIO Initiator"
|
|
|
|
|
#define INITIAL_TARGETADDRESS "0.0.0.0:0000,0"
|
|
|
|
|
#define INITIAL_TARGETPORTALGROUPTAG "1"
|
|
|
|
|
#define INITIAL_INITIALR2T YES
|
|
|
|
|
#define INITIAL_IMMEDIATEDATA YES
|
|
|
|
|
#define INITIAL_MAXRECVDATASEGMENTLENGTH "8192"
|
2012-09-29 22:47:16 -06:00
|
|
|
/*
|
|
|
|
|
* Match outgoing MXDSL default to incoming Open-iSCSI default
|
|
|
|
|
*/
|
|
|
|
|
#define INITIAL_MAXXMITDATASEGMENTLENGTH "262144"
|
2011-07-23 00:43:04 -06:00
|
|
|
#define INITIAL_MAXBURSTLENGTH "262144"
|
|
|
|
|
#define INITIAL_FIRSTBURSTLENGTH "65536"
|
|
|
|
|
#define INITIAL_DEFAULTTIME2WAIT "2"
|
|
|
|
|
#define INITIAL_DEFAULTTIME2RETAIN "20"
|
|
|
|
|
#define INITIAL_MAXOUTSTANDINGR2T "1"
|
|
|
|
|
#define INITIAL_DATAPDUINORDER YES
|
|
|
|
|
#define INITIAL_DATASEQUENCEINORDER YES
|
|
|
|
|
#define INITIAL_ERRORRECOVERYLEVEL "0"
|
|
|
|
|
#define INITIAL_SESSIONTYPE NORMAL
|
|
|
|
|
#define INITIAL_IFMARKER NO
|
|
|
|
|
#define INITIAL_OFMARKER NO
|
iscsi-target: remove support for obsolete markers
Support for markers is currently broken because of a bug in
iscsi_enforce_integrity_rules(): the "IFMarkInt_Reject" and
"OFMarkInt_Reject" variables are always equal to 1 in
iscsi_enforce_integrity_rules().
Moreover, fixed interval markers keys (IFMarker, OFMarker, IFMarkInt
and OFMarkInt) are obsolete according to iSCSI RFC 7143:
>From http://tools.ietf.org/html/rfc7143#section-13.25:
13.25. Obsoleted Keys
This document obsoletes the following keys defined in [RFC3720]:
IFMarker, OFMarker, OFMarkInt, and IFMarkInt. However, iSCSI
implementations compliant to this document may still receive these
obsoleted keys -- i.e., in a responder role -- in a text negotiation.
When an IFMarker or OFMarker key is received, a compliant iSCSI
implementation SHOULD respond with the constant "Reject" value. The
implementation MAY alternatively respond with a "No" value.
However, the implementation MUST NOT respond with a "NotUnderstood"
value for either of these keys.
When an IFMarkInt or OFMarkInt key is received, a compliant iSCSI
implementation MUST respond with the constant "Reject" value. The
implementation MUST NOT respond with a "NotUnderstood" value for
either of these keys.
This patch disables markers by turning the corresponding parameters to
read-only. The default value of IFMarker and OFMarker remains "No" but
the user cannot change it to "Yes" anymore. The new value of IFMarkInt
and OFMarkInt is "Reject".
(Drop left-over iscsi_get_value_from_number_range + make configfs
parameters attrs R/W nops - nab)
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2015-04-19 14:18:33 -06:00
|
|
|
#define INITIAL_IFMARKINT REJECT
|
|
|
|
|
#define INITIAL_OFMARKINT REJECT
|
2011-07-23 00:43:04 -06:00
|
|
|
|
2013-03-06 22:54:38 -07:00
|
|
|
/*
|
|
|
|
|
* Initial values for iSER parameters following RFC-5046 Section 6
|
|
|
|
|
*/
|
2013-05-11 17:24:21 -06:00
|
|
|
#define INITIAL_RDMAEXTENSIONS NO
|
2013-03-06 22:54:38 -07:00
|
|
|
#define INITIAL_INITIATORRECVDATASEGMENTLENGTH "262144"
|
|
|
|
|
#define INITIAL_TARGETRECVDATASEGMENTLENGTH "8192"
|
|
|
|
|
|
2011-07-23 00:43:04 -06:00
|
|
|
/*
|
|
|
|
|
* For [Header,Data]Digests.
|
|
|
|
|
*/
|
|
|
|
|
#define CRC32C "CRC32C"
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* For SessionType.
|
|
|
|
|
*/
|
|
|
|
|
#define DISCOVERY "Discovery"
|
|
|
|
|
#define NORMAL "Normal"
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* struct iscsi_param->use
|
|
|
|
|
*/
|
|
|
|
|
#define USE_LEADING_ONLY 0x01
|
|
|
|
|
#define USE_INITIAL_ONLY 0x02
|
|
|
|
|
#define USE_ALL 0x04
|
|
|
|
|
|
|
|
|
|
#define IS_USE_LEADING_ONLY(p) ((p)->use & USE_LEADING_ONLY)
|
|
|
|
|
#define IS_USE_INITIAL_ONLY(p) ((p)->use & USE_INITIAL_ONLY)
|
|
|
|
|
#define IS_USE_ALL(p) ((p)->use & USE_ALL)
|
|
|
|
|
|
|
|
|
|
#define SET_USE_INITIAL_ONLY(p) ((p)->use |= USE_INITIAL_ONLY)
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* struct iscsi_param->sender
|
|
|
|
|
*/
|
|
|
|
|
#define SENDER_INITIATOR 0x01
|
|
|
|
|
#define SENDER_TARGET 0x02
|
|
|
|
|
#define SENDER_BOTH 0x03
|
|
|
|
|
/* Used in iscsi_check_key() */
|
|
|
|
|
#define SENDER_RECEIVER 0x04
|
|
|
|
|
|
|
|
|
|
#define IS_SENDER_INITIATOR(p) ((p)->sender & SENDER_INITIATOR)
|
|
|
|
|
#define IS_SENDER_TARGET(p) ((p)->sender & SENDER_TARGET)
|
|
|
|
|
#define IS_SENDER_BOTH(p) ((p)->sender & SENDER_BOTH)
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* struct iscsi_param->scope
|
|
|
|
|
*/
|
|
|
|
|
#define SCOPE_CONNECTION_ONLY 0x01
|
|
|
|
|
#define SCOPE_SESSION_WIDE 0x02
|
|
|
|
|
|
|
|
|
|
#define IS_SCOPE_CONNECTION_ONLY(p) ((p)->scope & SCOPE_CONNECTION_ONLY)
|
|
|
|
|
#define IS_SCOPE_SESSION_WIDE(p) ((p)->scope & SCOPE_SESSION_WIDE)
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* struct iscsi_param->phase
|
|
|
|
|
*/
|
|
|
|
|
#define PHASE_SECURITY 0x01
|
|
|
|
|
#define PHASE_OPERATIONAL 0x02
|
|
|
|
|
#define PHASE_DECLARATIVE 0x04
|
|
|
|
|
#define PHASE_FFP0 0x08
|
|
|
|
|
|
|
|
|
|
#define IS_PHASE_SECURITY(p) ((p)->phase & PHASE_SECURITY)
|
|
|
|
|
#define IS_PHASE_OPERATIONAL(p) ((p)->phase & PHASE_OPERATIONAL)
|
|
|
|
|
#define IS_PHASE_DECLARATIVE(p) ((p)->phase & PHASE_DECLARATIVE)
|
|
|
|
|
#define IS_PHASE_FFP0(p) ((p)->phase & PHASE_FFP0)
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* struct iscsi_param->type
|
|
|
|
|
*/
|
|
|
|
|
#define TYPE_BOOL_AND 0x01
|
|
|
|
|
#define TYPE_BOOL_OR 0x02
|
|
|
|
|
#define TYPE_NUMBER 0x04
|
|
|
|
|
#define TYPE_NUMBER_RANGE 0x08
|
|
|
|
|
#define TYPE_STRING 0x10
|
|
|
|
|
#define TYPE_VALUE_LIST 0x20
|
|
|
|
|
|
|
|
|
|
#define IS_TYPE_BOOL_AND(p) ((p)->type & TYPE_BOOL_AND)
|
|
|
|
|
#define IS_TYPE_BOOL_OR(p) ((p)->type & TYPE_BOOL_OR)
|
|
|
|
|
#define IS_TYPE_NUMBER(p) ((p)->type & TYPE_NUMBER)
|
|
|
|
|
#define IS_TYPE_NUMBER_RANGE(p) ((p)->type & TYPE_NUMBER_RANGE)
|
|
|
|
|
#define IS_TYPE_STRING(p) ((p)->type & TYPE_STRING)
|
|
|
|
|
#define IS_TYPE_VALUE_LIST(p) ((p)->type & TYPE_VALUE_LIST)
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* struct iscsi_param->type_range
|
|
|
|
|
*/
|
|
|
|
|
#define TYPERANGE_BOOL_AND 0x0001
|
|
|
|
|
#define TYPERANGE_BOOL_OR 0x0002
|
|
|
|
|
#define TYPERANGE_0_TO_2 0x0004
|
|
|
|
|
#define TYPERANGE_0_TO_3600 0x0008
|
|
|
|
|
#define TYPERANGE_0_TO_32767 0x0010
|
|
|
|
|
#define TYPERANGE_0_TO_65535 0x0020
|
|
|
|
|
#define TYPERANGE_1_TO_65535 0x0040
|
|
|
|
|
#define TYPERANGE_2_TO_3600 0x0080
|
|
|
|
|
#define TYPERANGE_512_TO_16777215 0x0100
|
|
|
|
|
#define TYPERANGE_AUTH 0x0200
|
|
|
|
|
#define TYPERANGE_DIGEST 0x0400
|
|
|
|
|
#define TYPERANGE_ISCSINAME 0x0800
|
iscsi-target: remove support for obsolete markers
Support for markers is currently broken because of a bug in
iscsi_enforce_integrity_rules(): the "IFMarkInt_Reject" and
"OFMarkInt_Reject" variables are always equal to 1 in
iscsi_enforce_integrity_rules().
Moreover, fixed interval markers keys (IFMarker, OFMarker, IFMarkInt
and OFMarkInt) are obsolete according to iSCSI RFC 7143:
>From http://tools.ietf.org/html/rfc7143#section-13.25:
13.25. Obsoleted Keys
This document obsoletes the following keys defined in [RFC3720]:
IFMarker, OFMarker, OFMarkInt, and IFMarkInt. However, iSCSI
implementations compliant to this document may still receive these
obsoleted keys -- i.e., in a responder role -- in a text negotiation.
When an IFMarker or OFMarker key is received, a compliant iSCSI
implementation SHOULD respond with the constant "Reject" value. The
implementation MAY alternatively respond with a "No" value.
However, the implementation MUST NOT respond with a "NotUnderstood"
value for either of these keys.
When an IFMarkInt or OFMarkInt key is received, a compliant iSCSI
implementation MUST respond with the constant "Reject" value. The
implementation MUST NOT respond with a "NotUnderstood" value for
either of these keys.
This patch disables markers by turning the corresponding parameters to
read-only. The default value of IFMarker and OFMarker remains "No" but
the user cannot change it to "Yes" anymore. The new value of IFMarkInt
and OFMarkInt is "Reject".
(Drop left-over iscsi_get_value_from_number_range + make configfs
parameters attrs R/W nops - nab)
Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2015-04-19 14:18:33 -06:00
|
|
|
#define TYPERANGE_SESSIONTYPE 0x1000
|
|
|
|
|
#define TYPERANGE_TARGETADDRESS 0x2000
|
|
|
|
|
#define TYPERANGE_UTF8 0x4000
|
2011-07-23 00:43:04 -06:00
|
|
|
|
|
|
|
|
#define IS_TYPERANGE_0_TO_2(p) ((p)->type_range & TYPERANGE_0_TO_2)
|
|
|
|
|
#define IS_TYPERANGE_0_TO_3600(p) ((p)->type_range & TYPERANGE_0_TO_3600)
|
|
|
|
|
#define IS_TYPERANGE_0_TO_32767(p) ((p)->type_range & TYPERANGE_0_TO_32767)
|
|
|
|
|
#define IS_TYPERANGE_0_TO_65535(p) ((p)->type_range & TYPERANGE_0_TO_65535)
|
|
|
|
|
#define IS_TYPERANGE_1_TO_65535(p) ((p)->type_range & TYPERANGE_1_TO_65535)
|
|
|
|
|
#define IS_TYPERANGE_2_TO_3600(p) ((p)->type_range & TYPERANGE_2_TO_3600)
|
|
|
|
|
#define IS_TYPERANGE_512_TO_16777215(p) ((p)->type_range & \
|
|
|
|
|
TYPERANGE_512_TO_16777215)
|
|
|
|
|
#define IS_TYPERANGE_AUTH_PARAM(p) ((p)->type_range & TYPERANGE_AUTH)
|
|
|
|
|
#define IS_TYPERANGE_DIGEST_PARAM(p) ((p)->type_range & TYPERANGE_DIGEST)
|
|
|
|
|
#define IS_TYPERANGE_SESSIONTYPE(p) ((p)->type_range & \
|
|
|
|
|
TYPERANGE_SESSIONTYPE)
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* struct iscsi_param->state
|
|
|
|
|
*/
|
|
|
|
|
#define PSTATE_ACCEPTOR 0x01
|
|
|
|
|
#define PSTATE_NEGOTIATE 0x02
|
|
|
|
|
#define PSTATE_PROPOSER 0x04
|
|
|
|
|
#define PSTATE_IRRELEVANT 0x08
|
|
|
|
|
#define PSTATE_REJECT 0x10
|
|
|
|
|
#define PSTATE_REPLY_OPTIONAL 0x20
|
|
|
|
|
#define PSTATE_RESPONSE_GOT 0x40
|
|
|
|
|
#define PSTATE_RESPONSE_SENT 0x80
|
|
|
|
|
|
|
|
|
|
#define IS_PSTATE_ACCEPTOR(p) ((p)->state & PSTATE_ACCEPTOR)
|
|
|
|
|
#define IS_PSTATE_NEGOTIATE(p) ((p)->state & PSTATE_NEGOTIATE)
|
|
|
|
|
#define IS_PSTATE_PROPOSER(p) ((p)->state & PSTATE_PROPOSER)
|
|
|
|
|
#define IS_PSTATE_IRRELEVANT(p) ((p)->state & PSTATE_IRRELEVANT)
|
|
|
|
|
#define IS_PSTATE_REJECT(p) ((p)->state & PSTATE_REJECT)
|
|
|
|
|
#define IS_PSTATE_REPLY_OPTIONAL(p) ((p)->state & PSTATE_REPLY_OPTIONAL)
|
|
|
|
|
#define IS_PSTATE_RESPONSE_GOT(p) ((p)->state & PSTATE_RESPONSE_GOT)
|
|
|
|
|
#define IS_PSTATE_RESPONSE_SENT(p) ((p)->state & PSTATE_RESPONSE_SENT)
|
|
|
|
|
|
|
|
|
|
#define SET_PSTATE_ACCEPTOR(p) ((p)->state |= PSTATE_ACCEPTOR)
|
|
|
|
|
#define SET_PSTATE_NEGOTIATE(p) ((p)->state |= PSTATE_NEGOTIATE)
|
|
|
|
|
#define SET_PSTATE_PROPOSER(p) ((p)->state |= PSTATE_PROPOSER)
|
|
|
|
|
#define SET_PSTATE_IRRELEVANT(p) ((p)->state |= PSTATE_IRRELEVANT)
|
|
|
|
|
#define SET_PSTATE_REJECT(p) ((p)->state |= PSTATE_REJECT)
|
|
|
|
|
#define SET_PSTATE_REPLY_OPTIONAL(p) ((p)->state |= PSTATE_REPLY_OPTIONAL)
|
|
|
|
|
#define SET_PSTATE_RESPONSE_GOT(p) ((p)->state |= PSTATE_RESPONSE_GOT)
|
|
|
|
|
#define SET_PSTATE_RESPONSE_SENT(p) ((p)->state |= PSTATE_RESPONSE_SENT)
|
|
|
|
|
|
|
|
|
|
#endif /* ISCSI_PARAMETERS_H */
|