2009-04-07 21:40:12 -06:00
|
|
|
#!/usr/bin/perl -w
|
|
|
|
# (c) 2007, Joe Perches <joe@perches.com>
|
|
|
|
# created from checkpatch.pl
|
|
|
|
#
|
|
|
|
# Print selected MAINTAINERS information for
|
|
|
|
# the files modified in a patch or for a file
|
|
|
|
#
|
2009-11-11 15:26:13 -07:00
|
|
|
# usage: perl scripts/get_maintainer.pl [OPTIONS] <patch>
|
|
|
|
# perl scripts/get_maintainer.pl [OPTIONS] -f <file>
|
2009-04-07 21:40:12 -06:00
|
|
|
#
|
|
|
|
# Licensed under the terms of the GNU GPL License version 2
|
|
|
|
|
|
|
|
use strict;
|
|
|
|
|
|
|
|
my $P = $0;
|
2011-01-12 17:59:49 -07:00
|
|
|
my $V = '0.26';
|
2009-04-07 21:40:12 -06:00
|
|
|
|
|
|
|
use Getopt::Long qw(:config no_auto_abbrev);
|
2016-01-20 15:58:24 -07:00
|
|
|
use Cwd;
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2016-01-20 15:58:24 -07:00
|
|
|
my $cur_path = fastgetcwd() . '/';
|
2009-04-07 21:40:12 -06:00
|
|
|
my $lk_path = "./";
|
|
|
|
my $email = 1;
|
|
|
|
my $email_usename = 1;
|
|
|
|
my $email_maintainer = 1;
|
2014-06-02 13:05:17 -06:00
|
|
|
my $email_reviewer = 1;
|
2009-04-07 21:40:12 -06:00
|
|
|
my $email_list = 1;
|
|
|
|
my $email_subscriber_list = 0;
|
|
|
|
my $email_git_penguin_chiefs = 0;
|
2010-10-26 15:22:53 -06:00
|
|
|
my $email_git = 0;
|
2010-05-24 15:33:20 -06:00
|
|
|
my $email_git_all_signature_types = 0;
|
2009-12-14 19:00:50 -07:00
|
|
|
my $email_git_blame = 0;
|
2010-10-26 15:22:55 -06:00
|
|
|
my $email_git_blame_signatures = 1;
|
2010-10-26 15:22:53 -06:00
|
|
|
my $email_git_fallback = 1;
|
2009-04-07 21:40:12 -06:00
|
|
|
my $email_git_min_signatures = 1;
|
|
|
|
my $email_git_max_maintainers = 5;
|
2009-07-29 16:04:28 -06:00
|
|
|
my $email_git_min_percent = 5;
|
2009-04-07 21:40:12 -06:00
|
|
|
my $email_git_since = "1-year-ago";
|
2009-12-14 19:00:50 -07:00
|
|
|
my $email_hg_since = "-365";
|
2010-10-26 15:22:54 -06:00
|
|
|
my $interactive = 0;
|
2009-09-21 18:04:22 -06:00
|
|
|
my $email_remove_duplicates = 1;
|
2010-10-26 15:22:58 -06:00
|
|
|
my $email_use_mailmap = 1;
|
2009-04-07 21:40:12 -06:00
|
|
|
my $output_multiline = 1;
|
|
|
|
my $output_separator = ", ";
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
my $output_roles = 0;
|
2011-01-12 17:59:49 -07:00
|
|
|
my $output_rolestats = 1;
|
2015-06-25 16:01:52 -06:00
|
|
|
my $output_section_maxlen = 50;
|
2009-04-07 21:40:12 -06:00
|
|
|
my $scm = 0;
|
|
|
|
my $web = 0;
|
|
|
|
my $subsystem = 0;
|
|
|
|
my $status = 0;
|
2009-10-26 17:49:47 -06:00
|
|
|
my $keywords = 1;
|
2010-03-05 14:43:03 -07:00
|
|
|
my $sections = 0;
|
2010-03-05 14:43:00 -07:00
|
|
|
my $file_emails = 0;
|
2009-04-10 13:28:57 -06:00
|
|
|
my $from_filename = 0;
|
2009-09-21 18:04:17 -06:00
|
|
|
my $pattern_depth = 0;
|
2009-04-07 21:40:12 -06:00
|
|
|
my $version = 0;
|
|
|
|
my $help = 0;
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
my $vcs_used = 0;
|
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
my $exit = 0;
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
my %commit_author_hash;
|
|
|
|
my %commit_signer_hash;
|
2010-10-26 15:22:54 -06:00
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
my @penguin_chief = ();
|
2010-05-24 15:33:17 -06:00
|
|
|
push(@penguin_chief, "Linus Torvalds:torvalds\@linux-foundation.org");
|
2009-04-07 21:40:12 -06:00
|
|
|
#Andrew wants in on most everything - 2009/01/14
|
2010-05-24 15:33:17 -06:00
|
|
|
#push(@penguin_chief, "Andrew Morton:akpm\@linux-foundation.org");
|
2009-04-07 21:40:12 -06:00
|
|
|
|
|
|
|
my @penguin_chief_names = ();
|
|
|
|
foreach my $chief (@penguin_chief) {
|
|
|
|
if ($chief =~ m/^(.*):(.*)/) {
|
|
|
|
my $chief_name = $1;
|
|
|
|
my $chief_addr = $2;
|
|
|
|
push(@penguin_chief_names, $chief_name);
|
|
|
|
}
|
|
|
|
}
|
2010-05-24 15:33:17 -06:00
|
|
|
my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";
|
|
|
|
|
|
|
|
# Signature types of people who are either
|
|
|
|
# a) responsible for the code in question, or
|
|
|
|
# b) familiar enough with it to give relevant feedback
|
|
|
|
my @signature_tags = ();
|
|
|
|
push(@signature_tags, "Signed-off-by:");
|
|
|
|
push(@signature_tags, "Reviewed-by:");
|
|
|
|
push(@signature_tags, "Acked-by:");
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2012-06-20 13:53:02 -06:00
|
|
|
my $signature_pattern = "\(" . join("|", @signature_tags) . "\)";
|
|
|
|
|
2009-06-16 16:34:02 -06:00
|
|
|
# rfc822 email address - preloaded methods go here.
|
2009-06-16 16:34:01 -06:00
|
|
|
my $rfc822_lwsp = "(?:(?:\\r\\n)?[ \\t])";
|
2009-06-16 16:34:04 -06:00
|
|
|
my $rfc822_char = '[\\000-\\377]';
|
2009-06-16 16:34:01 -06:00
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
# VCS command support: class-like functions and strings
|
|
|
|
|
|
|
|
my %VCS_cmds;
|
|
|
|
|
|
|
|
my %VCS_cmds_git = (
|
|
|
|
"execute_cmd" => \&git_execute_cmd,
|
2014-02-10 15:25:31 -07:00
|
|
|
"available" => '(which("git") ne "") && (-e ".git")',
|
2010-10-26 15:22:55 -06:00
|
|
|
"find_signers_cmd" =>
|
2012-01-10 16:08:41 -07:00
|
|
|
"git log --no-color --follow --since=\$email_git_since " .
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
'--numstat --no-merges ' .
|
2010-10-26 15:22:55 -06:00
|
|
|
'--format="GitCommit: %H%n' .
|
|
|
|
'GitAuthor: %an <%ae>%n' .
|
|
|
|
'GitDate: %aD%n' .
|
|
|
|
'GitSubject: %s%n' .
|
|
|
|
'%b%n"' .
|
|
|
|
" -- \$file",
|
|
|
|
"find_commit_signers_cmd" =>
|
|
|
|
"git log --no-color " .
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
'--numstat ' .
|
2010-10-26 15:22:55 -06:00
|
|
|
'--format="GitCommit: %H%n' .
|
|
|
|
'GitAuthor: %an <%ae>%n' .
|
|
|
|
'GitDate: %aD%n' .
|
|
|
|
'GitSubject: %s%n' .
|
|
|
|
'%b%n"' .
|
|
|
|
" -1 \$commit",
|
|
|
|
"find_commit_author_cmd" =>
|
|
|
|
"git log --no-color " .
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
'--numstat ' .
|
2010-10-26 15:22:55 -06:00
|
|
|
'--format="GitCommit: %H%n' .
|
|
|
|
'GitAuthor: %an <%ae>%n' .
|
|
|
|
'GitDate: %aD%n' .
|
|
|
|
'GitSubject: %s%n"' .
|
|
|
|
" -1 \$commit",
|
2009-12-14 19:00:50 -07:00
|
|
|
"blame_range_cmd" => "git blame -l -L \$diff_start,+\$diff_length \$file",
|
|
|
|
"blame_file_cmd" => "git blame -l \$file",
|
2010-10-26 15:22:55 -06:00
|
|
|
"commit_pattern" => "^GitCommit: ([0-9a-f]{40,40})",
|
2010-10-26 15:22:54 -06:00
|
|
|
"blame_commit_pattern" => "^([0-9a-f]+) ",
|
2010-10-26 15:22:55 -06:00
|
|
|
"author_pattern" => "^GitAuthor: (.*)",
|
|
|
|
"subject_pattern" => "^GitSubject: (.*)",
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
"stat_pattern" => "^(\\d+)\\t(\\d+)\\t\$file\$",
|
2016-08-02 15:04:10 -06:00
|
|
|
"file_exists_cmd" => "git ls-files \$file",
|
2009-12-14 19:00:50 -07:00
|
|
|
);
|
|
|
|
|
|
|
|
my %VCS_cmds_hg = (
|
|
|
|
"execute_cmd" => \&hg_execute_cmd,
|
|
|
|
"available" => '(which("hg") ne "") && (-d ".hg")',
|
|
|
|
"find_signers_cmd" =>
|
2010-10-26 15:22:55 -06:00
|
|
|
"hg log --date=\$email_hg_since " .
|
|
|
|
"--template='HgCommit: {node}\\n" .
|
|
|
|
"HgAuthor: {author}\\n" .
|
|
|
|
"HgSubject: {desc}\\n'" .
|
|
|
|
" -- \$file",
|
|
|
|
"find_commit_signers_cmd" =>
|
|
|
|
"hg log " .
|
|
|
|
"--template='HgSubject: {desc}\\n'" .
|
|
|
|
" -r \$commit",
|
|
|
|
"find_commit_author_cmd" =>
|
|
|
|
"hg log " .
|
|
|
|
"--template='HgCommit: {node}\\n" .
|
|
|
|
"HgAuthor: {author}\\n" .
|
|
|
|
"HgSubject: {desc|firstline}\\n'" .
|
|
|
|
" -r \$commit",
|
2009-12-14 19:00:50 -07:00
|
|
|
"blame_range_cmd" => "", # not supported
|
2010-10-26 15:22:55 -06:00
|
|
|
"blame_file_cmd" => "hg blame -n \$file",
|
|
|
|
"commit_pattern" => "^HgCommit: ([0-9a-f]{40,40})",
|
|
|
|
"blame_commit_pattern" => "^([ 0-9a-f]+):",
|
|
|
|
"author_pattern" => "^HgAuthor: (.*)",
|
|
|
|
"subject_pattern" => "^HgSubject: (.*)",
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
"stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
|
2016-08-02 15:04:10 -06:00
|
|
|
"file_exists_cmd" => "hg files \$file",
|
2009-12-14 19:00:50 -07:00
|
|
|
);
|
|
|
|
|
2010-10-26 15:22:53 -06:00
|
|
|
my $conf = which_conf(".get_maintainer.conf");
|
|
|
|
if (-f $conf) {
|
2010-05-24 15:33:19 -06:00
|
|
|
my @conf_args;
|
2010-10-26 15:22:53 -06:00
|
|
|
open(my $conffile, '<', "$conf")
|
|
|
|
or warn "$P: Can't find a readable .get_maintainer.conf file $!\n";
|
|
|
|
|
2010-05-24 15:33:19 -06:00
|
|
|
while (<$conffile>) {
|
|
|
|
my $line = $_;
|
|
|
|
|
|
|
|
$line =~ s/\s*\n?$//g;
|
|
|
|
$line =~ s/^\s*//g;
|
|
|
|
$line =~ s/\s+/ /g;
|
|
|
|
|
|
|
|
next if ($line =~ m/^\s*#/);
|
|
|
|
next if ($line =~ m/^\s*$/);
|
|
|
|
|
|
|
|
my @words = split(" ", $line);
|
|
|
|
foreach my $word (@words) {
|
|
|
|
last if ($word =~ m/^#/);
|
|
|
|
push (@conf_args, $word);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
close($conffile);
|
|
|
|
unshift(@ARGV, @conf_args) if @conf_args;
|
|
|
|
}
|
|
|
|
|
2015-06-25 16:01:50 -06:00
|
|
|
my @ignore_emails = ();
|
|
|
|
my $ignore_file = which_conf(".get_maintainer.ignore");
|
|
|
|
if (-f $ignore_file) {
|
|
|
|
open(my $ignore, '<', "$ignore_file")
|
|
|
|
or warn "$P: Can't find a readable .get_maintainer.ignore file $!\n";
|
|
|
|
while (<$ignore>) {
|
|
|
|
my $line = $_;
|
|
|
|
|
|
|
|
$line =~ s/\s*\n?$//;
|
|
|
|
$line =~ s/^\s*//;
|
|
|
|
$line =~ s/\s+$//;
|
|
|
|
$line =~ s/#.*$//;
|
|
|
|
|
|
|
|
next if ($line =~ m/^\s*$/);
|
|
|
|
if (rfc822_valid($line)) {
|
|
|
|
push(@ignore_emails, $line);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
close($ignore);
|
|
|
|
}
|
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
if (!GetOptions(
|
|
|
|
'email!' => \$email,
|
|
|
|
'git!' => \$email_git,
|
2010-05-24 15:33:17 -06:00
|
|
|
'git-all-signature-types!' => \$email_git_all_signature_types,
|
2009-12-14 19:00:50 -07:00
|
|
|
'git-blame!' => \$email_git_blame,
|
2010-10-26 15:22:55 -06:00
|
|
|
'git-blame-signatures!' => \$email_git_blame_signatures,
|
2010-10-26 15:22:53 -06:00
|
|
|
'git-fallback!' => \$email_git_fallback,
|
2009-04-07 21:40:12 -06:00
|
|
|
'git-chief-penguins!' => \$email_git_penguin_chiefs,
|
|
|
|
'git-min-signatures=i' => \$email_git_min_signatures,
|
|
|
|
'git-max-maintainers=i' => \$email_git_max_maintainers,
|
2009-07-29 16:04:28 -06:00
|
|
|
'git-min-percent=i' => \$email_git_min_percent,
|
2009-04-07 21:40:12 -06:00
|
|
|
'git-since=s' => \$email_git_since,
|
2009-12-14 19:00:50 -07:00
|
|
|
'hg-since=s' => \$email_hg_since,
|
2010-10-26 15:22:54 -06:00
|
|
|
'i|interactive!' => \$interactive,
|
2009-09-21 18:04:22 -06:00
|
|
|
'remove-duplicates!' => \$email_remove_duplicates,
|
2010-10-26 15:22:58 -06:00
|
|
|
'mailmap!' => \$email_use_mailmap,
|
2009-04-07 21:40:12 -06:00
|
|
|
'm!' => \$email_maintainer,
|
2014-06-02 13:05:17 -06:00
|
|
|
'r!' => \$email_reviewer,
|
2009-04-07 21:40:12 -06:00
|
|
|
'n!' => \$email_usename,
|
|
|
|
'l!' => \$email_list,
|
|
|
|
's!' => \$email_subscriber_list,
|
|
|
|
'multiline!' => \$output_multiline,
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
'roles!' => \$output_roles,
|
|
|
|
'rolestats!' => \$output_rolestats,
|
2009-04-07 21:40:12 -06:00
|
|
|
'separator=s' => \$output_separator,
|
|
|
|
'subsystem!' => \$subsystem,
|
|
|
|
'status!' => \$status,
|
|
|
|
'scm!' => \$scm,
|
|
|
|
'web!' => \$web,
|
2009-09-21 18:04:17 -06:00
|
|
|
'pattern-depth=i' => \$pattern_depth,
|
2009-10-26 17:49:47 -06:00
|
|
|
'k|keywords!' => \$keywords,
|
2010-03-05 14:43:03 -07:00
|
|
|
'sections!' => \$sections,
|
2010-03-05 14:43:00 -07:00
|
|
|
'fe|file-emails!' => \$file_emails,
|
2009-04-10 13:28:57 -06:00
|
|
|
'f|file' => \$from_filename,
|
2009-04-07 21:40:12 -06:00
|
|
|
'v|version' => \$version,
|
2010-03-05 14:43:04 -07:00
|
|
|
'h|help|usage' => \$help,
|
2009-04-07 21:40:12 -06:00
|
|
|
)) {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
die "$P: invalid argument - use --help if necessary\n";
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
if ($help != 0) {
|
|
|
|
usage();
|
|
|
|
exit 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($version != 0) {
|
|
|
|
print("${P} ${V}\n");
|
|
|
|
exit 0;
|
|
|
|
}
|
|
|
|
|
2010-03-05 14:43:04 -07:00
|
|
|
if (-t STDIN && !@ARGV) {
|
|
|
|
# We're talking to a terminal, but have no command line arguments.
|
|
|
|
die "$P: missing patchfile or -f file - use --help if necessary\n";
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
$output_multiline = 0 if ($output_separator ne ", ");
|
|
|
|
$output_rolestats = 1 if ($interactive);
|
|
|
|
$output_roles = 1 if ($output_rolestats);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
|
2010-03-05 14:43:03 -07:00
|
|
|
if ($sections) {
|
|
|
|
$email = 0;
|
|
|
|
$email_list = 0;
|
|
|
|
$scm = 0;
|
|
|
|
$status = 0;
|
|
|
|
$subsystem = 0;
|
|
|
|
$web = 0;
|
|
|
|
$keywords = 0;
|
2010-10-26 15:22:56 -06:00
|
|
|
$interactive = 0;
|
2010-03-05 14:43:03 -07:00
|
|
|
} else {
|
|
|
|
my $selections = $email + $scm + $status + $subsystem + $web;
|
|
|
|
if ($selections == 0) {
|
|
|
|
die "$P: Missing required option: email, scm, status, subsystem or web\n";
|
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
|
2009-09-21 18:04:13 -06:00
|
|
|
if ($email &&
|
2014-06-02 13:05:17 -06:00
|
|
|
($email_maintainer + $email_reviewer +
|
|
|
|
$email_list + $email_subscriber_list +
|
2009-09-21 18:04:13 -06:00
|
|
|
$email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) {
|
2009-04-07 21:40:12 -06:00
|
|
|
die "$P: Please select at least 1 email option\n";
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!top_of_kernel_tree($lk_path)) {
|
|
|
|
die "$P: The current directory does not appear to be "
|
|
|
|
. "a linux kernel source tree.\n";
|
|
|
|
}
|
|
|
|
|
|
|
|
## Read MAINTAINERS for type/value pairs
|
|
|
|
|
|
|
|
my @typevalue = ();
|
2009-10-26 17:49:47 -06:00
|
|
|
my %keyword_hash;
|
|
|
|
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
open (my $maint, '<', "${lk_path}MAINTAINERS")
|
|
|
|
or die "$P: Can't open MAINTAINERS: $!\n";
|
|
|
|
while (<$maint>) {
|
2009-04-07 21:40:12 -06:00
|
|
|
my $line = $_;
|
|
|
|
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($line =~ m/^([A-Z]):\s*(.*)/) {
|
2009-04-07 21:40:12 -06:00
|
|
|
my $type = $1;
|
|
|
|
my $value = $2;
|
|
|
|
|
|
|
|
##Filename pattern matching
|
|
|
|
if ($type eq "F" || $type eq "X") {
|
|
|
|
$value =~ s@\.@\\\.@g; ##Convert . to \.
|
|
|
|
$value =~ s/\*/\.\*/g; ##Convert * to .*
|
|
|
|
$value =~ s/\?/\./g; ##Convert ? to .
|
2009-07-29 16:04:28 -06:00
|
|
|
##if pattern is a directory and it lacks a trailing slash, add one
|
|
|
|
if ((-d $value)) {
|
|
|
|
$value =~ s@([^/])$@$1/@;
|
|
|
|
}
|
2009-10-26 17:49:47 -06:00
|
|
|
} elsif ($type eq "K") {
|
|
|
|
$keyword_hash{@typevalue} = $value;
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
push(@typevalue, "$type:$value");
|
|
|
|
} elsif (!/^(\s)*$/) {
|
|
|
|
$line =~ s/\n$//g;
|
|
|
|
push(@typevalue, $line);
|
|
|
|
}
|
|
|
|
}
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
close($maint);
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
#
|
|
|
|
# Read mail address map
|
|
|
|
#
|
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
my $mailmap;
|
|
|
|
|
|
|
|
read_mailmap();
|
2010-10-26 15:22:56 -06:00
|
|
|
|
|
|
|
sub read_mailmap {
|
2010-10-26 15:22:58 -06:00
|
|
|
$mailmap = {
|
2010-10-26 15:22:56 -06:00
|
|
|
names => {},
|
|
|
|
addresses => {}
|
2010-10-26 15:22:57 -06:00
|
|
|
};
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
return if (!$email_use_mailmap || !(-f "${lk_path}.mailmap"));
|
2010-10-26 15:22:56 -06:00
|
|
|
|
|
|
|
open(my $mailmap_file, '<', "${lk_path}.mailmap")
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
or warn "$P: Can't open .mailmap: $!\n";
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
while (<$mailmap_file>) {
|
|
|
|
s/#.*$//; #strip comments
|
|
|
|
s/^\s+|\s+$//g; #trim
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
next if (/^\s*$/); #skip empty lines
|
|
|
|
#entries have one of the following formats:
|
|
|
|
# name1 <mail1>
|
|
|
|
# <mail1> <mail2>
|
|
|
|
# name1 <mail1> <mail2>
|
|
|
|
# name1 <mail1> name2 <mail2>
|
|
|
|
# (see man git-shortlog)
|
2011-07-25 18:13:13 -06:00
|
|
|
|
|
|
|
if (/^([^<]+)<([^>]+)>$/) {
|
2010-10-26 15:22:57 -06:00
|
|
|
my $real_name = $1;
|
|
|
|
my $address = $2;
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
$real_name =~ s/\s+$//;
|
2010-10-26 15:22:58 -06:00
|
|
|
($real_name, $address) = parse_email("$real_name <$address>");
|
2010-10-26 15:22:57 -06:00
|
|
|
$mailmap->{names}->{$address} = $real_name;
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2011-07-25 18:13:13 -06:00
|
|
|
} elsif (/^<([^>]+)>\s*<([^>]+)>$/) {
|
2010-10-26 15:22:57 -06:00
|
|
|
my $real_address = $1;
|
|
|
|
my $wrong_address = $2;
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
$mailmap->{addresses}->{$wrong_address} = $real_address;
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2011-07-25 18:13:13 -06:00
|
|
|
} elsif (/^(.+)<([^>]+)>\s*<([^>]+)>$/) {
|
2010-10-26 15:22:58 -06:00
|
|
|
my $real_name = $1;
|
2010-10-26 15:22:57 -06:00
|
|
|
my $real_address = $2;
|
|
|
|
my $wrong_address = $3;
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
$real_name =~ s/\s+$//;
|
2010-10-26 15:22:58 -06:00
|
|
|
($real_name, $real_address) =
|
|
|
|
parse_email("$real_name <$real_address>");
|
2010-10-26 15:22:57 -06:00
|
|
|
$mailmap->{names}->{$wrong_address} = $real_name;
|
|
|
|
$mailmap->{addresses}->{$wrong_address} = $real_address;
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2011-07-25 18:13:13 -06:00
|
|
|
} elsif (/^(.+)<([^>]+)>\s*(.+)\s*<([^>]+)>$/) {
|
2010-10-26 15:22:57 -06:00
|
|
|
my $real_name = $1;
|
|
|
|
my $real_address = $2;
|
|
|
|
my $wrong_name = $3;
|
|
|
|
my $wrong_address = $4;
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
$real_name =~ s/\s+$//;
|
2010-10-26 15:22:58 -06:00
|
|
|
($real_name, $real_address) =
|
|
|
|
parse_email("$real_name <$real_address>");
|
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
$wrong_name =~ s/\s+$//;
|
2010-10-26 15:22:58 -06:00
|
|
|
($wrong_name, $wrong_address) =
|
|
|
|
parse_email("$wrong_name <$wrong_address>");
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
my $wrong_email = format_email($wrong_name, $wrong_address, 1);
|
|
|
|
$mailmap->{names}->{$wrong_email} = $real_name;
|
|
|
|
$mailmap->{addresses}->{$wrong_email} = $real_address;
|
2009-09-21 18:04:22 -06:00
|
|
|
}
|
2009-09-21 18:04:21 -06:00
|
|
|
}
|
2010-10-26 15:22:56 -06:00
|
|
|
close($mailmap_file);
|
2009-09-21 18:04:21 -06:00
|
|
|
}
|
|
|
|
|
2009-04-10 13:28:57 -06:00
|
|
|
## use the filenames on the command line or find the filenames in the patchfiles
|
2009-04-07 21:40:12 -06:00
|
|
|
|
|
|
|
my @files = ();
|
2009-09-21 18:04:13 -06:00
|
|
|
my @range = ();
|
2009-10-26 17:49:47 -06:00
|
|
|
my @keyword_tvi = ();
|
2010-03-05 14:43:00 -07:00
|
|
|
my @file_emails = ();
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-03-05 14:43:04 -07:00
|
|
|
if (!@ARGV) {
|
|
|
|
push(@ARGV, "&STDIN");
|
|
|
|
}
|
|
|
|
|
2009-04-10 13:28:57 -06:00
|
|
|
foreach my $file (@ARGV) {
|
2010-03-05 14:43:04 -07:00
|
|
|
if ($file ne "&STDIN") {
|
|
|
|
##if $file is a directory and it lacks a trailing slash, add one
|
|
|
|
if ((-d $file)) {
|
|
|
|
$file =~ s@([^/])$@$1/@;
|
|
|
|
} elsif (!(-f $file)) {
|
|
|
|
die "$P: file '${file}' not found\n";
|
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
2016-08-02 15:04:10 -06:00
|
|
|
if ($from_filename || vcs_file_exists($file)) {
|
2016-01-20 15:58:24 -07:00
|
|
|
$file =~ s/^\Q${cur_path}\E//; #strip any absolute path
|
|
|
|
$file =~ s/^\Q${lk_path}\E//; #or the path to the lk tree
|
2009-04-10 13:28:57 -06:00
|
|
|
push(@files, $file);
|
2010-10-26 15:22:52 -06:00
|
|
|
if ($file ne "MAINTAINERS" && -f $file && ($keywords || $file_emails)) {
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
open(my $f, '<', $file)
|
|
|
|
or die "$P: Can't open $file: $!\n";
|
|
|
|
my $text = do { local($/) ; <$f> };
|
|
|
|
close($f);
|
2010-03-05 14:43:00 -07:00
|
|
|
if ($keywords) {
|
|
|
|
foreach my $line (keys %keyword_hash) {
|
|
|
|
if ($text =~ m/$keyword_hash{$line}/x) {
|
|
|
|
push(@keyword_tvi, $line);
|
|
|
|
}
|
2009-10-26 17:49:47 -06:00
|
|
|
}
|
|
|
|
}
|
2010-03-05 14:43:00 -07:00
|
|
|
if ($file_emails) {
|
|
|
|
my @poss_addr = $text =~ m$[A-Za-zÀ-ÿ\"\' \,\.\+-]*\s*[\,]*\s*[\(\<\{]{0,1}[A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+\.[A-Za-z0-9]+[\)\>\}]{0,1}$g;
|
|
|
|
push(@file_emails, clean_file_emails(@poss_addr));
|
|
|
|
}
|
2009-10-26 17:49:47 -06:00
|
|
|
}
|
2009-04-10 13:28:57 -06:00
|
|
|
} else {
|
|
|
|
my $file_cnt = @files;
|
2009-09-21 18:04:13 -06:00
|
|
|
my $lastfile;
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
|
2010-03-23 14:35:18 -06:00
|
|
|
open(my $patch, "< $file")
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
or die "$P: Can't open $file: $!\n";
|
2011-03-22 17:34:24 -06:00
|
|
|
|
|
|
|
# We can check arbitrary information before the patch
|
|
|
|
# like the commit message, mail headers, etc...
|
|
|
|
# This allows us to match arbitrary keywords against any part
|
|
|
|
# of a git format-patch generated file (subject tags, etc...)
|
|
|
|
|
|
|
|
my $patch_prefix = ""; #Parsing the intro
|
|
|
|
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
while (<$patch>) {
|
2009-10-26 17:49:47 -06:00
|
|
|
my $patch_line = $_;
|
2013-02-21 17:43:12 -07:00
|
|
|
if (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) {
|
2009-04-10 13:28:57 -06:00
|
|
|
my $filename = $1;
|
|
|
|
$filename =~ s@^[^/]*/@@;
|
|
|
|
$filename =~ s@\n@@;
|
2009-09-21 18:04:13 -06:00
|
|
|
$lastfile = $filename;
|
2009-04-10 13:28:57 -06:00
|
|
|
push(@files, $filename);
|
2011-03-22 17:34:24 -06:00
|
|
|
$patch_prefix = "^[+-].*"; #Now parsing the actual patch
|
2009-09-21 18:04:13 -06:00
|
|
|
} elsif (m/^\@\@ -(\d+),(\d+)/) {
|
|
|
|
if ($email_git_blame) {
|
|
|
|
push(@range, "$lastfile:$1:$2");
|
|
|
|
}
|
2009-10-26 17:49:47 -06:00
|
|
|
} elsif ($keywords) {
|
|
|
|
foreach my $line (keys %keyword_hash) {
|
2011-03-22 17:34:24 -06:00
|
|
|
if ($patch_line =~ m/${patch_prefix}$keyword_hash{$line}/x) {
|
2009-10-26 17:49:47 -06:00
|
|
|
push(@keyword_tvi, $line);
|
|
|
|
}
|
|
|
|
}
|
2009-04-10 13:28:57 -06:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
close($patch);
|
|
|
|
|
2009-04-10 13:28:57 -06:00
|
|
|
if ($file_cnt == @files) {
|
2009-06-16 16:34:04 -06:00
|
|
|
warn "$P: file '${file}' doesn't appear to be a patch. "
|
2009-04-10 13:28:57 -06:00
|
|
|
. "Add -f to options?\n";
|
|
|
|
}
|
|
|
|
@files = sort_and_uniq(@files);
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-03-05 14:43:00 -07:00
|
|
|
@file_emails = uniq(@file_emails);
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
my %email_hash_name;
|
|
|
|
my %email_hash_address;
|
2009-04-07 21:40:12 -06:00
|
|
|
my @email_to = ();
|
2010-10-26 15:22:55 -06:00
|
|
|
my %hash_list_to;
|
2009-06-16 16:33:58 -06:00
|
|
|
my @list_to = ();
|
2009-04-07 21:40:12 -06:00
|
|
|
my @scm = ();
|
|
|
|
my @web = ();
|
|
|
|
my @subsystem = ();
|
|
|
|
my @status = ();
|
2010-10-26 15:22:58 -06:00
|
|
|
my %deduplicate_name_hash = ();
|
|
|
|
my %deduplicate_address_hash = ();
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
my @maintainers = get_maintainers();
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
if (@maintainers) {
|
|
|
|
@maintainers = merge_email(@maintainers);
|
|
|
|
output(@maintainers);
|
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
|
|
|
|
if ($scm) {
|
|
|
|
@scm = uniq(@scm);
|
|
|
|
output(@scm);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($status) {
|
|
|
|
@status = uniq(@status);
|
|
|
|
output(@status);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($subsystem) {
|
|
|
|
@subsystem = uniq(@subsystem);
|
|
|
|
output(@subsystem);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($web) {
|
|
|
|
@web = uniq(@web);
|
|
|
|
output(@web);
|
|
|
|
}
|
|
|
|
|
|
|
|
exit($exit);
|
|
|
|
|
2015-06-25 16:01:50 -06:00
|
|
|
sub ignore_email_address {
|
|
|
|
my ($address) = @_;
|
|
|
|
|
|
|
|
foreach my $ignore (@ignore_emails) {
|
|
|
|
return 1 if ($ignore eq $address);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-01-12 17:59:50 -07:00
|
|
|
sub range_is_maintained {
|
|
|
|
my ($start, $end) = @_;
|
|
|
|
|
|
|
|
for (my $i = $start; $i < $end; $i++) {
|
|
|
|
my $line = $typevalue[$i];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($line =~ m/^([A-Z]):\s*(.*)/) {
|
2011-01-12 17:59:50 -07:00
|
|
|
my $type = $1;
|
|
|
|
my $value = $2;
|
|
|
|
if ($type eq 'S') {
|
|
|
|
if ($value =~ /(maintain|support)/i) {
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub range_has_maintainer {
|
|
|
|
my ($start, $end) = @_;
|
|
|
|
|
|
|
|
for (my $i = $start; $i < $end; $i++) {
|
|
|
|
my $line = $typevalue[$i];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($line =~ m/^([A-Z]):\s*(.*)/) {
|
2011-01-12 17:59:50 -07:00
|
|
|
my $type = $1;
|
|
|
|
my $value = $2;
|
|
|
|
if ($type eq 'M') {
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
sub get_maintainers {
|
2010-10-26 15:22:55 -06:00
|
|
|
%email_hash_name = ();
|
|
|
|
%email_hash_address = ();
|
|
|
|
%commit_author_hash = ();
|
|
|
|
%commit_signer_hash = ();
|
|
|
|
@email_to = ();
|
|
|
|
%hash_list_to = ();
|
|
|
|
@list_to = ();
|
|
|
|
@scm = ();
|
|
|
|
@web = ();
|
|
|
|
@subsystem = ();
|
|
|
|
@status = ();
|
2010-10-26 15:22:58 -06:00
|
|
|
%deduplicate_name_hash = ();
|
|
|
|
%deduplicate_address_hash = ();
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($email_git_all_signature_types) {
|
|
|
|
$signature_pattern = "(.+?)[Bb][Yy]:";
|
|
|
|
} else {
|
|
|
|
$signature_pattern = "\(" . join("|", @signature_tags) . "\)";
|
|
|
|
}
|
|
|
|
|
|
|
|
# Find responsible parties
|
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
my %exact_pattern_match_hash = ();
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
foreach my $file (@files) {
|
|
|
|
|
|
|
|
my %hash;
|
|
|
|
my $tvi = find_first_section();
|
|
|
|
while ($tvi < @typevalue) {
|
|
|
|
my $start = find_starting_index($tvi);
|
|
|
|
my $end = find_ending_index($tvi);
|
|
|
|
my $exclude = 0;
|
|
|
|
my $i;
|
|
|
|
|
|
|
|
#Do not match excluded file patterns
|
2010-01-08 15:42:48 -07:00
|
|
|
|
|
|
|
for ($i = $start; $i < $end; $i++) {
|
|
|
|
my $line = $typevalue[$i];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($line =~ m/^([A-Z]):\s*(.*)/) {
|
2010-01-08 15:42:48 -07:00
|
|
|
my $type = $1;
|
|
|
|
my $value = $2;
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($type eq 'X') {
|
2010-01-08 15:42:48 -07:00
|
|
|
if (file_match_pattern($file, $value)) {
|
2010-10-26 15:22:55 -06:00
|
|
|
$exclude = 1;
|
|
|
|
last;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!$exclude) {
|
|
|
|
for ($i = $start; $i < $end; $i++) {
|
|
|
|
my $line = $typevalue[$i];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($line =~ m/^([A-Z]):\s*(.*)/) {
|
2010-10-26 15:22:55 -06:00
|
|
|
my $type = $1;
|
|
|
|
my $value = $2;
|
|
|
|
if ($type eq 'F') {
|
|
|
|
if (file_match_pattern($file, $value)) {
|
|
|
|
my $value_pd = ($value =~ tr@/@@);
|
|
|
|
my $file_pd = ($file =~ tr@/@@);
|
|
|
|
$value_pd++ if (substr($value,-1,1) ne "/");
|
|
|
|
$value_pd = -1 if ($value =~ /^\.\*/);
|
2011-01-12 17:59:50 -07:00
|
|
|
if ($value_pd >= $file_pd &&
|
|
|
|
range_is_maintained($start, $end) &&
|
|
|
|
range_has_maintainer($start, $end)) {
|
2010-10-26 15:22:56 -06:00
|
|
|
$exact_pattern_match_hash{$file} = 1;
|
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($pattern_depth == 0 ||
|
|
|
|
(($file_pd - $value_pd) < $pattern_depth)) {
|
|
|
|
$hash{$tvi} = $value_pd;
|
|
|
|
}
|
2010-01-08 15:42:48 -07:00
|
|
|
}
|
2013-04-29 17:17:23 -06:00
|
|
|
} elsif ($type eq 'N') {
|
2013-02-27 18:02:53 -07:00
|
|
|
if ($file =~ m/$value/x) {
|
|
|
|
$hash{$tvi} = 0;
|
|
|
|
}
|
2010-01-08 15:42:48 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
$tvi = $end + 1;
|
2009-09-21 18:04:14 -06:00
|
|
|
}
|
2010-01-08 15:42:48 -07:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
|
|
|
|
add_categories($line);
|
|
|
|
if ($sections) {
|
|
|
|
my $i;
|
|
|
|
my $start = find_starting_index($line);
|
|
|
|
my $end = find_ending_index($line);
|
|
|
|
for ($i = $start; $i < $end; $i++) {
|
|
|
|
my $line = $typevalue[$i];
|
|
|
|
if ($line =~ /^[FX]:/) { ##Restore file patterns
|
|
|
|
$line =~ s/([^\\])\.([^\*])/$1\?$2/g;
|
|
|
|
$line =~ s/([^\\])\.$/$1\?/g; ##Convert . back to ?
|
|
|
|
$line =~ s/\\\./\./g; ##Convert \. to .
|
|
|
|
$line =~ s/\.\*/\*/g; ##Convert .* to *
|
|
|
|
}
|
|
|
|
$line =~ s/^([A-Z]):/$1:\t/g;
|
|
|
|
print("$line\n");
|
2010-03-05 14:43:03 -07:00
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
print("\n");
|
2010-03-05 14:43:03 -07:00
|
|
|
}
|
2010-10-26 15:22:51 -06:00
|
|
|
}
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($keywords) {
|
|
|
|
@keyword_tvi = sort_and_uniq(@keyword_tvi);
|
|
|
|
foreach my $line (@keyword_tvi) {
|
|
|
|
add_categories($line);
|
|
|
|
}
|
2009-10-26 17:49:47 -06:00
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
foreach my $email (@email_to, @list_to) {
|
|
|
|
$email->[0] = deduplicate_email($email->[0]);
|
|
|
|
}
|
2010-10-26 15:22:56 -06:00
|
|
|
|
|
|
|
foreach my $file (@files) {
|
|
|
|
if ($email &&
|
|
|
|
($email_git || ($email_git_fallback &&
|
|
|
|
!$exact_pattern_match_hash{$file}))) {
|
|
|
|
vcs_file_signoffs($file);
|
|
|
|
}
|
|
|
|
if ($email && $email_git_blame) {
|
|
|
|
vcs_file_blame($file);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($email) {
|
|
|
|
foreach my $chief (@penguin_chief) {
|
|
|
|
if ($chief =~ m/^(.*):(.*)/) {
|
|
|
|
my $email_address;
|
2009-09-21 18:04:20 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
$email_address = format_email($1, $2, $email_usename);
|
|
|
|
if ($email_git_penguin_chiefs) {
|
|
|
|
push(@email_to, [$email_address, 'chief penguin']);
|
|
|
|
} else {
|
|
|
|
@email_to = grep($_->[0] !~ /${email_address}/, @email_to);
|
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
}
|
2010-03-05 14:43:00 -07:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
foreach my $email (@file_emails) {
|
|
|
|
my ($name, $address) = parse_email($email);
|
2010-03-05 14:43:00 -07:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
my $tmp_email = format_email($name, $address, $email_usename);
|
|
|
|
push_email_address($tmp_email, '');
|
|
|
|
add_role($tmp_email, 'in file');
|
|
|
|
}
|
2010-03-05 14:43:00 -07:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2009-06-16 16:33:58 -06:00
|
|
|
my @to = ();
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($email || $email_list) {
|
|
|
|
if ($email) {
|
|
|
|
@to = (@to, @email_to);
|
|
|
|
}
|
|
|
|
if ($email_list) {
|
|
|
|
@to = (@to, @list_to);
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
2009-06-16 16:33:58 -06:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
if ($interactive) {
|
2010-10-26 15:22:58 -06:00
|
|
|
@to = interactive_get_maintainers(\@to);
|
2010-10-26 15:22:56 -06:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
return @to;
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
sub file_match_pattern {
|
|
|
|
my ($file, $pattern) = @_;
|
|
|
|
if (substr($pattern, -1) eq "/") {
|
|
|
|
if ($file =~ m@^$pattern@) {
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if ($file =~ m@^$pattern@) {
|
|
|
|
my $s1 = ($file =~ tr@/@@);
|
|
|
|
my $s2 = ($pattern =~ tr@/@@);
|
|
|
|
if ($s1 == $s2) {
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub usage {
|
|
|
|
print <<EOT;
|
|
|
|
usage: $P [options] patchfile
|
2009-07-29 16:04:28 -06:00
|
|
|
$P [options] -f file|directory
|
2009-04-07 21:40:12 -06:00
|
|
|
version: $V
|
|
|
|
|
|
|
|
MAINTAINER field selection options:
|
|
|
|
--email => print email address(es) if any
|
|
|
|
--git => include recent git \*-by: signers
|
2010-05-24 15:33:17 -06:00
|
|
|
--git-all-signature-types => include signers regardless of signature type
|
2010-10-26 15:22:55 -06:00
|
|
|
or use only ${signature_pattern} signers (default: $email_git_all_signature_types)
|
2010-10-26 15:22:53 -06:00
|
|
|
--git-fallback => use git when no exact MAINTAINERS pattern (default: $email_git_fallback)
|
2009-04-07 21:40:12 -06:00
|
|
|
--git-chief-penguins => include ${penguin_chiefs}
|
2010-05-24 15:33:17 -06:00
|
|
|
--git-min-signatures => number of signatures required (default: $email_git_min_signatures)
|
|
|
|
--git-max-maintainers => maximum maintainers to add (default: $email_git_max_maintainers)
|
|
|
|
--git-min-percent => minimum percentage of commits required (default: $email_git_min_percent)
|
2009-09-21 18:04:13 -06:00
|
|
|
--git-blame => use git blame to find modified commits for patch or file
|
2015-11-06 17:30:41 -07:00
|
|
|
--git-blame-signatures => when used with --git-blame, also include all commit signers
|
2010-05-24 15:33:17 -06:00
|
|
|
--git-since => git history to use (default: $email_git_since)
|
|
|
|
--hg-since => hg history to use (default: $email_hg_since)
|
2010-10-26 15:22:54 -06:00
|
|
|
--interactive => display a menu (mostly useful if used with the --git option)
|
2009-04-07 21:40:12 -06:00
|
|
|
--m => include maintainer(s) if any
|
2014-06-02 13:05:17 -06:00
|
|
|
--r => include reviewer(s) if any
|
2009-04-07 21:40:12 -06:00
|
|
|
--n => include name 'Full Name <addr\@domain.tld>'
|
|
|
|
--l => include list(s) if any
|
|
|
|
--s => include subscriber only list(s) if any
|
2009-09-21 18:04:22 -06:00
|
|
|
--remove-duplicates => minimize duplicate email names/addresses
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
--roles => show roles (status:subsystem, git-signer, list, etc...)
|
|
|
|
--rolestats => show roles and statistics (commits/total_commits, %)
|
2010-03-05 14:43:00 -07:00
|
|
|
--file-emails => add email addresses found in -f file (default: 0 (off))
|
2009-04-07 21:40:12 -06:00
|
|
|
--scm => print SCM tree(s) if any
|
|
|
|
--status => print status if any
|
|
|
|
--subsystem => print subsystem name if any
|
|
|
|
--web => print website(s) if any
|
|
|
|
|
|
|
|
Output type options:
|
|
|
|
--separator [, ] => separator for multiple entries on 1 line
|
2009-09-21 18:04:21 -06:00
|
|
|
using --separator also sets --nomultiline if --separator is not [, ]
|
2009-04-07 21:40:12 -06:00
|
|
|
--multiline => print 1 entry per line
|
|
|
|
|
|
|
|
Other options:
|
2009-09-21 18:04:17 -06:00
|
|
|
--pattern-depth => Number of pattern directory traversals (default: 0 (all))
|
2010-10-26 15:22:58 -06:00
|
|
|
--keywords => scan patch for keywords (default: $keywords)
|
|
|
|
--sections => print all of the subsystem sections with pattern matches
|
|
|
|
--mailmap => use .mailmap file (default: $email_use_mailmap)
|
2009-06-16 16:34:00 -06:00
|
|
|
--version => show version
|
2009-04-07 21:40:12 -06:00
|
|
|
--help => show this help information
|
|
|
|
|
2009-09-21 18:04:17 -06:00
|
|
|
Default options:
|
2015-11-06 17:30:49 -07:00
|
|
|
[--email --nogit --git-fallback --m --r --n --l --multiline --pattern-depth=0
|
2011-01-12 17:59:49 -07:00
|
|
|
--remove-duplicates --rolestats]
|
2009-09-21 18:04:17 -06:00
|
|
|
|
2009-07-29 16:04:28 -06:00
|
|
|
Notes:
|
|
|
|
Using "-f directory" may give unexpected results:
|
2009-09-21 18:04:13 -06:00
|
|
|
Used with "--git", git signators for _all_ files in and below
|
|
|
|
directory are examined as git recurses directories.
|
|
|
|
Any specified X: (exclude) pattern matches are _not_ ignored.
|
|
|
|
Used with "--nogit", directory is used as a pattern match,
|
2009-12-14 19:00:50 -07:00
|
|
|
no individual file within the directory or subdirectory
|
|
|
|
is matched.
|
2009-09-21 18:04:13 -06:00
|
|
|
Used with "--git-blame", does not iterate all files in directory
|
|
|
|
Using "--git-blame" is slow and may add old committers and authors
|
|
|
|
that are no longer active maintainers to the output.
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
Using "--roles" or "--rolestats" with git send-email --cc-cmd or any
|
|
|
|
other automated tools that expect only ["name"] <email address>
|
|
|
|
may not work because of additional output after <email address>.
|
|
|
|
Using "--rolestats" and "--git-blame" shows the #/total=% commits,
|
|
|
|
not the percentage of the entire file authored. # of commits is
|
|
|
|
not a good measure of amount of code authored. 1 major commit may
|
|
|
|
contain a thousand lines, 5 trivial commits may modify a single line.
|
2009-12-14 19:00:50 -07:00
|
|
|
If git is not installed, but mercurial (hg) is installed and an .hg
|
|
|
|
repository exists, the following options apply to mercurial:
|
|
|
|
--git,
|
|
|
|
--git-min-signatures, --git-max-maintainers, --git-min-percent, and
|
|
|
|
--git-blame
|
|
|
|
Use --hg-since not --git-since to control date selection
|
2010-05-24 15:33:19 -06:00
|
|
|
File ".get_maintainer.conf", if it exists in the linux kernel source root
|
|
|
|
directory, can change whatever get_maintainer defaults are desired.
|
|
|
|
Entries in this file can be any command line argument.
|
|
|
|
This file is prepended to any additional command line arguments.
|
|
|
|
Multiple lines and # comments are allowed.
|
2015-11-06 17:30:46 -07:00
|
|
|
Most options have both positive and negative forms.
|
|
|
|
The negative forms for --<foo> are --no<foo> and --no-<foo>.
|
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
EOT
|
|
|
|
}
|
|
|
|
|
|
|
|
sub top_of_kernel_tree {
|
2010-10-26 15:22:57 -06:00
|
|
|
my ($lk_path) = @_;
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
if ($lk_path ne "" && substr($lk_path,length($lk_path)-1,1) ne "/") {
|
|
|
|
$lk_path .= "/";
|
|
|
|
}
|
|
|
|
if ( (-f "${lk_path}COPYING")
|
|
|
|
&& (-f "${lk_path}CREDITS")
|
|
|
|
&& (-f "${lk_path}Kbuild")
|
|
|
|
&& (-f "${lk_path}MAINTAINERS")
|
|
|
|
&& (-f "${lk_path}Makefile")
|
|
|
|
&& (-f "${lk_path}README")
|
|
|
|
&& (-d "${lk_path}Documentation")
|
|
|
|
&& (-d "${lk_path}arch")
|
|
|
|
&& (-d "${lk_path}include")
|
|
|
|
&& (-d "${lk_path}drivers")
|
|
|
|
&& (-d "${lk_path}fs")
|
|
|
|
&& (-d "${lk_path}init")
|
|
|
|
&& (-d "${lk_path}ipc")
|
|
|
|
&& (-d "${lk_path}kernel")
|
|
|
|
&& (-d "${lk_path}lib")
|
|
|
|
&& (-d "${lk_path}scripts")) {
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
|
2009-09-21 18:04:20 -06:00
|
|
|
sub parse_email {
|
|
|
|
my ($formatted_email) = @_;
|
|
|
|
|
|
|
|
my $name = "";
|
|
|
|
my $address = "";
|
|
|
|
|
2009-09-21 18:04:22 -06:00
|
|
|
if ($formatted_email =~ /^([^<]+)<(.+\@.*)>.*$/) {
|
2009-09-21 18:04:20 -06:00
|
|
|
$name = $1;
|
|
|
|
$address = $2;
|
2009-09-21 18:04:22 -06:00
|
|
|
} elsif ($formatted_email =~ /^\s*<(.+\@\S*)>.*$/) {
|
2009-09-21 18:04:20 -06:00
|
|
|
$address = $1;
|
2009-09-21 18:04:24 -06:00
|
|
|
} elsif ($formatted_email =~ /^(.+\@\S*).*$/) {
|
2009-09-21 18:04:20 -06:00
|
|
|
$address = $1;
|
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
|
|
|
|
$name =~ s/^\s+|\s+$//g;
|
2009-06-16 16:34:02 -06:00
|
|
|
$name =~ s/^\"|\"$//g;
|
2009-09-21 18:04:20 -06:00
|
|
|
$address =~ s/^\s+|\s+$//g;
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-03-05 14:43:06 -07:00
|
|
|
if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
|
2009-09-21 18:04:20 -06:00
|
|
|
$name =~ s/(?<!\\)"/\\"/g; ##escape quotes
|
|
|
|
$name = "\"$name\"";
|
|
|
|
}
|
|
|
|
|
|
|
|
return ($name, $address);
|
|
|
|
}
|
|
|
|
|
|
|
|
sub format_email {
|
2009-12-14 19:00:49 -07:00
|
|
|
my ($name, $address, $usename) = @_;
|
2009-09-21 18:04:20 -06:00
|
|
|
|
|
|
|
my $formatted_email;
|
|
|
|
|
|
|
|
$name =~ s/^\s+|\s+$//g;
|
|
|
|
$name =~ s/^\"|\"$//g;
|
|
|
|
$address =~ s/^\s+|\s+$//g;
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2010-03-05 14:43:06 -07:00
|
|
|
if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
|
2009-04-07 21:40:12 -06:00
|
|
|
$name =~ s/(?<!\\)"/\\"/g; ##escape quotes
|
2009-09-21 18:04:20 -06:00
|
|
|
$name = "\"$name\"";
|
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:49 -07:00
|
|
|
if ($usename) {
|
2009-09-21 18:04:20 -06:00
|
|
|
if ("$name" eq "") {
|
|
|
|
$formatted_email = "$address";
|
|
|
|
} else {
|
2009-12-14 19:00:49 -07:00
|
|
|
$formatted_email = "$name <$address>";
|
2009-09-21 18:04:20 -06:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
} else {
|
2009-09-21 18:04:20 -06:00
|
|
|
$formatted_email = $address;
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
2009-09-21 18:04:20 -06:00
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
return $formatted_email;
|
|
|
|
}
|
|
|
|
|
2010-01-08 15:42:48 -07:00
|
|
|
sub find_first_section {
|
|
|
|
my $index = 0;
|
|
|
|
|
|
|
|
while ($index < @typevalue) {
|
|
|
|
my $tv = $typevalue[$index];
|
2015-06-25 16:01:55 -06:00
|
|
|
if (($tv =~ m/^([A-Z]):\s*(.*)/)) {
|
2010-01-08 15:42:48 -07:00
|
|
|
last;
|
|
|
|
}
|
|
|
|
$index++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return $index;
|
|
|
|
}
|
|
|
|
|
2009-09-21 18:04:24 -06:00
|
|
|
sub find_starting_index {
|
|
|
|
my ($index) = @_;
|
|
|
|
|
|
|
|
while ($index > 0) {
|
|
|
|
my $tv = $typevalue[$index];
|
2015-06-25 16:01:55 -06:00
|
|
|
if (!($tv =~ m/^([A-Z]):\s*(.*)/)) {
|
2009-09-21 18:04:24 -06:00
|
|
|
last;
|
|
|
|
}
|
|
|
|
$index--;
|
|
|
|
}
|
|
|
|
|
|
|
|
return $index;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub find_ending_index {
|
2009-04-07 21:40:12 -06:00
|
|
|
my ($index) = @_;
|
|
|
|
|
2009-09-21 18:04:24 -06:00
|
|
|
while ($index < @typevalue) {
|
2009-04-07 21:40:12 -06:00
|
|
|
my $tv = $typevalue[$index];
|
2015-06-25 16:01:55 -06:00
|
|
|
if (!($tv =~ m/^([A-Z]):\s*(.*)/)) {
|
2009-09-21 18:04:24 -06:00
|
|
|
last;
|
|
|
|
}
|
|
|
|
$index++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return $index;
|
|
|
|
}
|
|
|
|
|
2015-11-06 17:30:52 -07:00
|
|
|
sub get_subsystem_name {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
my ($index) = @_;
|
|
|
|
|
|
|
|
my $start = find_starting_index($index);
|
|
|
|
|
|
|
|
my $subsystem = $typevalue[$start];
|
2015-06-25 16:01:52 -06:00
|
|
|
if ($output_section_maxlen && length($subsystem) > $output_section_maxlen) {
|
|
|
|
$subsystem = substr($subsystem, 0, $output_section_maxlen - 3);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
$subsystem =~ s/\s*$//;
|
|
|
|
$subsystem = $subsystem . "...";
|
|
|
|
}
|
2015-11-06 17:30:52 -07:00
|
|
|
return $subsystem;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub get_maintainer_role {
|
|
|
|
my ($index) = @_;
|
|
|
|
|
|
|
|
my $i;
|
|
|
|
my $start = find_starting_index($index);
|
|
|
|
my $end = find_ending_index($index);
|
|
|
|
|
|
|
|
my $role = "unknown";
|
|
|
|
my $subsystem = get_subsystem_name($index);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
|
|
|
|
for ($i = $start + 1; $i < $end; $i++) {
|
|
|
|
my $tv = $typevalue[$i];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($tv =~ m/^([A-Z]):\s*(.*)/) {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
my $ptype = $1;
|
|
|
|
my $pvalue = $2;
|
|
|
|
if ($ptype eq "S") {
|
|
|
|
$role = $pvalue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$role = lc($role);
|
|
|
|
if ($role eq "supported") {
|
|
|
|
$role = "supporter";
|
|
|
|
} elsif ($role eq "maintained") {
|
|
|
|
$role = "maintainer";
|
|
|
|
} elsif ($role eq "odd fixes") {
|
|
|
|
$role = "odd fixer";
|
|
|
|
} elsif ($role eq "orphan") {
|
|
|
|
$role = "orphan minder";
|
|
|
|
} elsif ($role eq "obsolete") {
|
|
|
|
$role = "obsolete minder";
|
|
|
|
} elsif ($role eq "buried alive in reporters") {
|
|
|
|
$role = "chief penguin";
|
|
|
|
}
|
|
|
|
|
|
|
|
return $role . ":" . $subsystem;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub get_list_role {
|
|
|
|
my ($index) = @_;
|
|
|
|
|
2015-11-06 17:30:52 -07:00
|
|
|
my $subsystem = get_subsystem_name($index);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
|
|
|
|
if ($subsystem eq "THE REST") {
|
|
|
|
$subsystem = "";
|
|
|
|
}
|
|
|
|
|
|
|
|
return $subsystem;
|
|
|
|
}
|
|
|
|
|
2009-09-21 18:04:24 -06:00
|
|
|
sub add_categories {
|
|
|
|
my ($index) = @_;
|
|
|
|
|
|
|
|
my $i;
|
|
|
|
my $start = find_starting_index($index);
|
|
|
|
my $end = find_ending_index($index);
|
|
|
|
|
|
|
|
push(@subsystem, $typevalue[$start]);
|
|
|
|
|
|
|
|
for ($i = $start + 1; $i < $end; $i++) {
|
|
|
|
my $tv = $typevalue[$i];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($tv =~ m/^([A-Z]):\s*(.*)/) {
|
2009-04-07 21:40:12 -06:00
|
|
|
my $ptype = $1;
|
|
|
|
my $pvalue = $2;
|
|
|
|
if ($ptype eq "L") {
|
2009-06-16 16:33:58 -06:00
|
|
|
my $list_address = $pvalue;
|
|
|
|
my $list_additional = "";
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
my $list_role = get_list_role($i);
|
|
|
|
|
|
|
|
if ($list_role ne "") {
|
|
|
|
$list_role = ":" . $list_role;
|
|
|
|
}
|
2009-06-16 16:33:58 -06:00
|
|
|
if ($list_address =~ m/([^\s]+)\s+(.*)$/) {
|
|
|
|
$list_address = $1;
|
|
|
|
$list_additional = $2;
|
|
|
|
}
|
2009-06-16 16:33:59 -06:00
|
|
|
if ($list_additional =~ m/subscribers-only/) {
|
2009-04-07 21:40:12 -06:00
|
|
|
if ($email_subscriber_list) {
|
2010-10-26 15:22:56 -06:00
|
|
|
if (!$hash_list_to{lc($list_address)}) {
|
|
|
|
$hash_list_to{lc($list_address)} = 1;
|
2010-10-26 15:22:55 -06:00
|
|
|
push(@list_to, [$list_address,
|
|
|
|
"subscriber list${list_role}"]);
|
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if ($email_list) {
|
2010-10-26 15:22:56 -06:00
|
|
|
if (!$hash_list_to{lc($list_address)}) {
|
|
|
|
$hash_list_to{lc($list_address)} = 1;
|
2012-03-23 16:01:56 -06:00
|
|
|
if ($list_additional =~ m/moderated/) {
|
|
|
|
push(@list_to, [$list_address,
|
|
|
|
"moderated list${list_role}"]);
|
|
|
|
} else {
|
|
|
|
push(@list_to, [$list_address,
|
|
|
|
"open list${list_role}"]);
|
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
} elsif ($ptype eq "M") {
|
2009-09-21 18:04:20 -06:00
|
|
|
my ($name, $address) = parse_email($pvalue);
|
|
|
|
if ($name eq "") {
|
2009-09-21 18:04:24 -06:00
|
|
|
if ($i > 0) {
|
|
|
|
my $tv = $typevalue[$i - 1];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($tv =~ m/^([A-Z]):\s*(.*)/) {
|
2009-09-21 18:04:20 -06:00
|
|
|
if ($1 eq "P") {
|
|
|
|
$name = $2;
|
2009-12-14 19:00:49 -07:00
|
|
|
$pvalue = format_email($name, $address, $email_usename);
|
2009-06-16 16:34:02 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2009-09-21 18:04:20 -06:00
|
|
|
if ($email_maintainer) {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
my $role = get_maintainer_role($i);
|
|
|
|
push_email_addresses($pvalue, $role);
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
2014-06-02 13:05:17 -06:00
|
|
|
} elsif ($ptype eq "R") {
|
|
|
|
my ($name, $address) = parse_email($pvalue);
|
|
|
|
if ($name eq "") {
|
|
|
|
if ($i > 0) {
|
|
|
|
my $tv = $typevalue[$i - 1];
|
2015-06-25 16:01:55 -06:00
|
|
|
if ($tv =~ m/^([A-Z]):\s*(.*)/) {
|
2014-06-02 13:05:17 -06:00
|
|
|
if ($1 eq "P") {
|
|
|
|
$name = $2;
|
|
|
|
$pvalue = format_email($name, $address, $email_usename);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if ($email_reviewer) {
|
2015-11-06 17:30:52 -07:00
|
|
|
my $subsystem = get_subsystem_name($i);
|
|
|
|
push_email_addresses($pvalue, "reviewer:$subsystem");
|
2014-06-02 13:05:17 -06:00
|
|
|
}
|
2009-04-07 21:40:12 -06:00
|
|
|
} elsif ($ptype eq "T") {
|
|
|
|
push(@scm, $pvalue);
|
|
|
|
} elsif ($ptype eq "W") {
|
|
|
|
push(@web, $pvalue);
|
|
|
|
} elsif ($ptype eq "S") {
|
|
|
|
push(@status, $pvalue);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-09-21 18:04:22 -06:00
|
|
|
sub email_inuse {
|
|
|
|
my ($name, $address) = @_;
|
|
|
|
|
|
|
|
return 1 if (($name eq "") && ($address eq ""));
|
2010-10-26 15:22:56 -06:00
|
|
|
return 1 if (($name ne "") && exists($email_hash_name{lc($name)}));
|
|
|
|
return 1 if (($address ne "") && exists($email_hash_address{lc($address)}));
|
2009-09-21 18:04:20 -06:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-06-16 16:34:01 -06:00
|
|
|
sub push_email_address {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
my ($line, $role) = @_;
|
2009-06-16 16:34:01 -06:00
|
|
|
|
2009-09-21 18:04:20 -06:00
|
|
|
my ($name, $address) = parse_email($line);
|
2009-06-16 16:34:01 -06:00
|
|
|
|
2009-09-21 18:04:24 -06:00
|
|
|
if ($address eq "") {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-09-21 18:04:22 -06:00
|
|
|
if (!$email_remove_duplicates) {
|
2009-12-14 19:00:49 -07:00
|
|
|
push(@email_to, [format_email($name, $address, $email_usename), $role]);
|
2009-09-21 18:04:22 -06:00
|
|
|
} elsif (!email_inuse($name, $address)) {
|
2009-12-14 19:00:49 -07:00
|
|
|
push(@email_to, [format_email($name, $address, $email_usename), $role]);
|
2010-10-26 15:22:58 -06:00
|
|
|
$email_hash_name{lc($name)}++ if ($name ne "");
|
2010-10-26 15:22:56 -06:00
|
|
|
$email_hash_address{lc($address)}++;
|
2009-06-16 16:34:01 -06:00
|
|
|
}
|
2009-09-21 18:04:24 -06:00
|
|
|
|
|
|
|
return 1;
|
2009-06-16 16:34:01 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
sub push_email_addresses {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
my ($address, $role) = @_;
|
2009-06-16 16:34:01 -06:00
|
|
|
|
|
|
|
my @address_list = ();
|
|
|
|
|
2009-06-16 16:34:02 -06:00
|
|
|
if (rfc822_valid($address)) {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
push_email_address($address, $role);
|
2009-06-16 16:34:02 -06:00
|
|
|
} elsif (@address_list = rfc822_validlist($address)) {
|
2009-06-16 16:34:01 -06:00
|
|
|
my $array_count = shift(@address_list);
|
|
|
|
while (my $entry = shift(@address_list)) {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
push_email_address($entry, $role);
|
2009-06-16 16:34:01 -06:00
|
|
|
}
|
2009-06-16 16:34:02 -06:00
|
|
|
} else {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
if (!push_email_address($address, $role)) {
|
2009-09-21 18:04:24 -06:00
|
|
|
warn("Invalid MAINTAINERS address: '" . $address . "'\n");
|
|
|
|
}
|
2009-06-16 16:34:01 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
sub add_role {
|
|
|
|
my ($line, $role) = @_;
|
|
|
|
|
|
|
|
my ($name, $address) = parse_email($line);
|
2009-12-14 19:00:49 -07:00
|
|
|
my $email = format_email($name, $address, $email_usename);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
|
|
|
|
foreach my $entry (@email_to) {
|
|
|
|
if ($email_remove_duplicates) {
|
|
|
|
my ($entry_name, $entry_address) = parse_email($entry->[0]);
|
2010-03-05 14:43:00 -07:00
|
|
|
if (($name eq $entry_name || $address eq $entry_address)
|
|
|
|
&& ($role eq "" || !($entry->[1] =~ m/$role/))
|
|
|
|
) {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
if ($entry->[1] eq "") {
|
|
|
|
$entry->[1] = "$role";
|
|
|
|
} else {
|
|
|
|
$entry->[1] = "$entry->[1],$role";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
2010-03-05 14:43:00 -07:00
|
|
|
if ($email eq $entry->[0]
|
|
|
|
&& ($role eq "" || !($entry->[1] =~ m/$role/))
|
|
|
|
) {
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
if ($entry->[1] eq "") {
|
|
|
|
$entry->[1] = "$role";
|
|
|
|
} else {
|
|
|
|
$entry->[1] = "$entry->[1],$role";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
sub which {
|
|
|
|
my ($bin) = @_;
|
|
|
|
|
2009-06-16 16:34:00 -06:00
|
|
|
foreach my $path (split(/:/, $ENV{PATH})) {
|
2009-04-07 21:40:12 -06:00
|
|
|
if (-e "$path/$bin") {
|
|
|
|
return "$path/$bin";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return "";
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:53 -06:00
|
|
|
sub which_conf {
|
|
|
|
my ($conf) = @_;
|
|
|
|
|
|
|
|
foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
|
|
|
|
if (-e "$path/$conf") {
|
|
|
|
return "$path/$conf";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return "";
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
sub mailmap_email {
|
2010-10-26 15:22:58 -06:00
|
|
|
my ($line) = @_;
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
my ($name, $address) = parse_email($line);
|
|
|
|
my $email = format_email($name, $address, 1);
|
|
|
|
my $real_name = $name;
|
|
|
|
my $real_address = $address;
|
|
|
|
|
|
|
|
if (exists $mailmap->{names}->{$email} ||
|
|
|
|
exists $mailmap->{addresses}->{$email}) {
|
|
|
|
if (exists $mailmap->{names}->{$email}) {
|
|
|
|
$real_name = $mailmap->{names}->{$email};
|
|
|
|
}
|
|
|
|
if (exists $mailmap->{addresses}->{$email}) {
|
|
|
|
$real_address = $mailmap->{addresses}->{$email};
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if (exists $mailmap->{names}->{$address}) {
|
|
|
|
$real_name = $mailmap->{names}->{$address};
|
|
|
|
}
|
|
|
|
if (exists $mailmap->{addresses}->{$address}) {
|
|
|
|
$real_address = $mailmap->{addresses}->{$address};
|
2009-09-21 18:04:21 -06:00
|
|
|
}
|
2010-10-26 15:22:57 -06:00
|
|
|
}
|
|
|
|
return format_email($real_name, $real_address, 1);
|
2010-10-26 15:22:56 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
sub mailmap {
|
|
|
|
my (@addresses) = @_;
|
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
my @mapped_emails = ();
|
2010-10-26 15:22:56 -06:00
|
|
|
foreach my $line (@addresses) {
|
2010-10-26 15:22:58 -06:00
|
|
|
push(@mapped_emails, mailmap_email($line));
|
2009-09-21 18:04:21 -06:00
|
|
|
}
|
2010-10-26 15:22:58 -06:00
|
|
|
merge_by_realname(@mapped_emails) if ($email_use_mailmap);
|
|
|
|
return @mapped_emails;
|
2010-10-26 15:22:56 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
sub merge_by_realname {
|
2010-10-26 15:22:57 -06:00
|
|
|
my %address_map;
|
|
|
|
my (@emails) = @_;
|
2010-10-26 15:22:58 -06:00
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
foreach my $email (@emails) {
|
|
|
|
my ($name, $address) = parse_email($email);
|
2010-10-26 15:22:58 -06:00
|
|
|
if (exists $address_map{$name}) {
|
2010-10-26 15:22:57 -06:00
|
|
|
$address = $address_map{$name};
|
2010-10-26 15:22:58 -06:00
|
|
|
$email = format_email($name, $address, 1);
|
|
|
|
} else {
|
|
|
|
$address_map{$name} = $address;
|
2010-10-26 15:22:56 -06:00
|
|
|
}
|
2010-10-26 15:22:57 -06:00
|
|
|
}
|
2009-09-21 18:04:21 -06:00
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
sub git_execute_cmd {
|
|
|
|
my ($cmd) = @_;
|
|
|
|
my @lines = ();
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
my $output = `$cmd`;
|
|
|
|
$output =~ s/^\s*//gm;
|
|
|
|
@lines = split("\n", $output);
|
|
|
|
|
|
|
|
return @lines;
|
2009-12-14 19:00:49 -07:00
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
sub hg_execute_cmd {
|
2009-12-14 19:00:49 -07:00
|
|
|
my ($cmd) = @_;
|
2009-12-14 19:00:50 -07:00
|
|
|
my @lines = ();
|
|
|
|
|
|
|
|
my $output = `$cmd`;
|
|
|
|
@lines = split("\n", $output);
|
2009-12-14 19:00:49 -07:00
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
return @lines;
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
sub extract_formatted_signatures {
|
|
|
|
my (@signature_lines) = @_;
|
|
|
|
|
|
|
|
my @type = @signature_lines;
|
|
|
|
|
|
|
|
s/\s*(.*):.*/$1/ for (@type);
|
|
|
|
|
|
|
|
# cut -f2- -d":"
|
|
|
|
s/\s*.*:\s*(.+)\s*/$1/ for (@signature_lines);
|
|
|
|
|
|
|
|
## Reformat email addresses (with names) to avoid badly written signatures
|
|
|
|
|
|
|
|
foreach my $signer (@signature_lines) {
|
2010-10-26 15:22:58 -06:00
|
|
|
$signer = deduplicate_email($signer);
|
2010-10-26 15:22:55 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
return (\@type, \@signature_lines);
|
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
sub vcs_find_signers {
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my ($cmd, $file) = @_;
|
2009-12-14 19:00:49 -07:00
|
|
|
my $commits;
|
2010-10-26 15:22:55 -06:00
|
|
|
my @lines = ();
|
|
|
|
my @signatures = ();
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my @authors = ();
|
|
|
|
my @stats = ();
|
2009-12-14 19:00:49 -07:00
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
@lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
my $pattern = $VCS_cmds{"commit_pattern"};
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my $author_pattern = $VCS_cmds{"author_pattern"};
|
|
|
|
my $stat_pattern = $VCS_cmds{"stat_pattern"};
|
|
|
|
|
|
|
|
$stat_pattern =~ s/(\$\w+)/$1/eeg; #interpolate $stat_pattern
|
2009-04-07 21:40:12 -06:00
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
$commits = grep(/$pattern/, @lines); # of commits
|
2009-07-29 16:04:28 -06:00
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
@authors = grep(/$author_pattern/, @lines);
|
2010-10-26 15:22:55 -06:00
|
|
|
@signatures = grep(/^[ \t]*${signature_pattern}.*\@.*$/, @lines);
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
@stats = grep(/$stat_pattern/, @lines);
|
2010-10-26 15:22:51 -06:00
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
# print("stats: <@stats>\n");
|
|
|
|
|
|
|
|
return (0, \@signatures, \@authors, \@stats) if !@signatures;
|
2010-10-26 15:22:51 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
save_commits_by_author(@lines) if ($interactive);
|
|
|
|
save_commits_by_signer(@lines) if ($interactive);
|
2009-09-21 18:04:20 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
if (!$email_git_penguin_chiefs) {
|
|
|
|
@signatures = grep(!/${penguin_chiefs}/i, @signatures);
|
2009-12-14 19:00:49 -07:00
|
|
|
}
|
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my ($author_ref, $authors_ref) = extract_formatted_signatures(@authors);
|
2010-10-26 15:22:55 -06:00
|
|
|
my ($types_ref, $signers_ref) = extract_formatted_signatures(@signatures);
|
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
return ($commits, $signers_ref, $authors_ref, \@stats);
|
2009-12-14 19:00:49 -07:00
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:51 -06:00
|
|
|
sub vcs_find_author {
|
|
|
|
my ($cmd) = @_;
|
|
|
|
my @lines = ();
|
|
|
|
|
|
|
|
@lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
|
|
|
|
|
|
|
|
if (!$email_git_penguin_chiefs) {
|
|
|
|
@lines = grep(!/${penguin_chiefs}/i, @lines);
|
|
|
|
}
|
|
|
|
|
|
|
|
return @lines if !@lines;
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
my @authors = ();
|
2010-10-26 15:22:51 -06:00
|
|
|
foreach my $line (@lines) {
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($line =~ m/$VCS_cmds{"author_pattern"}/) {
|
|
|
|
my $author = $1;
|
|
|
|
my ($name, $address) = parse_email($author);
|
|
|
|
$author = format_email($name, $address, 1);
|
|
|
|
push(@authors, $author);
|
|
|
|
}
|
2010-10-26 15:22:51 -06:00
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
save_commits_by_author(@lines) if ($interactive);
|
|
|
|
save_commits_by_signer(@lines) if ($interactive);
|
|
|
|
|
|
|
|
return @authors;
|
2010-10-26 15:22:51 -06:00
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
sub vcs_save_commits {
|
|
|
|
my ($cmd) = @_;
|
|
|
|
my @lines = ();
|
|
|
|
my @commits = ();
|
|
|
|
|
|
|
|
@lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
|
|
|
|
|
|
|
|
foreach my $line (@lines) {
|
|
|
|
if ($line =~ m/$VCS_cmds{"blame_commit_pattern"}/) {
|
|
|
|
push(@commits, $1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return @commits;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub vcs_blame {
|
|
|
|
my ($file) = @_;
|
|
|
|
my $cmd;
|
|
|
|
my @commits = ();
|
|
|
|
|
|
|
|
return @commits if (!(-f $file));
|
|
|
|
|
|
|
|
if (@range && $VCS_cmds{"blame_range_cmd"} eq "") {
|
|
|
|
my @all_commits = ();
|
|
|
|
|
|
|
|
$cmd = $VCS_cmds{"blame_file_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; #interpolate $cmd
|
|
|
|
@all_commits = vcs_save_commits($cmd);
|
|
|
|
|
|
|
|
foreach my $file_range_diff (@range) {
|
|
|
|
next if (!($file_range_diff =~ m/(.+):(.+):(.+)/));
|
|
|
|
my $diff_file = $1;
|
|
|
|
my $diff_start = $2;
|
|
|
|
my $diff_length = $3;
|
|
|
|
next if ("$file" ne "$diff_file");
|
|
|
|
for (my $i = $diff_start; $i < $diff_start + $diff_length; $i++) {
|
|
|
|
push(@commits, $all_commits[$i]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} elsif (@range) {
|
|
|
|
foreach my $file_range_diff (@range) {
|
|
|
|
next if (!($file_range_diff =~ m/(.+):(.+):(.+)/));
|
|
|
|
my $diff_file = $1;
|
|
|
|
my $diff_start = $2;
|
|
|
|
my $diff_length = $3;
|
|
|
|
next if ("$file" ne "$diff_file");
|
|
|
|
$cmd = $VCS_cmds{"blame_range_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; #interpolate $cmd
|
|
|
|
push(@commits, vcs_save_commits($cmd));
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
$cmd = $VCS_cmds{"blame_file_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; #interpolate $cmd
|
|
|
|
@commits = vcs_save_commits($cmd);
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:51 -06:00
|
|
|
foreach my $commit (@commits) {
|
|
|
|
$commit =~ s/^\^//g;
|
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
return @commits;
|
|
|
|
}
|
|
|
|
|
|
|
|
my $printed_novcs = 0;
|
|
|
|
sub vcs_exists {
|
|
|
|
%VCS_cmds = %VCS_cmds_git;
|
|
|
|
return 1 if eval $VCS_cmds{"available"};
|
|
|
|
%VCS_cmds = %VCS_cmds_hg;
|
2010-10-26 15:22:55 -06:00
|
|
|
return 2 if eval $VCS_cmds{"available"};
|
2009-12-14 19:00:50 -07:00
|
|
|
%VCS_cmds = ();
|
|
|
|
if (!$printed_novcs) {
|
|
|
|
warn("$P: No supported VCS found. Add --nogit to options?\n");
|
|
|
|
warn("Using a git repository produces better results.\n");
|
|
|
|
warn("Try Linus Torvalds' latest git repository using:\n");
|
2011-08-25 16:59:07 -06:00
|
|
|
warn("git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git\n");
|
2009-12-14 19:00:50 -07:00
|
|
|
$printed_novcs = 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
sub vcs_is_git {
|
2010-10-26 15:22:58 -06:00
|
|
|
vcs_exists();
|
2010-10-26 15:22:55 -06:00
|
|
|
return $vcs_used == 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub vcs_is_hg {
|
|
|
|
return $vcs_used == 2;
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
sub interactive_get_maintainers {
|
2010-10-26 15:22:55 -06:00
|
|
|
my ($list_ref) = @_;
|
2010-10-26 15:22:54 -06:00
|
|
|
my @list = @$list_ref;
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
vcs_exists();
|
2010-10-26 15:22:54 -06:00
|
|
|
|
|
|
|
my %selected;
|
2010-10-26 15:22:55 -06:00
|
|
|
my %authored;
|
|
|
|
my %signed;
|
2010-10-26 15:22:54 -06:00
|
|
|
my $count = 0;
|
2010-10-26 15:22:56 -06:00
|
|
|
my $maintained = 0;
|
|
|
|
foreach my $entry (@list) {
|
2010-10-26 15:22:58 -06:00
|
|
|
$maintained = 1 if ($entry->[1] =~ /^(maintainer|supporter)/i);
|
|
|
|
$selected{$count} = 1;
|
2010-10-26 15:22:55 -06:00
|
|
|
$authored{$count} = 0;
|
|
|
|
$signed{$count} = 0;
|
|
|
|
$count++;
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
#menu loop
|
2010-10-26 15:22:55 -06:00
|
|
|
my $done = 0;
|
|
|
|
my $print_options = 0;
|
|
|
|
my $redraw = 1;
|
|
|
|
while (!$done) {
|
|
|
|
$count = 0;
|
|
|
|
if ($redraw) {
|
2010-10-26 15:22:56 -06:00
|
|
|
printf STDERR "\n%1s %2s %-65s",
|
|
|
|
"*", "#", "email/list and role:stats";
|
|
|
|
if ($email_git ||
|
|
|
|
($email_git_fallback && !$maintained) ||
|
|
|
|
$email_git_blame) {
|
|
|
|
print STDERR "auth sign";
|
|
|
|
}
|
|
|
|
print STDERR "\n";
|
2010-10-26 15:22:55 -06:00
|
|
|
foreach my $entry (@list) {
|
|
|
|
my $email = $entry->[0];
|
|
|
|
my $role = $entry->[1];
|
|
|
|
my $sel = "";
|
|
|
|
$sel = "*" if ($selected{$count});
|
|
|
|
my $commit_author = $commit_author_hash{$email};
|
|
|
|
my $commit_signer = $commit_signer_hash{$email};
|
|
|
|
my $authored = 0;
|
|
|
|
my $signed = 0;
|
|
|
|
$authored++ for (@{$commit_author});
|
|
|
|
$signed++ for (@{$commit_signer});
|
|
|
|
printf STDERR "%1s %2d %-65s", $sel, $count + 1, $email;
|
|
|
|
printf STDERR "%4d %4d", $authored, $signed
|
|
|
|
if ($authored > 0 || $signed > 0);
|
|
|
|
printf STDERR "\n %s\n", $role;
|
|
|
|
if ($authored{$count}) {
|
|
|
|
my $commit_author = $commit_author_hash{$email};
|
|
|
|
foreach my $ref (@{$commit_author}) {
|
|
|
|
print STDERR " Author: @{$ref}[1]\n";
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($signed{$count}) {
|
|
|
|
my $commit_signer = $commit_signer_hash{$email};
|
|
|
|
foreach my $ref (@{$commit_signer}) {
|
|
|
|
print STDERR " @{$ref}[2]: @{$ref}[1]\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$count++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
my $date_ref = \$email_git_since;
|
|
|
|
$date_ref = \$email_hg_since if (vcs_is_hg());
|
|
|
|
if ($print_options) {
|
|
|
|
$print_options = 0;
|
|
|
|
if (vcs_exists()) {
|
2010-10-26 15:22:58 -06:00
|
|
|
print STDERR <<EOT
|
|
|
|
|
|
|
|
Version Control options:
|
|
|
|
g use git history [$email_git]
|
|
|
|
gf use git-fallback [$email_git_fallback]
|
|
|
|
b use git blame [$email_git_blame]
|
|
|
|
bs use blame signatures [$email_git_blame_signatures]
|
|
|
|
c# minimum commits [$email_git_min_signatures]
|
|
|
|
%# min percent [$email_git_min_percent]
|
|
|
|
d# history to use [$$date_ref]
|
|
|
|
x# max maintainers [$email_git_max_maintainers]
|
|
|
|
t all signature types [$email_git_all_signature_types]
|
|
|
|
m use .mailmap [$email_use_mailmap]
|
|
|
|
EOT
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
2010-10-26 15:22:58 -06:00
|
|
|
print STDERR <<EOT
|
|
|
|
|
|
|
|
Additional options:
|
|
|
|
0 toggle all
|
|
|
|
tm toggle maintainers
|
|
|
|
tg toggle git entries
|
|
|
|
tl toggle open list entries
|
|
|
|
ts toggle subscriber list entries
|
|
|
|
f emails in file [$file_emails]
|
|
|
|
k keywords in file [$keywords]
|
|
|
|
r remove duplicates [$email_remove_duplicates]
|
|
|
|
p# pattern match depth [$pattern_depth]
|
|
|
|
EOT
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
print STDERR
|
|
|
|
"\n#(toggle), A#(author), S#(signed) *(all), ^(none), O(options), Y(approve): ";
|
|
|
|
|
|
|
|
my $input = <STDIN>;
|
2010-10-26 15:22:54 -06:00
|
|
|
chomp($input);
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
$redraw = 1;
|
|
|
|
my $rerun = 0;
|
|
|
|
my @wish = split(/[, ]+/, $input);
|
|
|
|
foreach my $nr (@wish) {
|
|
|
|
$nr = lc($nr);
|
|
|
|
my $sel = substr($nr, 0, 1);
|
|
|
|
my $str = substr($nr, 1);
|
|
|
|
my $val = 0;
|
|
|
|
$val = $1 if $str =~ /^(\d+)$/;
|
|
|
|
|
|
|
|
if ($sel eq "y") {
|
|
|
|
$interactive = 0;
|
|
|
|
$done = 1;
|
|
|
|
$output_rolestats = 0;
|
|
|
|
$output_roles = 0;
|
|
|
|
last;
|
|
|
|
} elsif ($nr =~ /^\d+$/ && $nr > 0 && $nr <= $count) {
|
|
|
|
$selected{$nr - 1} = !$selected{$nr - 1};
|
|
|
|
} elsif ($sel eq "*" || $sel eq '^') {
|
|
|
|
my $toggle = 0;
|
|
|
|
$toggle = 1 if ($sel eq '*');
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$selected{$i} = $toggle;
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
} elsif ($sel eq "0") {
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$selected{$i} = !$selected{$i};
|
|
|
|
}
|
2010-10-26 15:22:58 -06:00
|
|
|
} elsif ($sel eq "t") {
|
|
|
|
if (lc($str) eq "m") {
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$selected{$i} = !$selected{$i}
|
|
|
|
if ($list[$i]->[1] =~ /^(maintainer|supporter)/i);
|
|
|
|
}
|
|
|
|
} elsif (lc($str) eq "g") {
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$selected{$i} = !$selected{$i}
|
|
|
|
if ($list[$i]->[1] =~ /^(author|commit|signer)/i);
|
|
|
|
}
|
|
|
|
} elsif (lc($str) eq "l") {
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$selected{$i} = !$selected{$i}
|
|
|
|
if ($list[$i]->[1] =~ /^(open list)/i);
|
|
|
|
}
|
|
|
|
} elsif (lc($str) eq "s") {
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$selected{$i} = !$selected{$i}
|
|
|
|
if ($list[$i]->[1] =~ /^(subscriber list)/i);
|
|
|
|
}
|
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
} elsif ($sel eq "a") {
|
|
|
|
if ($val > 0 && $val <= $count) {
|
|
|
|
$authored{$val - 1} = !$authored{$val - 1};
|
|
|
|
} elsif ($str eq '*' || $str eq '^') {
|
|
|
|
my $toggle = 0;
|
|
|
|
$toggle = 1 if ($str eq '*');
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$authored{$i} = $toggle;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} elsif ($sel eq "s") {
|
|
|
|
if ($val > 0 && $val <= $count) {
|
|
|
|
$signed{$val - 1} = !$signed{$val - 1};
|
|
|
|
} elsif ($str eq '*' || $str eq '^') {
|
|
|
|
my $toggle = 0;
|
|
|
|
$toggle = 1 if ($str eq '*');
|
|
|
|
for (my $i = 0; $i < $count; $i++) {
|
|
|
|
$signed{$i} = $toggle;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} elsif ($sel eq "o") {
|
|
|
|
$print_options = 1;
|
|
|
|
$redraw = 1;
|
|
|
|
} elsif ($sel eq "g") {
|
|
|
|
if ($str eq "f") {
|
|
|
|
bool_invert(\$email_git_fallback);
|
2010-10-26 15:22:54 -06:00
|
|
|
} else {
|
2010-10-26 15:22:55 -06:00
|
|
|
bool_invert(\$email_git);
|
|
|
|
}
|
|
|
|
$rerun = 1;
|
|
|
|
} elsif ($sel eq "b") {
|
|
|
|
if ($str eq "s") {
|
|
|
|
bool_invert(\$email_git_blame_signatures);
|
|
|
|
} else {
|
|
|
|
bool_invert(\$email_git_blame);
|
|
|
|
}
|
|
|
|
$rerun = 1;
|
|
|
|
} elsif ($sel eq "c") {
|
|
|
|
if ($val > 0) {
|
|
|
|
$email_git_min_signatures = $val;
|
|
|
|
$rerun = 1;
|
|
|
|
}
|
|
|
|
} elsif ($sel eq "x") {
|
|
|
|
if ($val > 0) {
|
|
|
|
$email_git_max_maintainers = $val;
|
|
|
|
$rerun = 1;
|
|
|
|
}
|
|
|
|
} elsif ($sel eq "%") {
|
|
|
|
if ($str ne "" && $val >= 0) {
|
|
|
|
$email_git_min_percent = $val;
|
|
|
|
$rerun = 1;
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
} elsif ($sel eq "d") {
|
|
|
|
if (vcs_is_git()) {
|
|
|
|
$email_git_since = $str;
|
|
|
|
} elsif (vcs_is_hg()) {
|
|
|
|
$email_hg_since = $str;
|
|
|
|
}
|
|
|
|
$rerun = 1;
|
|
|
|
} elsif ($sel eq "t") {
|
|
|
|
bool_invert(\$email_git_all_signature_types);
|
|
|
|
$rerun = 1;
|
|
|
|
} elsif ($sel eq "f") {
|
|
|
|
bool_invert(\$file_emails);
|
|
|
|
$rerun = 1;
|
|
|
|
} elsif ($sel eq "r") {
|
|
|
|
bool_invert(\$email_remove_duplicates);
|
|
|
|
$rerun = 1;
|
2010-10-26 15:22:58 -06:00
|
|
|
} elsif ($sel eq "m") {
|
|
|
|
bool_invert(\$email_use_mailmap);
|
|
|
|
read_mailmap();
|
|
|
|
$rerun = 1;
|
2010-10-26 15:22:55 -06:00
|
|
|
} elsif ($sel eq "k") {
|
|
|
|
bool_invert(\$keywords);
|
|
|
|
$rerun = 1;
|
|
|
|
} elsif ($sel eq "p") {
|
|
|
|
if ($str ne "" && $val >= 0) {
|
|
|
|
$pattern_depth = $val;
|
|
|
|
$rerun = 1;
|
|
|
|
}
|
2010-10-26 15:22:56 -06:00
|
|
|
} elsif ($sel eq "h" || $sel eq "?") {
|
|
|
|
print STDERR <<EOT
|
|
|
|
|
|
|
|
Interactive mode allows you to select the various maintainers, submitters,
|
|
|
|
commit signers and mailing lists that could be CC'd on a patch.
|
|
|
|
|
|
|
|
Any *'d entry is selected.
|
|
|
|
|
2010-10-26 15:22:57 -06:00
|
|
|
If you have git or hg installed, you can choose to summarize the commit
|
2010-10-26 15:22:56 -06:00
|
|
|
history of files in the patch. Also, each line of the current file can
|
|
|
|
be matched to its commit author and that commits signers with blame.
|
|
|
|
|
|
|
|
Various knobs exist to control the length of time for active commit
|
|
|
|
tracking, the maximum number of commit authors and signers to add,
|
|
|
|
and such.
|
|
|
|
|
|
|
|
Enter selections at the prompt until you are satisfied that the selected
|
|
|
|
maintainers are appropriate. You may enter multiple selections separated
|
|
|
|
by either commas or spaces.
|
|
|
|
|
|
|
|
EOT
|
2010-10-26 15:22:55 -06:00
|
|
|
} else {
|
|
|
|
print STDERR "invalid option: '$nr'\n";
|
|
|
|
$redraw = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if ($rerun) {
|
|
|
|
print STDERR "git-blame can be very slow, please have patience..."
|
|
|
|
if ($email_git_blame);
|
2010-10-26 15:22:56 -06:00
|
|
|
goto &get_maintainers;
|
2010-10-26 15:22:55 -06:00
|
|
|
}
|
|
|
|
}
|
2010-10-26 15:22:54 -06:00
|
|
|
|
|
|
|
#drop not selected entries
|
|
|
|
$count = 0;
|
2010-10-26 15:22:55 -06:00
|
|
|
my @new_emailto = ();
|
|
|
|
foreach my $entry (@list) {
|
|
|
|
if ($selected{$count}) {
|
|
|
|
push(@new_emailto, $list[$count]);
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
|
|
|
$count++;
|
|
|
|
}
|
2010-10-26 15:22:55 -06:00
|
|
|
return @new_emailto;
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
sub bool_invert {
|
|
|
|
my ($bool_ref) = @_;
|
|
|
|
|
|
|
|
if ($$bool_ref) {
|
|
|
|
$$bool_ref = 0;
|
|
|
|
} else {
|
|
|
|
$$bool_ref = 1;
|
|
|
|
}
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
sub deduplicate_email {
|
|
|
|
my ($email) = @_;
|
|
|
|
|
|
|
|
my $matched = 0;
|
|
|
|
my ($name, $address) = parse_email($email);
|
|
|
|
$email = format_email($name, $address, 1);
|
|
|
|
$email = mailmap_email($email);
|
|
|
|
|
|
|
|
return $email if (!$email_remove_duplicates);
|
|
|
|
|
|
|
|
($name, $address) = parse_email($email);
|
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
if ($name ne "" && $deduplicate_name_hash{lc($name)}) {
|
2010-10-26 15:22:58 -06:00
|
|
|
$name = $deduplicate_name_hash{lc($name)}->[0];
|
|
|
|
$address = $deduplicate_name_hash{lc($name)}->[1];
|
|
|
|
$matched = 1;
|
|
|
|
} elsif ($deduplicate_address_hash{lc($address)}) {
|
|
|
|
$name = $deduplicate_address_hash{lc($address)}->[0];
|
|
|
|
$address = $deduplicate_address_hash{lc($address)}->[1];
|
|
|
|
$matched = 1;
|
|
|
|
}
|
|
|
|
if (!$matched) {
|
|
|
|
$deduplicate_name_hash{lc($name)} = [ $name, $address ];
|
|
|
|
$deduplicate_address_hash{lc($address)} = [ $name, $address ];
|
|
|
|
}
|
|
|
|
$email = format_email($name, $address, 1);
|
|
|
|
$email = mailmap_email($email);
|
|
|
|
return $email;
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
sub save_commits_by_author {
|
|
|
|
my (@lines) = @_;
|
|
|
|
|
|
|
|
my @authors = ();
|
|
|
|
my @commits = ();
|
|
|
|
my @subjects = ();
|
|
|
|
|
|
|
|
foreach my $line (@lines) {
|
|
|
|
if ($line =~ m/$VCS_cmds{"author_pattern"}/) {
|
|
|
|
my $author = $1;
|
2010-10-26 15:22:58 -06:00
|
|
|
$author = deduplicate_email($author);
|
2010-10-26 15:22:55 -06:00
|
|
|
push(@authors, $author);
|
|
|
|
}
|
|
|
|
push(@commits, $1) if ($line =~ m/$VCS_cmds{"commit_pattern"}/);
|
|
|
|
push(@subjects, $1) if ($line =~ m/$VCS_cmds{"subject_pattern"}/);
|
|
|
|
}
|
|
|
|
|
|
|
|
for (my $i = 0; $i < @authors; $i++) {
|
|
|
|
my $exists = 0;
|
|
|
|
foreach my $ref(@{$commit_author_hash{$authors[$i]}}) {
|
|
|
|
if (@{$ref}[0] eq $commits[$i] &&
|
|
|
|
@{$ref}[1] eq $subjects[$i]) {
|
|
|
|
$exists = 1;
|
|
|
|
last;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!$exists) {
|
|
|
|
push(@{$commit_author_hash{$authors[$i]}},
|
|
|
|
[ ($commits[$i], $subjects[$i]) ]);
|
|
|
|
}
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
sub save_commits_by_signer {
|
|
|
|
my (@lines) = @_;
|
|
|
|
|
|
|
|
my $commit = "";
|
|
|
|
my $subject = "";
|
2010-10-26 15:22:54 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
foreach my $line (@lines) {
|
|
|
|
$commit = $1 if ($line =~ m/$VCS_cmds{"commit_pattern"}/);
|
|
|
|
$subject = $1 if ($line =~ m/$VCS_cmds{"subject_pattern"}/);
|
|
|
|
if ($line =~ /^[ \t]*${signature_pattern}.*\@.*$/) {
|
|
|
|
my @signatures = ($line);
|
|
|
|
my ($types_ref, $signers_ref) = extract_formatted_signatures(@signatures);
|
|
|
|
my @types = @$types_ref;
|
|
|
|
my @signers = @$signers_ref;
|
|
|
|
|
|
|
|
my $type = $types[0];
|
|
|
|
my $signer = $signers[0];
|
|
|
|
|
2010-10-26 15:22:58 -06:00
|
|
|
$signer = deduplicate_email($signer);
|
2010-10-26 15:22:56 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
my $exists = 0;
|
|
|
|
foreach my $ref(@{$commit_signer_hash{$signer}}) {
|
|
|
|
if (@{$ref}[0] eq $commit &&
|
|
|
|
@{$ref}[1] eq $subject &&
|
|
|
|
@{$ref}[2] eq $type) {
|
|
|
|
$exists = 1;
|
|
|
|
last;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!$exists) {
|
|
|
|
push(@{$commit_signer_hash{$signer}},
|
|
|
|
[ ($commit, $subject, $type) ]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-10-26 15:22:54 -06:00
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
sub vcs_assign {
|
2009-12-14 19:00:49 -07:00
|
|
|
my ($role, $divisor, @lines) = @_;
|
|
|
|
|
|
|
|
my %hash;
|
|
|
|
my $count = 0;
|
|
|
|
|
|
|
|
return if (@lines <= 0);
|
|
|
|
|
|
|
|
if ($divisor <= 0) {
|
2009-12-14 19:00:50 -07:00
|
|
|
warn("Bad divisor in " . (caller(0))[3] . ": $divisor\n");
|
2009-12-14 19:00:49 -07:00
|
|
|
$divisor = 1;
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
}
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2010-10-26 15:22:56 -06:00
|
|
|
@lines = mailmap(@lines);
|
2009-09-21 18:04:20 -06:00
|
|
|
|
2010-10-26 15:22:51 -06:00
|
|
|
return if (@lines <= 0);
|
|
|
|
|
2009-09-21 18:04:20 -06:00
|
|
|
@lines = sort(@lines);
|
2009-09-21 18:04:22 -06:00
|
|
|
|
2009-09-21 18:04:20 -06:00
|
|
|
# uniq -c
|
2009-09-21 18:04:22 -06:00
|
|
|
$hash{$_}++ for @lines;
|
|
|
|
|
2009-09-21 18:04:20 -06:00
|
|
|
# sort -rn
|
|
|
|
foreach my $line (sort {$hash{$b} <=> $hash{$a}} keys %hash) {
|
2009-09-21 18:04:22 -06:00
|
|
|
my $sign_offs = $hash{$line};
|
2009-12-14 19:00:49 -07:00
|
|
|
my $percent = $sign_offs * 100 / $divisor;
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
|
2009-12-14 19:00:49 -07:00
|
|
|
$percent = 100 if ($percent > 100);
|
2015-06-25 16:01:50 -06:00
|
|
|
next if (ignore_email_address($line));
|
2009-09-21 18:04:22 -06:00
|
|
|
$count++;
|
|
|
|
last if ($sign_offs < $email_git_min_signatures ||
|
|
|
|
$count > $email_git_max_maintainers ||
|
2009-12-14 19:00:49 -07:00
|
|
|
$percent < $email_git_min_percent);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
push_email_address($line, '');
|
|
|
|
if ($output_rolestats) {
|
2009-12-14 19:00:49 -07:00
|
|
|
my $fmt_percent = sprintf("%.0f", $percent);
|
|
|
|
add_role($line, "$role:$sign_offs/$divisor=$fmt_percent%");
|
|
|
|
} else {
|
|
|
|
add_role($line, $role);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
}
|
2009-09-21 18:04:13 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
sub vcs_file_signoffs {
|
2009-12-14 19:00:49 -07:00
|
|
|
my ($file) = @_;
|
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my $authors_ref;
|
|
|
|
my $signers_ref;
|
|
|
|
my $stats_ref;
|
|
|
|
my @authors = ();
|
2009-12-14 19:00:49 -07:00
|
|
|
my @signers = ();
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my @stats = ();
|
2009-12-14 19:00:50 -07:00
|
|
|
my $commits;
|
2009-09-21 18:04:13 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
$vcs_used = vcs_exists();
|
|
|
|
return if (!$vcs_used);
|
2009-12-14 19:00:49 -07:00
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
my $cmd = $VCS_cmds{"find_signers_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; # interpolate $cmd
|
2009-09-21 18:04:13 -06:00
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
($commits, $signers_ref, $authors_ref, $stats_ref) = vcs_find_signers($cmd, $file);
|
|
|
|
|
|
|
|
@signers = @{$signers_ref} if defined $signers_ref;
|
|
|
|
@authors = @{$authors_ref} if defined $authors_ref;
|
|
|
|
@stats = @{$stats_ref} if defined $stats_ref;
|
|
|
|
|
|
|
|
# print("commits: <$commits>\nsigners:<@signers>\nauthors: <@authors>\nstats: <@stats>\n");
|
2010-10-26 15:22:58 -06:00
|
|
|
|
|
|
|
foreach my $signer (@signers) {
|
|
|
|
$signer = deduplicate_email($signer);
|
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
vcs_assign("commit_signer", $commits, @signers);
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
vcs_assign("authored", $commits, @authors);
|
|
|
|
if ($#authors == $#stats) {
|
|
|
|
my $stat_pattern = $VCS_cmds{"stat_pattern"};
|
|
|
|
$stat_pattern =~ s/(\$\w+)/$1/eeg; #interpolate $stat_pattern
|
|
|
|
|
|
|
|
my $added = 0;
|
|
|
|
my $deleted = 0;
|
|
|
|
for (my $i = 0; $i <= $#stats; $i++) {
|
|
|
|
if ($stats[$i] =~ /$stat_pattern/) {
|
|
|
|
$added += $1;
|
|
|
|
$deleted += $2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
my @tmp_authors = uniq(@authors);
|
|
|
|
foreach my $author (@tmp_authors) {
|
|
|
|
$author = deduplicate_email($author);
|
|
|
|
}
|
|
|
|
@tmp_authors = uniq(@tmp_authors);
|
|
|
|
my @list_added = ();
|
|
|
|
my @list_deleted = ();
|
|
|
|
foreach my $author (@tmp_authors) {
|
|
|
|
my $auth_added = 0;
|
|
|
|
my $auth_deleted = 0;
|
|
|
|
for (my $i = 0; $i <= $#stats; $i++) {
|
|
|
|
if ($author eq deduplicate_email($authors[$i]) &&
|
|
|
|
$stats[$i] =~ /$stat_pattern/) {
|
|
|
|
$auth_added += $1;
|
|
|
|
$auth_deleted += $2;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
for (my $i = 0; $i < $auth_added; $i++) {
|
|
|
|
push(@list_added, $author);
|
|
|
|
}
|
|
|
|
for (my $i = 0; $i < $auth_deleted; $i++) {
|
|
|
|
push(@list_deleted, $author);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
vcs_assign("added_lines", $added, @list_added);
|
|
|
|
vcs_assign("removed_lines", $deleted, @list_deleted);
|
|
|
|
}
|
2009-09-21 18:04:13 -06:00
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:50 -07:00
|
|
|
sub vcs_file_blame {
|
2009-09-21 18:04:13 -06:00
|
|
|
my ($file) = @_;
|
|
|
|
|
2009-12-14 19:00:49 -07:00
|
|
|
my @signers = ();
|
2010-10-26 15:22:51 -06:00
|
|
|
my @all_commits = ();
|
2009-12-14 19:00:50 -07:00
|
|
|
my @commits = ();
|
2009-12-14 19:00:49 -07:00
|
|
|
my $total_commits;
|
2010-10-26 15:22:51 -06:00
|
|
|
my $total_lines;
|
2009-09-21 18:04:13 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
$vcs_used = vcs_exists();
|
|
|
|
return if (!$vcs_used);
|
2009-09-21 18:04:13 -06:00
|
|
|
|
2010-10-26 15:22:51 -06:00
|
|
|
@all_commits = vcs_blame($file);
|
|
|
|
@commits = uniq(@all_commits);
|
2009-12-14 19:00:49 -07:00
|
|
|
$total_commits = @commits;
|
2010-10-26 15:22:51 -06:00
|
|
|
$total_lines = @all_commits;
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
if ($email_git_blame_signatures) {
|
|
|
|
if (vcs_is_hg()) {
|
|
|
|
my $commit_count;
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my $commit_authors_ref;
|
|
|
|
my $commit_signers_ref;
|
|
|
|
my $stats_ref;
|
|
|
|
my @commit_authors = ();
|
2010-10-26 15:22:55 -06:00
|
|
|
my @commit_signers = ();
|
|
|
|
my $commit = join(" -r ", @commits);
|
|
|
|
my $cmd;
|
2009-09-21 18:04:21 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
$cmd = $VCS_cmds{"find_commit_signers_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; #substitute variables in $cmd
|
2009-12-14 19:00:50 -07:00
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
($commit_count, $commit_signers_ref, $commit_authors_ref, $stats_ref) = vcs_find_signers($cmd, $file);
|
|
|
|
@commit_authors = @{$commit_authors_ref} if defined $commit_authors_ref;
|
|
|
|
@commit_signers = @{$commit_signers_ref} if defined $commit_signers_ref;
|
2010-10-26 15:22:51 -06:00
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
push(@signers, @commit_signers);
|
|
|
|
} else {
|
|
|
|
foreach my $commit (@commits) {
|
|
|
|
my $commit_count;
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
my $commit_authors_ref;
|
|
|
|
my $commit_signers_ref;
|
|
|
|
my $stats_ref;
|
|
|
|
my @commit_authors = ();
|
2010-10-26 15:22:55 -06:00
|
|
|
my @commit_signers = ();
|
|
|
|
my $cmd;
|
|
|
|
|
|
|
|
$cmd = $VCS_cmds{"find_commit_signers_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; #substitute variables in $cmd
|
|
|
|
|
get_maintainer: add commit author information to --rolestats
get_maintainer currently uses "Signed-off-by" style lines to find
interested parties to send patches to when the MAINTAINERS file does not
have a specific section entry with a matching file pattern.
Add statistics for commit authors and lines added and deleted to the
information provided by --rolestats.
These statistics are also emitted whenever --rolestats and --git are
selected even when there is a specified maintainer.
This can have the effect of expanding the number of people that are shown
as possible "maintainers" of a particular file because "authors",
"added_lines", and "removed_lines" are also used as criterion for the
--max-maintainers option separate from the "commit_signers".
The first "--git-max-maintainers" values of each criterion
are emitted. Any "ties" are not shown.
For example: (forcedeth does not have a named maintainer)
Old output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
New output:
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
"David S. Miller" <davem@davemloft.net> (commit_signer:8/10=80%)
Jiri Pirko <jiri@resnulli.us> (commit_signer:2/10=20%,authored:2/10=20%,removed_lines:3/33=9%)
Patrick McHardy <kaber@trash.net> (commit_signer:2/10=20%,authored:2/10=20%,added_lines:12/95=13%,removed_lines:10/33=30%)
Larry Finger <Larry.Finger@lwfinger.net> (commit_signer:1/10=10%,authored:1/10=10%,added_lines:35/95=37%)
Peter Zijlstra <peterz@infradead.org> (commit_signer:1/10=10%)
"Peter Hüwe" <PeterHuewe@gmx.de> (authored:1/10=10%,removed_lines:15/33=45%)
Joe Perches <joe@perches.com> (authored:1/10=10%)
Neil Horman <nhorman@tuxdriver.com> (added_lines:40/95=42%)
Bill Pemberton <wfp5p@virginia.edu> (removed_lines:3/33=9%)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-01-23 16:54:20 -07:00
|
|
|
($commit_count, $commit_signers_ref, $commit_authors_ref, $stats_ref) = vcs_find_signers($cmd, $file);
|
|
|
|
@commit_authors = @{$commit_authors_ref} if defined $commit_authors_ref;
|
|
|
|
@commit_signers = @{$commit_signers_ref} if defined $commit_signers_ref;
|
2010-10-26 15:22:55 -06:00
|
|
|
|
|
|
|
push(@signers, @commit_signers);
|
|
|
|
}
|
|
|
|
}
|
2009-09-21 18:04:13 -06:00
|
|
|
}
|
|
|
|
|
2009-12-14 19:00:49 -07:00
|
|
|
if ($from_filename) {
|
2010-10-26 15:22:51 -06:00
|
|
|
if ($output_rolestats) {
|
|
|
|
my @blame_signers;
|
2010-10-26 15:22:55 -06:00
|
|
|
if (vcs_is_hg()) {{ # Double brace for last exit
|
|
|
|
my $commit_count;
|
|
|
|
my @commit_signers = ();
|
|
|
|
@commits = uniq(@commits);
|
|
|
|
@commits = sort(@commits);
|
|
|
|
my $commit = join(" -r ", @commits);
|
|
|
|
my $cmd;
|
|
|
|
|
|
|
|
$cmd = $VCS_cmds{"find_commit_author_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; #substitute variables in $cmd
|
|
|
|
|
|
|
|
my @lines = ();
|
|
|
|
|
|
|
|
@lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
|
|
|
|
|
|
|
|
if (!$email_git_penguin_chiefs) {
|
|
|
|
@lines = grep(!/${penguin_chiefs}/i, @lines);
|
|
|
|
}
|
|
|
|
|
|
|
|
last if !@lines;
|
|
|
|
|
|
|
|
my @authors = ();
|
|
|
|
foreach my $line (@lines) {
|
|
|
|
if ($line =~ m/$VCS_cmds{"author_pattern"}/) {
|
|
|
|
my $author = $1;
|
2010-10-26 15:22:58 -06:00
|
|
|
$author = deduplicate_email($author);
|
|
|
|
push(@authors, $author);
|
2010-10-26 15:22:55 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
save_commits_by_author(@lines) if ($interactive);
|
|
|
|
save_commits_by_signer(@lines) if ($interactive);
|
|
|
|
|
|
|
|
push(@signers, @authors);
|
|
|
|
}}
|
|
|
|
else {
|
|
|
|
foreach my $commit (@commits) {
|
|
|
|
my $i;
|
|
|
|
my $cmd = $VCS_cmds{"find_commit_author_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; #interpolate $cmd
|
|
|
|
my @author = vcs_find_author($cmd);
|
|
|
|
next if !@author;
|
2010-10-26 15:22:58 -06:00
|
|
|
|
|
|
|
my $formatted_author = deduplicate_email($author[0]);
|
|
|
|
|
2010-10-26 15:22:55 -06:00
|
|
|
my $count = grep(/$commit/, @all_commits);
|
|
|
|
for ($i = 0; $i < $count ; $i++) {
|
2010-10-26 15:22:58 -06:00
|
|
|
push(@blame_signers, $formatted_author);
|
2010-10-26 15:22:55 -06:00
|
|
|
}
|
2010-10-26 15:22:51 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
if (@blame_signers) {
|
|
|
|
vcs_assign("authored lines", $total_lines, @blame_signers);
|
|
|
|
}
|
|
|
|
}
|
2010-10-26 15:22:58 -06:00
|
|
|
foreach my $signer (@signers) {
|
|
|
|
$signer = deduplicate_email($signer);
|
|
|
|
}
|
2009-12-14 19:00:50 -07:00
|
|
|
vcs_assign("commits", $total_commits, @signers);
|
2009-12-14 19:00:49 -07:00
|
|
|
} else {
|
2010-10-26 15:22:58 -06:00
|
|
|
foreach my $signer (@signers) {
|
|
|
|
$signer = deduplicate_email($signer);
|
|
|
|
}
|
2009-12-14 19:00:50 -07:00
|
|
|
vcs_assign("modified commits", $total_commits, @signers);
|
2009-04-07 21:40:12 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-08-02 15:04:10 -06:00
|
|
|
sub vcs_file_exists {
|
|
|
|
my ($file) = @_;
|
|
|
|
|
|
|
|
my $exists;
|
|
|
|
|
|
|
|
my $vcs_used = vcs_exists();
|
|
|
|
return 0 if (!$vcs_used);
|
|
|
|
|
|
|
|
my $cmd = $VCS_cmds{"file_exists_cmd"};
|
|
|
|
$cmd =~ s/(\$\w+)/$1/eeg; # interpolate $cmd
|
|
|
|
|
|
|
|
$exists = &{$VCS_cmds{"execute_cmd"}}($cmd);
|
|
|
|
|
|
|
|
return $exists;
|
|
|
|
}
|
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
sub uniq {
|
2009-12-14 19:00:49 -07:00
|
|
|
my (@parms) = @_;
|
2009-04-07 21:40:12 -06:00
|
|
|
|
|
|
|
my %saw;
|
|
|
|
@parms = grep(!$saw{$_}++, @parms);
|
|
|
|
return @parms;
|
|
|
|
}
|
|
|
|
|
|
|
|
sub sort_and_uniq {
|
2009-12-14 19:00:49 -07:00
|
|
|
my (@parms) = @_;
|
2009-04-07 21:40:12 -06:00
|
|
|
|
|
|
|
my %saw;
|
|
|
|
@parms = sort @parms;
|
|
|
|
@parms = grep(!$saw{$_}++, @parms);
|
|
|
|
return @parms;
|
|
|
|
}
|
|
|
|
|
2010-03-05 14:43:00 -07:00
|
|
|
sub clean_file_emails {
|
|
|
|
my (@file_emails) = @_;
|
|
|
|
my @fmt_emails = ();
|
|
|
|
|
|
|
|
foreach my $email (@file_emails) {
|
|
|
|
$email =~ s/[\(\<\{]{0,1}([A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+)[\)\>\}]{0,1}/\<$1\>/g;
|
|
|
|
my ($name, $address) = parse_email($email);
|
|
|
|
if ($name eq '"[,\.]"') {
|
|
|
|
$name = "";
|
|
|
|
}
|
|
|
|
|
|
|
|
my @nw = split(/[^A-Za-zÀ-ÿ\'\,\.\+-]/, $name);
|
|
|
|
if (@nw > 2) {
|
|
|
|
my $first = $nw[@nw - 3];
|
|
|
|
my $middle = $nw[@nw - 2];
|
|
|
|
my $last = $nw[@nw - 1];
|
|
|
|
|
|
|
|
if (((length($first) == 1 && $first =~ m/[A-Za-z]/) ||
|
|
|
|
(length($first) == 2 && substr($first, -1) eq ".")) ||
|
|
|
|
(length($middle) == 1 ||
|
|
|
|
(length($middle) == 2 && substr($middle, -1) eq "."))) {
|
|
|
|
$name = "$first $middle $last";
|
|
|
|
} else {
|
|
|
|
$name = "$middle $last";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (substr($name, -1) =~ /[,\.]/) {
|
|
|
|
$name = substr($name, 0, length($name) - 1);
|
|
|
|
} elsif (substr($name, -2) =~ /[,\.]"/) {
|
|
|
|
$name = substr($name, 0, length($name) - 2) . '"';
|
|
|
|
}
|
|
|
|
|
|
|
|
if (substr($name, 0, 1) =~ /[,\.]/) {
|
|
|
|
$name = substr($name, 1, length($name) - 1);
|
|
|
|
} elsif (substr($name, 0, 2) =~ /"[,\.]/) {
|
|
|
|
$name = '"' . substr($name, 2, length($name) - 2);
|
|
|
|
}
|
|
|
|
|
|
|
|
my $fmt_email = format_email($name, $address, $email_usename);
|
|
|
|
push(@fmt_emails, $fmt_email);
|
|
|
|
}
|
|
|
|
return @fmt_emails;
|
|
|
|
}
|
|
|
|
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
sub merge_email {
|
|
|
|
my @lines;
|
|
|
|
my %saw;
|
|
|
|
|
|
|
|
for (@_) {
|
|
|
|
my ($address, $role) = @$_;
|
|
|
|
if (!$saw{$address}) {
|
|
|
|
if ($output_roles) {
|
2009-12-14 19:00:50 -07:00
|
|
|
push(@lines, "$address ($role)");
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
} else {
|
2009-12-14 19:00:50 -07:00
|
|
|
push(@lines, $address);
|
scripts/get_maintainer.pl: add --roles and --rolestats
--roles shows the role of each email address, i.e. why it was selected.
--rolestats selects --roles and adds git log/blame signers #'s and %
Multiple roles are possible (supporter, maintainer, git-signer...)
--roles or --rolestats is meant to help identify appropriate maintainers
to notify and should not be used with "git send-email --cc-cmd"
Example output:
Existing:
$ ./scripts/get_maintainer.pl -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net>
Karol Kozimor <sziwan@users.sourceforge.net>
Len Brown <len.brown@intel.com>
Pavel Machek <pavel@ucw.cz>
Rafael J. Wysocki <rjw@sisk.pl>
Thomas Gleixner <tglx@linutronix.de>
Ingo Molnar <mingo@redhat.com>
H. Peter Anvin <hpa@zytor.com>
x86@kernel.org
Yinghai Lu <yhlu.kernel@gmail.com>
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
acpi4asus-user@lists.sourceforge.net
linux-pm@lists.linux-foundation.org
linux-kernel@vger.kernel.org
With --roles
$ ./scripts/get_maintainer.pl --roles -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats
$ ./scripts/get_maintainer.pl --rolestats -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
With --rolestats and --git-blame
$ ./scripts/get_maintainer.pl --rolestats --git-blame -f arch/x86/kernel/acpi/boot.c
Corentin Chary <corentincj@iksaif.net> (maintainer:ASUS ACPI EXTRAS...)
Karol Kozimor <sziwan@users.sourceforge.net> (maintainer:ASUS ACPI EXTRAS...)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM,git-signer:16/79=20%,commits:22/154=14%)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
Rafael J. Wysocki <rjw@sisk.pl> (supporter:SUSPEND TO RAM)
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...,git-signer:29/79=37%,commits:36/154=23%)
H. Peter Anvin <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Yinghai Lu <yhlu.kernel@gmail.com> (git-signer:12/79=15%,commits:9/154=6%)
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (git-signer:6/79=8%)
Andi Kleen <ak@suse.de> (commits:11/154=7%)
Andrew Morton <akpm@osdl.org> (commits:10/154=6%)
acpi4asus-user@lists.sourceforge.net (open list:ASUS ACPI EXTRAS...)
linux-pm@lists.linux-foundation.org (open list:SUSPEND TO RAM)
linux-kernel@vger.kernel.org (open list)
Other changes:
Format git-signers email addresses a bit to reduce bad signatures
Command line bad arguments emitted a verbose usage(), just show --help
Version number bumped to .22
Ben Hutchings had the idea and created a good deal of this implementation.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-14 19:00:46 -07:00
|
|
|
}
|
|
|
|
$saw{$address} = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return @lines;
|
|
|
|
}
|
|
|
|
|
2009-04-07 21:40:12 -06:00
|
|
|
sub output {
|
2009-12-14 19:00:49 -07:00
|
|
|
my (@parms) = @_;
|
2009-04-07 21:40:12 -06:00
|
|
|
|
|
|
|
if ($output_multiline) {
|
|
|
|
foreach my $line (@parms) {
|
|
|
|
print("${line}\n");
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
print(join($output_separator, @parms));
|
|
|
|
print("\n");
|
|
|
|
}
|
|
|
|
}
|
2009-06-16 16:34:01 -06:00
|
|
|
|
|
|
|
my $rfc822re;
|
|
|
|
|
|
|
|
sub make_rfc822re {
|
|
|
|
# Basic lexical tokens are specials, domain_literal, quoted_string, atom, and
|
|
|
|
# comment. We must allow for rfc822_lwsp (or comments) after each of these.
|
|
|
|
# This regexp will only work on addresses which have had comments stripped
|
|
|
|
# and replaced with rfc822_lwsp.
|
|
|
|
|
|
|
|
my $specials = '()<>@,;:\\\\".\\[\\]';
|
|
|
|
my $controls = '\\000-\\037\\177';
|
|
|
|
|
|
|
|
my $dtext = "[^\\[\\]\\r\\\\]";
|
|
|
|
my $domain_literal = "\\[(?:$dtext|\\\\.)*\\]$rfc822_lwsp*";
|
|
|
|
|
|
|
|
my $quoted_string = "\"(?:[^\\\"\\r\\\\]|\\\\.|$rfc822_lwsp)*\"$rfc822_lwsp*";
|
|
|
|
|
|
|
|
# Use zero-width assertion to spot the limit of an atom. A simple
|
|
|
|
# $rfc822_lwsp* causes the regexp engine to hang occasionally.
|
|
|
|
my $atom = "[^$specials $controls]+(?:$rfc822_lwsp+|\\Z|(?=[\\[\"$specials]))";
|
|
|
|
my $word = "(?:$atom|$quoted_string)";
|
|
|
|
my $localpart = "$word(?:\\.$rfc822_lwsp*$word)*";
|
|
|
|
|
|
|
|
my $sub_domain = "(?:$atom|$domain_literal)";
|
|
|
|
my $domain = "$sub_domain(?:\\.$rfc822_lwsp*$sub_domain)*";
|
|
|
|
|
|
|
|
my $addr_spec = "$localpart\@$rfc822_lwsp*$domain";
|
|
|
|
|
|
|
|
my $phrase = "$word*";
|
|
|
|
my $route = "(?:\@$domain(?:,\@$rfc822_lwsp*$domain)*:$rfc822_lwsp*)";
|
|
|
|
my $route_addr = "\\<$rfc822_lwsp*$route?$addr_spec\\>$rfc822_lwsp*";
|
|
|
|
my $mailbox = "(?:$addr_spec|$phrase$route_addr)";
|
|
|
|
|
|
|
|
my $group = "$phrase:$rfc822_lwsp*(?:$mailbox(?:,\\s*$mailbox)*)?;\\s*";
|
|
|
|
my $address = "(?:$mailbox|$group)";
|
|
|
|
|
|
|
|
return "$rfc822_lwsp*$address";
|
|
|
|
}
|
|
|
|
|
|
|
|
sub rfc822_strip_comments {
|
|
|
|
my $s = shift;
|
|
|
|
# Recursively remove comments, and replace with a single space. The simpler
|
|
|
|
# regexps in the Email Addressing FAQ are imperfect - they will miss escaped
|
|
|
|
# chars in atoms, for example.
|
|
|
|
|
|
|
|
while ($s =~ s/^((?:[^"\\]|\\.)*
|
|
|
|
(?:"(?:[^"\\]|\\.)*"(?:[^"\\]|\\.)*)*)
|
|
|
|
\((?:[^()\\]|\\.)*\)/$1 /osx) {}
|
|
|
|
return $s;
|
|
|
|
}
|
|
|
|
|
|
|
|
# valid: returns true if the parameter is an RFC822 valid address
|
|
|
|
#
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
sub rfc822_valid {
|
2009-06-16 16:34:01 -06:00
|
|
|
my $s = rfc822_strip_comments(shift);
|
|
|
|
|
|
|
|
if (!$rfc822re) {
|
|
|
|
$rfc822re = make_rfc822re();
|
|
|
|
}
|
|
|
|
|
|
|
|
return $s =~ m/^$rfc822re$/so && $s =~ m/^$rfc822_char*$/;
|
|
|
|
}
|
|
|
|
|
|
|
|
# validlist: In scalar context, returns true if the parameter is an RFC822
|
|
|
|
# valid list of addresses.
|
|
|
|
#
|
|
|
|
# In list context, returns an empty list on failure (an invalid
|
|
|
|
# address was found); otherwise a list whose first element is the
|
|
|
|
# number of addresses found and whose remaining elements are the
|
|
|
|
# addresses. This is needed to disambiguate failure (invalid)
|
|
|
|
# from success with no addresses found, because an empty string is
|
|
|
|
# a valid list.
|
|
|
|
|
get_maintainer: fix perlcritic warnings
perlcritic is a standard checker for Perl Best Practices. This patch
fixes most of the warnings in the get_maintainer script. If kernel
programmers are going to have checkpatch they should write clean scripts
as well...
Bareword file handle opened at line 176, column 1. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 176, column 1. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 207, column 5. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 207, column 5. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 246, column 6. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 246, column 6. See page 207 of PBP. (Severity: 5)
Bareword file handle opened at line 258, column 2. See pages 202,204 of PBP. (Severity: 5)
Two-argument "open" used at line 258, column 2. See page 207 of PBP. (Severity: 5)
Expression form of "eval" at line 983, column 17. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 985, column 17. See page 161 of PBP. (Severity: 5)
Subroutine prototypes used at line 1186, column 1. See page 194 of PBP. (Severity: 5)
Subroutine prototypes used at line 1206, column 1. See page 194 of PBP. (Severity: 5)
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-05 14:43:06 -07:00
|
|
|
sub rfc822_validlist {
|
2009-06-16 16:34:01 -06:00
|
|
|
my $s = rfc822_strip_comments(shift);
|
|
|
|
|
|
|
|
if (!$rfc822re) {
|
|
|
|
$rfc822re = make_rfc822re();
|
|
|
|
}
|
|
|
|
# * null list items are valid according to the RFC
|
|
|
|
# * the '1' business is to aid in distinguishing failure from no results
|
|
|
|
|
|
|
|
my @r;
|
|
|
|
if ($s =~ m/^(?:$rfc822re)?(?:,(?:$rfc822re)?)*$/so &&
|
|
|
|
$s =~ m/^$rfc822_char*$/) {
|
2009-06-16 16:34:02 -06:00
|
|
|
while ($s =~ m/(?:^|,$rfc822_lwsp*)($rfc822re)/gos) {
|
2009-12-14 19:00:50 -07:00
|
|
|
push(@r, $1);
|
2009-06-16 16:34:01 -06:00
|
|
|
}
|
|
|
|
return wantarray ? (scalar(@r), @r) : 1;
|
|
|
|
}
|
2009-12-14 19:00:50 -07:00
|
|
|
return wantarray ? () : 0;
|
2009-06-16 16:34:01 -06:00
|
|
|
}
|