2005-04-16 16:20:36 -06:00
|
|
|
/*
|
2014-06-14 18:42:19 -06:00
|
|
|
* ec.c - ACPI Embedded Controller Driver (v2.2)
|
2005-04-16 16:20:36 -06:00
|
|
|
*
|
2014-06-14 18:42:19 -06:00
|
|
|
* Copyright (C) 2001-2014 Intel Corporation
|
|
|
|
* Author: 2014 Lv Zheng <lv.zheng@intel.com>
|
|
|
|
* 2006, 2007 Alexey Starikovskiy <alexey.y.starikovskiy@intel.com>
|
|
|
|
* 2006 Denis Sadykov <denis.m.sadykov@intel.com>
|
|
|
|
* 2004 Luming Yu <luming.yu@intel.com>
|
|
|
|
* 2001, 2002 Andy Grover <andrew.grover@intel.com>
|
|
|
|
* 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
|
|
|
|
* Copyright (C) 2008 Alexey Starikovskiy <astarikovskiy@suse.de>
|
2005-04-16 16:20:36 -06:00
|
|
|
*
|
|
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or (at
|
|
|
|
* your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful, but
|
|
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
|
|
* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
|
|
|
|
*
|
|
|
|
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
*/
|
|
|
|
|
2008-09-25 11:00:31 -06:00
|
|
|
/* Uncomment next line to get verbose printout */
|
2008-01-23 20:34:09 -07:00
|
|
|
/* #define DEBUG */
|
2013-09-12 01:32:04 -06:00
|
|
|
#define pr_fmt(fmt) "ACPI : EC: " fmt
|
2008-01-23 20:34:09 -07:00
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/delay.h>
|
2005-03-18 23:10:05 -07:00
|
|
|
#include <linux/interrupt.h>
|
2007-05-29 06:43:02 -06:00
|
|
|
#include <linux/list.h>
|
2008-09-25 11:00:31 -06:00
|
|
|
#include <linux/spinlock.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 02:04:11 -06:00
|
|
|
#include <linux/slab.h>
|
2013-12-02 17:49:16 -07:00
|
|
|
#include <linux/acpi.h>
|
2009-07-06 21:40:19 -06:00
|
|
|
#include <linux/dmi.h>
|
2013-12-02 17:49:16 -07:00
|
|
|
#include <asm/io.h>
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2010-07-16 05:11:31 -06:00
|
|
|
#include "internal.h"
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
#define ACPI_EC_CLASS "embedded_controller"
|
|
|
|
#define ACPI_EC_DEVICE_NAME "Embedded Controller"
|
|
|
|
#define ACPI_EC_FILE_INFO "info"
|
2007-05-29 06:43:02 -06:00
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
/* EC status register */
|
2005-04-16 16:20:36 -06:00
|
|
|
#define ACPI_EC_FLAG_OBF 0x01 /* Output buffer full */
|
|
|
|
#define ACPI_EC_FLAG_IBF 0x02 /* Input buffer full */
|
2014-06-14 18:42:42 -06:00
|
|
|
#define ACPI_EC_FLAG_CMD 0x08 /* Input buffer contains a command */
|
2005-03-18 23:10:05 -07:00
|
|
|
#define ACPI_EC_FLAG_BURST 0x10 /* burst mode */
|
2005-04-16 16:20:36 -06:00
|
|
|
#define ACPI_EC_FLAG_SCI 0x20 /* EC-SCI occurred */
|
2007-05-29 06:42:57 -06:00
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
/* EC commands */
|
2006-12-07 08:42:17 -07:00
|
|
|
enum ec_command {
|
2006-12-07 08:42:17 -07:00
|
|
|
ACPI_EC_COMMAND_READ = 0x80,
|
|
|
|
ACPI_EC_COMMAND_WRITE = 0x81,
|
|
|
|
ACPI_EC_BURST_ENABLE = 0x82,
|
|
|
|
ACPI_EC_BURST_DISABLE = 0x83,
|
|
|
|
ACPI_EC_COMMAND_QUERY = 0x84,
|
2006-12-07 08:42:17 -07:00
|
|
|
};
|
2007-05-29 06:43:02 -06:00
|
|
|
|
2006-12-07 08:42:16 -07:00
|
|
|
#define ACPI_EC_DELAY 500 /* Wait 500ms max. during EC ops */
|
2006-09-26 09:50:33 -06:00
|
|
|
#define ACPI_EC_UDELAY_GLK 1000 /* Wait 1ms max. to get global lock */
|
2009-08-29 17:06:14 -06:00
|
|
|
#define ACPI_EC_MSI_UDELAY 550 /* Wait 550us for MSI EC */
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
#define ACPI_EC_CLEAR_MAX 100 /* Maximum number of events to query
|
|
|
|
* when trying to clear the EC */
|
2006-09-26 09:50:33 -06:00
|
|
|
|
2007-10-22 04:18:30 -06:00
|
|
|
enum {
|
|
|
|
EC_FLAGS_QUERY_PENDING, /* Query is pending */
|
2008-09-25 11:00:31 -06:00
|
|
|
EC_FLAGS_GPE_STORM, /* GPE storm detected */
|
2010-03-03 17:52:58 -07:00
|
|
|
EC_FLAGS_HANDLERS_INSTALLED, /* Handlers for GPE and
|
2008-09-25 11:00:31 -06:00
|
|
|
* OpReg are installed */
|
2010-04-08 17:40:38 -06:00
|
|
|
EC_FLAGS_BLOCKED, /* Transactions are blocked */
|
2005-04-16 16:20:36 -06:00
|
|
|
};
|
2006-09-26 09:50:33 -06:00
|
|
|
|
2014-06-14 18:41:35 -06:00
|
|
|
#define ACPI_EC_COMMAND_POLL 0x01 /* Available for command byte */
|
|
|
|
#define ACPI_EC_COMMAND_COMPLETE 0x02 /* Completed last byte */
|
|
|
|
|
2010-10-21 10:24:57 -06:00
|
|
|
/* ec.c is compiled in acpi namespace so this shows up as acpi.ec_delay param */
|
|
|
|
static unsigned int ec_delay __read_mostly = ACPI_EC_DELAY;
|
|
|
|
module_param(ec_delay, uint, 0644);
|
|
|
|
MODULE_PARM_DESC(ec_delay, "Timeout(ms) waited until an EC command completes");
|
|
|
|
|
2012-09-28 01:22:00 -06:00
|
|
|
/*
|
|
|
|
* If the number of false interrupts per one transaction exceeds
|
|
|
|
* this threshold, will think there is a GPE storm happened and
|
|
|
|
* will disable the GPE for normal transaction.
|
|
|
|
*/
|
|
|
|
static unsigned int ec_storm_threshold __read_mostly = 8;
|
|
|
|
module_param(ec_storm_threshold, uint, 0644);
|
|
|
|
MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");
|
|
|
|
|
2007-05-29 06:43:02 -06:00
|
|
|
struct acpi_ec_query_handler {
|
|
|
|
struct list_head node;
|
|
|
|
acpi_ec_query_func func;
|
|
|
|
acpi_handle handle;
|
|
|
|
void *data;
|
|
|
|
u8 query_bit;
|
|
|
|
};
|
|
|
|
|
2008-09-25 14:54:28 -06:00
|
|
|
struct transaction {
|
2008-09-25 11:00:31 -06:00
|
|
|
const u8 *wdata;
|
|
|
|
u8 *rdata;
|
|
|
|
unsigned short irq_count;
|
2008-09-25 14:54:28 -06:00
|
|
|
u8 command;
|
2008-11-11 15:40:19 -07:00
|
|
|
u8 wi;
|
|
|
|
u8 ri;
|
2008-09-25 11:00:31 -06:00
|
|
|
u8 wlen;
|
|
|
|
u8 rlen;
|
2014-06-14 18:41:35 -06:00
|
|
|
u8 flags;
|
2008-09-25 11:00:31 -06:00
|
|
|
};
|
|
|
|
|
2010-07-16 05:11:31 -06:00
|
|
|
struct acpi_ec *boot_ec, *first_ec;
|
|
|
|
EXPORT_SYMBOL(first_ec);
|
2006-09-26 09:50:33 -06:00
|
|
|
|
2009-02-21 10:18:13 -07:00
|
|
|
static int EC_FLAGS_MSI; /* Out-of-spec MSI controller */
|
2009-10-02 10:21:33 -06:00
|
|
|
static int EC_FLAGS_VALIDATE_ECDT; /* ASUStec ECDTs need to be validated */
|
2009-10-02 10:21:40 -06:00
|
|
|
static int EC_FLAGS_SKIP_DSDT_SCAN; /* Not all BIOS survive early DSDT scan */
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
static int EC_FLAGS_CLEAR_ON_RESUME; /* Needs acpi_ec_clear() on boot/resume */
|
2009-02-21 10:18:13 -07:00
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/* --------------------------------------------------------------------------
|
|
|
|
Transaction Management
|
|
|
|
-------------------------------------------------------------------------- */
|
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
static inline u8 acpi_ec_read_status(struct acpi_ec *ec)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-11-20 17:23:26 -07:00
|
|
|
u8 x = inb(ec->command_addr);
|
2014-06-14 18:42:42 -06:00
|
|
|
pr_debug("EC_SC(R) = 0x%2.2x "
|
|
|
|
"SCI_EVT=%d BURST=%d CMD=%d IBF=%d OBF=%d\n",
|
|
|
|
x,
|
|
|
|
!!(x & ACPI_EC_FLAG_SCI),
|
|
|
|
!!(x & ACPI_EC_FLAG_BURST),
|
|
|
|
!!(x & ACPI_EC_FLAG_CMD),
|
|
|
|
!!(x & ACPI_EC_FLAG_IBF),
|
|
|
|
!!(x & ACPI_EC_FLAG_OBF));
|
2007-11-20 17:23:26 -07:00
|
|
|
return x;
|
2005-03-18 23:10:05 -07:00
|
|
|
}
|
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
static inline u8 acpi_ec_read_data(struct acpi_ec *ec)
|
2006-09-26 09:50:33 -06:00
|
|
|
{
|
2007-11-20 17:23:26 -07:00
|
|
|
u8 x = inb(ec->data_addr);
|
2014-06-14 18:42:42 -06:00
|
|
|
pr_debug("EC_DATA(R) = 0x%2.2x\n", x);
|
2008-09-25 11:00:31 -06:00
|
|
|
return x;
|
2006-09-26 09:50:33 -06:00
|
|
|
}
|
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
static inline void acpi_ec_write_cmd(struct acpi_ec *ec, u8 command)
|
2005-07-23 02:08:00 -06:00
|
|
|
{
|
2014-06-14 18:42:42 -06:00
|
|
|
pr_debug("EC_SC(W) = 0x%2.2x\n", command);
|
2006-09-26 09:50:33 -06:00
|
|
|
outb(command, ec->command_addr);
|
2005-07-23 02:08:00 -06:00
|
|
|
}
|
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
static inline void acpi_ec_write_data(struct acpi_ec *ec, u8 data)
|
2005-07-23 02:08:00 -06:00
|
|
|
{
|
2014-06-14 18:42:42 -06:00
|
|
|
pr_debug("EC_DATA(W) = 0x%2.2x\n", data);
|
2006-09-26 09:50:33 -06:00
|
|
|
outb(data, ec->data_addr);
|
2006-09-26 09:50:33 -06:00
|
|
|
}
|
2005-07-23 02:08:00 -06:00
|
|
|
|
2014-06-14 18:41:35 -06:00
|
|
|
static int ec_transaction_completed(struct acpi_ec *ec)
|
2006-09-26 09:50:33 -06:00
|
|
|
{
|
2008-09-25 11:00:31 -06:00
|
|
|
unsigned long flags;
|
|
|
|
int ret = 0;
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_lock_irqsave(&ec->lock, flags);
|
2014-06-14 18:42:07 -06:00
|
|
|
if (ec->curr && (ec->curr->flags & ACPI_EC_COMMAND_COMPLETE))
|
2008-09-25 11:00:31 -06:00
|
|
|
ret = 1;
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_unlock_irqrestore(&ec->lock, flags);
|
2008-09-25 11:00:31 -06:00
|
|
|
return ret;
|
2005-07-23 02:08:00 -06:00
|
|
|
}
|
2005-03-18 23:10:05 -07:00
|
|
|
|
2014-06-14 18:42:07 -06:00
|
|
|
static bool advance_transaction(struct acpi_ec *ec)
|
2006-09-26 09:50:33 -06:00
|
|
|
{
|
2013-11-15 12:41:29 -07:00
|
|
|
struct transaction *t;
|
2014-06-14 18:41:17 -06:00
|
|
|
u8 status;
|
2014-06-14 18:42:07 -06:00
|
|
|
bool wakeup = false;
|
2012-10-22 17:29:38 -06:00
|
|
|
|
2014-06-14 18:41:17 -06:00
|
|
|
pr_debug("===== %s =====\n", in_interrupt() ? "IRQ" : "TASK");
|
|
|
|
status = acpi_ec_read_status(ec);
|
2013-11-15 12:41:29 -07:00
|
|
|
t = ec->curr;
|
2012-10-22 17:29:38 -06:00
|
|
|
if (!t)
|
2014-06-14 18:41:35 -06:00
|
|
|
goto err;
|
|
|
|
if (t->flags & ACPI_EC_COMMAND_POLL) {
|
|
|
|
if (t->wlen > t->wi) {
|
|
|
|
if ((status & ACPI_EC_FLAG_IBF) == 0)
|
|
|
|
acpi_ec_write_data(ec, t->wdata[t->wi++]);
|
|
|
|
else
|
|
|
|
goto err;
|
|
|
|
} else if (t->rlen > t->ri) {
|
|
|
|
if ((status & ACPI_EC_FLAG_OBF) == 1) {
|
|
|
|
t->rdata[t->ri++] = acpi_ec_read_data(ec);
|
2014-06-14 18:42:07 -06:00
|
|
|
if (t->rlen == t->ri) {
|
2014-06-14 18:41:35 -06:00
|
|
|
t->flags |= ACPI_EC_COMMAND_COMPLETE;
|
2014-06-14 18:42:07 -06:00
|
|
|
wakeup = true;
|
|
|
|
}
|
2014-06-14 18:41:35 -06:00
|
|
|
} else
|
|
|
|
goto err;
|
|
|
|
} else if (t->wlen == t->wi &&
|
2014-06-14 18:42:07 -06:00
|
|
|
(status & ACPI_EC_FLAG_IBF) == 0) {
|
2014-06-14 18:41:35 -06:00
|
|
|
t->flags |= ACPI_EC_COMMAND_COMPLETE;
|
2014-06-14 18:42:07 -06:00
|
|
|
wakeup = true;
|
|
|
|
}
|
|
|
|
return wakeup;
|
2014-06-14 18:41:35 -06:00
|
|
|
} else {
|
|
|
|
if ((status & ACPI_EC_FLAG_IBF) == 0) {
|
|
|
|
acpi_ec_write_cmd(ec, t->command);
|
|
|
|
t->flags |= ACPI_EC_COMMAND_POLL;
|
2008-09-25 11:00:31 -06:00
|
|
|
} else
|
2008-11-08 11:42:30 -07:00
|
|
|
goto err;
|
2014-06-14 18:42:07 -06:00
|
|
|
return wakeup;
|
2014-06-14 18:41:35 -06:00
|
|
|
}
|
2008-11-08 11:42:30 -07:00
|
|
|
err:
|
2012-10-22 17:30:12 -06:00
|
|
|
/*
|
|
|
|
* If SCI bit is set, then don't think it's a false IRQ
|
|
|
|
* otherwise will take a not handled IRQ as a false one.
|
|
|
|
*/
|
2014-06-14 18:41:35 -06:00
|
|
|
if (!(status & ACPI_EC_FLAG_SCI)) {
|
|
|
|
if (in_interrupt() && t)
|
|
|
|
++t->irq_count;
|
|
|
|
}
|
2014-06-14 18:42:07 -06:00
|
|
|
return wakeup;
|
2014-06-14 18:41:35 -06:00
|
|
|
}
|
2012-10-22 17:30:12 -06:00
|
|
|
|
2014-06-14 18:41:35 -06:00
|
|
|
static void start_transaction(struct acpi_ec *ec)
|
|
|
|
{
|
|
|
|
ec->curr->irq_count = ec->curr->wi = ec->curr->ri = 0;
|
|
|
|
ec->curr->flags = 0;
|
2014-06-14 18:42:07 -06:00
|
|
|
(void)advance_transaction(ec);
|
2008-03-21 08:07:03 -06:00
|
|
|
}
|
2008-01-23 20:28:34 -07:00
|
|
|
|
2014-04-29 08:51:20 -06:00
|
|
|
static int acpi_ec_sync_query(struct acpi_ec *ec, u8 *data);
|
2008-09-25 11:00:31 -06:00
|
|
|
|
2009-12-24 01:34:16 -07:00
|
|
|
static int ec_check_sci_sync(struct acpi_ec *ec, u8 state)
|
2006-09-26 09:50:33 -06:00
|
|
|
{
|
2008-09-25 11:00:31 -06:00
|
|
|
if (state & ACPI_EC_FLAG_SCI) {
|
|
|
|
if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags))
|
2014-04-29 08:51:20 -06:00
|
|
|
return acpi_ec_sync_query(ec, NULL);
|
2008-09-25 11:00:31 -06:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ec_poll(struct acpi_ec *ec)
|
|
|
|
{
|
2009-08-29 17:06:14 -06:00
|
|
|
unsigned long flags;
|
2013-05-05 21:23:40 -06:00
|
|
|
int repeat = 5; /* number of command restarts */
|
2009-08-29 17:06:14 -06:00
|
|
|
while (repeat--) {
|
|
|
|
unsigned long delay = jiffies +
|
2010-10-21 10:24:57 -06:00
|
|
|
msecs_to_jiffies(ec_delay);
|
2009-08-29 17:06:14 -06:00
|
|
|
do {
|
|
|
|
/* don't sleep with disabled interrupts */
|
|
|
|
if (EC_FLAGS_MSI || irqs_disabled()) {
|
|
|
|
udelay(ACPI_EC_MSI_UDELAY);
|
2014-06-14 18:41:35 -06:00
|
|
|
if (ec_transaction_completed(ec))
|
2009-08-29 17:06:14 -06:00
|
|
|
return 0;
|
|
|
|
} else {
|
|
|
|
if (wait_event_timeout(ec->wait,
|
2014-06-14 18:41:35 -06:00
|
|
|
ec_transaction_completed(ec),
|
2009-08-29 17:06:14 -06:00
|
|
|
msecs_to_jiffies(1)))
|
|
|
|
return 0;
|
|
|
|
}
|
2014-06-14 18:41:35 -06:00
|
|
|
spin_lock_irqsave(&ec->lock, flags);
|
2014-06-14 18:42:07 -06:00
|
|
|
(void)advance_transaction(ec);
|
2014-06-14 18:41:35 -06:00
|
|
|
spin_unlock_irqrestore(&ec->lock, flags);
|
2009-08-29 17:06:14 -06:00
|
|
|
} while (time_before(jiffies, delay));
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("controller reset, restart transaction\n");
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_lock_irqsave(&ec->lock, flags);
|
2009-08-29 17:06:14 -06:00
|
|
|
start_transaction(ec);
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_unlock_irqrestore(&ec->lock, flags);
|
2006-12-07 08:42:16 -07:00
|
|
|
}
|
2008-03-21 08:07:15 -06:00
|
|
|
return -ETIME;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2008-09-25 14:54:28 -06:00
|
|
|
static int acpi_ec_transaction_unlocked(struct acpi_ec *ec,
|
2009-08-29 17:06:14 -06:00
|
|
|
struct transaction *t)
|
2005-07-23 02:08:00 -06:00
|
|
|
{
|
2008-09-25 11:00:31 -06:00
|
|
|
unsigned long tmp;
|
|
|
|
int ret = 0;
|
2009-02-21 10:18:13 -07:00
|
|
|
if (EC_FLAGS_MSI)
|
2009-08-29 17:06:14 -06:00
|
|
|
udelay(ACPI_EC_MSI_UDELAY);
|
2008-09-25 11:00:31 -06:00
|
|
|
/* start transaction */
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_lock_irqsave(&ec->lock, tmp);
|
2008-09-25 11:00:31 -06:00
|
|
|
/* following two actions should be kept atomic */
|
2008-09-25 14:54:28 -06:00
|
|
|
ec->curr = t;
|
2008-11-11 15:40:19 -07:00
|
|
|
start_transaction(ec);
|
2008-09-25 14:54:28 -06:00
|
|
|
if (ec->curr->command == ACPI_EC_COMMAND_QUERY)
|
2007-10-22 04:18:30 -06:00
|
|
|
clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_unlock_irqrestore(&ec->lock, tmp);
|
2009-08-29 17:06:14 -06:00
|
|
|
ret = ec_poll(ec);
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_lock_irqsave(&ec->lock, tmp);
|
2008-09-25 14:54:28 -06:00
|
|
|
ec->curr = NULL;
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_unlock_irqrestore(&ec->lock, tmp);
|
2008-09-25 11:00:31 -06:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2009-08-29 17:06:14 -06:00
|
|
|
static int acpi_ec_transaction(struct acpi_ec *ec, struct transaction *t)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2006-09-05 10:12:24 -06:00
|
|
|
int status;
|
2005-08-11 15:32:05 -06:00
|
|
|
u32 glk;
|
2008-09-25 14:54:28 -06:00
|
|
|
if (!ec || (!t) || (t->wlen && !t->wdata) || (t->rlen && !t->rdata))
|
2006-06-26 22:41:40 -06:00
|
|
|
return -EINVAL;
|
2008-09-25 14:54:28 -06:00
|
|
|
if (t->rdata)
|
|
|
|
memset(t->rdata, 0, t->rlen);
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_lock(&ec->mutex);
|
2010-04-08 17:40:38 -06:00
|
|
|
if (test_bit(EC_FLAGS_BLOCKED, &ec->flags)) {
|
2010-03-03 17:52:58 -07:00
|
|
|
status = -EINVAL;
|
|
|
|
goto unlock;
|
|
|
|
}
|
2006-09-26 09:50:33 -06:00
|
|
|
if (ec->global_lock) {
|
2005-04-16 16:20:36 -06:00
|
|
|
status = acpi_acquire_global_lock(ACPI_EC_UDELAY_GLK, &glk);
|
2007-02-15 13:16:18 -07:00
|
|
|
if (ACPI_FAILURE(status)) {
|
2008-09-25 11:00:31 -06:00
|
|
|
status = -ENODEV;
|
|
|
|
goto unlock;
|
2007-02-15 13:16:18 -07:00
|
|
|
}
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("transaction start (cmd=0x%02x, addr=0x%02x)\n",
|
2012-10-22 17:29:38 -06:00
|
|
|
t->command, t->wdata ? t->wdata[0] : 0);
|
2009-12-24 01:34:16 -07:00
|
|
|
/* disable GPE during transaction if storm is detected */
|
|
|
|
if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
|
2010-06-24 17:21:42 -06:00
|
|
|
/* It has to be disabled, so that it doesn't trigger. */
|
|
|
|
acpi_disable_gpe(NULL, ec->gpe);
|
2009-12-24 01:34:16 -07:00
|
|
|
}
|
|
|
|
|
2009-08-29 17:06:14 -06:00
|
|
|
status = acpi_ec_transaction_unlocked(ec, t);
|
2009-12-24 01:34:16 -07:00
|
|
|
|
|
|
|
/* check if we received SCI during transaction */
|
|
|
|
ec_check_sci_sync(ec, acpi_ec_read_status(ec));
|
|
|
|
if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
|
2009-12-30 05:53:10 -07:00
|
|
|
msleep(1);
|
2010-06-24 17:21:42 -06:00
|
|
|
/* It is safe to enable the GPE outside of the transaction. */
|
|
|
|
acpi_enable_gpe(NULL, ec->gpe);
|
2012-09-28 01:22:00 -06:00
|
|
|
} else if (t->irq_count > ec_storm_threshold) {
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_info("GPE storm detected(%d GPEs), "
|
2012-10-22 17:29:38 -06:00
|
|
|
"transactions will use polling mode\n",
|
|
|
|
t->irq_count);
|
2009-12-24 01:34:16 -07:00
|
|
|
set_bit(EC_FLAGS_GPE_STORM, &ec->flags);
|
|
|
|
}
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("transaction end\n");
|
2006-09-26 09:50:33 -06:00
|
|
|
if (ec->global_lock)
|
2005-04-16 16:20:36 -06:00
|
|
|
acpi_release_global_lock(glk);
|
2008-09-25 11:00:31 -06:00
|
|
|
unlock:
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_unlock(&ec->mutex);
|
2006-06-26 22:41:40 -06:00
|
|
|
return status;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2008-12-09 12:45:30 -07:00
|
|
|
static int acpi_ec_burst_enable(struct acpi_ec *ec)
|
2007-03-07 12:28:00 -07:00
|
|
|
{
|
|
|
|
u8 d;
|
2008-09-25 14:54:28 -06:00
|
|
|
struct transaction t = {.command = ACPI_EC_BURST_ENABLE,
|
|
|
|
.wdata = NULL, .rdata = &d,
|
|
|
|
.wlen = 0, .rlen = 1};
|
|
|
|
|
2009-08-29 17:06:14 -06:00
|
|
|
return acpi_ec_transaction(ec, &t);
|
2007-03-07 12:28:00 -07:00
|
|
|
}
|
|
|
|
|
2008-12-09 12:45:30 -07:00
|
|
|
static int acpi_ec_burst_disable(struct acpi_ec *ec)
|
2007-03-07 12:28:00 -07:00
|
|
|
{
|
2008-09-25 14:54:28 -06:00
|
|
|
struct transaction t = {.command = ACPI_EC_BURST_DISABLE,
|
|
|
|
.wdata = NULL, .rdata = NULL,
|
|
|
|
.wlen = 0, .rlen = 0};
|
|
|
|
|
2008-09-25 11:00:31 -06:00
|
|
|
return (acpi_ec_read_status(ec) & ACPI_EC_FLAG_BURST) ?
|
2009-08-29 17:06:14 -06:00
|
|
|
acpi_ec_transaction(ec, &t) : 0;
|
2007-03-07 12:28:00 -07:00
|
|
|
}
|
|
|
|
|
2006-12-07 08:42:17 -07:00
|
|
|
static int acpi_ec_read(struct acpi_ec *ec, u8 address, u8 * data)
|
2006-09-26 09:50:33 -06:00
|
|
|
{
|
|
|
|
int result;
|
|
|
|
u8 d;
|
2008-09-25 14:54:28 -06:00
|
|
|
struct transaction t = {.command = ACPI_EC_COMMAND_READ,
|
|
|
|
.wdata = &address, .rdata = &d,
|
|
|
|
.wlen = 1, .rlen = 1};
|
2006-09-26 09:50:33 -06:00
|
|
|
|
2009-08-29 17:06:14 -06:00
|
|
|
result = acpi_ec_transaction(ec, &t);
|
2006-09-26 09:50:33 -06:00
|
|
|
*data = d;
|
|
|
|
return result;
|
|
|
|
}
|
2006-09-26 09:50:33 -06:00
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
static int acpi_ec_write(struct acpi_ec *ec, u8 address, u8 data)
|
|
|
|
{
|
2006-12-07 08:42:17 -07:00
|
|
|
u8 wdata[2] = { address, data };
|
2008-09-25 14:54:28 -06:00
|
|
|
struct transaction t = {.command = ACPI_EC_COMMAND_WRITE,
|
|
|
|
.wdata = wdata, .rdata = NULL,
|
|
|
|
.wlen = 2, .rlen = 0};
|
|
|
|
|
2009-08-29 17:06:14 -06:00
|
|
|
return acpi_ec_transaction(ec, &t);
|
2006-09-26 09:50:33 -06:00
|
|
|
}
|
|
|
|
|
2012-10-22 17:29:38 -06:00
|
|
|
int ec_read(u8 addr, u8 *val)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
int err;
|
2006-09-26 09:50:33 -06:00
|
|
|
u8 temp_data;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
if (!first_ec)
|
|
|
|
return -ENODEV;
|
|
|
|
|
2007-03-07 12:28:00 -07:00
|
|
|
err = acpi_ec_read(first_ec, addr, &temp_data);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
if (!err) {
|
|
|
|
*val = temp_data;
|
|
|
|
return 0;
|
2005-08-11 15:32:05 -06:00
|
|
|
} else
|
2005-04-16 16:20:36 -06:00
|
|
|
return err;
|
|
|
|
}
|
2005-08-11 15:32:05 -06:00
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
EXPORT_SYMBOL(ec_read);
|
|
|
|
|
2005-08-11 15:32:05 -06:00
|
|
|
int ec_write(u8 addr, u8 val)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
|
|
|
if (!first_ec)
|
|
|
|
return -ENODEV;
|
|
|
|
|
2007-03-07 12:28:00 -07:00
|
|
|
err = acpi_ec_write(first_ec, addr, val);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
2005-08-11 15:32:05 -06:00
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
EXPORT_SYMBOL(ec_write);
|
|
|
|
|
2006-10-26 23:47:34 -06:00
|
|
|
int ec_transaction(u8 command,
|
2007-03-07 16:29:35 -07:00
|
|
|
const u8 * wdata, unsigned wdata_len,
|
2011-03-31 05:36:38 -06:00
|
|
|
u8 * rdata, unsigned rdata_len)
|
2005-07-23 02:08:00 -06:00
|
|
|
{
|
2008-09-25 14:54:28 -06:00
|
|
|
struct transaction t = {.command = command,
|
|
|
|
.wdata = wdata, .rdata = rdata,
|
|
|
|
.wlen = wdata_len, .rlen = rdata_len};
|
2006-09-05 10:12:24 -06:00
|
|
|
if (!first_ec)
|
|
|
|
return -ENODEV;
|
2005-07-23 02:08:00 -06:00
|
|
|
|
2009-08-29 17:06:14 -06:00
|
|
|
return acpi_ec_transaction(first_ec, &t);
|
2005-07-23 02:08:00 -06:00
|
|
|
}
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2006-10-03 20:49:00 -06:00
|
|
|
EXPORT_SYMBOL(ec_transaction);
|
|
|
|
|
2012-01-18 12:44:08 -07:00
|
|
|
/* Get the handle to the EC device */
|
|
|
|
acpi_handle ec_get_handle(void)
|
|
|
|
{
|
|
|
|
if (!first_ec)
|
|
|
|
return NULL;
|
|
|
|
return first_ec->handle;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(ec_get_handle);
|
|
|
|
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
/*
|
2014-04-29 08:51:20 -06:00
|
|
|
* Process _Q events that might have accumulated in the EC.
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
* Run with locked ec mutex.
|
|
|
|
*/
|
|
|
|
static void acpi_ec_clear(struct acpi_ec *ec)
|
|
|
|
{
|
|
|
|
int i, status;
|
|
|
|
u8 value = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < ACPI_EC_CLEAR_MAX; i++) {
|
2014-04-29 08:51:20 -06:00
|
|
|
status = acpi_ec_sync_query(ec, &value);
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
if (status || !value)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (unlikely(i == ACPI_EC_CLEAR_MAX))
|
|
|
|
pr_warn("Warning: Maximum of %d stale EC events cleared\n", i);
|
|
|
|
else
|
|
|
|
pr_info("%d stale EC events cleared\n", i);
|
|
|
|
}
|
|
|
|
|
2010-04-08 17:40:38 -06:00
|
|
|
void acpi_ec_block_transactions(void)
|
2010-03-03 17:52:58 -07:00
|
|
|
{
|
|
|
|
struct acpi_ec *ec = first_ec;
|
|
|
|
|
|
|
|
if (!ec)
|
|
|
|
return;
|
|
|
|
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_lock(&ec->mutex);
|
2010-03-03 17:52:58 -07:00
|
|
|
/* Prevent transactions from being carried out */
|
2010-04-08 17:40:38 -06:00
|
|
|
set_bit(EC_FLAGS_BLOCKED, &ec->flags);
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_unlock(&ec->mutex);
|
2010-03-03 17:52:58 -07:00
|
|
|
}
|
|
|
|
|
2010-04-08 17:40:38 -06:00
|
|
|
void acpi_ec_unblock_transactions(void)
|
2010-03-03 17:52:58 -07:00
|
|
|
{
|
|
|
|
struct acpi_ec *ec = first_ec;
|
|
|
|
|
|
|
|
if (!ec)
|
|
|
|
return;
|
|
|
|
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_lock(&ec->mutex);
|
2010-03-03 17:52:58 -07:00
|
|
|
/* Allow transactions to be carried out again */
|
2010-04-08 17:40:38 -06:00
|
|
|
clear_bit(EC_FLAGS_BLOCKED, &ec->flags);
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
|
|
|
|
if (EC_FLAGS_CLEAR_ON_RESUME)
|
|
|
|
acpi_ec_clear(ec);
|
|
|
|
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_unlock(&ec->mutex);
|
2010-03-03 17:52:58 -07:00
|
|
|
}
|
|
|
|
|
2010-04-08 17:40:38 -06:00
|
|
|
void acpi_ec_unblock_transactions_early(void)
|
2010-04-08 17:39:40 -06:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Allow transactions to happen again (this function is called from
|
|
|
|
* atomic context during wakeup, so we don't need to acquire the mutex).
|
|
|
|
*/
|
|
|
|
if (first_ec)
|
2010-04-08 17:40:38 -06:00
|
|
|
clear_bit(EC_FLAGS_BLOCKED, &first_ec->flags);
|
2010-04-08 17:39:40 -06:00
|
|
|
}
|
|
|
|
|
2009-12-24 01:34:16 -07:00
|
|
|
static int acpi_ec_query_unlocked(struct acpi_ec *ec, u8 * data)
|
2006-09-26 09:50:33 -06:00
|
|
|
{
|
|
|
|
int result;
|
2006-12-07 08:42:17 -07:00
|
|
|
u8 d;
|
2008-09-25 14:54:28 -06:00
|
|
|
struct transaction t = {.command = ACPI_EC_COMMAND_QUERY,
|
|
|
|
.wdata = NULL, .rdata = &d,
|
|
|
|
.wlen = 0, .rlen = 1};
|
2006-12-07 08:42:17 -07:00
|
|
|
if (!ec || !data)
|
|
|
|
return -EINVAL;
|
|
|
|
/*
|
|
|
|
* Query the EC to find out which _Qxx method we need to evaluate.
|
|
|
|
* Note that successful completion of the query causes the ACPI_EC_SCI
|
|
|
|
* bit to be cleared (and thus clearing the interrupt source).
|
|
|
|
*/
|
2009-12-24 01:34:16 -07:00
|
|
|
result = acpi_ec_transaction_unlocked(ec, &t);
|
2006-12-07 08:42:17 -07:00
|
|
|
if (result)
|
|
|
|
return result;
|
|
|
|
if (!d)
|
|
|
|
return -ENODATA;
|
|
|
|
*data = d;
|
|
|
|
return 0;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/* --------------------------------------------------------------------------
|
|
|
|
Event Management
|
|
|
|
-------------------------------------------------------------------------- */
|
2007-05-29 06:43:02 -06:00
|
|
|
int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit,
|
|
|
|
acpi_handle handle, acpi_ec_query_func func,
|
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
struct acpi_ec_query_handler *handler =
|
|
|
|
kzalloc(sizeof(struct acpi_ec_query_handler), GFP_KERNEL);
|
|
|
|
if (!handler)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
handler->query_bit = query_bit;
|
|
|
|
handler->handle = handle;
|
|
|
|
handler->func = func;
|
|
|
|
handler->data = data;
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_lock(&ec->mutex);
|
2007-09-26 09:43:22 -06:00
|
|
|
list_add(&handler->node, &ec->list);
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_unlock(&ec->mutex);
|
2007-05-29 06:43:02 -06:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL_GPL(acpi_ec_add_query_handler);
|
|
|
|
|
|
|
|
void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit)
|
|
|
|
{
|
2007-10-24 10:26:00 -06:00
|
|
|
struct acpi_ec_query_handler *handler, *tmp;
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_lock(&ec->mutex);
|
2007-10-24 10:26:00 -06:00
|
|
|
list_for_each_entry_safe(handler, tmp, &ec->list, node) {
|
2007-05-29 06:43:02 -06:00
|
|
|
if (query_bit == handler->query_bit) {
|
|
|
|
list_del(&handler->node);
|
|
|
|
kfree(handler);
|
|
|
|
}
|
|
|
|
}
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_unlock(&ec->mutex);
|
2007-05-29 06:43:02 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2009-12-24 01:34:16 -07:00
|
|
|
static void acpi_ec_run(void *cxt)
|
2005-07-23 02:08:00 -06:00
|
|
|
{
|
2009-12-24 01:34:16 -07:00
|
|
|
struct acpi_ec_query_handler *handler = cxt;
|
|
|
|
if (!handler)
|
2006-12-07 08:42:16 -07:00
|
|
|
return;
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("start query execution\n");
|
2009-12-24 01:34:16 -07:00
|
|
|
if (handler->func)
|
|
|
|
handler->func(handler->data);
|
|
|
|
else if (handler->handle)
|
|
|
|
acpi_evaluate_object(handler->handle, NULL, NULL, NULL);
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("stop query execution\n");
|
2009-12-24 01:34:16 -07:00
|
|
|
kfree(handler);
|
|
|
|
}
|
|
|
|
|
2014-04-29 08:51:20 -06:00
|
|
|
static int acpi_ec_sync_query(struct acpi_ec *ec, u8 *data)
|
2009-12-24 01:34:16 -07:00
|
|
|
{
|
|
|
|
u8 value = 0;
|
|
|
|
int status;
|
|
|
|
struct acpi_ec_query_handler *handler, *copy;
|
2014-04-29 08:51:20 -06:00
|
|
|
|
|
|
|
status = acpi_ec_query_unlocked(ec, &value);
|
|
|
|
if (data)
|
|
|
|
*data = value;
|
|
|
|
if (status)
|
2009-12-24 01:34:16 -07:00
|
|
|
return status;
|
2014-04-29 08:51:20 -06:00
|
|
|
|
2007-05-29 06:43:02 -06:00
|
|
|
list_for_each_entry(handler, &ec->list, node) {
|
|
|
|
if (value == handler->query_bit) {
|
|
|
|
/* have custom handler for this bit */
|
2009-12-24 01:34:16 -07:00
|
|
|
copy = kmalloc(sizeof(*handler), GFP_KERNEL);
|
|
|
|
if (!copy)
|
|
|
|
return -ENOMEM;
|
|
|
|
memcpy(copy, handler, sizeof(*copy));
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("push query execution (0x%2x) on queue\n",
|
|
|
|
value);
|
2009-12-30 05:53:03 -07:00
|
|
|
return acpi_os_execute((copy->func) ?
|
|
|
|
OSL_NOTIFY_HANDLER : OSL_GPE_HANDLER,
|
2009-12-24 01:34:16 -07:00
|
|
|
acpi_ec_run, copy);
|
2007-05-29 06:43:02 -06:00
|
|
|
}
|
|
|
|
}
|
2009-12-24 01:34:16 -07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void acpi_ec_gpe_query(void *ec_cxt)
|
|
|
|
{
|
|
|
|
struct acpi_ec *ec = ec_cxt;
|
|
|
|
if (!ec)
|
|
|
|
return;
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_lock(&ec->mutex);
|
2014-04-29 08:51:20 -06:00
|
|
|
acpi_ec_sync_query(ec, NULL);
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_unlock(&ec->mutex);
|
2005-07-23 02:08:00 -06:00
|
|
|
}
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2009-12-24 01:34:16 -07:00
|
|
|
static int ec_check_sci(struct acpi_ec *ec, u8 state)
|
|
|
|
{
|
|
|
|
if (state & ACPI_EC_FLAG_SCI) {
|
|
|
|
if (!test_and_set_bit(EC_FLAGS_QUERY_PENDING, &ec->flags)) {
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("push gpe query to the queue\n");
|
2009-12-24 01:34:16 -07:00
|
|
|
return acpi_os_execute(OSL_NOTIFY_HANDLER,
|
|
|
|
acpi_ec_gpe_query, ec);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-12-12 22:38:46 -07:00
|
|
|
static u32 acpi_ec_gpe_handler(acpi_handle gpe_device,
|
|
|
|
u32 gpe_number, void *data)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2014-06-14 18:41:35 -06:00
|
|
|
unsigned long flags;
|
2007-03-07 12:28:00 -07:00
|
|
|
struct acpi_ec *ec = data;
|
2008-09-25 11:00:31 -06:00
|
|
|
|
2014-06-14 18:41:35 -06:00
|
|
|
spin_lock_irqsave(&ec->lock, flags);
|
2014-06-14 18:42:07 -06:00
|
|
|
if (advance_transaction(ec))
|
2009-08-29 17:06:14 -06:00
|
|
|
wake_up(&ec->wait);
|
2014-06-14 18:42:07 -06:00
|
|
|
spin_unlock_irqrestore(&ec->lock, flags);
|
|
|
|
ec_check_sci(ec, acpi_ec_read_status(ec));
|
2010-12-12 22:39:17 -07:00
|
|
|
return ACPI_INTERRUPT_HANDLED | ACPI_REENABLE_GPE;
|
2008-03-21 08:07:03 -06:00
|
|
|
}
|
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
/* --------------------------------------------------------------------------
|
|
|
|
Address Space Management
|
|
|
|
-------------------------------------------------------------------------- */
|
|
|
|
|
|
|
|
static acpi_status
|
2007-05-29 06:42:52 -06:00
|
|
|
acpi_ec_space_handler(u32 function, acpi_physical_address address,
|
2010-03-17 11:14:13 -06:00
|
|
|
u32 bits, u64 *value64,
|
2005-08-11 15:32:05 -06:00
|
|
|
void *handler_context, void *region_context)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-03-07 12:28:00 -07:00
|
|
|
struct acpi_ec *ec = handler_context;
|
2010-03-17 11:14:13 -06:00
|
|
|
int result = 0, i, bytes = bits / 8;
|
|
|
|
u8 *value = (u8 *)value64;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
if ((address > 0xFF) || !value || !handler_context)
|
2006-06-26 22:41:40 -06:00
|
|
|
return AE_BAD_PARAMETER;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-05-29 06:42:52 -06:00
|
|
|
if (function != ACPI_READ && function != ACPI_WRITE)
|
2006-06-26 22:41:40 -06:00
|
|
|
return AE_BAD_PARAMETER;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2010-03-17 11:14:13 -06:00
|
|
|
if (EC_FLAGS_MSI || bits > 8)
|
2009-08-28 13:29:44 -06:00
|
|
|
acpi_ec_burst_enable(ec);
|
2008-01-10 16:42:57 -07:00
|
|
|
|
2010-03-17 11:14:13 -06:00
|
|
|
for (i = 0; i < bytes; ++i, ++address, ++value)
|
|
|
|
result = (function == ACPI_READ) ?
|
|
|
|
acpi_ec_read(ec, address, value) :
|
|
|
|
acpi_ec_write(ec, address, *value);
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2010-03-17 11:14:13 -06:00
|
|
|
if (EC_FLAGS_MSI || bits > 8)
|
2009-08-28 13:29:44 -06:00
|
|
|
acpi_ec_burst_disable(ec);
|
2008-01-10 16:42:57 -07:00
|
|
|
|
2005-04-16 16:20:36 -06:00
|
|
|
switch (result) {
|
|
|
|
case -EINVAL:
|
2006-06-26 22:41:40 -06:00
|
|
|
return AE_BAD_PARAMETER;
|
2005-04-16 16:20:36 -06:00
|
|
|
break;
|
|
|
|
case -ENODEV:
|
2006-06-26 22:41:40 -06:00
|
|
|
return AE_NOT_FOUND;
|
2005-04-16 16:20:36 -06:00
|
|
|
break;
|
|
|
|
case -ETIME:
|
2006-06-26 22:41:40 -06:00
|
|
|
return AE_TIME;
|
2005-04-16 16:20:36 -06:00
|
|
|
break;
|
|
|
|
default:
|
2006-06-26 22:41:40 -06:00
|
|
|
return AE_OK;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* --------------------------------------------------------------------------
|
|
|
|
Driver Interface
|
|
|
|
-------------------------------------------------------------------------- */
|
2007-03-07 12:28:00 -07:00
|
|
|
static acpi_status
|
|
|
|
ec_parse_io_ports(struct acpi_resource *resource, void *context);
|
|
|
|
|
|
|
|
static struct acpi_ec *make_acpi_ec(void)
|
|
|
|
{
|
|
|
|
struct acpi_ec *ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
|
|
|
|
if (!ec)
|
|
|
|
return NULL;
|
2007-10-22 04:18:30 -06:00
|
|
|
ec->flags = 1 << EC_FLAGS_QUERY_PENDING;
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_init(&ec->mutex);
|
2007-03-07 12:28:00 -07:00
|
|
|
init_waitqueue_head(&ec->wait);
|
2007-05-29 06:43:02 -06:00
|
|
|
INIT_LIST_HEAD(&ec->list);
|
2012-10-22 17:29:27 -06:00
|
|
|
spin_lock_init(&ec->lock);
|
2007-03-07 12:28:00 -07:00
|
|
|
return ec;
|
|
|
|
}
|
2007-05-29 06:43:02 -06:00
|
|
|
|
2007-08-13 23:03:42 -06:00
|
|
|
static acpi_status
|
|
|
|
acpi_ec_register_query_methods(acpi_handle handle, u32 level,
|
|
|
|
void *context, void **return_value)
|
|
|
|
{
|
2008-12-16 01:46:12 -07:00
|
|
|
char node_name[5];
|
|
|
|
struct acpi_buffer buffer = { sizeof(node_name), node_name };
|
2007-08-13 23:03:42 -06:00
|
|
|
struct acpi_ec *ec = context;
|
|
|
|
int value = 0;
|
2008-12-16 01:46:12 -07:00
|
|
|
acpi_status status;
|
|
|
|
|
|
|
|
status = acpi_get_name(handle, ACPI_SINGLE_NAME, &buffer);
|
|
|
|
|
|
|
|
if (ACPI_SUCCESS(status) && sscanf(node_name, "_Q%x", &value) == 1) {
|
2007-08-13 23:03:42 -06:00
|
|
|
acpi_ec_add_query_handler(ec, value, handle, NULL, NULL);
|
|
|
|
}
|
|
|
|
return AE_OK;
|
|
|
|
}
|
|
|
|
|
2007-08-03 15:52:48 -06:00
|
|
|
static acpi_status
|
|
|
|
ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
|
2007-05-29 06:43:02 -06:00
|
|
|
{
|
2007-08-03 15:52:48 -06:00
|
|
|
acpi_status status;
|
2008-11-03 12:26:40 -07:00
|
|
|
unsigned long long tmp = 0;
|
2007-08-03 15:52:48 -06:00
|
|
|
|
|
|
|
struct acpi_ec *ec = context;
|
2009-03-31 23:33:15 -06:00
|
|
|
|
|
|
|
/* clear addr values, ec_parse_io_ports depend on it */
|
|
|
|
ec->command_addr = ec->data_addr = 0;
|
|
|
|
|
2007-08-03 15:52:48 -06:00
|
|
|
status = acpi_walk_resources(handle, METHOD_NAME__CRS,
|
|
|
|
ec_parse_io_ports, ec);
|
|
|
|
if (ACPI_FAILURE(status))
|
|
|
|
return status;
|
2007-05-29 06:43:02 -06:00
|
|
|
|
|
|
|
/* Get GPE bit assignment (EC events). */
|
|
|
|
/* TODO: Add support for _GPE returning a package */
|
2008-10-10 00:22:59 -06:00
|
|
|
status = acpi_evaluate_integer(handle, "_GPE", NULL, &tmp);
|
2007-08-03 15:52:48 -06:00
|
|
|
if (ACPI_FAILURE(status))
|
|
|
|
return status;
|
2008-10-10 00:22:59 -06:00
|
|
|
ec->gpe = tmp;
|
2007-05-29 06:43:02 -06:00
|
|
|
/* Use the global lock for all EC transactions? */
|
2008-11-03 12:26:40 -07:00
|
|
|
tmp = 0;
|
2008-10-10 00:22:59 -06:00
|
|
|
acpi_evaluate_integer(handle, "_GLK", NULL, &tmp);
|
|
|
|
ec->global_lock = tmp;
|
2007-05-29 06:43:02 -06:00
|
|
|
ec->handle = handle;
|
2007-08-03 15:52:48 -06:00
|
|
|
return AE_CTRL_TERMINATE;
|
2007-05-29 06:43:02 -06:00
|
|
|
}
|
|
|
|
|
2009-06-22 14:41:30 -06:00
|
|
|
static int ec_install_handlers(struct acpi_ec *ec)
|
|
|
|
{
|
|
|
|
acpi_status status;
|
|
|
|
if (test_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags))
|
|
|
|
return 0;
|
|
|
|
status = acpi_install_gpe_handler(NULL, ec->gpe,
|
|
|
|
ACPI_GPE_EDGE_TRIGGERED,
|
|
|
|
&acpi_ec_gpe_handler, ec);
|
|
|
|
if (ACPI_FAILURE(status))
|
|
|
|
return -ENODEV;
|
2010-02-17 15:41:07 -07:00
|
|
|
|
2010-06-30 20:11:45 -06:00
|
|
|
acpi_enable_gpe(NULL, ec->gpe);
|
2009-06-22 14:41:30 -06:00
|
|
|
status = acpi_install_address_space_handler(ec->handle,
|
|
|
|
ACPI_ADR_SPACE_EC,
|
|
|
|
&acpi_ec_space_handler,
|
|
|
|
NULL, ec);
|
|
|
|
if (ACPI_FAILURE(status)) {
|
|
|
|
if (status == AE_NOT_FOUND) {
|
|
|
|
/*
|
|
|
|
* Maybe OS fails in evaluating the _REG object.
|
|
|
|
* The AE_NOT_FOUND error will be ignored and OS
|
|
|
|
* continue to initialize EC.
|
|
|
|
*/
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_err("Fail in evaluating the _REG object"
|
2009-06-22 14:41:30 -06:00
|
|
|
" of EC device. Broken bios is suspected.\n");
|
|
|
|
} else {
|
2013-12-12 03:08:52 -07:00
|
|
|
acpi_disable_gpe(NULL, ec->gpe);
|
2009-06-22 14:41:30 -06:00
|
|
|
acpi_remove_gpe_handler(NULL, ec->gpe,
|
|
|
|
&acpi_ec_gpe_handler);
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
set_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2007-09-05 17:56:38 -06:00
|
|
|
static void ec_remove_handlers(struct acpi_ec *ec)
|
|
|
|
{
|
2010-06-30 20:11:45 -06:00
|
|
|
acpi_disable_gpe(NULL, ec->gpe);
|
2007-09-05 17:56:38 -06:00
|
|
|
if (ACPI_FAILURE(acpi_remove_address_space_handler(ec->handle,
|
|
|
|
ACPI_ADR_SPACE_EC, &acpi_ec_space_handler)))
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_err("failed to remove space handler\n");
|
2007-09-05 17:56:38 -06:00
|
|
|
if (ACPI_FAILURE(acpi_remove_gpe_handler(NULL, ec->gpe,
|
|
|
|
&acpi_ec_gpe_handler)))
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_err("failed to remove gpe handler\n");
|
2008-09-25 11:00:31 -06:00
|
|
|
clear_bit(EC_FLAGS_HANDLERS_INSTALLED, &ec->flags);
|
2007-09-05 17:56:38 -06:00
|
|
|
}
|
|
|
|
|
2006-09-26 09:50:33 -06:00
|
|
|
static int acpi_ec_add(struct acpi_device *device)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2006-09-26 09:50:33 -06:00
|
|
|
struct acpi_ec *ec = NULL;
|
2009-06-22 14:41:35 -06:00
|
|
|
int ret;
|
2005-07-23 02:08:00 -06:00
|
|
|
|
2007-03-07 12:28:00 -07:00
|
|
|
strcpy(acpi_device_name(device), ACPI_EC_DEVICE_NAME);
|
|
|
|
strcpy(acpi_device_class(device), ACPI_EC_CLASS);
|
|
|
|
|
2007-09-05 17:56:38 -06:00
|
|
|
/* Check for boot EC */
|
2008-03-24 14:22:36 -06:00
|
|
|
if (boot_ec &&
|
|
|
|
(boot_ec->handle == device->handle ||
|
|
|
|
boot_ec->handle == ACPI_ROOT_OBJECT)) {
|
|
|
|
ec = boot_ec;
|
|
|
|
boot_ec = NULL;
|
|
|
|
} else {
|
|
|
|
ec = make_acpi_ec();
|
|
|
|
if (!ec)
|
|
|
|
return -ENOMEM;
|
2009-03-31 23:33:15 -06:00
|
|
|
}
|
|
|
|
if (ec_parse_device(device->handle, 0, ec, NULL) !=
|
|
|
|
AE_CTRL_TERMINATE) {
|
2008-03-24 14:22:36 -06:00
|
|
|
kfree(ec);
|
|
|
|
return -EINVAL;
|
2007-09-05 17:56:38 -06:00
|
|
|
}
|
|
|
|
|
2008-03-24 14:22:36 -06:00
|
|
|
/* Find and register all query methods */
|
|
|
|
acpi_walk_namespace(ACPI_TYPE_METHOD, ec->handle, 1,
|
2009-11-12 19:06:08 -07:00
|
|
|
acpi_ec_register_query_methods, NULL, ec, NULL);
|
2008-03-24 14:22:36 -06:00
|
|
|
|
2007-09-05 17:56:38 -06:00
|
|
|
if (!first_ec)
|
|
|
|
first_ec = ec;
|
2008-09-22 15:37:34 -06:00
|
|
|
device->driver_data = ec;
|
2010-07-29 14:08:44 -06:00
|
|
|
|
2012-02-06 09:17:08 -07:00
|
|
|
ret = !!request_region(ec->data_addr, 1, "EC data");
|
|
|
|
WARN(!ret, "Could not request EC data io port 0x%lx", ec->data_addr);
|
|
|
|
ret = !!request_region(ec->command_addr, 1, "EC cmd");
|
|
|
|
WARN(!ret, "Could not request EC cmd io port 0x%lx", ec->command_addr);
|
2010-07-29 14:08:44 -06:00
|
|
|
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_info("GPE = 0x%lx, I/O: command/status = 0x%lx, data = 0x%lx\n",
|
2007-09-05 17:56:38 -06:00
|
|
|
ec->gpe, ec->command_addr, ec->data_addr);
|
2009-06-22 14:41:30 -06:00
|
|
|
|
|
|
|
ret = ec_install_handlers(ec);
|
|
|
|
|
|
|
|
/* EC is fully operational, allow queries */
|
|
|
|
clear_bit(EC_FLAGS_QUERY_PENDING, &ec->flags);
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
|
|
|
|
/* Clear stale _Q events if hardware might require that */
|
|
|
|
if (EC_FLAGS_CLEAR_ON_RESUME) {
|
|
|
|
mutex_lock(&ec->mutex);
|
|
|
|
acpi_ec_clear(ec);
|
|
|
|
mutex_unlock(&ec->mutex);
|
|
|
|
}
|
2009-06-22 14:41:30 -06:00
|
|
|
return ret;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
2013-01-23 16:24:48 -07:00
|
|
|
static int acpi_ec_remove(struct acpi_device *device)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-03-07 12:28:00 -07:00
|
|
|
struct acpi_ec *ec;
|
2007-07-29 09:00:37 -06:00
|
|
|
struct acpi_ec_query_handler *handler, *tmp;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
if (!device)
|
2006-06-26 22:41:40 -06:00
|
|
|
return -EINVAL;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
ec = acpi_driver_data(device);
|
2009-06-22 14:41:40 -06:00
|
|
|
ec_remove_handlers(ec);
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_lock(&ec->mutex);
|
2007-07-29 09:00:37 -06:00
|
|
|
list_for_each_entry_safe(handler, tmp, &ec->list, node) {
|
2007-05-29 06:43:02 -06:00
|
|
|
list_del(&handler->node);
|
|
|
|
kfree(handler);
|
|
|
|
}
|
2012-10-22 17:29:27 -06:00
|
|
|
mutex_unlock(&ec->mutex);
|
2010-07-29 14:08:44 -06:00
|
|
|
release_region(ec->data_addr, 1);
|
|
|
|
release_region(ec->command_addr, 1);
|
2008-09-22 15:37:34 -06:00
|
|
|
device->driver_data = NULL;
|
2007-03-07 12:28:00 -07:00
|
|
|
if (ec == first_ec)
|
2007-03-07 12:28:00 -07:00
|
|
|
first_ec = NULL;
|
2007-09-05 17:56:38 -06:00
|
|
|
kfree(ec);
|
2006-06-26 22:41:40 -06:00
|
|
|
return 0;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
static acpi_status
|
2007-03-07 12:28:00 -07:00
|
|
|
ec_parse_io_ports(struct acpi_resource *resource, void *context)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2007-03-07 12:28:00 -07:00
|
|
|
struct acpi_ec *ec = context;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2007-03-07 12:28:00 -07:00
|
|
|
if (resource->type != ACPI_RESOURCE_TYPE_IO)
|
2005-04-16 16:20:36 -06:00
|
|
|
return AE_OK;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The first address region returned is the data port, and
|
|
|
|
* the second address region returned is the status/command
|
|
|
|
* port.
|
|
|
|
*/
|
2010-07-29 14:08:44 -06:00
|
|
|
if (ec->data_addr == 0)
|
2006-09-26 09:50:33 -06:00
|
|
|
ec->data_addr = resource->data.io.minimum;
|
2010-07-29 14:08:44 -06:00
|
|
|
else if (ec->command_addr == 0)
|
2006-09-26 09:50:33 -06:00
|
|
|
ec->command_addr = resource->data.io.minimum;
|
2007-03-07 12:28:00 -07:00
|
|
|
else
|
2005-04-16 16:20:36 -06:00
|
|
|
return AE_CTRL_TERMINATE;
|
|
|
|
|
|
|
|
return AE_OK;
|
|
|
|
}
|
|
|
|
|
2008-01-01 12:12:55 -07:00
|
|
|
int __init acpi_boot_ec_enable(void)
|
|
|
|
{
|
2008-09-25 11:00:31 -06:00
|
|
|
if (!boot_ec || test_bit(EC_FLAGS_HANDLERS_INSTALLED, &boot_ec->flags))
|
2008-01-01 12:12:55 -07:00
|
|
|
return 0;
|
|
|
|
if (!ec_install_handlers(boot_ec)) {
|
|
|
|
first_ec = boot_ec;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
return -EFAULT;
|
|
|
|
}
|
|
|
|
|
2008-03-21 08:07:21 -06:00
|
|
|
static const struct acpi_device_id ec_device_ids[] = {
|
|
|
|
{"PNP0C09", 0},
|
|
|
|
{"", 0},
|
|
|
|
};
|
|
|
|
|
2009-10-02 10:21:40 -06:00
|
|
|
/* Some BIOS do not survive early DSDT scan, skip it */
|
|
|
|
static int ec_skip_dsdt_scan(const struct dmi_system_id *id)
|
|
|
|
{
|
|
|
|
EC_FLAGS_SKIP_DSDT_SCAN = 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-10-02 10:21:33 -06:00
|
|
|
/* ASUStek often supplies us with broken ECDT, validate it */
|
|
|
|
static int ec_validate_ecdt(const struct dmi_system_id *id)
|
|
|
|
{
|
|
|
|
EC_FLAGS_VALIDATE_ECDT = 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* MSI EC needs special treatment, enable it */
|
|
|
|
static int ec_flag_msi(const struct dmi_system_id *id)
|
|
|
|
{
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("Detected MSI hardware, enabling workarounds.\n");
|
2009-10-02 10:21:33 -06:00
|
|
|
EC_FLAGS_MSI = 1;
|
|
|
|
EC_FLAGS_VALIDATE_ECDT = 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-09-28 01:22:01 -06:00
|
|
|
/*
|
|
|
|
* Clevo M720 notebook actually works ok with IRQ mode, if we lifted
|
|
|
|
* the GPE storm threshold back to 20
|
|
|
|
*/
|
|
|
|
static int ec_enlarge_storm_threshold(const struct dmi_system_id *id)
|
|
|
|
{
|
|
|
|
pr_debug("Setting the EC GPE storm threshold to 20\n");
|
|
|
|
ec_storm_threshold = 20;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
/*
|
|
|
|
* On some hardware it is necessary to clear events accumulated by the EC during
|
|
|
|
* sleep. These ECs stop reporting GPEs until they are manually polled, if too
|
|
|
|
* many events are accumulated. (e.g. Samsung Series 5/9 notebooks)
|
|
|
|
*
|
|
|
|
* https://bugzilla.kernel.org/show_bug.cgi?id=44161
|
|
|
|
*
|
|
|
|
* Ideally, the EC should also be instructed NOT to accumulate events during
|
|
|
|
* sleep (which Windows seems to do somehow), but the interface to control this
|
|
|
|
* behaviour is not known at this time.
|
|
|
|
*
|
|
|
|
* Models known to be affected are Samsung 530Uxx/535Uxx/540Uxx/550Pxx/900Xxx,
|
|
|
|
* however it is very likely that other Samsung models are affected.
|
|
|
|
*
|
|
|
|
* On systems which don't accumulate _Q events during sleep, this extra check
|
|
|
|
* should be harmless.
|
|
|
|
*/
|
|
|
|
static int ec_clear_on_resume(const struct dmi_system_id *id)
|
|
|
|
{
|
|
|
|
pr_debug("Detected system needing EC poll on resume.\n");
|
|
|
|
EC_FLAGS_CLEAR_ON_RESUME = 1;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-08-07 05:46:55 -06:00
|
|
|
static struct dmi_system_id ec_dmi_table[] __initdata = {
|
2009-10-02 10:21:40 -06:00
|
|
|
{
|
|
|
|
ec_skip_dsdt_scan, "Compal JFL92", {
|
|
|
|
DMI_MATCH(DMI_BIOS_VENDOR, "COMPAL"),
|
|
|
|
DMI_MATCH(DMI_BOARD_NAME, "JFL92") }, NULL},
|
2009-10-02 10:21:33 -06:00
|
|
|
{
|
|
|
|
ec_flag_msi, "MSI hardware", {
|
2009-12-22 00:42:52 -07:00
|
|
|
DMI_MATCH(DMI_BIOS_VENDOR, "Micro-Star")}, NULL},
|
|
|
|
{
|
|
|
|
ec_flag_msi, "MSI hardware", {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "Micro-Star")}, NULL},
|
|
|
|
{
|
|
|
|
ec_flag_msi, "MSI hardware", {
|
|
|
|
DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-Star")}, NULL},
|
2009-10-02 10:21:33 -06:00
|
|
|
{
|
2010-12-09 15:07:54 -07:00
|
|
|
ec_flag_msi, "MSI hardware", {
|
|
|
|
DMI_MATCH(DMI_CHASSIS_VENDOR, "MICRO-STAR")}, NULL},
|
|
|
|
{
|
2011-04-26 02:30:02 -06:00
|
|
|
ec_flag_msi, "Quanta hardware", {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "Quanta"),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "TW8/SW8/DW8"),}, NULL},
|
|
|
|
{
|
|
|
|
ec_flag_msi, "Quanta hardware", {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "Quanta"),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "TW9/SW9"),}, NULL},
|
|
|
|
{
|
2009-10-02 10:21:33 -06:00
|
|
|
ec_validate_ecdt, "ASUS hardware", {
|
|
|
|
DMI_MATCH(DMI_BIOS_VENDOR, "ASUS") }, NULL},
|
2011-04-24 15:09:32 -06:00
|
|
|
{
|
|
|
|
ec_validate_ecdt, "ASUS hardware", {
|
|
|
|
DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer Inc.") }, NULL},
|
2012-09-28 01:22:01 -06:00
|
|
|
{
|
|
|
|
ec_enlarge_storm_threshold, "CLEVO hardware", {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "CLEVO Co."),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "M720T/M730T"),}, NULL},
|
2013-06-04 20:27:51 -06:00
|
|
|
{
|
|
|
|
ec_skip_dsdt_scan, "HP Folio 13", {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "HP Folio 13"),}, NULL},
|
2013-08-25 20:19:18 -06:00
|
|
|
{
|
|
|
|
ec_validate_ecdt, "ASUS hardware", {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTek Computer Inc."),
|
|
|
|
DMI_MATCH(DMI_PRODUCT_NAME, "L4R"),}, NULL},
|
ACPI / EC: Clear stale EC events on Samsung systems
A number of Samsung notebooks (530Uxx/535Uxx/540Uxx/550Pxx/900Xxx/etc)
continue to log events during sleep (lid open/close, AC plug/unplug,
battery level change), which accumulate in the EC until a buffer fills.
After the buffer is full (tests suggest it holds 8 events), GPEs stop
being triggered for new events. This state persists on wake or even on
power cycle, and prevents new events from being registered until the EC
is manually polled.
This is the root cause of a number of bugs, including AC not being
detected properly, lid close not triggering suspend, and low ambient
light not triggering the keyboard backlight. The bug also seemed to be
responsible for performance issues on at least one user's machine.
Juan Manuel Cabo found the cause of bug and the workaround of polling
the EC manually on wake.
The loop which clears the stale events is based on an earlier patch by
Lan Tianyu (see referenced attachment).
This patch:
- Adds a function acpi_ec_clear() which polls the EC for stale _Q
events at most ACPI_EC_CLEAR_MAX (currently 100) times. A warning is
logged if this limit is reached.
- Adds a flag EC_FLAGS_CLEAR_ON_RESUME which is set to 1 if the DMI
system vendor is Samsung. This check could be replaced by several
more specific DMI vendor/product pairs, but it's likely that the bug
affects more Samsung products than just the five series mentioned
above. Further, it should not be harmful to run acpi_ec_clear() on
systems without the bug; it will return immediately after finding no
data waiting.
- Runs acpi_ec_clear() on initialisation (boot), from acpi_ec_add()
- Runs acpi_ec_clear() on wake, from acpi_ec_unblock_transactions()
References: https://bugzilla.kernel.org/show_bug.cgi?id=44161
References: https://bugzilla.kernel.org/show_bug.cgi?id=45461
References: https://bugzilla.kernel.org/show_bug.cgi?id=57271
References: https://bugzilla.kernel.org/attachment.cgi?id=126801
Suggested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Signed-off-by: Kieran Clancy <clancy.kieran@gmail.com>
Reviewed-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Kieran Clancy <clancy.kieran@gmail.com>
Tested-by: Juan Manuel Cabo <juanmanuel.cabo@gmail.com>
Tested-by: Dennis Jansen <dennis.jansen@web.de>
Tested-by: Maurizio D'Addona <mauritiusdadd@gmail.com>
Tested-by: San Zamoyski <san@plusnet.pl>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
2014-02-28 07:12:28 -07:00
|
|
|
{
|
|
|
|
ec_clear_on_resume, "Samsung hardware", {
|
|
|
|
DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD.")}, NULL},
|
2009-10-02 10:21:33 -06:00
|
|
|
{},
|
|
|
|
};
|
|
|
|
|
2007-03-07 12:28:00 -07:00
|
|
|
int __init acpi_ec_ecdt_probe(void)
|
|
|
|
{
|
|
|
|
acpi_status status;
|
2009-01-13 16:57:53 -07:00
|
|
|
struct acpi_ec *saved_ec = NULL;
|
2005-08-11 15:32:05 -06:00
|
|
|
struct acpi_table_ecdt *ecdt_ptr;
|
2005-07-23 02:08:00 -06:00
|
|
|
|
2007-03-07 12:28:00 -07:00
|
|
|
boot_ec = make_acpi_ec();
|
|
|
|
if (!boot_ec)
|
2007-03-07 12:28:00 -07:00
|
|
|
return -ENOMEM;
|
|
|
|
/*
|
|
|
|
* Generate a boot ec context
|
|
|
|
*/
|
2009-10-02 10:21:33 -06:00
|
|
|
dmi_check_system(ec_dmi_table);
|
2007-02-02 09:48:22 -07:00
|
|
|
status = acpi_get_table(ACPI_SIG_ECDT, 1,
|
|
|
|
(struct acpi_table_header **)&ecdt_ptr);
|
2007-08-03 15:52:48 -06:00
|
|
|
if (ACPI_SUCCESS(status)) {
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_info("EC description table is found, configuring boot EC\n");
|
2007-08-03 15:52:48 -06:00
|
|
|
boot_ec->command_addr = ecdt_ptr->control.address;
|
|
|
|
boot_ec->data_addr = ecdt_ptr->data.address;
|
|
|
|
boot_ec->gpe = ecdt_ptr->gpe;
|
2008-03-10 22:27:16 -06:00
|
|
|
boot_ec->handle = ACPI_ROOT_OBJECT;
|
2008-03-24 14:22:36 -06:00
|
|
|
acpi_get_handle(ACPI_ROOT_OBJECT, ecdt_ptr->id, &boot_ec->handle);
|
2009-01-13 16:57:53 -07:00
|
|
|
/* Don't trust ECDT, which comes from ASUSTek */
|
2009-10-02 10:21:33 -06:00
|
|
|
if (!EC_FLAGS_VALIDATE_ECDT)
|
2008-11-26 15:11:53 -07:00
|
|
|
goto install;
|
2010-05-15 15:16:21 -06:00
|
|
|
saved_ec = kmemdup(boot_ec, sizeof(struct acpi_ec), GFP_KERNEL);
|
2009-01-13 16:57:53 -07:00
|
|
|
if (!saved_ec)
|
|
|
|
return -ENOMEM;
|
2008-11-26 15:11:53 -07:00
|
|
|
/* fall through */
|
2007-08-03 15:52:48 -06:00
|
|
|
}
|
2009-10-02 10:21:33 -06:00
|
|
|
|
2014-07-02 17:35:09 -06:00
|
|
|
if (EC_FLAGS_SKIP_DSDT_SCAN) {
|
|
|
|
kfree(saved_ec);
|
2009-10-02 10:21:40 -06:00
|
|
|
return -ENODEV;
|
2014-07-02 17:35:09 -06:00
|
|
|
}
|
2009-10-02 10:21:40 -06:00
|
|
|
|
2008-11-26 15:11:53 -07:00
|
|
|
/* This workaround is needed only on some broken machines,
|
|
|
|
* which require early EC, but fail to provide ECDT */
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_debug("Look up EC in DSDT\n");
|
2008-11-26 15:11:53 -07:00
|
|
|
status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
|
|
|
|
boot_ec, NULL);
|
|
|
|
/* Check that acpi_get_devices actually find something */
|
|
|
|
if (ACPI_FAILURE(status) || !boot_ec->handle)
|
|
|
|
goto error;
|
2009-01-13 16:57:53 -07:00
|
|
|
if (saved_ec) {
|
|
|
|
/* try to find good ECDT from ASUSTek */
|
|
|
|
if (saved_ec->command_addr != boot_ec->command_addr ||
|
|
|
|
saved_ec->data_addr != boot_ec->data_addr ||
|
|
|
|
saved_ec->gpe != boot_ec->gpe ||
|
|
|
|
saved_ec->handle != boot_ec->handle)
|
2013-09-12 01:32:04 -06:00
|
|
|
pr_info("ASUSTek keeps feeding us with broken "
|
2009-01-13 16:57:53 -07:00
|
|
|
"ECDT tables, which are very hard to workaround. "
|
|
|
|
"Trying to use DSDT EC info instead. Please send "
|
|
|
|
"output of acpidump to linux-acpi@vger.kernel.org\n");
|
|
|
|
kfree(saved_ec);
|
|
|
|
saved_ec = NULL;
|
|
|
|
} else {
|
|
|
|
/* We really need to limit this workaround, the only ASUS,
|
|
|
|
* which needs it, has fake EC._INI method, so use it as flag.
|
|
|
|
* Keep boot_ec struct as it will be needed soon.
|
|
|
|
*/
|
|
|
|
if (!dmi_name_in_vendors("ASUS") ||
|
2013-06-28 10:24:38 -06:00
|
|
|
!acpi_has_method(boot_ec->handle, "_INI"))
|
2009-01-13 16:57:53 -07:00
|
|
|
return -ENODEV;
|
|
|
|
}
|
2008-11-26 15:11:53 -07:00
|
|
|
install:
|
|
|
|
if (!ec_install_handlers(boot_ec)) {
|
2007-03-07 12:28:00 -07:00
|
|
|
first_ec = boot_ec;
|
2007-03-07 12:28:00 -07:00
|
|
|
return 0;
|
2007-03-07 12:28:00 -07:00
|
|
|
}
|
2008-11-26 15:11:53 -07:00
|
|
|
error:
|
2007-03-07 12:28:00 -07:00
|
|
|
kfree(boot_ec);
|
2014-07-02 17:35:09 -06:00
|
|
|
kfree(saved_ec);
|
2007-03-07 12:28:00 -07:00
|
|
|
boot_ec = NULL;
|
2005-04-16 16:20:36 -06:00
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2008-03-21 08:07:21 -06:00
|
|
|
static struct acpi_driver acpi_ec_driver = {
|
|
|
|
.name = "ec",
|
|
|
|
.class = ACPI_EC_CLASS,
|
|
|
|
.ids = ec_device_ids,
|
|
|
|
.ops = {
|
|
|
|
.add = acpi_ec_add,
|
|
|
|
.remove = acpi_ec_remove,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2009-03-24 16:49:48 -06:00
|
|
|
int __init acpi_ec_init(void)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
2005-08-11 15:32:05 -06:00
|
|
|
int result = 0;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
|
|
|
/* Now register the driver for the EC */
|
|
|
|
result = acpi_bus_register_driver(&acpi_ec_driver);
|
2010-07-16 05:11:34 -06:00
|
|
|
if (result < 0)
|
2006-06-26 22:41:40 -06:00
|
|
|
return -ENODEV;
|
2005-04-16 16:20:36 -06:00
|
|
|
|
2006-06-26 22:41:40 -06:00
|
|
|
return result;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
/* EC driver currently not unloadable */
|
|
|
|
#if 0
|
2005-08-11 15:32:05 -06:00
|
|
|
static void __exit acpi_ec_exit(void)
|
2005-04-16 16:20:36 -06:00
|
|
|
{
|
|
|
|
|
|
|
|
acpi_bus_unregister_driver(&acpi_ec_driver);
|
2006-06-26 22:41:40 -06:00
|
|
|
return;
|
2005-04-16 16:20:36 -06:00
|
|
|
}
|
2007-10-22 04:18:43 -06:00
|
|
|
#endif /* 0 */
|