2010-10-14 00:01:34 -06:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2010 Red Hat, Inc., Peter Zijlstra <pzijlstr@redhat.com>
|
|
|
|
*
|
|
|
|
* Provides a framework for enqueueing and running callbacks from hardirq
|
|
|
|
* context. The enqueueing is NMI-safe.
|
|
|
|
*/
|
|
|
|
|
2012-04-01 14:38:37 -06:00
|
|
|
#include <linux/bug.h>
|
2010-10-14 00:01:34 -06:00
|
|
|
#include <linux/kernel.h>
|
2011-05-23 12:51:41 -06:00
|
|
|
#include <linux/export.h>
|
2010-10-14 00:01:34 -06:00
|
|
|
#include <linux/irq_work.h>
|
2011-07-18 11:03:04 -06:00
|
|
|
#include <linux/percpu.h>
|
2010-10-14 00:01:34 -06:00
|
|
|
#include <linux/hardirq.h>
|
2012-04-11 10:21:39 -06:00
|
|
|
#include <linux/irqflags.h>
|
2012-10-19 14:43:41 -06:00
|
|
|
#include <linux/sched.h>
|
|
|
|
#include <linux/tick.h>
|
2012-11-15 09:34:21 -07:00
|
|
|
#include <linux/cpu.h>
|
|
|
|
#include <linux/notifier.h>
|
2014-05-07 17:37:48 -06:00
|
|
|
#include <linux/smp.h>
|
2011-07-18 11:03:04 -06:00
|
|
|
#include <asm/processor.h>
|
2010-10-14 00:01:34 -06:00
|
|
|
|
|
|
|
|
2014-05-23 10:10:21 -06:00
|
|
|
static DEFINE_PER_CPU(struct llist_head, raised_list);
|
|
|
|
static DEFINE_PER_CPU(struct llist_head, lazy_list);
|
2010-10-14 00:01:34 -06:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Claim the entry so that no one else will poke at it.
|
|
|
|
*/
|
2011-09-08 00:00:46 -06:00
|
|
|
static bool irq_work_claim(struct irq_work *work)
|
2010-10-14 00:01:34 -06:00
|
|
|
{
|
irq_work: Fix racy check on work pending flag
Work claiming wants to be SMP-safe.
And by the time we try to claim a work, if it is already executing
concurrently on another CPU, we want to succeed the claiming and queue
the work again because the other CPU may have missed the data we wanted
to handle in our work if it's about to complete there.
This scenario is summarized below:
CPU 1 CPU 2
----- -----
(flags = 0)
cmpxchg(flags, 0, IRQ_WORK_FLAGS)
(flags = 3)
[...]
xchg(flags, IRQ_WORK_BUSY)
(flags = 2)
func()
if (flags & IRQ_WORK_PENDING)
(not true)
cmpxchg(flags, flags, IRQ_WORK_FLAGS)
(flags = 3)
[...]
cmpxchg(flags, IRQ_WORK_BUSY, 0);
(fail, pending on CPU 2)
This state machine is synchronized using [cmp]xchg() on the flags.
As such, the early IRQ_WORK_PENDING check in CPU 2 above is racy.
By the time we check it, we may be dealing with a stale value because
we aren't using an atomic accessor. As a result, CPU 2 may "see"
that the work is still pending on another CPU while it may be
actually completing the work function exection already, leaving
our data unprocessed.
To fix this, we start by speculating about the value we wish to be
in the work->flags but we only make any conclusion after the value
returned by the cmpxchg() call that either claims the work or let
the current owner handle the pending work for us.
Changelog-heavily-inspired-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Anish Kumar <anish198519851985@gmail.com>
2012-10-27 07:21:36 -06:00
|
|
|
unsigned long flags, oflags, nflags;
|
2010-10-14 00:01:34 -06:00
|
|
|
|
irq_work: Fix racy check on work pending flag
Work claiming wants to be SMP-safe.
And by the time we try to claim a work, if it is already executing
concurrently on another CPU, we want to succeed the claiming and queue
the work again because the other CPU may have missed the data we wanted
to handle in our work if it's about to complete there.
This scenario is summarized below:
CPU 1 CPU 2
----- -----
(flags = 0)
cmpxchg(flags, 0, IRQ_WORK_FLAGS)
(flags = 3)
[...]
xchg(flags, IRQ_WORK_BUSY)
(flags = 2)
func()
if (flags & IRQ_WORK_PENDING)
(not true)
cmpxchg(flags, flags, IRQ_WORK_FLAGS)
(flags = 3)
[...]
cmpxchg(flags, IRQ_WORK_BUSY, 0);
(fail, pending on CPU 2)
This state machine is synchronized using [cmp]xchg() on the flags.
As such, the early IRQ_WORK_PENDING check in CPU 2 above is racy.
By the time we check it, we may be dealing with a stale value because
we aren't using an atomic accessor. As a result, CPU 2 may "see"
that the work is still pending on another CPU while it may be
actually completing the work function exection already, leaving
our data unprocessed.
To fix this, we start by speculating about the value we wish to be
in the work->flags but we only make any conclusion after the value
returned by the cmpxchg() call that either claims the work or let
the current owner handle the pending work for us.
Changelog-heavily-inspired-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Anish Kumar <anish198519851985@gmail.com>
2012-10-27 07:21:36 -06:00
|
|
|
/*
|
|
|
|
* Start with our best wish as a premise but only trust any
|
|
|
|
* flag value after cmpxchg() result.
|
|
|
|
*/
|
|
|
|
flags = work->flags & ~IRQ_WORK_PENDING;
|
2011-09-08 00:00:46 -06:00
|
|
|
for (;;) {
|
|
|
|
nflags = flags | IRQ_WORK_FLAGS;
|
irq_work: Fix racy check on work pending flag
Work claiming wants to be SMP-safe.
And by the time we try to claim a work, if it is already executing
concurrently on another CPU, we want to succeed the claiming and queue
the work again because the other CPU may have missed the data we wanted
to handle in our work if it's about to complete there.
This scenario is summarized below:
CPU 1 CPU 2
----- -----
(flags = 0)
cmpxchg(flags, 0, IRQ_WORK_FLAGS)
(flags = 3)
[...]
xchg(flags, IRQ_WORK_BUSY)
(flags = 2)
func()
if (flags & IRQ_WORK_PENDING)
(not true)
cmpxchg(flags, flags, IRQ_WORK_FLAGS)
(flags = 3)
[...]
cmpxchg(flags, IRQ_WORK_BUSY, 0);
(fail, pending on CPU 2)
This state machine is synchronized using [cmp]xchg() on the flags.
As such, the early IRQ_WORK_PENDING check in CPU 2 above is racy.
By the time we check it, we may be dealing with a stale value because
we aren't using an atomic accessor. As a result, CPU 2 may "see"
that the work is still pending on another CPU while it may be
actually completing the work function exection already, leaving
our data unprocessed.
To fix this, we start by speculating about the value we wish to be
in the work->flags but we only make any conclusion after the value
returned by the cmpxchg() call that either claims the work or let
the current owner handle the pending work for us.
Changelog-heavily-inspired-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Anish Kumar <anish198519851985@gmail.com>
2012-10-27 07:21:36 -06:00
|
|
|
oflags = cmpxchg(&work->flags, flags, nflags);
|
|
|
|
if (oflags == flags)
|
2011-09-08 00:00:46 -06:00
|
|
|
break;
|
irq_work: Fix racy check on work pending flag
Work claiming wants to be SMP-safe.
And by the time we try to claim a work, if it is already executing
concurrently on another CPU, we want to succeed the claiming and queue
the work again because the other CPU may have missed the data we wanted
to handle in our work if it's about to complete there.
This scenario is summarized below:
CPU 1 CPU 2
----- -----
(flags = 0)
cmpxchg(flags, 0, IRQ_WORK_FLAGS)
(flags = 3)
[...]
xchg(flags, IRQ_WORK_BUSY)
(flags = 2)
func()
if (flags & IRQ_WORK_PENDING)
(not true)
cmpxchg(flags, flags, IRQ_WORK_FLAGS)
(flags = 3)
[...]
cmpxchg(flags, IRQ_WORK_BUSY, 0);
(fail, pending on CPU 2)
This state machine is synchronized using [cmp]xchg() on the flags.
As such, the early IRQ_WORK_PENDING check in CPU 2 above is racy.
By the time we check it, we may be dealing with a stale value because
we aren't using an atomic accessor. As a result, CPU 2 may "see"
that the work is still pending on another CPU while it may be
actually completing the work function exection already, leaving
our data unprocessed.
To fix this, we start by speculating about the value we wish to be
in the work->flags but we only make any conclusion after the value
returned by the cmpxchg() call that either claims the work or let
the current owner handle the pending work for us.
Changelog-heavily-inspired-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Anish Kumar <anish198519851985@gmail.com>
2012-10-27 07:21:36 -06:00
|
|
|
if (oflags & IRQ_WORK_PENDING)
|
|
|
|
return false;
|
|
|
|
flags = oflags;
|
2011-09-08 00:00:46 -06:00
|
|
|
cpu_relax();
|
|
|
|
}
|
2010-10-14 00:01:34 -06:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void __weak arch_irq_work_raise(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Lame architectures will get the timer tick callback
|
|
|
|
*/
|
|
|
|
}
|
|
|
|
|
2014-05-07 17:37:48 -06:00
|
|
|
#ifdef CONFIG_SMP
|
2010-10-14 00:01:34 -06:00
|
|
|
/*
|
2014-05-07 17:37:48 -06:00
|
|
|
* Enqueue the irq_work @work on @cpu unless it's already pending
|
2013-02-03 14:08:23 -07:00
|
|
|
* somewhere.
|
|
|
|
*
|
|
|
|
* Can be re-enqueued while the callback is still in progress.
|
2010-10-14 00:01:34 -06:00
|
|
|
*/
|
2014-05-07 17:37:48 -06:00
|
|
|
bool irq_work_queue_on(struct irq_work *work, int cpu)
|
|
|
|
{
|
|
|
|
/* All work should have been flushed before going offline */
|
|
|
|
WARN_ON_ONCE(cpu_is_offline(cpu));
|
|
|
|
|
|
|
|
/* Arch remote IPI send/receive backend aren't NMI safe */
|
|
|
|
WARN_ON_ONCE(in_nmi());
|
|
|
|
|
|
|
|
/* Only queue if not already pending */
|
|
|
|
if (!irq_work_claim(work))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (llist_add(&work->llnode, &per_cpu(raised_list, cpu)))
|
|
|
|
arch_send_call_function_single_ipi(cpu);
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(irq_work_queue_on);
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/* Enqueue the irq work @work on the current CPU */
|
2014-02-11 08:01:16 -07:00
|
|
|
bool irq_work_queue(struct irq_work *work)
|
2010-10-14 00:01:34 -06:00
|
|
|
{
|
2013-02-03 14:08:23 -07:00
|
|
|
/* Only queue if not already pending */
|
|
|
|
if (!irq_work_claim(work))
|
2014-02-11 08:01:16 -07:00
|
|
|
return false;
|
2013-02-03 14:08:23 -07:00
|
|
|
|
|
|
|
/* Queue the entry and raise the IPI if needed. */
|
2010-12-14 09:28:45 -07:00
|
|
|
preempt_disable();
|
2010-10-14 00:01:34 -06:00
|
|
|
|
2014-05-23 10:10:21 -06:00
|
|
|
/* If the work is "lazy", handle it from next tick if any */
|
|
|
|
if (work->flags & IRQ_WORK_LAZY) {
|
2014-08-17 11:30:25 -06:00
|
|
|
if (llist_add(&work->llnode, this_cpu_ptr(&lazy_list)) &&
|
2014-05-23 10:10:21 -06:00
|
|
|
tick_nohz_tick_stopped())
|
|
|
|
arch_irq_work_raise();
|
|
|
|
} else {
|
2014-08-17 11:30:25 -06:00
|
|
|
if (llist_add(&work->llnode, this_cpu_ptr(&raised_list)))
|
2012-10-19 14:43:41 -06:00
|
|
|
arch_irq_work_raise();
|
|
|
|
}
|
2010-10-14 00:01:34 -06:00
|
|
|
|
2010-12-14 09:28:45 -07:00
|
|
|
preempt_enable();
|
2014-02-11 08:01:16 -07:00
|
|
|
|
|
|
|
return true;
|
2010-10-14 00:01:34 -06:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(irq_work_queue);
|
|
|
|
|
2012-11-07 13:03:07 -07:00
|
|
|
bool irq_work_needs_cpu(void)
|
|
|
|
{
|
2014-05-23 10:10:21 -06:00
|
|
|
struct llist_head *raised, *lazy;
|
2012-11-07 13:03:07 -07:00
|
|
|
|
2014-08-17 11:30:25 -06:00
|
|
|
raised = this_cpu_ptr(&raised_list);
|
|
|
|
lazy = this_cpu_ptr(&lazy_list);
|
2014-08-16 10:37:19 -06:00
|
|
|
|
|
|
|
if (llist_empty(raised) || arch_irq_work_has_interrupt())
|
|
|
|
if (llist_empty(lazy))
|
|
|
|
return false;
|
2012-11-07 13:03:07 -07:00
|
|
|
|
2012-11-15 10:52:44 -07:00
|
|
|
/* All work should have been flushed before going offline */
|
|
|
|
WARN_ON_ONCE(cpu_is_offline(smp_processor_id()));
|
|
|
|
|
2012-11-07 13:03:07 -07:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-05-23 10:10:21 -06:00
|
|
|
static void irq_work_run_list(struct llist_head *list)
|
2010-10-14 00:01:34 -06:00
|
|
|
{
|
2012-10-19 14:43:41 -06:00
|
|
|
unsigned long flags;
|
2011-09-08 00:00:46 -06:00
|
|
|
struct irq_work *work;
|
|
|
|
struct llist_node *llnode;
|
2010-10-14 00:01:34 -06:00
|
|
|
|
2014-05-23 10:10:21 -06:00
|
|
|
BUG_ON(!irqs_disabled());
|
2012-10-19 14:43:41 -06:00
|
|
|
|
2014-05-23 10:10:21 -06:00
|
|
|
if (llist_empty(list))
|
2010-10-14 00:01:34 -06:00
|
|
|
return;
|
|
|
|
|
2014-05-23 10:10:21 -06:00
|
|
|
llnode = llist_del_all(list);
|
2011-09-08 00:00:46 -06:00
|
|
|
while (llnode != NULL) {
|
|
|
|
work = llist_entry(llnode, struct irq_work, llnode);
|
2010-10-14 00:01:34 -06:00
|
|
|
|
2011-09-12 05:12:28 -06:00
|
|
|
llnode = llist_next(llnode);
|
2010-10-14 00:01:34 -06:00
|
|
|
|
|
|
|
/*
|
2011-09-08 00:00:46 -06:00
|
|
|
* Clear the PENDING bit, after this point the @work
|
2010-10-14 00:01:34 -06:00
|
|
|
* can be re-used.
|
irq_work: Fix racy IRQ_WORK_BUSY flag setting
The IRQ_WORK_BUSY flag is set right before we execute the
work. Once this flag value is set, the work enters a
claimable state again.
So if we have specific data to compute in our work, we ensure it's
either handled by another CPU or locally by enqueuing the work again.
This state machine is guanranteed by atomic operations on the flags.
So when we set IRQ_WORK_BUSY without using an xchg-like operation,
we break this guarantee as in the following summarized scenario:
CPU 1 CPU 2
----- -----
(flags = 0)
old_flags = flags;
(flags = 0)
cmpxchg(flags, old_flags,
old_flags | IRQ_WORK_FLAGS)
(flags = 3)
[...]
flags = IRQ_WORK_BUSY
(flags = 2)
func()
(sees flags = 3)
cmpxchg(flags, old_flags,
old_flags | IRQ_WORK_FLAGS)
(give up)
cmpxchg(flags, 2, 0);
(flags = 0)
CPU 1 claims a work and executes it, so it sets IRQ_WORK_BUSY and
the work is again in a claimable state. Now CPU 2 has new data to process
and try to claim that work but it may see a stale value of the flags
and think the work is still pending somewhere that will handle our data.
This is because CPU 1 doesn't set IRQ_WORK_BUSY atomically.
As a result, the data expected to be handle by CPU 2 won't get handled.
To fix this, use xchg() to set IRQ_WORK_BUSY, this way we ensure the CPU 2
will see the correct value with cmpxchg() using the expected ordering.
Changelog-heavily-inspired-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Anish Kumar <anish198519851985@gmail.com>
2012-10-30 06:33:54 -06:00
|
|
|
* Make it immediately visible so that other CPUs trying
|
|
|
|
* to claim that work don't rely on us to handle their data
|
|
|
|
* while we are in the middle of the func.
|
2010-10-14 00:01:34 -06:00
|
|
|
*/
|
2012-10-19 14:43:41 -06:00
|
|
|
flags = work->flags & ~IRQ_WORK_PENDING;
|
|
|
|
xchg(&work->flags, flags);
|
|
|
|
|
2011-09-08 00:00:46 -06:00
|
|
|
work->func(work);
|
2010-10-14 00:01:34 -06:00
|
|
|
/*
|
|
|
|
* Clear the BUSY bit and return to the free state if
|
|
|
|
* no-one else claimed it meanwhile.
|
|
|
|
*/
|
2012-10-19 14:43:41 -06:00
|
|
|
(void)cmpxchg(&work->flags, flags, flags & ~IRQ_WORK_BUSY);
|
2010-10-14 00:01:34 -06:00
|
|
|
}
|
|
|
|
}
|
2012-11-15 09:34:21 -07:00
|
|
|
|
|
|
|
/*
|
2014-06-24 23:13:07 -06:00
|
|
|
* hotplug calls this through:
|
|
|
|
* hotplug_cfd() -> flush_smp_call_function_queue()
|
2012-11-15 09:34:21 -07:00
|
|
|
*/
|
|
|
|
void irq_work_run(void)
|
|
|
|
{
|
2014-08-17 11:30:25 -06:00
|
|
|
irq_work_run_list(this_cpu_ptr(&raised_list));
|
|
|
|
irq_work_run_list(this_cpu_ptr(&lazy_list));
|
2012-11-15 09:34:21 -07:00
|
|
|
}
|
2010-10-14 00:01:34 -06:00
|
|
|
EXPORT_SYMBOL_GPL(irq_work_run);
|
|
|
|
|
2014-08-16 10:37:19 -06:00
|
|
|
void irq_work_tick(void)
|
|
|
|
{
|
|
|
|
struct llist_head *raised = &__get_cpu_var(raised_list);
|
|
|
|
|
|
|
|
if (!llist_empty(raised) && !arch_irq_work_has_interrupt())
|
|
|
|
irq_work_run_list(raised);
|
|
|
|
irq_work_run_list(&__get_cpu_var(lazy_list));
|
|
|
|
}
|
|
|
|
|
2010-10-14 00:01:34 -06:00
|
|
|
/*
|
|
|
|
* Synchronize against the irq_work @entry, ensures the entry is not
|
|
|
|
* currently in use.
|
|
|
|
*/
|
2011-09-08 00:00:46 -06:00
|
|
|
void irq_work_sync(struct irq_work *work)
|
2010-10-14 00:01:34 -06:00
|
|
|
{
|
|
|
|
WARN_ON_ONCE(irqs_disabled());
|
|
|
|
|
2011-09-08 00:00:46 -06:00
|
|
|
while (work->flags & IRQ_WORK_BUSY)
|
2010-10-14 00:01:34 -06:00
|
|
|
cpu_relax();
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(irq_work_sync);
|