2010-01-20 10:28:45 -07:00
|
|
|
/*
|
|
|
|
* builtin-buildid-cache.c
|
|
|
|
*
|
|
|
|
* Builtin buildid-cache command: Manages build-id cache
|
|
|
|
*
|
|
|
|
* Copyright (C) 2010, Red Hat Inc.
|
|
|
|
* Copyright (C) 2010, Arnaldo Carvalho de Melo <acme@redhat.com>
|
|
|
|
*/
|
2013-10-14 07:57:29 -06:00
|
|
|
#include <sys/types.h>
|
|
|
|
#include <sys/time.h>
|
|
|
|
#include <time.h>
|
|
|
|
#include <dirent.h>
|
|
|
|
#include <unistd.h>
|
2010-01-20 10:28:45 -07:00
|
|
|
#include "builtin.h"
|
|
|
|
#include "perf.h"
|
|
|
|
#include "util/cache.h"
|
|
|
|
#include "util/debug.h"
|
|
|
|
#include "util/header.h"
|
2015-12-15 08:39:39 -07:00
|
|
|
#include <subcmd/parse-options.h>
|
2010-01-20 10:28:45 -07:00
|
|
|
#include "util/strlist.h"
|
2012-10-27 15:18:28 -06:00
|
|
|
#include "util/build-id.h"
|
2012-12-07 12:28:27 -07:00
|
|
|
#include "util/session.h"
|
2012-10-27 15:18:29 -06:00
|
|
|
#include "util/symbol.h"
|
2010-01-20 10:28:45 -07:00
|
|
|
|
2013-10-14 07:57:29 -06:00
|
|
|
static int build_id_cache__kcore_buildid(const char *proc_dir, char *sbuildid)
|
|
|
|
{
|
|
|
|
char root_dir[PATH_MAX];
|
|
|
|
char *p;
|
|
|
|
|
|
|
|
strlcpy(root_dir, proc_dir, sizeof(root_dir));
|
|
|
|
|
|
|
|
p = strrchr(root_dir, '/');
|
|
|
|
if (!p)
|
|
|
|
return -1;
|
|
|
|
*p = '\0';
|
2015-08-15 05:42:59 -06:00
|
|
|
return sysfs__sprintf_build_id(root_dir, sbuildid);
|
2013-10-14 07:57:29 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
static int build_id_cache__kcore_dir(char *dir, size_t sz)
|
|
|
|
{
|
2016-01-25 02:56:13 -07:00
|
|
|
return fetch_current_timestamp(dir, sz);
|
2013-10-14 07:57:29 -06:00
|
|
|
}
|
|
|
|
|
2014-01-29 07:14:44 -07:00
|
|
|
static bool same_kallsyms_reloc(const char *from_dir, char *to_dir)
|
|
|
|
{
|
|
|
|
char from[PATH_MAX];
|
|
|
|
char to[PATH_MAX];
|
|
|
|
const char *name;
|
|
|
|
u64 addr1 = 0, addr2 = 0;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
scnprintf(from, sizeof(from), "%s/kallsyms", from_dir);
|
|
|
|
scnprintf(to, sizeof(to), "%s/kallsyms", to_dir);
|
|
|
|
|
|
|
|
for (i = 0; (name = ref_reloc_sym_names[i]) != NULL; i++) {
|
|
|
|
addr1 = kallsyms__get_function_start(from, name);
|
|
|
|
if (addr1)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (name)
|
|
|
|
addr2 = kallsyms__get_function_start(to, name);
|
|
|
|
|
|
|
|
return addr1 == addr2;
|
|
|
|
}
|
|
|
|
|
2013-10-14 07:57:29 -06:00
|
|
|
static int build_id_cache__kcore_existing(const char *from_dir, char *to_dir,
|
|
|
|
size_t to_dir_sz)
|
|
|
|
{
|
|
|
|
char from[PATH_MAX];
|
|
|
|
char to[PATH_MAX];
|
2014-01-29 07:14:44 -07:00
|
|
|
char to_subdir[PATH_MAX];
|
2013-10-14 07:57:29 -06:00
|
|
|
struct dirent *dent;
|
|
|
|
int ret = -1;
|
|
|
|
DIR *d;
|
|
|
|
|
|
|
|
d = opendir(to_dir);
|
|
|
|
if (!d)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
scnprintf(from, sizeof(from), "%s/modules", from_dir);
|
|
|
|
|
|
|
|
while (1) {
|
|
|
|
dent = readdir(d);
|
|
|
|
if (!dent)
|
|
|
|
break;
|
|
|
|
if (dent->d_type != DT_DIR)
|
|
|
|
continue;
|
|
|
|
scnprintf(to, sizeof(to), "%s/%s/modules", to_dir,
|
|
|
|
dent->d_name);
|
2014-01-29 07:14:44 -07:00
|
|
|
scnprintf(to_subdir, sizeof(to_subdir), "%s/%s",
|
|
|
|
to_dir, dent->d_name);
|
|
|
|
if (!compare_proc_modules(from, to) &&
|
|
|
|
same_kallsyms_reloc(from_dir, to_subdir)) {
|
|
|
|
strlcpy(to_dir, to_subdir, to_dir_sz);
|
2013-10-14 07:57:29 -06:00
|
|
|
ret = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
closedir(d);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-02-10 02:18:51 -07:00
|
|
|
static int build_id_cache__add_kcore(const char *filename, bool force)
|
2013-10-14 07:57:29 -06:00
|
|
|
{
|
2015-07-15 03:14:28 -06:00
|
|
|
char dir[32], sbuildid[SBUILD_ID_SIZE];
|
2013-10-14 07:57:29 -06:00
|
|
|
char from_dir[PATH_MAX], to_dir[PATH_MAX];
|
|
|
|
char *p;
|
|
|
|
|
|
|
|
strlcpy(from_dir, filename, sizeof(from_dir));
|
|
|
|
|
|
|
|
p = strrchr(from_dir, '/');
|
|
|
|
if (!p || strcmp(p + 1, "kcore"))
|
|
|
|
return -1;
|
|
|
|
*p = '\0';
|
|
|
|
|
2015-08-15 05:42:59 -06:00
|
|
|
if (build_id_cache__kcore_buildid(from_dir, sbuildid) < 0)
|
2013-10-14 07:57:29 -06:00
|
|
|
return -1;
|
|
|
|
|
2016-05-14 21:19:40 -06:00
|
|
|
scnprintf(to_dir, sizeof(to_dir), "%s/%s/%s",
|
|
|
|
buildid_dir, DSO__NAME_KCORE, sbuildid);
|
2013-10-14 07:57:29 -06:00
|
|
|
|
2014-07-14 04:02:38 -06:00
|
|
|
if (!force &&
|
|
|
|
!build_id_cache__kcore_existing(from_dir, to_dir, sizeof(to_dir))) {
|
2013-10-14 07:57:29 -06:00
|
|
|
pr_debug("same kcore found in %s\n", to_dir);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (build_id_cache__kcore_dir(dir, sizeof(dir)))
|
|
|
|
return -1;
|
|
|
|
|
2016-05-14 21:19:40 -06:00
|
|
|
scnprintf(to_dir, sizeof(to_dir), "%s/%s/%s/%s",
|
|
|
|
buildid_dir, DSO__NAME_KCORE, sbuildid, dir);
|
2013-10-14 07:57:29 -06:00
|
|
|
|
|
|
|
if (mkdir_p(to_dir, 0755))
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
if (kcore_copy(from_dir, to_dir)) {
|
|
|
|
/* Remove YYYYmmddHHMMSShh directory */
|
|
|
|
if (!rmdir(to_dir)) {
|
|
|
|
p = strrchr(to_dir, '/');
|
|
|
|
if (p)
|
|
|
|
*p = '\0';
|
|
|
|
/* Try to remove buildid directory */
|
|
|
|
if (!rmdir(to_dir)) {
|
|
|
|
p = strrchr(to_dir, '/');
|
|
|
|
if (p)
|
|
|
|
*p = '\0';
|
|
|
|
/* Try to remove [kernel.kcore] directory */
|
|
|
|
rmdir(to_dir);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
pr_debug("kcore added to build-id cache directory %s\n", to_dir);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-02-10 02:18:51 -07:00
|
|
|
static int build_id_cache__add_file(const char *filename)
|
2010-01-20 10:28:45 -07:00
|
|
|
{
|
2015-07-15 03:14:28 -06:00
|
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
2010-01-20 10:28:45 -07:00
|
|
|
u8 build_id[BUILD_ID_SIZE];
|
|
|
|
int err;
|
|
|
|
|
|
|
|
if (filename__read_build_id(filename, &build_id, sizeof(build_id)) < 0) {
|
|
|
|
pr_debug("Couldn't read a build-id in %s\n", filename);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
build_id__sprintf(build_id, sizeof(build_id), sbuild_id);
|
2015-02-10 02:18:51 -07:00
|
|
|
err = build_id_cache__add_s(sbuild_id, filename,
|
2012-09-10 10:50:19 -06:00
|
|
|
false, false);
|
2015-02-26 21:50:28 -07:00
|
|
|
pr_debug("Adding %s %s: %s\n", sbuild_id, filename,
|
|
|
|
err ? "FAIL" : "Ok");
|
2010-01-20 10:28:45 -07:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2015-02-10 02:18:51 -07:00
|
|
|
static int build_id_cache__remove_file(const char *filename)
|
2010-01-20 10:28:45 -07:00
|
|
|
{
|
|
|
|
u8 build_id[BUILD_ID_SIZE];
|
2015-07-15 03:14:28 -06:00
|
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
2010-01-20 10:28:45 -07:00
|
|
|
|
|
|
|
int err;
|
|
|
|
|
|
|
|
if (filename__read_build_id(filename, &build_id, sizeof(build_id)) < 0) {
|
|
|
|
pr_debug("Couldn't read a build-id in %s\n", filename);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
build_id__sprintf(build_id, sizeof(build_id), sbuild_id);
|
2015-02-10 02:18:51 -07:00
|
|
|
err = build_id_cache__remove_s(sbuild_id);
|
2015-02-26 21:50:28 -07:00
|
|
|
pr_debug("Removing %s %s: %s\n", sbuild_id, filename,
|
|
|
|
err ? "FAIL" : "Ok");
|
2010-01-20 10:28:45 -07:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2015-02-26 21:50:26 -07:00
|
|
|
static int build_id_cache__purge_path(const char *pathname)
|
|
|
|
{
|
|
|
|
struct strlist *list;
|
|
|
|
struct str_node *pos;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
err = build_id_cache__list_build_ids(pathname, &list);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
|
|
|
|
2016-06-23 08:31:20 -06:00
|
|
|
strlist__for_each_entry(pos, list) {
|
2015-02-26 21:50:26 -07:00
|
|
|
err = build_id_cache__remove_s(pos->s);
|
2015-02-26 21:50:28 -07:00
|
|
|
pr_debug("Removing %s %s: %s\n", pos->s, pathname,
|
|
|
|
err ? "FAIL" : "Ok");
|
2015-02-26 21:50:26 -07:00
|
|
|
if (err)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
strlist__delete(list);
|
|
|
|
|
|
|
|
out:
|
2015-02-26 21:50:28 -07:00
|
|
|
pr_debug("Purging %s: %s\n", pathname, err ? "FAIL" : "Ok");
|
2015-02-26 21:50:26 -07:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2012-12-07 12:28:27 -07:00
|
|
|
static bool dso__missing_buildid_cache(struct dso *dso, int parm __maybe_unused)
|
|
|
|
{
|
|
|
|
char filename[PATH_MAX];
|
|
|
|
u8 build_id[BUILD_ID_SIZE];
|
|
|
|
|
|
|
|
if (dso__build_id_filename(dso, filename, sizeof(filename)) &&
|
|
|
|
filename__read_build_id(filename, build_id,
|
|
|
|
sizeof(build_id)) != sizeof(build_id)) {
|
|
|
|
if (errno == ENOENT)
|
|
|
|
return false;
|
|
|
|
|
2014-12-17 13:24:45 -07:00
|
|
|
pr_warning("Problems with %s file, consider removing it from the cache\n",
|
2012-12-07 12:28:27 -07:00
|
|
|
filename);
|
|
|
|
} else if (memcmp(dso->build_id, build_id, sizeof(dso->build_id))) {
|
2014-12-17 13:24:45 -07:00
|
|
|
pr_warning("Problems with %s file, consider removing it from the cache\n",
|
2012-12-07 12:28:27 -07:00
|
|
|
filename);
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2014-08-12 00:40:36 -06:00
|
|
|
static int build_id_cache__fprintf_missing(struct perf_session *session, FILE *fp)
|
2012-12-07 12:28:27 -07:00
|
|
|
{
|
|
|
|
perf_session__fprintf_dsos_buildid(session, fp, dso__missing_buildid_cache, 0);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-02-10 02:18:51 -07:00
|
|
|
static int build_id_cache__update_file(const char *filename)
|
2013-02-07 02:02:11 -07:00
|
|
|
{
|
|
|
|
u8 build_id[BUILD_ID_SIZE];
|
2015-07-15 03:14:28 -06:00
|
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
2013-02-07 02:02:11 -07:00
|
|
|
|
2015-02-25 23:54:40 -07:00
|
|
|
int err = 0;
|
2013-02-07 02:02:11 -07:00
|
|
|
|
|
|
|
if (filename__read_build_id(filename, &build_id, sizeof(build_id)) < 0) {
|
|
|
|
pr_debug("Couldn't read a build-id in %s\n", filename);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
build_id__sprintf(build_id, sizeof(build_id), sbuild_id);
|
2015-02-25 23:54:40 -07:00
|
|
|
if (build_id_cache__cached(sbuild_id))
|
|
|
|
err = build_id_cache__remove_s(sbuild_id);
|
|
|
|
|
2015-02-10 02:18:51 -07:00
|
|
|
if (!err)
|
|
|
|
err = build_id_cache__add_s(sbuild_id, filename, false, false);
|
|
|
|
|
2015-02-26 21:50:28 -07:00
|
|
|
pr_debug("Updating %s %s: %s\n", sbuild_id, filename,
|
|
|
|
err ? "FAIL" : "Ok");
|
2013-02-07 02:02:11 -07:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2012-10-01 12:20:58 -06:00
|
|
|
int cmd_buildid_cache(int argc, const char **argv,
|
|
|
|
const char *prefix __maybe_unused)
|
2010-01-20 10:28:45 -07:00
|
|
|
{
|
|
|
|
struct strlist *list;
|
|
|
|
struct str_node *pos;
|
2012-12-07 12:28:27 -07:00
|
|
|
int ret = 0;
|
|
|
|
bool force = false;
|
2012-10-01 12:20:58 -06:00
|
|
|
char const *add_name_list_str = NULL,
|
2012-12-07 12:28:27 -07:00
|
|
|
*remove_name_list_str = NULL,
|
2015-02-26 21:50:26 -07:00
|
|
|
*purge_name_list_str = NULL,
|
2013-02-07 02:02:11 -07:00
|
|
|
*missing_filename = NULL,
|
2013-10-14 07:57:29 -06:00
|
|
|
*update_name_list_str = NULL,
|
2014-12-01 12:06:27 -07:00
|
|
|
*kcore_filename = NULL;
|
2014-08-13 20:22:49 -06:00
|
|
|
char sbuf[STRERR_BUFSIZE];
|
2013-02-07 02:02:11 -07:00
|
|
|
|
2014-08-12 00:40:36 -06:00
|
|
|
struct perf_data_file file = {
|
|
|
|
.mode = PERF_DATA_MODE_READ,
|
|
|
|
};
|
|
|
|
struct perf_session *session = NULL;
|
|
|
|
|
2012-10-01 12:20:58 -06:00
|
|
|
const struct option buildid_cache_options[] = {
|
|
|
|
OPT_STRING('a', "add", &add_name_list_str,
|
|
|
|
"file list", "file(s) to add"),
|
2013-10-14 07:57:29 -06:00
|
|
|
OPT_STRING('k', "kcore", &kcore_filename,
|
|
|
|
"file", "kcore file to add"),
|
2012-10-01 12:20:58 -06:00
|
|
|
OPT_STRING('r', "remove", &remove_name_list_str, "file list",
|
|
|
|
"file(s) to remove"),
|
2015-02-26 21:50:26 -07:00
|
|
|
OPT_STRING('p', "purge", &purge_name_list_str, "path list",
|
|
|
|
"path(s) to remove (remove old caches too)"),
|
2012-12-07 12:28:27 -07:00
|
|
|
OPT_STRING('M', "missing", &missing_filename, "file",
|
|
|
|
"to find missing build ids in the cache"),
|
|
|
|
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
|
2013-02-07 02:02:11 -07:00
|
|
|
OPT_STRING('u', "update", &update_name_list_str, "file list",
|
|
|
|
"file(s) to update"),
|
2012-10-01 12:20:58 -06:00
|
|
|
OPT_INCR('v', "verbose", &verbose, "be more verbose"),
|
|
|
|
OPT_END()
|
|
|
|
};
|
|
|
|
const char * const buildid_cache_usage[] = {
|
|
|
|
"perf buildid-cache [<options>]",
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
argc = parse_options(argc, argv, buildid_cache_options,
|
|
|
|
buildid_cache_usage, 0);
|
|
|
|
|
2015-02-26 21:50:31 -07:00
|
|
|
if (argc || (!add_name_list_str && !kcore_filename &&
|
|
|
|
!remove_name_list_str && !purge_name_list_str &&
|
|
|
|
!missing_filename && !update_name_list_str))
|
|
|
|
usage_with_options(buildid_cache_usage, buildid_cache_options);
|
|
|
|
|
2014-08-12 00:40:36 -06:00
|
|
|
if (missing_filename) {
|
|
|
|
file.path = missing_filename;
|
|
|
|
file.force = force;
|
|
|
|
|
|
|
|
session = perf_session__new(&file, false, NULL);
|
|
|
|
if (session == NULL)
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2014-08-12 00:40:45 -06:00
|
|
|
if (symbol__init(session ? &session->header.env : NULL) < 0)
|
2014-08-12 00:40:36 -06:00
|
|
|
goto out;
|
2012-10-01 12:20:58 -06:00
|
|
|
|
|
|
|
setup_pager();
|
2010-01-20 10:28:45 -07:00
|
|
|
|
|
|
|
if (add_name_list_str) {
|
2015-07-20 09:13:34 -06:00
|
|
|
list = strlist__new(add_name_list_str, NULL);
|
2010-01-20 10:28:45 -07:00
|
|
|
if (list) {
|
2016-06-23 08:31:20 -06:00
|
|
|
strlist__for_each_entry(pos, list)
|
2015-02-10 02:18:51 -07:00
|
|
|
if (build_id_cache__add_file(pos->s)) {
|
2010-01-20 10:28:45 -07:00
|
|
|
if (errno == EEXIST) {
|
|
|
|
pr_debug("%s already in the cache\n",
|
|
|
|
pos->s);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
pr_warning("Couldn't add %s: %s\n",
|
tools: Introduce str_error_r()
The tools so far have been using the strerror_r() GNU variant, that
returns a string, be it the buffer passed or something else.
But that, besides being tricky in cases where we expect that the
function using strerror_r() returns the error formatted in a provided
buffer (we have to check if it returned something else and copy that
instead), breaks the build on systems not using glibc, like Alpine
Linux, where musl libc is used.
So, introduce yet another wrapper, str_error_r(), that has the GNU
interface, but uses the portable XSI variant of strerror_r(), so that
users rest asured that the provided buffer is used and it is what is
returned.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-d4t42fnf48ytlk8rjxs822tf@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2016-07-06 08:56:20 -06:00
|
|
|
pos->s, str_error_r(errno, sbuf, sizeof(sbuf)));
|
2010-01-20 10:28:45 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
strlist__delete(list);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (remove_name_list_str) {
|
2015-07-20 09:13:34 -06:00
|
|
|
list = strlist__new(remove_name_list_str, NULL);
|
2010-01-20 10:28:45 -07:00
|
|
|
if (list) {
|
2016-06-23 08:31:20 -06:00
|
|
|
strlist__for_each_entry(pos, list)
|
2015-02-10 02:18:51 -07:00
|
|
|
if (build_id_cache__remove_file(pos->s)) {
|
2010-01-20 10:28:45 -07:00
|
|
|
if (errno == ENOENT) {
|
|
|
|
pr_debug("%s wasn't in the cache\n",
|
|
|
|
pos->s);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
pr_warning("Couldn't remove %s: %s\n",
|
tools: Introduce str_error_r()
The tools so far have been using the strerror_r() GNU variant, that
returns a string, be it the buffer passed or something else.
But that, besides being tricky in cases where we expect that the
function using strerror_r() returns the error formatted in a provided
buffer (we have to check if it returned something else and copy that
instead), breaks the build on systems not using glibc, like Alpine
Linux, where musl libc is used.
So, introduce yet another wrapper, str_error_r(), that has the GNU
interface, but uses the portable XSI variant of strerror_r(), so that
users rest asured that the provided buffer is used and it is what is
returned.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-d4t42fnf48ytlk8rjxs822tf@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2016-07-06 08:56:20 -06:00
|
|
|
pos->s, str_error_r(errno, sbuf, sizeof(sbuf)));
|
2010-01-20 10:28:45 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
strlist__delete(list);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-26 21:50:26 -07:00
|
|
|
if (purge_name_list_str) {
|
2015-07-20 09:13:34 -06:00
|
|
|
list = strlist__new(purge_name_list_str, NULL);
|
2015-02-26 21:50:26 -07:00
|
|
|
if (list) {
|
2016-06-23 08:31:20 -06:00
|
|
|
strlist__for_each_entry(pos, list)
|
2015-02-26 21:50:26 -07:00
|
|
|
if (build_id_cache__purge_path(pos->s)) {
|
|
|
|
if (errno == ENOENT) {
|
|
|
|
pr_debug("%s wasn't in the cache\n",
|
|
|
|
pos->s);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
pr_warning("Couldn't remove %s: %s\n",
|
tools: Introduce str_error_r()
The tools so far have been using the strerror_r() GNU variant, that
returns a string, be it the buffer passed or something else.
But that, besides being tricky in cases where we expect that the
function using strerror_r() returns the error formatted in a provided
buffer (we have to check if it returned something else and copy that
instead), breaks the build on systems not using glibc, like Alpine
Linux, where musl libc is used.
So, introduce yet another wrapper, str_error_r(), that has the GNU
interface, but uses the portable XSI variant of strerror_r(), so that
users rest asured that the provided buffer is used and it is what is
returned.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-d4t42fnf48ytlk8rjxs822tf@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2016-07-06 08:56:20 -06:00
|
|
|
pos->s, str_error_r(errno, sbuf, sizeof(sbuf)));
|
2015-02-26 21:50:26 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
strlist__delete(list);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-12-07 12:28:27 -07:00
|
|
|
if (missing_filename)
|
2014-08-12 00:40:36 -06:00
|
|
|
ret = build_id_cache__fprintf_missing(session, stdout);
|
2012-12-07 12:28:27 -07:00
|
|
|
|
2013-02-07 02:02:11 -07:00
|
|
|
if (update_name_list_str) {
|
2015-07-20 09:13:34 -06:00
|
|
|
list = strlist__new(update_name_list_str, NULL);
|
2013-02-07 02:02:11 -07:00
|
|
|
if (list) {
|
2016-06-23 08:31:20 -06:00
|
|
|
strlist__for_each_entry(pos, list)
|
2015-02-10 02:18:51 -07:00
|
|
|
if (build_id_cache__update_file(pos->s)) {
|
2013-02-07 02:02:11 -07:00
|
|
|
if (errno == ENOENT) {
|
|
|
|
pr_debug("%s wasn't in the cache\n",
|
|
|
|
pos->s);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
pr_warning("Couldn't update %s: %s\n",
|
tools: Introduce str_error_r()
The tools so far have been using the strerror_r() GNU variant, that
returns a string, be it the buffer passed or something else.
But that, besides being tricky in cases where we expect that the
function using strerror_r() returns the error formatted in a provided
buffer (we have to check if it returned something else and copy that
instead), breaks the build on systems not using glibc, like Alpine
Linux, where musl libc is used.
So, introduce yet another wrapper, str_error_r(), that has the GNU
interface, but uses the portable XSI variant of strerror_r(), so that
users rest asured that the provided buffer is used and it is what is
returned.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-d4t42fnf48ytlk8rjxs822tf@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2016-07-06 08:56:20 -06:00
|
|
|
pos->s, str_error_r(errno, sbuf, sizeof(sbuf)));
|
2013-02-07 02:02:11 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
strlist__delete(list);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-10 02:18:51 -07:00
|
|
|
if (kcore_filename && build_id_cache__add_kcore(kcore_filename, force))
|
2013-10-14 07:57:29 -06:00
|
|
|
pr_warning("Couldn't add %s\n", kcore_filename);
|
|
|
|
|
2014-08-12 00:40:36 -06:00
|
|
|
out:
|
2016-06-22 07:02:16 -06:00
|
|
|
perf_session__delete(session);
|
2014-08-12 00:40:36 -06:00
|
|
|
|
2012-12-07 12:28:27 -07:00
|
|
|
return ret;
|
2010-01-20 10:28:45 -07:00
|
|
|
}
|