redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

rtlwifi: rtl8192cu: Fix value set in descriptor 

In the process of converting the bit manipulation macros were converted
to use GENMASK(), the compiler reported a value too big for the field.
The offending statement was trying to write 0x100 into a 5-bit field.
An accompaning comment says to set bit 3, thus the code is changed
appropriately.

This error has been in the driver since its initial submission.

Fixes: 29d00a3e46 ("rtlwifi: rtl8192cu: Add routine trx")
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
alistair/sunxi64-5.4-dsi
Larry Finger 2019-08-12 14:27:41 -05:00 committed by Kalle Valo
parent b6326fc025
commit 01bb31de52
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
View File

@ -611,7 +611,7 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 *pdesc,
SET_TX_DESC_NAV_USE_HDR(pdesc, 1);
} else {
SET_TX_DESC_HWSEQ_EN(pdesc, 1); /* Hw set sequence number */
SET_TX_DESC_PKT_ID(pdesc, 0x100); /* set bit3 to 1. */
SET_TX_DESC_PKT_ID(pdesc, BIT(3)); /* set bit3 to 1. */
}
SET_TX_DESC_USE_RATE(pdesc, 1); /* use data rate which is set by Sw */
SET_TX_DESC_OWN(pdesc, 1);