drivers/net/wireless/libertas_tf: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the allocated region. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
80caf6017a
commit
0273002953
|
@ -538,7 +538,8 @@ static void if_usb_receive_fwload(struct urb *urb)
|
|||
return;
|
||||
}
|
||||
|
||||
syncfwheader = kmalloc(sizeof(struct fwsyncheader), GFP_ATOMIC);
|
||||
syncfwheader = kmemdup(skb->data, sizeof(struct fwsyncheader),
|
||||
GFP_ATOMIC);
|
||||
if (!syncfwheader) {
|
||||
lbtf_deb_usbd(&cardp->udev->dev, "Failure to allocate syncfwheader\n");
|
||||
kfree_skb(skb);
|
||||
|
@ -546,8 +547,6 @@ static void if_usb_receive_fwload(struct urb *urb)
|
|||
return;
|
||||
}
|
||||
|
||||
memcpy(syncfwheader, skb->data, sizeof(struct fwsyncheader));
|
||||
|
||||
if (!syncfwheader->cmd) {
|
||||
lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk with correct CRC\n");
|
||||
lbtf_deb_usb2(&cardp->udev->dev, "FW received Blk seqnum = %d\n",
|
||||
|
|
Loading…
Reference in a new issue