redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: core: add defensive connection disable post disconnect 

Bundle drivers *must* disable their connections in the disconnect
callback, but add a defensive test and warn about buggy drivers
nonetheless.

Note that bundle drivers would generally release their state containers
in disconnect so a failure stop I/O could potentially lead to
use-after-free bugs in any late operation completion callbacks.

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Johan Hovold 2016-01-19 12:51:10 +01:00 committed by Greg Kroah-Hartman
parent fa8369c130
commit 02a54dd18f
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/greybus/core.c
View File

@ -165,6 +165,13 @@ static int greybus_remove(struct device *dev)
gb_connection_disable_rx(connection);
driver->disconnect(bundle);
/* Catch buggy drivers that fail to disable their connections. */
list_for_each_entry(connection, &bundle->connections, bundle_links) {
if (WARN_ON(connection->state != GB_CONNECTION_STATE_DISABLED))
gb_connection_disable(connection);
}
return 0;
}