ext4: open-code ext4_mb_update_group_info
ext4_mb_update_group_info is only called in one place, and it's extremely simple. There's no reason to have it in a separate function in a separate file as far as I can tell, it just obfuscates what's really going on. Perhaps it was intended to keep the grp->bb_* manipulation local to mballoc.c but we're already accessing other grp-> fields in balloc.c directly so this seems ok. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
This commit is contained in:
parent
bf43d84b18
commit
0373130d5b
|
@ -478,7 +478,7 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb,
|
||||||
* new bitmap information
|
* new bitmap information
|
||||||
*/
|
*/
|
||||||
set_bit(EXT4_GROUP_INFO_NEED_INIT_BIT, &(grp->bb_state));
|
set_bit(EXT4_GROUP_INFO_NEED_INIT_BIT, &(grp->bb_state));
|
||||||
ext4_mb_update_group_info(grp, blocks_freed);
|
grp->bb_free += blocks_freed;
|
||||||
up_write(&grp->alloc_sem);
|
up_write(&grp->alloc_sem);
|
||||||
|
|
||||||
/* We dirtied the bitmap block */
|
/* We dirtied the bitmap block */
|
||||||
|
|
|
@ -1343,8 +1343,6 @@ extern void ext4_mb_free_blocks(handle_t *, struct inode *,
|
||||||
ext4_fsblk_t, unsigned long, int, unsigned long *);
|
ext4_fsblk_t, unsigned long, int, unsigned long *);
|
||||||
extern int ext4_mb_add_groupinfo(struct super_block *sb,
|
extern int ext4_mb_add_groupinfo(struct super_block *sb,
|
||||||
ext4_group_t i, struct ext4_group_desc *desc);
|
ext4_group_t i, struct ext4_group_desc *desc);
|
||||||
extern void ext4_mb_update_group_info(struct ext4_group_info *grp,
|
|
||||||
ext4_grpblk_t add);
|
|
||||||
extern int ext4_mb_get_buddy_cache_lock(struct super_block *, ext4_group_t);
|
extern int ext4_mb_get_buddy_cache_lock(struct super_block *, ext4_group_t);
|
||||||
extern void ext4_mb_put_buddy_cache_lock(struct super_block *,
|
extern void ext4_mb_put_buddy_cache_lock(struct super_block *,
|
||||||
ext4_group_t, int);
|
ext4_group_t, int);
|
||||||
|
|
|
@ -2554,15 +2554,6 @@ exit_meta_group_info:
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
} /* ext4_mb_add_groupinfo */
|
} /* ext4_mb_add_groupinfo */
|
||||||
|
|
||||||
/*
|
|
||||||
* Update an existing group.
|
|
||||||
* This function is used for online resize
|
|
||||||
*/
|
|
||||||
void ext4_mb_update_group_info(struct ext4_group_info *grp, ext4_grpblk_t add)
|
|
||||||
{
|
|
||||||
grp->bb_free += add;
|
|
||||||
}
|
|
||||||
|
|
||||||
static int ext4_mb_init_backend(struct super_block *sb)
|
static int ext4_mb_init_backend(struct super_block *sb)
|
||||||
{
|
{
|
||||||
ext4_group_t ngroups = ext4_get_groups_count(sb);
|
ext4_group_t ngroups = ext4_get_groups_count(sb);
|
||||||
|
|
Loading…
Reference in a new issue