redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ipmi_si: Potential array underflow in hotmod_handler() 

The "ival" variable needs to signed so that we don't read before the
start of the str[] array.  This would only happen the user passed in a
module parameter that was just comprised of space characters.

Fixes: e80444ae4fc3 ("ipmi_si: Switch hotmod to use a platform device")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Message-Id: <20190222195530.GA306@kadam>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
hifive-unleashed-5.1
Dan Carpenter 2019-02-22 22:55:30 +03:00 committed by Corey Minyard
parent 90b2d4f15f
commit 0389035933
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/char/ipmi/ipmi_si_hotmod.c
View File

@ -187,7 +187,8 @@ static int hotmod_handler(const char *val, const struct kernel_param *kp)
char *str = kstrdup(val, GFP_KERNEL), *curr, *next;
int rv;
struct ipmi_plat_data h;
unsigned int len, ival;
unsigned int len;
int ival;
if (!str)
return -ENOMEM;