redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

cxgb4: Initialize mbox lock and list for mgmt dev

Browse source 
Initialize mbox lock and list for mgmt dev to avoid NULL pointer
dereference when cxgb_set_vf_mac is called.

And also allocate memory for private data while allocating mgmt
netdev.

Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ganesh Goudar 2017-01-12 12:23:21 +05:30 committed by David S. Miller
parent 738b35ccee
commit 038c35a86d
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
View file

@ -4516,7 +4516,8 @@ static int config_mgmt_dev(struct pci_dev *pdev)
int err;
snprintf(name, IFNAMSIZ, "mgmtpf%d%d", adap->adap_idx, adap->pf);
netdev = alloc_netdev(0, name, NET_NAME_UNKNOWN, dummy_setup);
netdev = alloc_netdev(sizeof(struct port_info), name, NET_NAME_UNKNOWN,
dummy_setup);
if (!netdev)
return -ENOMEM;
@ -4990,6 +4991,8 @@ sriov:
err = -ENOMEM;
goto free_adapter;
}
spin_lock_init(&adapter->mbox_lock);
INIT_LIST_HEAD(&adapter->mlist.list);
pci_set_drvdata(pdev, adapter);
return 0;