redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ALSA: oxfw: fix wrong reference count for stream functionality at error path of rawmidi interface 

In IEC 61883-6, several types of sampling data can be multiplexed into
payload of common isochronous packet (CIP). For typical audio and music
units, PCM samples and MIDI messages are multiplexed into one packet
streaming.

ALSA oxfw driver allows applications of rawmidi interface to start
packet streaming for transmission of MIDI messages. However at error
path, the reference count of stream functionality is not operated
correctly. This can brings a bug that packet streaming is not stopped
when all referrers release the count.

This commit fixes the bug.

Fixes: 4f380d0070 ("ALSA: oxfw: configure packet format in pcm.hw_params callback")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
alistair/sunxi64-5.4-dsi
Takashi Sakamoto 2019-07-07 14:20:08 +09:00 committed by Takashi Iwai
parent 2e9f17e34e
commit 03a954aef7
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/firewire/oxfw/oxfw-midi.c
View File

@ -23,6 +23,8 @@ static int midi_capture_open(struct snd_rawmidi_substream *substream)
if (err >= 0) {
++oxfw->substreams_count;
err = snd_oxfw_stream_start_duplex(oxfw);
if (err < 0)
--oxfw->substreams_count;
}
mutex_unlock(&oxfw->mutex);