redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

V4L/DVB (5743): Tuner: clean up kfree() after release

Browse source 
Although it is safe to kfree(NULL), We only need to kfree(priv)
if the release callback is undefined.  As it stands now, there
is some redundancy in the operation of releasing the priv data
structures. This patch will call kfree(priv) and set priv to NULL,
if the release callback isnt defined.  Otherwise, let the release
callback handle this itself.
Thanks to Mauro Carvalho Chehab for suggesting this.

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
This commit is contained in:
Michael Krufky 2007-06-04 16:00:45 -03:00 committed by Mauro Carvalho Chehab
parent 024cf53089
commit 052c50d916
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/media/video/tuner-core.c
View file

@ -180,8 +180,10 @@ static void set_type(struct i2c_client *c, unsigned int type,
/* discard private data, in case set_type() was previously called */
if (t->release)
t->release(c);
kfree(t->priv);
t->priv = NULL;
else {
kfree(t->priv);
t->priv = NULL;
}
switch (t->type) {
case TUNER_MT2032:
@ -566,7 +568,9 @@ static int tuner_detach(struct i2c_client *client)
if (t->release)
t->release(client);
kfree(t->priv);
else {
kfree(t->priv);
}
kfree(t);
return 0;
}