redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: mt7621-mmc: Remove multiple assignments

Browse source 
Fix checkpatch: multiple assignments should be avoided, to improve
readability.
It aslo moves the second assignment out of the if/else block, that is
valid, because drv_mode is of type msdc_mode, an enum with only those
three elements, so one of the if/ else if statements is always
taken. And the second assignment can happen after the conditions.

Signed-off-by: Christian Lütke-Stetzkamp <christian@lkamp.de>
Reviewed-by: NeilBrown <neil@brown.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian Lütke-Stetzkamp 2018-04-24 20:01:23 +02:00 committed by Greg Kroah-Hartman
parent afcc0ca1c8
commit 05e41c96a6
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/staging/mt7621-mmc/sd.c
View file

@ -1397,11 +1397,12 @@ static int msdc_do_request(struct mmc_host *mmc, struct mmc_request *mrq)
/* deside the transfer mode */
if (drv_mode[host->id] == MODE_PIO)
host->dma_xfer = dma = 0;
host->dma_xfer = 0;
else if (drv_mode[host->id] == MODE_DMA)
host->dma_xfer = dma = 1;
host->dma_xfer = 1;
else if (drv_mode[host->id] == MODE_SIZE_DEP)
host->dma_xfer = dma = ((host->xfer_size >= dma_size[host->id]) ? 1 : 0);
host->dma_xfer = ((host->xfer_size >= dma_size[host->id]) ? 1 : 0);
dma = host->dma_xfer;
if (read) {
if ((host->timeout_ns != data->timeout_ns) ||