redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[SCSI] zfcp: Remove qtcb dump to kernel log

Browse source 
Is not appropriate to printk() tons of hardware trace data.

Signed-off-by: Martin Peschke <mp3@de.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
Martin Peschke 2008-03-27 14:21:57 +01:00 committed by James Bottomley
parent 0f65e951ee
commit 07c70d26b5
1 changed files with 0 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
drivers/s390/scsi/zfcp_fsf.c
View file

@ -284,37 +284,6 @@ zfcp_fsf_protstatus_eval(struct zfcp_fsf_req *fsf_req)
goto skip_protstatus;
}
/* log additional information provided by FSF (if any) */
if (likely(qtcb->header.log_length)) {
/* do not trust them ;-) */
if (unlikely(qtcb->header.log_start >
sizeof(struct fsf_qtcb))) {
ZFCP_LOG_NORMAL
("bug: ULP (FSF logging) log data starts "
"beyond end of packet header. Ignored. "
"(start=%i, size=%li)\n",
qtcb->header.log_start,
sizeof(struct fsf_qtcb));
goto forget_log;
}
if (unlikely((size_t) (qtcb->header.log_start +
qtcb->header.log_length) >
sizeof(struct fsf_qtcb))) {
ZFCP_LOG_NORMAL("bug: ULP (FSF logging) log data ends "
"beyond end of packet header. Ignored. "
"(start=%i, length=%i, size=%li)\n",
qtcb->header.log_start,
qtcb->header.log_length,
sizeof(struct fsf_qtcb));
goto forget_log;
}
ZFCP_LOG_TRACE("ULP log data: \n");
ZFCP_HEX_DUMP(ZFCP_LOG_LEVEL_TRACE,
(char *) qtcb + qtcb->header.log_start,
qtcb->header.log_length);
}
forget_log:
/* evaluate FSF Protocol Status */
switch (qtcb->prefix.prot_status) {