[media] media: ti-vpe: vpdma: Use bidirectional cached buffers
VPDMA buffer will be used by CPU as well as by the VPDMA. CPU will write/update the VPDMA descriptors containing data about the video buffer DMA addresses. VPDMA will write the "write descriptor" containing the data about the DMA operation. When mapping/unmapping the buffer, driver has to take care of WriteBack and invalidation of the cache so that all the coherency is maintained from both directions. Use DMA_BIDIRECTIONAL to maintain coherency between CPU and VPDMA. Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com> Signed-off-by: Benoit Parrot <bparrot@ti.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
parent
c786595beb
commit
07e72eb072
|
@ -367,7 +367,7 @@ int vpdma_map_desc_buf(struct vpdma_data *vpdma, struct vpdma_buf *buf)
|
||||||
|
|
||||||
WARN_ON(buf->mapped);
|
WARN_ON(buf->mapped);
|
||||||
buf->dma_addr = dma_map_single(dev, buf->addr, buf->size,
|
buf->dma_addr = dma_map_single(dev, buf->addr, buf->size,
|
||||||
DMA_TO_DEVICE);
|
DMA_BIDIRECTIONAL);
|
||||||
if (dma_mapping_error(dev, buf->dma_addr)) {
|
if (dma_mapping_error(dev, buf->dma_addr)) {
|
||||||
dev_err(dev, "failed to map buffer\n");
|
dev_err(dev, "failed to map buffer\n");
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
@ -388,7 +388,8 @@ void vpdma_unmap_desc_buf(struct vpdma_data *vpdma, struct vpdma_buf *buf)
|
||||||
struct device *dev = &vpdma->pdev->dev;
|
struct device *dev = &vpdma->pdev->dev;
|
||||||
|
|
||||||
if (buf->mapped)
|
if (buf->mapped)
|
||||||
dma_unmap_single(dev, buf->dma_addr, buf->size, DMA_TO_DEVICE);
|
dma_unmap_single(dev, buf->dma_addr, buf->size,
|
||||||
|
DMA_BIDIRECTIONAL);
|
||||||
|
|
||||||
buf->mapped = false;
|
buf->mapped = false;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue