redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

Staging: lustre: llite: llite_lib: remove unneeded null test before free

Browse source 
Kfree can cope with a null argument, so drop null tests.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ expression ptr; @@

- if (ptr != NULL)
  kfree(ptr);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julia Lawall 2015-05-01 21:38:00 +02:00 committed by Greg Kroah-Hartman
parent e6b9a3b225
commit 081825f589
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/staging/lustre/lustre/llite/llite_lib.c
View file

@ -574,10 +574,8 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt,
get_uuid2fsid(uuid->uuid, strlen(uuid->uuid), &sbi->ll_fsid);
}
if (data != NULL)
kfree(data);
if (osfs != NULL)
kfree(osfs);
kfree(data);
kfree(osfs);
return err;
out_root:
@ -595,10 +593,8 @@ out_md:
obd_disconnect(sbi->ll_md_exp);
sbi->ll_md_exp = NULL;
out:
if (data != NULL)
kfree(data);
if (osfs != NULL)
kfree(osfs);
kfree(data);
kfree(osfs);
lprocfs_unregister_mountpoint(sbi);
return err;
}