redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[PATCH] kfree cleanups for drivers/firmware/ 

Here's a patch with kfree() cleanups for drivers/firmware/efivars.c Patch
removes redundant NULL checks before kfree and also makes a small
whitespace cleanup - moves two statements on same line to separate lines.

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Acked-by: Matt Domsch <Matt_Domsch@dell.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
hifive-unleashed-5.1
Jesper Juhl 2005-06-25 14:59:15 -07:00 committed by Linus Torvalds
parent 0159f76d9f
commit 0933ad9c23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/firmware/efivars.c
View File

@ -618,8 +618,8 @@ efivar_create_sysfs_entry(unsigned long variable_name_size,
new_efivar = kmalloc(sizeof(struct efivar_entry), GFP_KERNEL);
if (!short_name || !new_efivar) {
if (short_name) kfree(short_name);
if (new_efivar) kfree(new_efivar);
kfree(short_name);
kfree(new_efivar);
return 1;
}
memset(short_name, 0, short_name_size+1);
@ -644,7 +644,8 @@ efivar_create_sysfs_entry(unsigned long variable_name_size,
kobj_set_kset_s(new_efivar, vars_subsys);
kobject_register(&new_efivar->kobj);
kfree(short_name); short_name = NULL;
kfree(short_name);
short_name = NULL;
spin_lock(&efivars_lock);
list_add(&new_efivar->list, &efivar_list);