redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

hwmon: (ams) Fix permissions on 'joystick' module parameter

Browse source 
We should not allow writes to the 'joystick' module parameters since
writing there will not trigger creation of the input device. Disable
writes since we provide alternative way of enabling input device via
AMS device's sysfs attribute.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
This commit is contained in:
Dmitry Torokhov 2008-10-17 17:51:12 +02:00 committed by Jean Delvare
parent 810ad7b62c
commit 0a02002268
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/hwmon/ams/ams-input.c
View file

@ -20,11 +20,11 @@
#include "ams.h"
static unsigned int joystick;
module_param(joystick, bool, 0644);
module_param(joystick, bool, S_IRUGO);
MODULE_PARM_DESC(joystick, "Enable the input class device on module load");
static unsigned int invert;
module_param(invert, bool, 0644);
module_param(invert, bool, S_IWUSR | S_IRUGO);
MODULE_PARM_DESC(invert, "Invert input data on X and Y axis");
static void ams_idev_poll(struct input_polled_dev *dev)