redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: most: cdev: simplify list iteration

Browse source 
This patch uses a less confusing list traversing structure to
either return an item of the list that meets the prerequisites
or NULL otherwise.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Link: https://lore.kernel.org/r/1592815695-19305-7-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian Gromm 2020-06-22 10:48:15 +02:00 committed by Greg Kroah-Hartman
parent 78aee65166
commit 0ae9e4f22d
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/staging/most/cdev/cdev.c
View file

@ -66,19 +66,16 @@ static struct comp_channel *get_channel(struct most_interface *iface, int id)
{ {
struct comp_channel *c, *tmp; struct comp_channel *c, *tmp;
unsigned long flags; unsigned long flags;
int found_channel = 0;
spin_lock_irqsave(&ch_list_lock, flags); spin_lock_irqsave(&ch_list_lock, flags);
list_for_each_entry_safe(c, tmp, &channel_list, list) { list_for_each_entry_safe(c, tmp, &channel_list, list) {
if ((c->iface == iface) && (c->channel_id == id)) { if ((c->iface == iface) && (c->channel_id == id)) {
found_channel = 1; spin_unlock_irqrestore(&ch_list_lock, flags);
break; return c;
} }
} }
spin_unlock_irqrestore(&ch_list_lock, flags); spin_unlock_irqrestore(&ch_list_lock, flags);
if (!found_channel) return NULL;
return NULL;
return c;
} }
static void stop_channel(struct comp_channel *c) static void stop_channel(struct comp_channel *c)