redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

usb: phy: twl6030-usb: signedness bug in twl6030_readb() 

"ret" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
hifive-unleashed-5.1
Dan Carpenter 2013-11-08 01:43:17 -08:00 committed by Felipe Balbi
parent 501fae5125
commit 0b55149033
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/phy/phy-twl6030-usb.c
View File

@ -127,7 +127,8 @@ static inline int twl6030_writeb(struct twl6030_usb *twl, u8 module,
static inline u8 twl6030_readb(struct twl6030_usb *twl, u8 module, u8 address)
{
u8 data, ret = 0;
u8 data;
int ret;
ret = twl_i2c_read_u8(module, &data, address);
if (ret >= 0)