redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

PCI/DPC: Squash dpc_rp_pio_print_tlp_header() into dpc_rp_pio_print_error() 

Separating dpc_rp_pio_print_tlp_header() doesn't really provide any useful
abstraction, so squash it into its caller, dpc_rp_pio_print_error().  No
functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Sinan Kaya <okaya@codeaurora.org>
hifive-unleashed-5.1
Bjorn Helgaas 2018-01-29 18:57:21 -06:00 committed by Bjorn Helgaas
parent e68d281cee
commit 0bbe0eb85f
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/pci/pcie/pcie-dpc.c
View File

@ -142,13 +142,6 @@ static void dpc_work(struct work_struct *work)
ctl | PCI_EXP_DPC_CTL_INT_EN);
}
static void dpc_rp_pio_print_tlp_header(struct device *dev,
struct rp_pio_header_log_regs *t)
{
dev_err(dev, "TLP Header: %#010x %#010x %#010x %#010x\n",
t->dw0, t->dw1, t->dw2, t->dw3);
}
static void dpc_rp_pio_print_error(struct dpc_dev *dpc,
struct dpc_rp_pio_regs *rp_pio)
{
@ -172,7 +165,9 @@ static void dpc_rp_pio_print_error(struct dpc_dev *dpc,
rp_pio->first_error == i ? " (First)" : "");
}
dpc_rp_pio_print_tlp_header(dev, &rp_pio->header_log);
dev_err(dev, "TLP Header: %#010x %#010x %#010x %#010x\n",
rp_pio->header_log.dw0, rp_pio->header_log.dw1,
rp_pio->header_log.dw2, rp_pio->header_log.dw3);
if (dpc->rp_log_size == 4)
return;