redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

power: qcom_smbb: test the correct variable 

"state" is a bool so it's never less than zero.  The intent was to test
"ret" instead.

Fixes: 56d7df8716 ('power: Add Qualcomm SMBB driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
hifive-unleashed-5.1
Dan Carpenter 2015-09-24 21:41:37 +03:00 committed by Sebastian Reichel
parent 28153a31b8
commit 0bc58e9381
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/power/qcom_smbb.c
View File

@ -351,7 +351,7 @@ static void smbb_set_line_flag(struct smbb_charger *chg, int irq, int flag)
int ret;
ret = irq_get_irqchip_state(irq, IRQCHIP_STATE_LINE_LEVEL, &state);
if (state < 0) {
if (ret < 0) {
dev_err(chg->dev, "failed to read irq line\n");
return;
}