redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

leds: aat1290: Add missing of_node_put 

The refcount of device_node increases after of_get_next_available_child()
is called. Make sure it is decremented also in case of DT parsing error.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
hifive-unleashed-5.1
Jacek Anaszewski 2015-11-25 09:22:19 +01:00
parent f5db6b8301
commit 0c24199ca9
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/leds/leds-aat1290.c
View File

@ -275,7 +275,7 @@ static int aat1290_led_parse_dt(struct aat1290_led *led,
if (ret < 0) {
dev_err(dev,
"flash-max-microamp DT property missing\n");
return ret;
goto err_parse_dt;
}
ret = of_property_read_u32(child_node, "flash-max-timeout-us",
@ -283,13 +283,14 @@ static int aat1290_led_parse_dt(struct aat1290_led *led,
if (ret < 0) {
dev_err(dev,
"flash-max-timeout-us DT property missing\n");
return ret;
goto err_parse_dt;
}
of_node_put(child_node);
*sub_node = child_node;
err_parse_dt:
of_node_put(child_node);
return ret;
}