redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

dm snapshot: remove unnecessary NULL checks before vfree() calls 

The vfree() function performs input parameter validation.
Thus the NULL pointer test around vfree() calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
hifive-unleashed-5.1
Markus Elfring 2015-02-02 14:38:29 +01:00 committed by Mike Snitzer
parent ff658e9c1a
commit 0c8f86322f
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/md/dm-snap-persistent.c
View File

@ -200,16 +200,11 @@ err_area:
static void free_area(struct pstore *ps)
{
if (ps->area)
vfree(ps->area);
vfree(ps->area);
ps->area = NULL;
if (ps->zero_area)
vfree(ps->zero_area);
vfree(ps->zero_area);
ps->zero_area = NULL;
if (ps->header_area)
vfree(ps->header_area);
vfree(ps->header_area);
ps->header_area = NULL;
}
@ -605,8 +600,7 @@ static void persistent_dtr(struct dm_exception_store *store)
free_area(ps);
/* Allocated in persistent_read_metadata */
if (ps->callbacks)
vfree(ps->callbacks);
vfree(ps->callbacks);
kfree(ps);
}