redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

be2net: define BE_MAX_MTU 

This patch defines a new macro BE_MAX_MTU to make the code in be_change_mtu()
more readable.

Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Kalesh AP 2014-09-02 09:56:53 +05:30 committed by David S. Miller
parent 3fb8cb801a
commit 0d3f5ccec9
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/emulex/benet/be.h
View File

@ -86,6 +86,8 @@ static inline char *nic_name(struct pci_dev *pdev)
#define BE_MAX_JUMBO_FRAME_SIZE 9018 #define BE_MAX_JUMBO_FRAME_SIZE 9018
#define BE_MIN_MTU 256 #define BE_MIN_MTU 256
#define BE_MAX_MTU (BE_MAX_JUMBO_FRAME_SIZE - \
(ETH_HLEN + ETH_FCS_LEN))
#define BE_NUM_VLANS_SUPPORTED 64 #define BE_NUM_VLANS_SUPPORTED 64
#define BE_MAX_EQD 128u #define BE_MAX_EQD 128u

14
drivers/net/ethernet/emulex/benet/be_main.c
View File

@ -1073,15 +1073,15 @@ static netdev_tx_t be_xmit(struct sk_buff *skb, struct net_device *netdev)
static int be_change_mtu(struct net_device *netdev, int new_mtu) static int be_change_mtu(struct net_device *netdev, int new_mtu)
{ {
struct be_adapter *adapter = netdev_priv(netdev); struct be_adapter *adapter = netdev_priv(netdev);
if (new_mtu < BE_MIN_MTU || struct device *dev = &adapter->pdev->dev;
new_mtu > (BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN))) {
dev_info(&adapter->pdev->dev, if (new_mtu < BE_MIN_MTU || new_mtu > BE_MAX_MTU) {
"MTU must be between %d and %d bytes\n", dev_info(dev, "MTU must be between %d and %d bytes\n",
BE_MIN_MTU, BE_MIN_MTU, BE_MAX_MTU);
(BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN)));
return -EINVAL; return -EINVAL;
} }
dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n",
dev_info(dev, "MTU changed from %d to %d bytes\n",
netdev->mtu, new_mtu); netdev->mtu, new_mtu);
netdev->mtu = new_mtu; netdev->mtu = new_mtu;
return 0; return 0;