redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

Btrfs: Check kthread_should_stop() before schedule() in worker_loop 

In worker_loop(), the func should check whether it has been requested to stop
before it decides to schedule out.

Otherwise if the stop request(also the last wake_up()) sent by
btrfs_stop_workers() happens when worker_loop() running after the "while"
judgement and before schedule(), woker_loop() will schedule away and never be
woken up, which will also cause btrfs_stop_workers() wait forever.

Signed-off-by: Chris Mason <chris.mason@oracle.com>
hifive-unleashed-5.1
yanhai zhu 2008-11-12 14:36:58 -05:00 committed by Chris Mason
parent c36047d729
commit 0df49b911d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/btrfs/async-thread.c
View File

@ -171,7 +171,8 @@ static int worker_loop(void *arg)
} else {
set_current_state(TASK_INTERRUPTIBLE);
spin_unlock_irq(&worker->lock);
schedule();
if (!kthread_should_stop())
schedule();
__set_current_state(TASK_RUNNING);
}
} while (!kthread_should_stop());